feat(core): async adapter - #419
Merged
Merged
Conversation
* feat(core/adapter): pass filter to get_sids * feat: add custom `Iterator` return for apply_opts fn
* test(e2e): provide e2e testing system for adapters * fix(e2e/adapter): remove redis deps
Closed
Totodore
enabled auto-merge (rebase)
January 12, 2025 18:03
auto-merge was automatically disabled
January 12, 2025 18:06
Rebase failed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full rework of the async adapter.
The majority of the adapter code is now in the
socketioxide-corecrate. It contains aLocalAdapterwith the following type def:The
SocketEmitteris an internal interface implemented by thesocketioxidecrate to execute actions on the sockets:The
Adapterdefault implementation is the local adapter. Any other implementation that uses remote systems (redis, mongo, ...) can propagate requests and then execute the default behavior with theCoreLocalAdapterpassed to the adapter implementation.