Skip to content

Bump tokio tungstenite to 0.26 - #428

Merged
Totodore merged 6 commits into
mainfrom
bump-tokio-tungstenite
Jan 13, 2025
Merged

Bump tokio tungstenite to 0.26#428
Totodore merged 6 commits into
mainfrom
bump-tokio-tungstenite

Conversation

@Totodore

@TotodoreTotodore commented Jan 12, 2025•
edited
Loading

Copy link
Copy Markdown
Owner
  • Use new tokio-tungstenite Message API with Bytes rather than owned Vec. Thanks to that we have much less allocations when reading/writing to websockets.
  • Switch from TryFrom<Packet> for String to From<Packet> for String because there is no errors when serializing a packet to a string.

@Totodore
Totodoreforce-pushed the bump-tokio-tungstenite branch from 264f36e to d8e13f4CompareJanuary 12, 2025 18:57
@Totodore
Totodoreforce-pushed the bump-tokio-tungstenite branch from d8e13f4 to e37edb6CompareJanuary 12, 2025 19:06
github-advanced-security[bot]
github-advanced-securityAI found potential problems Jan 13, 2025
View reviewed changes
Comment threadcrates/socketioxide/tests/disconnect_reason.rs Fixed
Comment threadcrates/socketioxide/tests/fixture.rs Fixed
Comment threadcrates/socketioxide/tests/fixture.rs Fixed
Comment threadcrates/socketioxide/tests/fixture.rs Fixed
@Totodore
Totodoreforce-pushed the bump-tokio-tungstenite branch from 34661ee to 9118637CompareJanuary 13, 2025 13:34
@TotodoreTotodore changed the title Bump tokio tungsteniteBump tokio tungstenite to 0.26Jan 13, 2025
@Totodore
Totodore enabled auto-merge (squash) January 13, 2025 13:42
@Totodore
Totodore merged commit fe09c45 into mainJan 13, 2025
@Totodore
Totodore deleted the bump-tokio-tungstenite branch January 17, 2025 16:59
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Totodore@github-advanced-security