fix(engineio): heartbeat delay - #437
Merged
Merged
Conversation
In case of http polling heartbeat timeout, engine.io might send a close packet to an existing polling connection before closing. Fix the test for this case.
A delay was arbitrarily before starting the engine.io delay. The goal was mostly to comply with the socket.io test suite which was not checking the ping packet before doing other operations. With the js implementation it is OK because it is slow. But it was causing issue with this one. Fix many tests to work with this issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A delay was arbitrarily before starting the engine.io heartbeat when the socket is connecting.
The goal was mostly to comply with the socket.io test suite which was
not checking the ping packet before doing other operations.
With the js implementation it is OK because it is slow.
But it was causing issue with this one.