Skip to content

Test redis adapter - #439

Merged
Totodore merged 9 commits into
mainfrom
test-redis-adapter
Jan 16, 2025
Merged

Test redis adapter#439
Totodore merged 9 commits into
mainfrom
test-redis-adapter

Conversation

@Totodore

@TotodoreTotodore commented Jan 16, 2025

Copy link
Copy Markdown
Owner
  • Improve the adapter test-suite to cover a lot more cases.
  • Fix issues on redis adapter:
    • The ack stream was closed if the remote part was closed without checking the local one.
    • The expected response count when waiting for responses was set to server count even when sending the request to a single server leading to waiting for the timeout before getting the response.
  • Fix issue on RemoteSocket struct, the impl RoomParam lifetime was bound to the async function for leave and join fns. Therefore it was impossible to use &'static str whereas RoomParam is implemented for &'static str.
  • Manual implementation for some Clone and Debug to avoid automatic bound on generic adapter.

@TotodoreTotodore added C-Bug Something isn't working A-socketioxide Area related to socketioxide A-redis-adapter Area related to redis-adapter T-testing Topic: testing labels Jan 16, 2025
@Totodore
Totodore merged commit 39ab18a into mainJan 16, 2025
@Totodore
Totodore deleted the test-redis-adapter branch January 16, 2025 15:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-redis-adapterArea related to redis-adapterA-socketioxideArea related to socketioxideC-BugSomething isn't workingT-testingTopic: testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Totodore