Stop site update after errors

[jteresco]

With the new siteupdate still in the commonupdate branch:

If C++ siteupdate fails, it still writes some of the .sql file, and then siteupdate.sh tries to use it.

[yakra]

Weird. Don't know why siteupdate.sh would still be running in order to try to use it, if there's the || exit 1 if siteupdate fails.

DataProcessing/siteupdate/siteupdate.sh

Line 306 in 0af3140

$siteupdate $errorcheck -d TravelMapping-$datestr $graphflag -l $indir/$logdir -c $indir/$statdir -g $indir/$graphdir -n $indir/$nmpmdir -w $tmbasedir/HighwayData -u $tmbasedir/UserData/list_files | tee -a $indir/$logdir/siteupdate.log 2>&1 || exit 1

Did siteupdate abort due to ErrorList errors, or did it crash?
What were your HighwayData, UserData & DataProcessing commits? git show -s

[michihdeu]

I guess that this caused the issue.

[yakra]

@michihdeu thanks for the commit info. I'll use the parent commit for testing purposes.

@jteresco I'm not sure I'll get the same behavior under Linux as under FreeBSD. Back when I opened #383 it had been a while since I'd observed what happened and how. Time to refresh my memory I guess. Test out a few different command lines under CentOS, Ubuntu & FreeBSD, Python & C++ flavors...

If all else fails, we can always tail -n 1 siteupdate.log | grep -c 'Total run time:'...

[yakra]

Maybe BSD tee returns the same exit code as whatever's piped to it, and Linux tee just returns 0?

• ./siteupdate -e -t 4 -d .//TravelMapping -l .//logs -c .//stats -g .//graphs -u $HOME/tm/UserData/list_files -w $HOME/tm/HighwayData | tee siteupdate.log || echo FAIL FAIL FAIL does not actually echo FAIL FAIL FAIL. Observed under Ubuntu & CentOS, and a bit surprisingly, also on Noreaster.
  Same behavior when I run the Python version.
  So how in blazes did existing localupdate.sh actually work?
  Is it set -e? Nope?
• (./siteupdate -e -t 4 -d .//TravelMapping -l .//logs -c .//stats -g .//graphs -u $HOME/tm/UserData/list_files -w $HOME/tm/HighwayData || echo FAIL FAIL FAIL) | tee siteupdate.log behaves as expected. Hm. I thought I had tried parentheses that time years ago? Good to see.