Skip to content

remove OUT_OF_BOUNDS from datacheck_always_error - #128

Merged
jteresco merged 2 commits into
TravelMapping:masterfrom
yakra:dc_labels
Nov 14, 2018
Merged

remove OUT_OF_BOUNDS from datacheck_always_error#128
jteresco merged 2 commits into
TravelMapping:masterfrom
yakra:dc_labels

Conversation

@yakra

@yakrayakra commented Nov 13, 2018

Copy link
Copy Markdown
Contributor

< -180° or > 180° should be allowed in some limited circumstances.
Any road spanning +/-180° (E.G., West Coast Road, Taveuni, Fiji) will get messed up if these coords are "repaired": Leaflet will draw long E-W lines spanning almost the entire globe.

@jteresco

Copy link
Copy Markdown
Contributor

Such points would fall outside the quadtree, so maybe its initial E/W bounds should be a tad beyond 180.

@jteresco
jteresco merged commit e32f674 into TravelMapping:masterNov 14, 2018
@yakra

Copy link
Copy Markdown
ContributorAuthor

Where to put them, though?
I don't see the bounds as causing any harm. This would behave just as before #126, when longitude bounds were set at +/-90°, just on a much smaller scale: Quadtree Nodes along the E & W edges of the map will still receive points outside their nominal bounds, and pass them down to their child nodes based on where they fall relative to mid_lng.
Nodes may fill up & refine a tad faster, as they have more width in which to receive points.
But there should be relatively few (if any) of these points, and the effects should be minimal. Nothing like the long narrow "stripes" that had to contend with taking in all the waypoints for an extra 90° longitude.

@yakra
yakra deleted the dc_labels branch November 14, 2018 02:12
@yakrayakra mentioned this pull request Dec 24, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@yakra@jteresco