Uh oh!
There was an error while loading. Please reload this page.
move fatal error reporting before graph generation - #163
Merged
Conversation
jteresco
commented
Jan 7, 2019
Contributor
Yes, please do. |
yakra
commented
Jan 7, 2019
ContributorAuthor
This is the case for updates.csv, systemupdates.csv, areagraphs.csv, systemgraphs.csv, multisystem.csv, multiregion.csv, datacheckfps.csv. |
jteresco
commented
Jan 7, 2019
Contributor
Yes, I think that would be good. It's not really hurting anything but it's good practice. |
yakra
commented
Jan 7, 2019
ContributorAuthor
Done. |
jteresco
commented
Jan 7, 2019
Contributor
Excellent, thanks. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes#162.
Looks like we never had a
file.close()for datacheckfps.csv.I didn't add one, Shall we do so?