Uh oh!
There was an error while loading. Please reload this page.
match vertices once per simple/collapsed pair - #185
Merged
Conversation
jteresco
reviewed
Feb 5, 2019
jteresco
left a comment
Contributor
There was a problem hiding this comment.
Those time savings are excellent! As far as the code changes, I'm not seeing anything that concerns me, but I admit I haven't looked super carefully. I think what I'll do is merge it in tonight and see how it goes. I can always back up and regenerate for this week's Algorithms labs (which are going to be using the graphs extensively) if there's any hint of trouble.
jteresco
approved these changes
Feb 5, 2019
jteresco
left a comment
Contributor
There was a problem hiding this comment.
Specifically addressing your request to look at the population of the graph list, I'm very confident that that change will not cause trouble.
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#183.
@jteresco, requesting a review:
Changes were more extensive this time around. In particular,
graph_listis now passed towrite_subgraphs_tmg, and the entries are appended there. I want to be sure I didn't goof anything up that would cause the graph list entries to get mangled when we put them into the DB.