Skip to content

HighwayGraphCollapsedEdgeInfo initial setup - #191

Merged
jteresco merged 9 commits into
TravelMapping:masterfrom
yakra:hgce
Mar 12, 2019
Merged

HighwayGraphCollapsedEdgeInfo initial setup#191
jteresco merged 9 commits into
TravelMapping:masterfrom
yakra:hgce

Conversation

@yakra

@yakrayakra commented Feb 8, 2019

Copy link
Copy Markdown
Contributor

This branch also contains the commits in #188 & #190.

With the initial HighwayGraphCollapsedEdgeInfo setup based on a HighwaySegment, we end up recomputing a lot of the info we just obtained for the HighwayGraphEdgeInfo based on the same HighwaySegment. If we base initial construction on the corresponding HighwayGraphEdgeInfo instead, we can avoid duplicating this work.

  • segment_name is copied from the HighwayGraphEdgeInfo, rather than recomputed from HighwaySegment.segment_name().
  • vertex1 & vertex2 are copied from the HighwayGraphEdgeInfo, avoiding looking them up by Waypoint in the hash table.
  • "Reverse" duplicate checks are done away with, as we already know the HighwayGraphEdgeInfo to not be a duplicate.
  • If a HighwayGraphEdgeInfo is a duplicate, we skip its corresponding HighwayGraphCollapsedEdgeInfo entirely.

Compared to the version in #190, this reduces initial HighwayGraph setup time from ~41.8s to ~38.5s on BiggaTomato.


ToDo: The HighwayGraphCollapsedEdgeInfo constructor receives a HighwayGraph object, but doesn't do anything with it. This can be trimmed.Done:268485b

@yakra

Copy link
Copy Markdown
ContributorAuthor

Putting this on hold until I get yakra#64 sorted.

@yakrayakra reopened this Feb 10, 2019
@yakrayakra mentioned this pull request Feb 11, 2019
@jteresco
jteresco merged commit 381289a into TravelMapping:masterMar 12, 2019
@yakra
yakra deleted the hgce branch March 16, 2019 18:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@yakra@jteresco