Uh oh!
There was an error while loading. Please reload this page.
ev_combine - #259
Merged
Merged
Conversation
yakra
commented
Nov 16, 2019
ContributorAuthor
Due diligence: I will test the Python version on noreaster, then reopen. |
yakra
commented
Nov 17, 2019
ContributorAuthor
Looks good. Ready to rock. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tidied up subgraph-generation code by matching all vertices and simple, collapsed & traveled edges in a single function, yielding a very small speedup. Closes#233.
Python: Saves ~4s on BiggaTomato. We're down 23 lines of code.
C++: Saves only ~1s, with more substantial code-cleanup benefits here; we're down 76 total lines across several files. In the process, we save some RAM by getting rid of the underwhelming per-Region & per-HighwaySystem edge sets from #187, no worse for wear performance-wise.