Uh oh!
There was an error while loading. Please reload this page.
datacheck enhancements - #265
Merged
Merged
Conversation
yakra
commented
Nov 25, 2019
ContributorAuthor
Actually, I'm going to rethink this, depending on how the C++ version ends up getting implemented. |
...with some changes to the Python version as well to get it to behave the same way and avoid diffs when both the lat= and lon= arguments are malformed
ContributorAuthor
C++ implementation done. So much for parsing the URL in just 4 lines of code. It was nice while it lasted! 😆 |
jteresco
commented
Nov 26, 2019
Contributor
Good to go live with this now? |
yakra
commented
Nov 26, 2019
ContributorAuthor
Yes. |
jteresco
commented
Nov 26, 2019
Contributor
OK, good. It will be used on tonight's update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See also: TravelMapping/Web#378