Uh oh!
There was an error while loading. Please reload this page.
null zero bugfix - #310
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change from #309 was poorly thought out.
The idea was to have a wee bit more robustness & allow for cases with whitespace before null zeros, and trim the null zeros first.
Problem is, unlike C++'s
std::getline, Python'sreadlinesdoesn't automatically strip the endline. So The\0s aren't stripped because of the endline, and any whitespace then won't be stripped because of the\0s.A single customized strip should take care of any combination of the three.
Luckily, this only affects lowenbrau.list, and even then not the latest version. Found this because I frequently check out an older head to run speed tests.