Uh oh!
There was an error while loading. Please reload this page.
refactor roots & list names; smash case - #320
Merged
Merged
Conversation
* Refactor checks for root & list name uniqueness and Route/ConnectedRoute correspondence for improved efficiency & error reporting and more concise code (TravelMapping#316) * Perform fewer case conversions on AltLabels & AltRouteNames for increased speed Processing traveler list files (TravelMapping#319) * C++: clean up a couple classes' static member definitions
yakra
commented
May 8, 2020
ContributorAuthor
I wrote:
Oops, guess I forgot I said that. :) Still waiting on 3 fixes:
|
jteresco
commented
May 11, 2020
Contributor
Good to go now? |
* Retrieve elements by value rather than reference. Same principle as in #270, just without the big speed increase. Best practice nonetheless. * Convert traditional for loops to range for loops where possible, for cleaner more concise code.
yakra
commented
May 14, 2020
ContributorAuthor
The last conflict, AR549, was fixed about 7 hours ago. Good to go. |
This was referenced May 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python:
2/3 the processing time, 3/2 the speed, Processing traveler list files
C++

Less of an improvement than I'd have hoped for, but it's still something. This helps out most on BiggaTomato, my system most constrained by memory bandwidth & cache size. (Well... there's also my laptop, with its 512K L2 cache. I'm not even bothering testing speed on that single-core dinosaur.)
Compare the graphs in #313: