Uh oh!
There was an error while loading. Please reload this page.
US_LETTER datacheck - #357
Merged
Merged
Conversation
to eliminate redundant string comparisons
jteresco
commented
Nov 16, 2020
Contributor
Pulled to noreaster before tonight's update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#351.
See also TravelMapping/Web#554.
The US_BANNER datacheck was present in siteupdate but commented out since the earliest days. Very few results overall (31 as of 3d2f858), though most were FPs, due to the A or B beginning a string such as "ALT" (vice "Alt") or a city suffix that would more properly go after an underscore.
This revision tightens the net, to omit these cases better left to a different datacheck.
Now, an error is flagged if the
AorBends the label or is followed by/,_or(.Only 6 results.
Renaming to US_LETTER: a better fit IMO, as most datacheck names describe what's wrong, whereas US_BANNER is more of a description of what would be right instead.
Along for the ride: some stuff. Commit messages & diffs should be self explanatory enough. :)