Skip to content

HgVertex cleanup/speedup; LABEL_INVALID_CHAR fixes - #416

Merged
jteresco merged 4 commits into
TravelMapping:masterfrom
yakra:HGVertex
Feb 17, 2021
Merged

HgVertex cleanup/speedup; LABEL_INVALID_CHAR fixes#416
jteresco merged 4 commits into
TravelMapping:masterfrom
yakra:HGVertex

Conversation

@yakra

@yakrayakra commented Feb 16, 2021

Copy link
Copy Markdown
Contributor
  • closesvertex-related cleanup yakra/DataProcessing#107
    • 3f938cb cleans up vertex iteration. Dict keys are Waypoint objects rather than vertex labels now, and can be used for the HIDDEN_JUNCTION datacheck rather than the vestigial first_waypoint variable.
    • A longstanding comment notes that we can remove either lat & lng or first_waypoint from HGVertex, but not both. 315f834 removes first_waypoint. This option takes up about 4 MB more RAM, but the other option is slightly slower and requires minor changes to PlaceRadius.
  • closesstr(HGVertex) yakra/DataProcessing#153
    • ac65bc3 constructs & stores .tmg vertex line strings only once, retrieving them to write to all 3 graph files. This saves a surprising amount of time, subgraphs down to 67.23 s from 74.77 s on lab1. Python string construction gets pretty expensive what with interning, automatic hashing, etc.
  • closesUTF-8 byte order mark HighwayData#4561
    • b155944 flags LABEL_INVALID_CHAR only once per waypoint label, and notes cases caused by a UTF-8 BOM.
    • See also: UTF-8 BOM Web#630

@yakrayakra mentioned this pull request Feb 16, 2021
@yakra

Copy link
Copy Markdown
ContributorAuthor

Might have one more commit to add on to this.

@jteresco

Copy link
Copy Markdown
Contributor

bring in?

@yakra

Copy link
Copy Markdown
ContributorAuthor

Ready to bring in. I'll save that commit for later.

@jteresco
jteresco merged commit 2d33c7b into TravelMapping:masterFeb 17, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UTF-8 byte order mark str(HGVertex) vertex-related cleanup

2 participants

@yakra@jteresco