Uh oh!
There was an error while loading. Please reload this page.
minor concurrency augment speedup - #581
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
list->vectorconversion helps cache coherency & iteration.What's neato here is that reduced cache misses cause subsequent tasks to run faster even though their code is unchanged, kind of the reverse of #311 (comment). Proportionally, their speedup is even bigger.
Writing to concurrencies.log (single-threaded):
Worth noting again that soon, after the region.php ranking bugfix is implemented, CompStatsRThread & CompStatsTThread will cease to be separate tasks.
Subsequent tasks (highwaydatastats.log, Creating per-traveler stats logs and augmenting data structure, etc.) were not measured; I had siteupdate terminate early to finish the speed tests in a reasonable amount of time. Though surely as the program marches onward & more stuff is read out of main memory into cache, the effect will be less & less.