Uh oh!
There was an error while loading. Please reload this page.
Favicons on webpages - #143
Merged
Merged
Conversation
theFXexpert
commented
Jan 21, 2017
ContributorAuthor
Just added a fix for some shields. |
jteresco
commented
Jan 22, 2017
Contributor
This is live, looks like at least eure still coming up blank. |
theFXexpert
commented
Jan 22, 2017
ContributorAuthor
Hmm. The code for the favicons isn't showing up either. There is also a superfluous semicolon in line 100 and line 134 of shieldgen.php |
jteresco added a commit
that referenced
this pull request
Jan 22, 2017
jteresco
commented
Jan 22, 2017
Contributor
I think I did not pull down the merged code before installing. I did that now and I think things are a little better. |
theFXexpert
commented
Jan 22, 2017
ContributorAuthor
Looks like the contents of line 111 in shieldgen.php: |
jteresco added a commit
that referenced
this pull request
Jan 22, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies favicons to other pages.