Uh oh!
There was an error while loading. Please reload this page.
Routes Traveled ranking bugfix - #325
Merged
Merged
Conversation
jteresco
commented
Jul 14, 2019
Contributor
I think if you don't use a while loop and find something that does the search for you, there's probably some similar loop hidden inside, so I wouldn't worry. The ; syntax shouldn't be a problem. Ready to try on tmtest? |
yakra
commented
Jul 14, 2019
ContributorAuthor
True enough. It just bugged me. I wanted some neat & clean syntax. :)
Ready! |
jteresco
commented
Jul 14, 2019
Contributor
Just installed on tmtest. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#278.
Web/user/region.php
Lines 255 to 256 in f8c6c79
Web/user/region.php
Lines 291 to 292 in f8c6c79
Web/user/system.php
Lines 233 to 234 in f8c6c79
These three bits still bother me a little. I'd like a more elegant way to just fetch the one row we need with a single function. If such exists, I haven't learned what it is yet; it seems I have to use a while loop. (?)
Also a little nervous about ending the line with a
;rather than a{}. I'm brand new to PHP, don't know how standard syntax that is, or whether FreeBSD will be OK with it.We may want to try this out on tmtest before the production site?