Skip to content

fix for #340, take 2 - #348

Merged
jteresco merged 2 commits into
TravelMapping:masterfrom
yakra:untraveled2
Nov 8, 2019
Merged

fix for #340, take 2#348
jteresco merged 2 commits into
TravelMapping:masterfrom
yakra:untraveled2

Conversation

@yakra

@yakrayakra commented Sep 8, 2019

Copy link
Copy Markdown
Contributor

Closes#340.

On untraveled routes:

On both noreaster & lab2: Total Clinched count, percentage of users & percentage of drivers, and Average Traveled percentage failed to display.
On lab2 only: Total Length shown as 0.00; user traveled percentage is NAN.
Fixed all that.
Skip displaying clinched/driven %age for untraveled routes, because what sense does that make. 0/0.
In the process, changed all percentages in the Route Stats table to drop trailing zeros.
Changed Waypoints table to match.

I'll post some before & after links in the forum, in the 0%/100% thread.

@yakrayakra added bug Highway Browser This label has been replaced by findroute and showroute SQL labels Sep 8, 2019
@yakra
yakra requested a review from jterescoSeptember 8, 2019 05:51
@yakrayakra mentioned this pull request Sep 8, 2019
@yakrayakra added pending and removed pending labels Oct 10, 2019
@jteresco
jteresco merged commit f702b74 into TravelMapping:masterNov 8, 2019
@jteresco

Copy link
Copy Markdown
Contributor

Live on tmtest.

@yakra

yakra commented Nov 9, 2019

Copy link
Copy Markdown
ContributorAuthor

@yakra
yakra deleted the untraveled2 branch November 12, 2019 03:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugHighway BrowserThis label has been replaced by findroute and showrouteSQL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lab2: routes with 0 travelers have Total Length of 0

2 participants

@yakra@jteresco