Skip to content

center map at waypoint when clicking on table - #361

Merged
jteresco merged 3 commits into
TravelMapping:masterfrom
yakra:wptedit
Nov 8, 2019
Merged

center map at waypoint when clicking on table#361
jteresco merged 3 commits into
TravelMapping:masterfrom
yakra:wptedit

Conversation

@yakra

Copy link
Copy Markdown
Contributor

Fixes#322

@yakra

Copy link
Copy Markdown
ContributorAuthor

Closing this pending some more testing on lab2

@yakrayakra closed this Oct 10, 2019
@yakra

Copy link
Copy Markdown
ContributorAuthor

51b9b30#diff-ee2abcb14108e77ec77a5cc1d194655dL841-R843 breaks centering for Intersecting/Concurrent Routes links, which are created before panning the map to the new center.
Alternately,

markers[i].openPopup();map.panTo([lat,lon]);intersectingConcurrentRoutes(i);

introduces a new variant on the original problem: we getCenter() before the map is finished panning.

when clicking on table
@yakrayakra reopened this Oct 11, 2019
@yakra

yakra commented Oct 11, 2019

Copy link
Copy Markdown
ContributorAuthor

Fixed in 2d0fd26.

@jteresco
jteresco merged commit 4c36c51 into TravelMapping:masterNov 8, 2019
@jteresco

Copy link
Copy Markdown
Contributor

Live on tmtest.

@michihdeu

michihdeu commented Nov 8, 2019

Copy link
Copy Markdown
Contributor

It doesn't center and the opacity of the lines is 100%.

http://tmtest.teresco.org/wptedit/

@jteresco

Copy link
Copy Markdown
Contributor

I'll hold off on putting this on the main site, then.

@yakra

yakra commented Nov 9, 2019

Copy link
Copy Markdown
ContributorAuthor
[yakra@noreaster /home/www/tmtest/wptedit]$ ls -l
total 48
-rw-r--r-- 1 terescoj wheel 4904 Jun 13 2018 index.php
-rw-r--r-- 1 terescoj wheel 40041 Jun 13 2018 wptfunctions.js

@yakra

yakra commented Nov 9, 2019

Copy link
Copy Markdown
ContributorAuthor

@michihdeu, how does the HB look re this behavior?

@michihdeu

michihdeu commented Nov 9, 2019

Copy link
Copy Markdown
Contributor

HB works! 👍

About wpt editor:
I don't change the zoom level but just add a few wps next to each other, e.g.:

+X847513 http://www.openstreetmap.org/?lat=42.719438&lon=-73.752058
+X225087 http://www.openstreetmap.org/?lat=42.719769&lon=-73.756821
+X907452 http://www.openstreetmap.org/?lat=42.719076&lon=-73.763430

Then, click on the first wp of the table and it's not centered.

@jteresco

Copy link
Copy Markdown
Contributor

Forgot that the wptedit code isn't updated by the default installer script. Re-ran and the new code should be installed now. Sorry about that.

@michihdeu

Copy link
Copy Markdown
Contributor

Works fine! It's the most annoying issue with wpt editor. I think it can (and I hope it will) go live soon.

@jteresco

Copy link
Copy Markdown
Contributor

Good! @yakra agree it's safe to put all of this on the main site?

@yakra

yakra commented Nov 9, 2019

Copy link
Copy Markdown
ContributorAuthor

Yes, I think so.

@jteresco

Copy link
Copy Markdown
Contributor

This and other changes from recently merged pull requests are live on the main site.

@yakra

Copy link
Copy Markdown
ContributorAuthor

@FL0gnap, a simple Javascript fix for a big annoyance

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

wpt editor: always center map option

3 participants

@yakra@jteresco@michihdeu