Skip to content

data errors manual + (new) data check page error colors - #487

Merged
yakra merged 5 commits into
TravelMapping:masterfrom
michihdeu:master
Jun 14, 2020
Merged

data errors manual + (new) data check page error colors#487
yakra merged 5 commits into
TravelMapping:masterfrom
michihdeu:master

Conversation

@michihdeu

Copy link
Copy Markdown
Contributor

No description provided.

Partial implementation of
TravelMapping#390
Not implemmented: Conditional DUPLICATE_LABEL red if visible, black if
hidden
@yakra
yakra self-requested a review June 14, 2020 09:07
@yakra

Copy link
Copy Markdown
Contributor

I'd check this out in detail but it's almost sleep o'clock. In the mor--afternoon!

@yakra

yakra commented Jun 14, 2020

Copy link
Copy Markdown
Contributor

syserr.php

< <li>For example, a <conn2>green line</conn1>> <li>For example, a <conn2>green line</conn2>

The rest looks good.

Also: duplicate the datacheck.php changes in the live devel/datacheck.php?

@michihdeu

michihdeu commented Jun 14, 2020

Copy link
Copy Markdown
ContributorAuthor

Also: duplicate the datacheck.php changes in the live devel/datacheck.php?

I cannot test it on my end and don't wanna break anything. But I think that there is virtually no chance to make anything wrong here....

and: I was not sure whether we should announce on the forum..... or even ask whether it is fine.... OTOH, I think that virtually no one cares............. till the day anyone is directly effected by an error report or reminder to fix errors....... well,... it's lunch time now! 😄

@jteresco

Copy link
Copy Markdown
Contributor

Drop a note in here when you're ready to have this go live.

@yakra

Copy link
Copy Markdown
Contributor

The changes are pretty straightforward, but I can merge this in & make the corresponding changes to /devel/datacheck.php, test them out on lab2 for good measure, and commit.

@michihdeu

Copy link
Copy Markdown
ContributorAuthor

The latest commit closes #355

@yakra

Copy link
Copy Markdown
Contributor

@michihdeu, is this good to go, or do you have more commits coming?

@michihdeu

Copy link
Copy Markdown
ContributorAuthor

No, this can go live now!

@yakra
yakra merged commit 39c11d7 into TravelMapping:masterJun 14, 2020
@yakra

Copy link
Copy Markdown
Contributor

OK. I'll handle the changes to /devel/datacheck.php. Thanks for all your work on this!

@michihdeu

Copy link
Copy Markdown
ContributorAuthor

Ah, I missed your previous post that you want to work on the remaining DL thing... Thanks! 😄

@michihdeu

michihdeu commented Jun 14, 2020

Copy link
Copy Markdown
ContributorAuthor

Or do you only wanna test my change to devel_new and apply to devel if it's fine? Which would also be great!

@yakra

Copy link
Copy Markdown
Contributor

Or do you only wanna test my change to devel_new and apply to devel if it's fine? Which would also be great!

This.

yakra added a commit to yakra/Web that referenced this pull request Jun 14, 2020
@jteresco

Copy link
Copy Markdown
Contributor

This should be live on the main site now.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@michihdeu@yakra@jteresco