Skip to content

wptedit datacheck additions & enhancements - #489

Merged
jteresco merged 1 commit into
TravelMapping:masterfrom
yakra:wptedit
Jun 15, 2020
Merged

wptedit datacheck additions & enhancements#489
jteresco merged 1 commit into
TravelMapping:masterfrom
yakra:wptedit

Conversation

@yakra

@yakrayakra commented Jun 15, 2020

Copy link
Copy Markdown
Contributor

addresses part of #374

• variable & function names changed to match TM nomenclature.
• wptedit-specific "short codes" removed in favor of full TM error codes
• datacheck functions alphabetized
Edit: forgot to mention the old "Exit" 0 & "Exit" 999 datachecks have been removed.

• BAD_ANGLE added
• BUS_WITH_I improved
• HIDDEN_TERMINUS added
• INVALID_FINAL_CHAR added
• INVALID_FIRST_CHAR added
• LABEL_INVALID_CHAR added (AltLabels still imperfect)
• LABEL_LOOKS_HIDDEN added
• LABEL_PARENS bugfix
• LABEL_SLASHES added
• LABEL_TOO_LONG added
• LACKS_GENERIC bugfix
• LONG_SEGMENT added
• LONG_UNDERSCORE improved
• OUT_OF_BOUNDS added


ping @michihdeu -- all the datachecks listed as "added" can be marked as a YES in the WPT File
Editor
column on syserr.php.

The following datachecks remain a yellow NO for now:
• LABEL_SELFREF
• MALFORMED_LAT
• MALFORMED_LON
• MALFORMED_URL

other syserr.php info:

LONG_SEGMENT
< (distance > 10 mi, 16 km)> (distance > 20 mi, 32 km)
LONG_UNDERSCORE
< Label has long underscore suffix (> 4 characters after underscore)> Label has long underscore suffix: > 4 characters after underscore, or 4 characters not ending in a capital letter.
VISIBLE_HIDDEN_COLOC
< The visisble waypoint> The visible waypoint

addresses part of TravelMapping#374
* variable & function names changed to match TM nomenclature.
* wptedit-specific "short codes" removed in favor of full TM error codes
* datacheck functions alphabetized
* BAD_ANGLE added
* BUS_WITH_I improved
* HIDDEN_TERMINUS added
* INVALID_FINAL_CHAR added
* INVALID_FIRST_CHAR added
* LABEL_INVALID_CHAR added (AltLabels still imperfect)
* LABEL_LOOKS_HIDDEN added
* LABEL_PARENS bugfix
* LABEL_SLASHES added
* LABEL_TOO_LONG added
* LACKS_GENERIC bugfix
* LONG_SEGMENT added
* LONG_UNDERSCORE improved
* OUT_OF_BOUNDS added
@michihdeu

Copy link
Copy Markdown
Contributor

LACKS_GENERIC bugfix

ups, I wasn't aware that it's available. It was still commented on syserr.php because it's indicated that it's only a placeholder: #374

Please provide a description.

michihdeu added a commit to michihdeu/Web that referenced this pull request Jun 15, 2020
@jteresco
jteresco merged commit cea2f85 into TravelMapping:masterJun 15, 2020
@yakra

Copy link
Copy Markdown
ContributorAuthor

@jteresco, https://travelmapping.net/wptedit/wptfunctions.js is still the old version.
Though it has only been 4 hours since the merge, so maybe I should just be patient. :)

@jteresco

Copy link
Copy Markdown
Contributor

I forgot that the update script doesn't copy wptedit by default. Just installed now.

@yakra

Copy link
Copy Markdown
ContributorAuthor

@michih, oops... it's a placeholder in the siteupdate program (but not for long), so I had a brainfart when creating its table entry in #374. Pretty confusing re wptedit, but you had it right for syserr.php.
The "bugfix" was of course only for wptedit. Forgot to specify that would be added to syserr.php as well, so good catch.

Description:
Label begins with "Old" followed immediately by a number without a preceding generic designation type such as US, E, A, Hwy, Rte, etc.

The two YESes you already have in the table are correct.

@yakra

Copy link
Copy Markdown
ContributorAuthor

I forgot that the update script doesn't copy wptedit by default. Just installed now.

Should it?
It's starting to undergo a period of heavy revision.
And when it's not changed, hey, no harm, right?

michihdeu added a commit to michihdeu/Web that referenced this pull request Jun 15, 2020
@yakrayakra mentioned this pull request Jun 15, 2020
@yakra

Copy link
Copy Markdown
ContributorAuthor

@FL0gnap, this uses JavaScipt to flag lots of errors "in real time" as project contributors create highway data files.
The idea is to nip some common errors in the bud and have contributors fix them before the data even makes it into the HighwayData repo

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@yakra@michihdeu@jteresco