Uh oh!
There was an error while loading. Please reload this page.
COMBINE_CON_ROUTES (Web) - #800
Merged
Merged
Conversation
yakra
commented
Oct 19, 2024
ContributorAuthor
Don't merge just yet. |
split 83cfa88 into 2 commits rebase 90c1536 (remove extraneous quote) rebase 2e19eee (remove exrtaneous parens)
yakra
commented
Oct 20, 2024
ContributorAuthor
Looks good on tmtest! |
jteresco
commented
Oct 24, 2024
Contributor
Missed that "looks good" while I was traveling. So I should put this up on the production server? @yakra |
yakra
commented
Oct 24, 2024
ContributorAuthor
Let's hold off on this. I'm making some last-minute changes to TravelMapping/DataProcessing#662. |
yakra
commented
Oct 24, 2024
ContributorAuthor
Updated TravelMapping/DataProcessing#662. |
michihdeu
commented
Oct 29, 2024
Contributor
@jteresco you missed this when merging TravelMapping/DataProcessing#662 |
jteresco
commented
Oct 29, 2024
Contributor
live on the site now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See TravelMapping/DataProcessing#662.
This isn't what I originally had in mind when I posted on the forum, but may be another item for tmtest,
as lab2 is down (possibly for good?), so I can't test this out locally until I get another server up & running.
If we don't merge this in right away and merge TravelMapping/DataProcessing#662 in without it,
it's not the end of the world:
Infocolumn unavailable.Not a big deal in the immediate term -- since HighwayData#7812, there are only 2 errors left.
These are pretty uncommon and I doubt any genuine FPs will make their way in before we get this sorted.
Alternately...
git checkout d61b93bif it didn't work. Whatever's clever.