Pull Request 070716 - #96

Merged
jteresco merged 9 commits into
TravelMapping:masterfrom
wjorda:pull_request_070716
Jul 17, 2016
Merged

Pull Request 070716#96
jteresco merged 9 commits into
TravelMapping:masterfrom
wjorda:pull_request_070716

Conversation

@wjorda

@wjordawjorda commented Jul 17, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

A compilation of new fixes and features that I've been working on for the past few weeks.

Notes:
*Improved user selection navigation across the site.
*stat.php now shows the current user's stats and ranks at the top, if one is selected.
*Added "back to user page" links on region.php and system.php
*Added user selection to hb.php, as requested in #42.
*Added some statistics to highway pages, including total mileage, LIST name, number of drivers, number clinched, and average mileage per driver.
*Also added per-segment statistics, showing the percentage of drivers who have traveled it.
*Fixes for #73 and #92, as well as implementations of #42, #48, and #93.

@jteresco
jteresco merged commit 092cd0d into TravelMapping:masterJul 17, 2016
@jteresco

jteresco commented Jul 17, 2016

Copy link
Copy Markdown
Contributor

Thanks for all of these. They're live on tmtest, and I'll get them over on the main site soon unless some problems are uncovered in a little testing.

This was referenced Jul 17, 2016
Closed
Closed
wjorda added a commit to wjorda/Web that referenced this pull request Jul 17, 2016
@wjorda
hotfix for mislabled columns inTravelMapping#96.
32de11a
@wjordawjorda mentioned this pull request Jul 17, 2016
Closed
@michihdeu

michihdeu commented Jul 17, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

Thanks for the great improvement 👍

*Added user selection to hb.php, as requested in #42.

The links from user stats to HB are broken now:
http://tmtest.teresco.org/hb/?u=michih
instead of
http://tm.teresco.org/hb?rg=DEU
but should be
http://tmtest.teresco.org/hb?rg=DEU&rg&u=michih

For that reason, I cannot test the rest of the feature.

@michihdeu

michihdeu commented Jul 19, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

*stat.php now shows the current user's stats and ranks at the top, if one is selected.

I like that very much 👍

Nevertheless, I'm not sure how it works:

For instance, German A1 which I've clinched 100%: http://tm.teresco.org/hb/index.php?u=michih&r=deu.a001.

Total Mileage 380.63 mi
LIST Name DEU A1
Average Mileage 112.77 mi (29.63 %)
Total Drivers 12 (9.23 %)
Total Clinched 1 (0.77 %)
8.33 % of drivers

Why is (my?) average milage 29.63% only?

Waypoints
Coordinates Name %

What's indicated in the % column? Values are changing?

(54.094612,10.775914) 14 25.00
(54.052259,10.733814) 15 16.67
(54.034721,10.729179) 16 25.00

Is data not calculated for the selected user but for all users? Which should only be displayed if none is selected? It's a little bit confusing...

Why are higher % values red? I think it should be green, shouldn't it? Maybe 0-50% red to light red, 50-100% light green to green? Just my 2c...

@wjorda

wjorda commented Jul 19, 2016

Copy link
Copy Markdown
ContributorAuthor

@michihdeu:
The stats on the HB pages are not dependent on the user.

"Average Mileage" is the average distance traveled by users who have driven the road (ie, people who have driven the road have driven it on average 112.77 miles)

The percentages are the percentage of drivers who have traveled the segment that starts at that waypoint.

@michihdeu

michihdeu commented Jul 19, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

OK. I was about to request that it should be shown in tooltip but it already is. Even the traveler names in "total driver" line. Perfect :)

@rickmastfan67

rickmastfan67 commented Jul 21, 2016

Copy link
Copy Markdown

I don't know if this was to effect the 'update' page, but I can no longer go directly to a route page from it.
http://tm.teresco.org/devel/updates.php#updates
Any link to a route from that page takes me to the "Travel Mapping Highway Browser" instead. So, if I want to double check a route from that page, I have to go to the system, then the route. Very annoying and time consuming.

@michihdeu

michihdeu commented Jul 21, 2016

Copy link
Copy Markdown
Contributor

Any link to a route from that page takes me to the "Travel Mapping Highway Browser" instead.

It works for me. I've clicked on the first 6 links (eng.a1173imm,...), all are fine.

@rickmastfan67

rickmastfan67 commented Jul 21, 2016

Copy link
Copy Markdown

Well, still a no-go for me in both IE & FF. Takes me to this URL everytime: http://tm.teresco.org/hb/?u=rickmastfan67

Could there be some bug with the site cookies? It works fine when I'm in 'private' mode for FF, just not in the normal part that stores the cookies.

@michihdeu

michihdeu commented Jul 21, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

I don't think that it's in combination with private mode but it depends whether an user is selected. If cookies are cleared and you open the update page, no user is known and it works. If you select an user via 'Traveler Stats' first, it does not work.

I think it's a duplicate to the problem I've reported that HB is not opened from user stats (because user is always known there).

@wjordawjorda mentioned this pull request Jul 21, 2016
Closed
wjorda added a commit to wjorda/Web that referenced this pull request Jul 21, 2016
@wjorda
hotfix for mislabled columns inTravelMapping#96.
17a30d7
@wjordawjorda mentioned this pull request Jul 21, 2016
Merged
jteresco added a commit that referenced this pull request Jul 22, 2016
@jteresco
Merge pull request#99from Thing342/pull_request_070716
d79f99b
Hotfixes for #96
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wjorda@jteresco@michihdeu@rickmastfan67
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Pull Request 070716 - #96
Merged
jteresco merged 9 commits into
TravelMapping:masterfrom 
wjorda:pull_request_070716
Jul 17, 2016
Merged
Pull Request 070716#96
jteresco merged 9 commits into
TravelMapping:masterfrom 
wjorda:pull_request_070716
Conversation
@wjorda
@wjordawjorda
commented
Jul 17, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
A compilation of new fixes and features that I've been working on for the past few weeks.
Notes:

*Improved user selection navigation across the site.

*stat.php now shows the current user's stats and ranks at the top, if one is selected.

*Added "back to user page" links on region.php and system.php

*Added user selection to hb.php, as requested in #42.

*Added some statistics to highway pages, including total mileage, LIST name, number of drivers, number clinched, and average mileage per driver.

*Also added per-segment statistics, showing the percentage of drivers who have traveled it.

*Fixes for #73 and #92, as well as implementations of #42, #48, and #93.
@jteresco
jteresco
merged commit 092cd0d
into
TravelMapping:masterJul 17, 2016
@jteresco
jteresco
commented
Jul 17, 2016

Copy link


Copy Markdown

Contributor
Thanks for all of these. They're live on tmtest, and I'll get them over on the main site soon unless some problems are uncovered in a little testing.

This was referenced Jul 17, 2016

Closed


Closed

wjorda added a commit
to wjorda/Web
that referenced
this pull request
Jul 17, 2016
@wjorda
hotfix for mislabled columns inTravelMapping#96.
32de11a
@wjordawjorda
mentioned this pull request
Jul 17, 2016

Closed

@michihdeu
michihdeu
commented
Jul 17, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
Thanks for the great improvement 👍
*Added user selection to hb.php, as requested in #42.
The links from user stats to HB are broken now:
http://tmtest.teresco.org/hb/?u=michih

instead of
http://tm.teresco.org/hb?rg=DEU

but should be
http://tmtest.teresco.org/hb?rg=DEU&rg&u=michih
For that reason, I cannot test the rest of the feature.
@michihdeu
michihdeu
commented
Jul 19, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
*stat.php now shows the current user's stats and ranks at the top, if one is selected.
I like that very much 👍
Nevertheless, I'm not sure how it works:
For instance, German A1 which I've clinched 100%: http://tm.teresco.org/hb/index.php?u=michih&r=deu.a001.
Total Mileage 380.63 mi

LIST Name DEU A1

Average Mileage 112.77 mi (29.63 %)

Total Drivers 12 (9.23 %)

Total Clinched 1 (0.77 %)

8.33 % of drivers
Why is (my?) average milage 29.63% only?
Waypoints

Coordinates Name %
What's indicated in the % column? Values are changing?
(54.094612,10.775914) 14 25.00

(54.052259,10.733814) 15 16.67

(54.034721,10.729179) 16 25.00
Is data not calculated for the selected user but for all users? Which should only be displayed if none is selected? It's a little bit confusing...
Why are higher % values red? I think it should be green, shouldn't it? Maybe 0-50% red to light red, 50-100% light green to green? Just my 2c...
@wjorda
wjorda
commented
Jul 19, 2016

Copy link


Copy Markdown

ContributorAuthor
@michihdeu:

The stats on the HB pages are not dependent on the user.
"Average Mileage" is the average distance traveled by users who have driven the road (ie, people who have driven the road have driven it on average 112.77 miles)
The percentages are the percentage of drivers who have traveled the segment that starts at that waypoint.
@michihdeu
michihdeu
commented
Jul 19, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
OK. I was about to request that it should be shown in tooltip but it already is. Even the traveler names in "total driver" line. Perfect :)
@rickmastfan67
rickmastfan67
commented
Jul 21, 2016

Copy link


Copy Markdown

I don't know if this was to effect the 'update' page, but I can no longer go directly to a route page from it.
http://tm.teresco.org/devel/updates.php#updates

Any link to a route from that page takes me to the "Travel Mapping Highway Browser" instead. So, if I want to double check a route from that page, I have to go to the system, then the route. Very annoying and time consuming.
@michihdeu
michihdeu
commented
Jul 21, 2016

Copy link


Copy Markdown

Contributor
Any link to a route from that page takes me to the "Travel Mapping Highway Browser" instead.
It works for me. I've clicked on the first 6 links (eng.a1173imm,...), all are fine.
@rickmastfan67
rickmastfan67
commented
Jul 21, 2016

Copy link


Copy Markdown

Well, still a no-go for me in both IE & FF. Takes me to this URL everytime: http://tm.teresco.org/hb/?u=rickmastfan67
Could there be some bug with the site cookies? It works fine when I'm in 'private' mode for FF, just not in the normal part that stores the cookies.
@michihdeu
michihdeu
commented
Jul 21, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
I don't think that it's in combination with private mode but it depends whether an user is selected. If cookies are cleared and you open the update page, no user is known and it works. If you select an user via 'Traveler Stats' first, it does not work.
I think it's a duplicate to the problem I've reported that HB is not opened from user stats (because user is always known there).
@wjordawjorda
mentioned this pull request
Jul 21, 2016

Closed

wjorda added a commit
to wjorda/Web
that referenced
this pull request
Jul 21, 2016
@wjorda
hotfix for mislabled columns inTravelMapping#96.
17a30d7
@wjordawjorda
mentioned this pull request
Jul 21, 2016
 Merged

jteresco added a commit
that referenced
this pull request
Jul 22, 2016
@jteresco
Merge pull request#99from Thing342/pull_request_070716
d79f99b
Hotfixes for #96
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@wjorda@jteresco@michihdeu@rickmastfan67

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Pull Request 070716 - #96
Merged
jteresco merged 9 commits into
TravelMapping:masterfrom 
wjorda:pull_request_070716
Jul 17, 2016
Merged
Pull Request 070716#96
jteresco merged 9 commits into
TravelMapping:masterfrom 
wjorda:pull_request_070716
Conversation
@wjorda
@wjordawjorda
commented
Jul 17, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
A compilation of new fixes and features that I've been working on for the past few weeks.
Notes:

*Improved user selection navigation across the site.

*stat.php now shows the current user's stats and ranks at the top, if one is selected.

*Added "back to user page" links on region.php and system.php

*Added user selection to hb.php, as requested in #42.

*Added some statistics to highway pages, including total mileage, LIST name, number of drivers, number clinched, and average mileage per driver.

*Also added per-segment statistics, showing the percentage of drivers who have traveled it.

*Fixes for #73 and #92, as well as implementations of #42, #48, and #93.
@jteresco
jteresco
merged commit 092cd0d
into
TravelMapping:masterJul 17, 2016
@jteresco
jteresco
commented
Jul 17, 2016

Copy link


Copy Markdown

Contributor
Thanks for all of these. They're live on tmtest, and I'll get them over on the main site soon unless some problems are uncovered in a little testing.

This was referenced Jul 17, 2016

Closed


Closed

wjorda added a commit
to wjorda/Web
that referenced
this pull request
Jul 17, 2016
@wjorda
hotfix for mislabled columns inTravelMapping#96.
32de11a
@wjordawjorda
mentioned this pull request
Jul 17, 2016

Closed

@michihdeu
michihdeu
commented
Jul 17, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
Thanks for the great improvement 👍
*Added user selection to hb.php, as requested in #42.
The links from user stats to HB are broken now:
http://tmtest.teresco.org/hb/?u=michih

instead of
http://tm.teresco.org/hb?rg=DEU

but should be
http://tmtest.teresco.org/hb?rg=DEU&rg&u=michih
For that reason, I cannot test the rest of the feature.
@michihdeu
michihdeu
commented
Jul 19, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
*stat.php now shows the current user's stats and ranks at the top, if one is selected.
I like that very much 👍
Nevertheless, I'm not sure how it works:
For instance, German A1 which I've clinched 100%: http://tm.teresco.org/hb/index.php?u=michih&r=deu.a001.
Total Mileage 380.63 mi

LIST Name DEU A1

Average Mileage 112.77 mi (29.63 %)

Total Drivers 12 (9.23 %)

Total Clinched 1 (0.77 %)

8.33 % of drivers
Why is (my?) average milage 29.63% only?
Waypoints

Coordinates Name %
What's indicated in the % column? Values are changing?
(54.094612,10.775914) 14 25.00

(54.052259,10.733814) 15 16.67

(54.034721,10.729179) 16 25.00
Is data not calculated for the selected user but for all users? Which should only be displayed if none is selected? It's a little bit confusing...
Why are higher % values red? I think it should be green, shouldn't it? Maybe 0-50% red to light red, 50-100% light green to green? Just my 2c...
@wjorda
wjorda
commented
Jul 19, 2016

Copy link


Copy Markdown

ContributorAuthor
@michihdeu:

The stats on the HB pages are not dependent on the user.
"Average Mileage" is the average distance traveled by users who have driven the road (ie, people who have driven the road have driven it on average 112.77 miles)
The percentages are the percentage of drivers who have traveled the segment that starts at that waypoint.
@michihdeu
michihdeu
commented
Jul 19, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
OK. I was about to request that it should be shown in tooltip but it already is. Even the traveler names in "total driver" line. Perfect :)
@rickmastfan67
rickmastfan67
commented
Jul 21, 2016

Copy link


Copy Markdown

I don't know if this was to effect the 'update' page, but I can no longer go directly to a route page from it.
http://tm.teresco.org/devel/updates.php#updates

Any link to a route from that page takes me to the "Travel Mapping Highway Browser" instead. So, if I want to double check a route from that page, I have to go to the system, then the route. Very annoying and time consuming.
@michihdeu
michihdeu
commented
Jul 21, 2016

Copy link


Copy Markdown

Contributor
Any link to a route from that page takes me to the "Travel Mapping Highway Browser" instead.
It works for me. I've clicked on the first 6 links (eng.a1173imm,...), all are fine.
@rickmastfan67
rickmastfan67
commented
Jul 21, 2016

Copy link


Copy Markdown

Well, still a no-go for me in both IE & FF. Takes me to this URL everytime: http://tm.teresco.org/hb/?u=rickmastfan67
Could there be some bug with the site cookies? It works fine when I'm in 'private' mode for FF, just not in the normal part that stores the cookies.
@michihdeu
michihdeu
commented
Jul 21, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
I don't think that it's in combination with private mode but it depends whether an user is selected. If cookies are cleared and you open the update page, no user is known and it works. If you select an user via 'Traveler Stats' first, it does not work.
I think it's a duplicate to the problem I've reported that HB is not opened from user stats (because user is always known there).
@wjordawjorda
mentioned this pull request
Jul 21, 2016

Closed

wjorda added a commit
to wjorda/Web
that referenced
this pull request
Jul 21, 2016
@wjorda
hotfix for mislabled columns inTravelMapping#96.
17a30d7
@wjordawjorda
mentioned this pull request
Jul 21, 2016
 Merged

jteresco added a commit
that referenced
this pull request
Jul 22, 2016
@jteresco
Merge pull request#99from Thing342/pull_request_070716
d79f99b
Hotfixes for #96
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@wjorda@jteresco@michihdeu@rickmastfan67

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Pull Request 070716 - #96
Merged
jteresco merged 9 commits into
TravelMapping:masterfrom 
wjorda:pull_request_070716
Jul 17, 2016
Merged
Pull Request 070716#96
jteresco merged 9 commits into
TravelMapping:masterfrom 
wjorda:pull_request_070716
Conversation
@wjorda
@wjordawjorda
commented
Jul 17, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
A compilation of new fixes and features that I've been working on for the past few weeks.
Notes:

*Improved user selection navigation across the site.

*stat.php now shows the current user's stats and ranks at the top, if one is selected.

*Added "back to user page" links on region.php and system.php

*Added user selection to hb.php, as requested in #42.

*Added some statistics to highway pages, including total mileage, LIST name, number of drivers, number clinched, and average mileage per driver.

*Also added per-segment statistics, showing the percentage of drivers who have traveled it.

*Fixes for #73 and #92, as well as implementations of #42, #48, and #93.
@jteresco
jteresco
merged commit 092cd0d
into
TravelMapping:masterJul 17, 2016
@jteresco
jteresco
commented
Jul 17, 2016

Copy link


Copy Markdown

Contributor
Thanks for all of these. They're live on tmtest, and I'll get them over on the main site soon unless some problems are uncovered in a little testing.

This was referenced Jul 17, 2016

Closed


Closed

wjorda added a commit
to wjorda/Web
that referenced
this pull request
Jul 17, 2016
@wjorda
hotfix for mislabled columns inTravelMapping#96.
32de11a
@wjordawjorda
mentioned this pull request
Jul 17, 2016

Closed

@michihdeu
michihdeu
commented
Jul 17, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
Thanks for the great improvement 👍
*Added user selection to hb.php, as requested in #42.
The links from user stats to HB are broken now:
http://tmtest.teresco.org/hb/?u=michih

instead of
http://tm.teresco.org/hb?rg=DEU

but should be
http://tmtest.teresco.org/hb?rg=DEU&rg&u=michih
For that reason, I cannot test the rest of the feature.
@michihdeu
michihdeu
commented
Jul 19, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
*stat.php now shows the current user's stats and ranks at the top, if one is selected.
I like that very much 👍
Nevertheless, I'm not sure how it works:
For instance, German A1 which I've clinched 100%: http://tm.teresco.org/hb/index.php?u=michih&r=deu.a001.
Total Mileage 380.63 mi

LIST Name DEU A1

Average Mileage 112.77 mi (29.63 %)

Total Drivers 12 (9.23 %)

Total Clinched 1 (0.77 %)

8.33 % of drivers
Why is (my?) average milage 29.63% only?
Waypoints

Coordinates Name %
What's indicated in the % column? Values are changing?
(54.094612,10.775914) 14 25.00

(54.052259,10.733814) 15 16.67

(54.034721,10.729179) 16 25.00
Is data not calculated for the selected user but for all users? Which should only be displayed if none is selected? It's a little bit confusing...
Why are higher % values red? I think it should be green, shouldn't it? Maybe 0-50% red to light red, 50-100% light green to green? Just my 2c...
@wjorda
wjorda
commented
Jul 19, 2016

Copy link


Copy Markdown

ContributorAuthor
@michihdeu:

The stats on the HB pages are not dependent on the user.
"Average Mileage" is the average distance traveled by users who have driven the road (ie, people who have driven the road have driven it on average 112.77 miles)
The percentages are the percentage of drivers who have traveled the segment that starts at that waypoint.
@michihdeu
michihdeu
commented
Jul 19, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
OK. I was about to request that it should be shown in tooltip but it already is. Even the traveler names in "total driver" line. Perfect :)
@rickmastfan67
rickmastfan67
commented
Jul 21, 2016

Copy link


Copy Markdown

I don't know if this was to effect the 'update' page, but I can no longer go directly to a route page from it.
http://tm.teresco.org/devel/updates.php#updates

Any link to a route from that page takes me to the "Travel Mapping Highway Browser" instead. So, if I want to double check a route from that page, I have to go to the system, then the route. Very annoying and time consuming.
@michihdeu
michihdeu
commented
Jul 21, 2016

Copy link


Copy Markdown

Contributor
Any link to a route from that page takes me to the "Travel Mapping Highway Browser" instead.
It works for me. I've clicked on the first 6 links (eng.a1173imm,...), all are fine.
@rickmastfan67
rickmastfan67
commented
Jul 21, 2016

Copy link


Copy Markdown

Well, still a no-go for me in both IE & FF. Takes me to this URL everytime: http://tm.teresco.org/hb/?u=rickmastfan67
Could there be some bug with the site cookies? It works fine when I'm in 'private' mode for FF, just not in the normal part that stores the cookies.
@michihdeu
michihdeu
commented
Jul 21, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
I don't think that it's in combination with private mode but it depends whether an user is selected. If cookies are cleared and you open the update page, no user is known and it works. If you select an user via 'Traveler Stats' first, it does not work.
I think it's a duplicate to the problem I've reported that HB is not opened from user stats (because user is always known there).
@wjordawjorda
mentioned this pull request
Jul 21, 2016

Closed

wjorda added a commit
to wjorda/Web
that referenced
this pull request
Jul 21, 2016
@wjorda
hotfix for mislabled columns inTravelMapping#96.
17a30d7
@wjordawjorda
mentioned this pull request
Jul 21, 2016
 Merged

jteresco added a commit
that referenced
this pull request
Jul 22, 2016
@jteresco
Merge pull request#99from Thing342/pull_request_070716
d79f99b
Hotfixes for #96
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@wjorda@jteresco@michihdeu@rickmastfan67

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Pull Request 070716 - #96
Merged
jteresco merged 9 commits into
TravelMapping:masterfrom 
wjorda:pull_request_070716
Jul 17, 2016
Merged
Pull Request 070716#96
jteresco merged 9 commits into
TravelMapping:masterfrom 
wjorda:pull_request_070716
Conversation
@wjorda
@wjordawjorda
commented
Jul 17, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
A compilation of new fixes and features that I've been working on for the past few weeks.
Notes:

*Improved user selection navigation across the site.

*stat.php now shows the current user's stats and ranks at the top, if one is selected.

*Added "back to user page" links on region.php and system.php

*Added user selection to hb.php, as requested in #42.

*Added some statistics to highway pages, including total mileage, LIST name, number of drivers, number clinched, and average mileage per driver.

*Also added per-segment statistics, showing the percentage of drivers who have traveled it.

*Fixes for #73 and #92, as well as implementations of #42, #48, and #93.
@jteresco
jteresco
merged commit 092cd0d
into
TravelMapping:masterJul 17, 2016
@jteresco
jteresco
commented
Jul 17, 2016

Copy link


Copy Markdown

Contributor
Thanks for all of these. They're live on tmtest, and I'll get them over on the main site soon unless some problems are uncovered in a little testing.

This was referenced Jul 17, 2016

Closed


Closed

wjorda added a commit
to wjorda/Web
that referenced
this pull request
Jul 17, 2016
@wjorda
hotfix for mislabled columns inTravelMapping#96.
32de11a
@wjordawjorda
mentioned this pull request
Jul 17, 2016

Closed

@michihdeu
michihdeu
commented
Jul 17, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
Thanks for the great improvement 👍
*Added user selection to hb.php, as requested in #42.
The links from user stats to HB are broken now:
http://tmtest.teresco.org/hb/?u=michih

instead of
http://tm.teresco.org/hb?rg=DEU

but should be
http://tmtest.teresco.org/hb?rg=DEU&rg&u=michih
For that reason, I cannot test the rest of the feature.
@michihdeu
michihdeu
commented
Jul 19, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
*stat.php now shows the current user's stats and ranks at the top, if one is selected.
I like that very much 👍
Nevertheless, I'm not sure how it works:
For instance, German A1 which I've clinched 100%: http://tm.teresco.org/hb/index.php?u=michih&r=deu.a001.
Total Mileage 380.63 mi

LIST Name DEU A1

Average Mileage 112.77 mi (29.63 %)

Total Drivers 12 (9.23 %)

Total Clinched 1 (0.77 %)

8.33 % of drivers
Why is (my?) average milage 29.63% only?
Waypoints

Coordinates Name %
What's indicated in the % column? Values are changing?
(54.094612,10.775914) 14 25.00

(54.052259,10.733814) 15 16.67

(54.034721,10.729179) 16 25.00
Is data not calculated for the selected user but for all users? Which should only be displayed if none is selected? It's a little bit confusing...
Why are higher % values red? I think it should be green, shouldn't it? Maybe 0-50% red to light red, 50-100% light green to green? Just my 2c...
@wjorda
wjorda
commented
Jul 19, 2016

Copy link


Copy Markdown

ContributorAuthor
@michihdeu:

The stats on the HB pages are not dependent on the user.
"Average Mileage" is the average distance traveled by users who have driven the road (ie, people who have driven the road have driven it on average 112.77 miles)
The percentages are the percentage of drivers who have traveled the segment that starts at that waypoint.
@michihdeu
michihdeu
commented
Jul 19, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
OK. I was about to request that it should be shown in tooltip but it already is. Even the traveler names in "total driver" line. Perfect :)
@rickmastfan67
rickmastfan67
commented
Jul 21, 2016

Copy link


Copy Markdown

I don't know if this was to effect the 'update' page, but I can no longer go directly to a route page from it.
http://tm.teresco.org/devel/updates.php#updates

Any link to a route from that page takes me to the "Travel Mapping Highway Browser" instead. So, if I want to double check a route from that page, I have to go to the system, then the route. Very annoying and time consuming.
@michihdeu
michihdeu
commented
Jul 21, 2016

Copy link


Copy Markdown

Contributor
Any link to a route from that page takes me to the "Travel Mapping Highway Browser" instead.
It works for me. I've clicked on the first 6 links (eng.a1173imm,...), all are fine.
@rickmastfan67
rickmastfan67
commented
Jul 21, 2016

Copy link


Copy Markdown

Well, still a no-go for me in both IE & FF. Takes me to this URL everytime: http://tm.teresco.org/hb/?u=rickmastfan67
Could there be some bug with the site cookies? It works fine when I'm in 'private' mode for FF, just not in the normal part that stores the cookies.
@michihdeu
michihdeu
commented
Jul 21, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
I don't think that it's in combination with private mode but it depends whether an user is selected. If cookies are cleared and you open the update page, no user is known and it works. If you select an user via 'Traveler Stats' first, it does not work.
I think it's a duplicate to the problem I've reported that HB is not opened from user stats (because user is always known there).
@wjordawjorda
mentioned this pull request
Jul 21, 2016

Closed

wjorda added a commit
to wjorda/Web
that referenced
this pull request
Jul 21, 2016
@wjorda
hotfix for mislabled columns inTravelMapping#96.
17a30d7
@wjordawjorda
mentioned this pull request
Jul 21, 2016
 Merged

jteresco added a commit
that referenced
this pull request
Jul 22, 2016
@jteresco
Merge pull request#99from Thing342/pull_request_070716
d79f99b
Hotfixes for #96
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@wjorda@jteresco@michihdeu@rickmastfan67

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Pull Request 070716 - #96
Merged
jteresco merged 9 commits into
TravelMapping:masterfrom 
wjorda:pull_request_070716
Jul 17, 2016
Merged
Pull Request 070716#96
jteresco merged 9 commits into
TravelMapping:masterfrom 
wjorda:pull_request_070716
Conversation
@wjorda
@wjordawjorda
commented
Jul 17, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
A compilation of new fixes and features that I've been working on for the past few weeks.
Notes:

*Improved user selection navigation across the site.

*stat.php now shows the current user's stats and ranks at the top, if one is selected.

*Added "back to user page" links on region.php and system.php

*Added user selection to hb.php, as requested in #42.

*Added some statistics to highway pages, including total mileage, LIST name, number of drivers, number clinched, and average mileage per driver.

*Also added per-segment statistics, showing the percentage of drivers who have traveled it.

*Fixes for #73 and #92, as well as implementations of #42, #48, and #93.
@jteresco
jteresco
merged commit 092cd0d
into
TravelMapping:masterJul 17, 2016
@jteresco
jteresco
commented
Jul 17, 2016

Copy link


Copy Markdown

Contributor
Thanks for all of these. They're live on tmtest, and I'll get them over on the main site soon unless some problems are uncovered in a little testing.

This was referenced Jul 17, 2016

Closed


Closed

wjorda added a commit
to wjorda/Web
that referenced
this pull request
Jul 17, 2016
@wjorda
hotfix for mislabled columns inTravelMapping#96.
32de11a
@wjordawjorda
mentioned this pull request
Jul 17, 2016

Closed

@michihdeu
michihdeu
commented
Jul 17, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
Thanks for the great improvement 👍
*Added user selection to hb.php, as requested in #42.
The links from user stats to HB are broken now:
http://tmtest.teresco.org/hb/?u=michih

instead of
http://tm.teresco.org/hb?rg=DEU

but should be
http://tmtest.teresco.org/hb?rg=DEU&rg&u=michih
For that reason, I cannot test the rest of the feature.
@michihdeu
michihdeu
commented
Jul 19, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
*stat.php now shows the current user's stats and ranks at the top, if one is selected.
I like that very much 👍
Nevertheless, I'm not sure how it works:
For instance, German A1 which I've clinched 100%: http://tm.teresco.org/hb/index.php?u=michih&r=deu.a001.
Total Mileage 380.63 mi

LIST Name DEU A1

Average Mileage 112.77 mi (29.63 %)

Total Drivers 12 (9.23 %)

Total Clinched 1 (0.77 %)

8.33 % of drivers
Why is (my?) average milage 29.63% only?
Waypoints

Coordinates Name %
What's indicated in the % column? Values are changing?
(54.094612,10.775914) 14 25.00

(54.052259,10.733814) 15 16.67

(54.034721,10.729179) 16 25.00
Is data not calculated for the selected user but for all users? Which should only be displayed if none is selected? It's a little bit confusing...
Why are higher % values red? I think it should be green, shouldn't it? Maybe 0-50% red to light red, 50-100% light green to green? Just my 2c...
@wjorda
wjorda
commented
Jul 19, 2016

Copy link


Copy Markdown

ContributorAuthor
@michihdeu:

The stats on the HB pages are not dependent on the user.
"Average Mileage" is the average distance traveled by users who have driven the road (ie, people who have driven the road have driven it on average 112.77 miles)
The percentages are the percentage of drivers who have traveled the segment that starts at that waypoint.
@michihdeu
michihdeu
commented
Jul 19, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
OK. I was about to request that it should be shown in tooltip but it already is. Even the traveler names in "total driver" line. Perfect :)
@rickmastfan67
rickmastfan67
commented
Jul 21, 2016

Copy link


Copy Markdown

I don't know if this was to effect the 'update' page, but I can no longer go directly to a route page from it.
http://tm.teresco.org/devel/updates.php#updates

Any link to a route from that page takes me to the "Travel Mapping Highway Browser" instead. So, if I want to double check a route from that page, I have to go to the system, then the route. Very annoying and time consuming.
@michihdeu
michihdeu
commented
Jul 21, 2016

Copy link


Copy Markdown

Contributor
Any link to a route from that page takes me to the "Travel Mapping Highway Browser" instead.
It works for me. I've clicked on the first 6 links (eng.a1173imm,...), all are fine.
@rickmastfan67
rickmastfan67
commented
Jul 21, 2016

Copy link


Copy Markdown

Well, still a no-go for me in both IE & FF. Takes me to this URL everytime: http://tm.teresco.org/hb/?u=rickmastfan67
Could there be some bug with the site cookies? It works fine when I'm in 'private' mode for FF, just not in the normal part that stores the cookies.
@michihdeu
michihdeu
commented
Jul 21, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
I don't think that it's in combination with private mode but it depends whether an user is selected. If cookies are cleared and you open the update page, no user is known and it works. If you select an user via 'Traveler Stats' first, it does not work.
I think it's a duplicate to the problem I've reported that HB is not opened from user stats (because user is always known there).
@wjordawjorda
mentioned this pull request
Jul 21, 2016

Closed

wjorda added a commit
to wjorda/Web
that referenced
this pull request
Jul 21, 2016
@wjorda
hotfix for mislabled columns inTravelMapping#96.
17a30d7
@wjordawjorda
mentioned this pull request
Jul 21, 2016
 Merged

jteresco added a commit
that referenced
this pull request
Jul 22, 2016
@jteresco
Merge pull request#99from Thing342/pull_request_070716
d79f99b
Hotfixes for #96
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@wjorda@jteresco@michihdeu@rickmastfan67

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Pull Request 070716 - #96
Merged
jteresco merged 9 commits into
TravelMapping:masterfrom 
wjorda:pull_request_070716
Jul 17, 2016
Merged
Pull Request 070716#96
jteresco merged 9 commits into
TravelMapping:masterfrom 
wjorda:pull_request_070716
Conversation
@wjorda
@wjordawjorda
commented
Jul 17, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
A compilation of new fixes and features that I've been working on for the past few weeks.
Notes:

*Improved user selection navigation across the site.

*stat.php now shows the current user's stats and ranks at the top, if one is selected.

*Added "back to user page" links on region.php and system.php

*Added user selection to hb.php, as requested in #42.

*Added some statistics to highway pages, including total mileage, LIST name, number of drivers, number clinched, and average mileage per driver.

*Also added per-segment statistics, showing the percentage of drivers who have traveled it.

*Fixes for #73 and #92, as well as implementations of #42, #48, and #93.
@jteresco
jteresco
merged commit 092cd0d
into
TravelMapping:masterJul 17, 2016
@jteresco
jteresco
commented
Jul 17, 2016

Copy link


Copy Markdown

Contributor
Thanks for all of these. They're live on tmtest, and I'll get them over on the main site soon unless some problems are uncovered in a little testing.

This was referenced Jul 17, 2016

Closed


Closed

wjorda added a commit
to wjorda/Web
that referenced
this pull request
Jul 17, 2016
@wjorda
hotfix for mislabled columns inTravelMapping#96.
32de11a
@wjordawjorda
mentioned this pull request
Jul 17, 2016

Closed

@michihdeu
michihdeu
commented
Jul 17, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
Thanks for the great improvement 👍
*Added user selection to hb.php, as requested in #42.
The links from user stats to HB are broken now:
http://tmtest.teresco.org/hb/?u=michih

instead of
http://tm.teresco.org/hb?rg=DEU

but should be
http://tmtest.teresco.org/hb?rg=DEU&rg&u=michih
For that reason, I cannot test the rest of the feature.
@michihdeu
michihdeu
commented
Jul 19, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
*stat.php now shows the current user's stats and ranks at the top, if one is selected.
I like that very much 👍
Nevertheless, I'm not sure how it works:
For instance, German A1 which I've clinched 100%: http://tm.teresco.org/hb/index.php?u=michih&r=deu.a001.
Total Mileage 380.63 mi

LIST Name DEU A1

Average Mileage 112.77 mi (29.63 %)

Total Drivers 12 (9.23 %)

Total Clinched 1 (0.77 %)

8.33 % of drivers
Why is (my?) average milage 29.63% only?
Waypoints

Coordinates Name %
What's indicated in the % column? Values are changing?
(54.094612,10.775914) 14 25.00

(54.052259,10.733814) 15 16.67

(54.034721,10.729179) 16 25.00
Is data not calculated for the selected user but for all users? Which should only be displayed if none is selected? It's a little bit confusing...
Why are higher % values red? I think it should be green, shouldn't it? Maybe 0-50% red to light red, 50-100% light green to green? Just my 2c...
@wjorda
wjorda
commented
Jul 19, 2016

Copy link


Copy Markdown

ContributorAuthor
@michihdeu:

The stats on the HB pages are not dependent on the user.
"Average Mileage" is the average distance traveled by users who have driven the road (ie, people who have driven the road have driven it on average 112.77 miles)
The percentages are the percentage of drivers who have traveled the segment that starts at that waypoint.
@michihdeu
michihdeu
commented
Jul 19, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
OK. I was about to request that it should be shown in tooltip but it already is. Even the traveler names in "total driver" line. Perfect :)
@rickmastfan67
rickmastfan67
commented
Jul 21, 2016

Copy link


Copy Markdown

I don't know if this was to effect the 'update' page, but I can no longer go directly to a route page from it.
http://tm.teresco.org/devel/updates.php#updates

Any link to a route from that page takes me to the "Travel Mapping Highway Browser" instead. So, if I want to double check a route from that page, I have to go to the system, then the route. Very annoying and time consuming.
@michihdeu
michihdeu
commented
Jul 21, 2016

Copy link


Copy Markdown

Contributor
Any link to a route from that page takes me to the "Travel Mapping Highway Browser" instead.
It works for me. I've clicked on the first 6 links (eng.a1173imm,...), all are fine.
@rickmastfan67
rickmastfan67
commented
Jul 21, 2016

Copy link


Copy Markdown

Well, still a no-go for me in both IE & FF. Takes me to this URL everytime: http://tm.teresco.org/hb/?u=rickmastfan67
Could there be some bug with the site cookies? It works fine when I'm in 'private' mode for FF, just not in the normal part that stores the cookies.
@michihdeu
michihdeu
commented
Jul 21, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
I don't think that it's in combination with private mode but it depends whether an user is selected. If cookies are cleared and you open the update page, no user is known and it works. If you select an user via 'Traveler Stats' first, it does not work.
I think it's a duplicate to the problem I've reported that HB is not opened from user stats (because user is always known there).
@wjordawjorda
mentioned this pull request
Jul 21, 2016

Closed

wjorda added a commit
to wjorda/Web
that referenced
this pull request
Jul 21, 2016
@wjorda
hotfix for mislabled columns inTravelMapping#96.
17a30d7
@wjordawjorda
mentioned this pull request
Jul 21, 2016
 Merged

jteresco added a commit
that referenced
this pull request
Jul 22, 2016
@jteresco
Merge pull request#99from Thing342/pull_request_070716
d79f99b
Hotfixes for #96
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@wjorda@jteresco@michihdeu@rickmastfan67

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Pull Request 070716 - #96
Merged
jteresco merged 9 commits into
TravelMapping:masterfrom 
wjorda:pull_request_070716
Jul 17, 2016
Merged
Pull Request 070716#96
jteresco merged 9 commits into
TravelMapping:masterfrom 
wjorda:pull_request_070716
Conversation
@wjorda
@wjordawjorda
commented
Jul 17, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
A compilation of new fixes and features that I've been working on for the past few weeks.
Notes:

*Improved user selection navigation across the site.

*stat.php now shows the current user's stats and ranks at the top, if one is selected.

*Added "back to user page" links on region.php and system.php

*Added user selection to hb.php, as requested in #42.

*Added some statistics to highway pages, including total mileage, LIST name, number of drivers, number clinched, and average mileage per driver.

*Also added per-segment statistics, showing the percentage of drivers who have traveled it.

*Fixes for #73 and #92, as well as implementations of #42, #48, and #93.
@jteresco
jteresco
merged commit 092cd0d
into
TravelMapping:masterJul 17, 2016
@jteresco
jteresco
commented
Jul 17, 2016

Copy link


Copy Markdown

Contributor
Thanks for all of these. They're live on tmtest, and I'll get them over on the main site soon unless some problems are uncovered in a little testing.

This was referenced Jul 17, 2016

Closed


Closed

wjorda added a commit
to wjorda/Web
that referenced
this pull request
Jul 17, 2016
@wjorda
hotfix for mislabled columns inTravelMapping#96.
32de11a
@wjordawjorda
mentioned this pull request
Jul 17, 2016

Closed

@michihdeu
michihdeu
commented
Jul 17, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
Thanks for the great improvement 👍
*Added user selection to hb.php, as requested in #42.
The links from user stats to HB are broken now:
http://tmtest.teresco.org/hb/?u=michih

instead of
http://tm.teresco.org/hb?rg=DEU

but should be
http://tmtest.teresco.org/hb?rg=DEU&rg&u=michih
For that reason, I cannot test the rest of the feature.
@michihdeu
michihdeu
commented
Jul 19, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
*stat.php now shows the current user's stats and ranks at the top, if one is selected.
I like that very much 👍
Nevertheless, I'm not sure how it works:
For instance, German A1 which I've clinched 100%: http://tm.teresco.org/hb/index.php?u=michih&r=deu.a001.
Total Mileage 380.63 mi

LIST Name DEU A1

Average Mileage 112.77 mi (29.63 %)

Total Drivers 12 (9.23 %)

Total Clinched 1 (0.77 %)

8.33 % of drivers
Why is (my?) average milage 29.63% only?
Waypoints

Coordinates Name %
What's indicated in the % column? Values are changing?
(54.094612,10.775914) 14 25.00

(54.052259,10.733814) 15 16.67

(54.034721,10.729179) 16 25.00
Is data not calculated for the selected user but for all users? Which should only be displayed if none is selected? It's a little bit confusing...
Why are higher % values red? I think it should be green, shouldn't it? Maybe 0-50% red to light red, 50-100% light green to green? Just my 2c...
@wjorda
wjorda
commented
Jul 19, 2016

Copy link


Copy Markdown

ContributorAuthor
@michihdeu:

The stats on the HB pages are not dependent on the user.
"Average Mileage" is the average distance traveled by users who have driven the road (ie, people who have driven the road have driven it on average 112.77 miles)
The percentages are the percentage of drivers who have traveled the segment that starts at that waypoint.
@michihdeu
michihdeu
commented
Jul 19, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
OK. I was about to request that it should be shown in tooltip but it already is. Even the traveler names in "total driver" line. Perfect :)
@rickmastfan67
rickmastfan67
commented
Jul 21, 2016

Copy link


Copy Markdown

I don't know if this was to effect the 'update' page, but I can no longer go directly to a route page from it.
http://tm.teresco.org/devel/updates.php#updates

Any link to a route from that page takes me to the "Travel Mapping Highway Browser" instead. So, if I want to double check a route from that page, I have to go to the system, then the route. Very annoying and time consuming.
@michihdeu
michihdeu
commented
Jul 21, 2016

Copy link


Copy Markdown

Contributor
Any link to a route from that page takes me to the "Travel Mapping Highway Browser" instead.
It works for me. I've clicked on the first 6 links (eng.a1173imm,...), all are fine.
@rickmastfan67
rickmastfan67
commented
Jul 21, 2016

Copy link


Copy Markdown

Well, still a no-go for me in both IE & FF. Takes me to this URL everytime: http://tm.teresco.org/hb/?u=rickmastfan67
Could there be some bug with the site cookies? It works fine when I'm in 'private' mode for FF, just not in the normal part that stores the cookies.
@michihdeu
michihdeu
commented
Jul 21, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
I don't think that it's in combination with private mode but it depends whether an user is selected. If cookies are cleared and you open the update page, no user is known and it works. If you select an user via 'Traveler Stats' first, it does not work.
I think it's a duplicate to the problem I've reported that HB is not opened from user stats (because user is always known there).
@wjordawjorda
mentioned this pull request
Jul 21, 2016

Closed

wjorda added a commit
to wjorda/Web
that referenced
this pull request
Jul 21, 2016
@wjorda
hotfix for mislabled columns inTravelMapping#96.
17a30d7
@wjordawjorda
mentioned this pull request
Jul 21, 2016
 Merged

jteresco added a commit
that referenced
this pull request
Jul 22, 2016
@jteresco
Merge pull request#99from Thing342/pull_request_070716
d79f99b
Hotfixes for #96
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@wjorda@jteresco@michihdeu@rickmastfan67