Uh oh!
There was an error while loading. Please reload this page.
Fix AudioMidiPanel missing _reset_to_default - #241
Open
sastraxi wants to merge 2 commits into
Open
Conversation
ArcKnobWidget fires _reset_to_default on LONG_CLICK, but AudioMidiPanel lacked this method, causing AttributeError. Add the standard implementation: look up the parameter by symbol and set_param to its default value. This matches the pattern used by mixer/panel.py (the correct variant that actually calls set_param — unlike gx_cabinet and tap_reverb which only return early when p is None).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ArcKnobWidget fires _reset_to_default on LONG_CLICK, but AudioMidiPanel lacked this method, causing AttributeError.
This fix matches the pattern used by mixer/panel.py.