Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 47 additions & 13 deletions apps/web/src/components/chat/ChatComposer.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,6 +43,10 @@ import {
replaceTextRange,
} from "../../composer-logic";
import { deriveComposerSendState, readFileAsDataUrl } from "../ChatView.logic";
import {
dataTransferHasComposerMention,
makeComposerMentionDragHandlers,
} from "./composerMentionDrag";
import {
type ComposerImageAttachment,
type DraftId,
Expand DownExpand Up@@ -1855,6 +1859,44 @@ export const ChatComposer = memo(function ChatComposer(props: ChatComposerProps)
addComposerImages(files);
focusComposer();
};

const insertComposerTextAtEnd = (text: string): boolean => {
// Pending plan questions keep the composer usable (the replacement path
// routes text into the custom answer), so they do not block insertion.
if (
text.length === 0 ||
isConnecting ||
isComposerApprovalState ||
(environmentUnavailable !== null && activePendingProgress === null)
) {
return false;
}
const rangeEnd = promptRef.current.length;
Comment thread
coderabbitai[bot] marked this conversation as resolved.
return applyPromptReplacement(rangeEnd, rangeEnd, text);
};

// File-tree drags land as mentions. Handled in the capture phase so the
// editor never sees the drop; the load-bearing rules (native stop, "move"
// effect, no eager focus) live in makeComposerMentionDragHandlers.
const composerMentionDragHandlers = makeComposerMentionDragHandlers({
insertMentionAtEnd: insertComposerTextAtEnd,
setDragActive: setIsDragOverComposer,
onInsertRejected: () => {
toastManager.add({
type: "error",
title: "Unable to add to chat",
description: "The composer is busy; try again once it is ready.",
});
},
});

const onComposerMentionDragLeaveCapture = (event: React.DragEvent<HTMLDivElement>) => {
if (!dataTransferHasComposerMention(event.dataTransfer.types)) return;
event.stopPropagation();
const nextTarget = event.relatedTarget;
if (nextTarget instanceof Node && event.currentTarget.contains(nextTarget)) return;
setIsDragOverComposer(false);
};
const handleInterruptPrimaryAction = useCallback(() => {
void onInterrupt();
}, [onInterrupt]);
Expand DownExpand Up@@ -1918,19 +1960,7 @@ export const ChatComposer = memo(function ChatComposer(props: ChatComposerProps)
focusAt: (cursor: number) => {
composerEditorRef.current?.focusAt(cursor);
},
insertTextAtEnd: (text: string) => {
if (
text.length === 0 ||
isConnecting ||
isComposerApprovalState ||
pendingUserInputs.length > 0 ||
(environmentUnavailable !== null && activePendingProgress === null)
) {
return false;
}
const rangeEnd = promptRef.current.length;
return applyPromptReplacement(rangeEnd, rangeEnd, text);
},
insertTextAtEnd: insertComposerTextAtEnd,
openModelPicker: () => {
setIsComposerModelPickerOpen(true);
},
Expand DownExpand Up@@ -2056,6 +2086,10 @@ export const ChatComposer = memo(function ChatComposer(props: ChatComposerProps)
onDragOver={onComposerDragOver}
onDragLeave={onComposerDragLeave}
onDrop={onComposerDrop}
onDragEnterCapture={composerMentionDragHandlers.onDragEnter}
onDragOverCapture={composerMentionDragHandlers.onDragOver}
onDragLeaveCapture={onComposerMentionDragLeaveCapture}
onDropCapture={composerMentionDragHandlers.onDrop}
>
<div
ref={composerSurfaceRef}
Expand Down
123 changes: 123 additions & 0 deletions apps/web/src/components/chat/composerMentionDrag.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,123 @@
import { describe, expect, it } from "@effect/vitest";

import {
COMPOSER_MENTION_DRAG_TYPE,
type ComposerMentionDropHost,
composerMentionFromTreePath,
dataTransferHasComposerMention,
makeComposerMentionDragHandlers,
} from "./composerMentionDrag.ts";

const makeDragEvent = (options?: { mention?: string; types?: ReadonlyArray<string> }) => {
const mention = options?.mention ?? "[index.md](docs/index.md)";
const calls: Array<string> = [];
const event = {
dataTransfer: {
types: options?.types ?? [COMPOSER_MENTION_DRAG_TYPE, "text/plain"],
getData: (format: string) => (format === COMPOSER_MENTION_DRAG_TYPE ? mention : ""),
dropEffect: "none",
},
nativeEvent: {
stopPropagation: () => void calls.push("nativeStopPropagation"),
},
preventDefault: () => void calls.push("preventDefault"),
stopPropagation: () => void calls.push("stopPropagation"),
};
return { event, calls };
};

const makeHost = (insertResult = true) => {
const log: Array<string> = [];
const host: ComposerMentionDropHost = {
insertMentionAtEnd: (text) => {
log.push(`insert:${text}`);
return insertResult;
},
setDragActive: (active) => void log.push(`active:${active}`),
onInsertRejected: () => void log.push("rejected"),
};
return { host, log };
};

describe("composerMentionFromTreePath", () => {
it("serializes a file path into a mention", () => {
expect(composerMentionFromTreePath("docs/index.md")).toBe("[index.md](docs/index.md)");
});

it("strips the trailing slash directory rows carry", () => {
expect(composerMentionFromTreePath("docs/architecture/")).toBe(
"[architecture](docs/architecture)",
);
});

it("rejects drags that carry no path", () => {
expect(composerMentionFromTreePath("")).toBeNull();
expect(composerMentionFromTreePath("/")).toBeNull();
});
});

describe("dataTransferHasComposerMention", () => {
it("detects the mention payload among drag types", () => {
expect(dataTransferHasComposerMention([COMPOSER_MENTION_DRAG_TYPE, "text/plain"])).toBe(true);
expect(dataTransferHasComposerMention(["Files"])).toBe(false);
expect(dataTransferHasComposerMention([])).toBe(false);
});
});

describe("makeComposerMentionDragHandlers", () => {
it("leaves drags without the mention payload alone", () => {
const { host, log } = makeHost();
const handlers = makeComposerMentionDragHandlers(host);
const { event, calls } = makeDragEvent({ types: ["Files"] });
handlers.onDragEnter(event);
handlers.onDragOver(event);
handlers.onDrop(event);
expect(calls).toEqual([]);
expect(log).toEqual([]);
});

it("stops the native event too, not just the synthetic one", () => {
// React's stopPropagation only halts synthetic dispatch; without the
// native stop, the editor's own DOM listeners process the drop and sync
// their stale state back over the inserted mention.
const { host } = makeHost();
const handlers = makeComposerMentionDragHandlers(host);
const { event, calls } = makeDragEvent();
handlers.onDrop(event);
expect(calls).toContain("preventDefault");
expect(calls).toContain("stopPropagation");
expect(calls).toContain("nativeStopPropagation");
});

it('answers dragover with the "move" effect the tree allows', () => {
// Naming an effect outside the source's effectAllowed makes the browser
// cancel the drop without ever firing it.
const { host } = makeHost();
const handlers = makeComposerMentionDragHandlers(host);
const { event } = makeDragEvent();
handlers.onDragOver(event);
expect(event.dataTransfer.dropEffect).toBe("move");
});

it("inserts the mention with its trailing space and clears the highlight", () => {
const { host, log } = makeHost();
const handlers = makeComposerMentionDragHandlers(host);
handlers.onDragEnter(makeDragEvent().event);
handlers.onDrop(makeDragEvent().event);
expect(log).toEqual(["active:true", "active:false", "insert:[index.md](docs/index.md) "]);
});

it("reports a rejected insert instead of failing silently", () => {
const { host, log } = makeHost(false);
const handlers = makeComposerMentionDragHandlers(host);
handlers.onDrop(makeDragEvent().event);
expect(log).toContain("rejected");
});

it("ignores a drop whose payload is empty", () => {
const { host, log } = makeHost();
const handlers = makeComposerMentionDragHandlers(host);
handlers.onDrop(makeDragEvent({ mention: "" }).event);
expect(log).toEqual(["active:false"]);
});
});
98 changes: 98 additions & 0 deletions apps/web/src/components/chat/composerMentionDrag.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,98 @@
import { serializeComposerFileLink } from "@t3tools/shared/composerTrigger";

/**
* Drag payload type carrying a serialized composer mention. Set on drags that
* start in the workspace file tree so the composer can tell them apart from
* OS file drags and plain text selections.
*/
export const COMPOSER_MENTION_DRAG_TYPE = "application/x-t3code-composer-mention";

export function composerMentionFromTreePath(treePath: string): string | null {
const relativePath = treePath.replace(/\/+$/, "");
if (relativePath.length === 0) {
return null;
}
return serializeComposerFileLink(relativePath);
}

export function dataTransferHasComposerMention(types: ReadonlyArray<string>): boolean {
return types.includes(COMPOSER_MENTION_DRAG_TYPE);
}

export interface ComposerMentionDragTransfer {
readonly types: ReadonlyArray<string>;
getData(format: string): string;
dropEffect: string;
}

export interface ComposerMentionDragEvent {
readonly dataTransfer: ComposerMentionDragTransfer;
readonly nativeEvent: { stopPropagation(): void };
preventDefault(): void;
stopPropagation(): void;
}

/**
* What a mention drop is allowed to do to the composer. Deliberately narrow:
* there is no way to focus the editor from here. Focusing it synchronously
* during the drop makes the not-yet-reconciled editor sync its stale empty
* state back over the inserted mention; the insert path already focuses on
* the next frame, after the editor has caught up.
*/
export interface ComposerMentionDropHost {
insertMentionAtEnd(text: string): boolean;
setDragActive(active: boolean): void;
onInsertRejected(): void;
}

export interface ComposerMentionDragHandlers {
onDragEnter(event: ComposerMentionDragEvent): void;
onDragOver(event: ComposerMentionDragEvent): void;
onDrop(event: ComposerMentionDragEvent): void;
}

export function makeComposerMentionDragHandlers(
host: ComposerMentionDropHost,
): ComposerMentionDragHandlers {
// Claim the event for the composer: React's stopPropagation only halts the
// synthetic dispatch, so the native event must be stopped too or the
// editor's own DOM listeners still process the drag.
const claim = (event: ComposerMentionDragEvent): boolean => {
if (!dataTransferHasComposerMention(event.dataTransfer.types)) {
return false;
}
event.preventDefault();
event.stopPropagation();
event.nativeEvent.stopPropagation();
return true;
};
return {
onDragEnter(event) {
if (claim(event)) {
host.setDragActive(true);
}
},
onDragOver(event) {
if (!claim(event)) {
return;
}
// The tree constrains its drags to effectAllowed "move"; naming any
// other effect makes the browser cancel the drop without firing it.
event.dataTransfer.dropEffect = "move";
host.setDragActive(true);
},
onDrop(event) {
if (!claim(event)) {
return;
}
host.setDragActive(false);
const mention = event.dataTransfer.getData(COMPOSER_MENTION_DRAG_TYPE);
if (mention.length === 0) {
return;
}
if (!host.insertMentionAtEnd(`${mention} `)) {
host.onInsertRejected();
}
},
};
}
44 changes: 44 additions & 0 deletions apps/web/src/components/files/FileBrowserPanel.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,6 +16,7 @@ import { cn } from "~/lib/utils";
import { readLocalApi } from "~/localApi";
import { T3_PIERRE_ICONS } from "~/pierre-icons";

import { createFileTreeDragMentionController } from "./fileTreeDragMention";
import { useProjectEntriesQuery } from "./projectFilesQueryState";

interface FileBrowserPanelProps {
Expand DownExpand Up@@ -128,6 +129,14 @@ export default function FileBrowserPanel({
showEntryContextMenuRef.current = showEntryContextMenu;
});

const treeModelRef = useRef<ReturnType<typeof useFileTree>["model"] | null>(null);
const dragMention = useMemo(
() =>
createFileTreeDragMentionController({
deselect: (path) => treeModelRef.current?.getItem(path)?.deselect(),
}),
[],
);
const { model } = useFileTree({
composition: {
contextMenu: {
Expand All@@ -137,12 +146,21 @@ export default function FileBrowserPanel({
},
},
},
// Rows only need to be draggable so entries can be dropped into the chat
// composer; rearranging files inside the tree stays off.
dragAndDrop: { canDrop: () => false },
density: "compact",
fileTreeSearchMode: "hide-non-matches",
flattenEmptyDirectories: true,
initialExpansion: 1,
icons: T3_PIERRE_ICONS,
onSelectionChange: (selectedPaths) => {
dragMention.handleSelectionChange(selectedPaths);
// Starting a drag selects the dragged row; that selection is a side
// effect of the gesture, not a request to open the file.
if (dragMention.isDragInProgress()) {
return;
}
const selectedPath = selectedPaths.at(-1)?.replace(/\/$/, "");
if (selectedPath && entryKindsRef.current.get(selectedPath) === "file") {
onOpenFile(selectedPath);
Expand All@@ -165,8 +183,34 @@ export default function FileBrowserPanel({
[entries],
);

// Tag tree drags with the composer mention payload. The row is read from
// the composed event path (the tree's shadow root is open), so this does
// not depend on running after the tree's own dragstart handler; the drag
// data store is writable for every dragstart listener in the dispatch.
// The capture phase runs before the tree's own dragstart handler selects
// the dragged row, so the drag flag is up before that selection emits.
const panelRef = useRef<HTMLDivElement | null>(null);
useEffect(() => {
treeModelRef.current = model;
}, [model]);
useEffect(() => {
const panel = panelRef.current;
if (panel === null) {
return;
}
const handleDragStart = (event: DragEvent) => dragMention.handleDragStart(event);
const handleDragEnd = () => dragMention.handleDragEnd();
panel.addEventListener("dragstart", handleDragStart, true);
panel.addEventListener("dragend", handleDragEnd);
return () => {
panel.removeEventListener("dragstart", handleDragStart, true);
panel.removeEventListener("dragend", handleDragEnd);
};
}, [dragMention]);

return (
<div
ref={panelRef}
className="flex min-h-0 flex-1 flex-col bg-background"
data-file-browser-panel={`${environmentId}:${cwd}`}
>
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 47 additions & 13 deletions apps/web/src/components/chat/ChatComposer.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,6 +43,10 @@ import {
replaceTextRange,
} from "../../composer-logic";
import { deriveComposerSendState, readFileAsDataUrl } from "../ChatView.logic";
import {
dataTransferHasComposerMention,
makeComposerMentionDragHandlers,
} from "./composerMentionDrag";
import {
type ComposerImageAttachment,
type DraftId,
Expand DownExpand Up@@ -1855,6 +1859,44 @@ export const ChatComposer = memo(function ChatComposer(props: ChatComposerProps)
addComposerImages(files);
focusComposer();
};

const insertComposerTextAtEnd = (text: string): boolean => {
// Pending plan questions keep the composer usable (the replacement path
// routes text into the custom answer), so they do not block insertion.
if (
text.length === 0 ||
isConnecting ||
isComposerApprovalState ||
(environmentUnavailable !== null && activePendingProgress === null)
) {
return false;
}
const rangeEnd = promptRef.current.length;
Comment thread
coderabbitai[bot] marked this conversation as resolved.
return applyPromptReplacement(rangeEnd, rangeEnd, text);
};

// File-tree drags land as mentions. Handled in the capture phase so the
// editor never sees the drop; the load-bearing rules (native stop, "move"
// effect, no eager focus) live in makeComposerMentionDragHandlers.
const composerMentionDragHandlers = makeComposerMentionDragHandlers({
insertMentionAtEnd: insertComposerTextAtEnd,
setDragActive: setIsDragOverComposer,
onInsertRejected: () => {
toastManager.add({
type: "error",
title: "Unable to add to chat",
description: "The composer is busy; try again once it is ready.",
});
},
});

const onComposerMentionDragLeaveCapture = (event: React.DragEvent<HTMLDivElement>) => {
if (!dataTransferHasComposerMention(event.dataTransfer.types)) return;
event.stopPropagation();
const nextTarget = event.relatedTarget;
if (nextTarget instanceof Node && event.currentTarget.contains(nextTarget)) return;
setIsDragOverComposer(false);
};
const handleInterruptPrimaryAction = useCallback(() => {
void onInterrupt();
}, [onInterrupt]);
Expand DownExpand Up@@ -1918,19 +1960,7 @@ export const ChatComposer = memo(function ChatComposer(props: ChatComposerProps)
focusAt: (cursor: number) => {
composerEditorRef.current?.focusAt(cursor);
},
insertTextAtEnd: (text: string) => {
if (
text.length === 0 ||
isConnecting ||
isComposerApprovalState ||
pendingUserInputs.length > 0 ||
(environmentUnavailable !== null && activePendingProgress === null)
) {
return false;
}
const rangeEnd = promptRef.current.length;
return applyPromptReplacement(rangeEnd, rangeEnd, text);
},
insertTextAtEnd: insertComposerTextAtEnd,
openModelPicker: () => {
setIsComposerModelPickerOpen(true);
},
Expand DownExpand Up@@ -2056,6 +2086,10 @@ export const ChatComposer = memo(function ChatComposer(props: ChatComposerProps)
onDragOver={onComposerDragOver}
onDragLeave={onComposerDragLeave}
onDrop={onComposerDrop}
onDragEnterCapture={composerMentionDragHandlers.onDragEnter}
onDragOverCapture={composerMentionDragHandlers.onDragOver}
onDragLeaveCapture={onComposerMentionDragLeaveCapture}
onDropCapture={composerMentionDragHandlers.onDrop}
>
<div
ref={composerSurfaceRef}
Expand Down
123 changes: 123 additions & 0 deletions apps/web/src/components/chat/composerMentionDrag.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,123 @@
import { describe, expect, it } from "@effect/vitest";

import {
COMPOSER_MENTION_DRAG_TYPE,
type ComposerMentionDropHost,
composerMentionFromTreePath,
dataTransferHasComposerMention,
makeComposerMentionDragHandlers,
} from "./composerMentionDrag.ts";

const makeDragEvent = (options?: { mention?: string; types?: ReadonlyArray<string> }) => {
const mention = options?.mention ?? "[index.md](docs/index.md)";
const calls: Array<string> = [];
const event = {
dataTransfer: {
types: options?.types ?? [COMPOSER_MENTION_DRAG_TYPE, "text/plain"],
getData: (format: string) => (format === COMPOSER_MENTION_DRAG_TYPE ? mention : ""),
dropEffect: "none",
},
nativeEvent: {
stopPropagation: () => void calls.push("nativeStopPropagation"),
},
preventDefault: () => void calls.push("preventDefault"),
stopPropagation: () => void calls.push("stopPropagation"),
};
return { event, calls };
};

const makeHost = (insertResult = true) => {
const log: Array<string> = [];
const host: ComposerMentionDropHost = {
insertMentionAtEnd: (text) => {
log.push(`insert:${text}`);
return insertResult;
},
setDragActive: (active) => void log.push(`active:${active}`),
onInsertRejected: () => void log.push("rejected"),
};
return { host, log };
};

describe("composerMentionFromTreePath", () => {
it("serializes a file path into a mention", () => {
expect(composerMentionFromTreePath("docs/index.md")).toBe("[index.md](docs/index.md)");
});

it("strips the trailing slash directory rows carry", () => {
expect(composerMentionFromTreePath("docs/architecture/")).toBe(
"[architecture](docs/architecture)",
);
});

it("rejects drags that carry no path", () => {
expect(composerMentionFromTreePath("")).toBeNull();
expect(composerMentionFromTreePath("/")).toBeNull();
});
});

describe("dataTransferHasComposerMention", () => {
it("detects the mention payload among drag types", () => {
expect(dataTransferHasComposerMention([COMPOSER_MENTION_DRAG_TYPE, "text/plain"])).toBe(true);
expect(dataTransferHasComposerMention(["Files"])).toBe(false);
expect(dataTransferHasComposerMention([])).toBe(false);
});
});

describe("makeComposerMentionDragHandlers", () => {
it("leaves drags without the mention payload alone", () => {
const { host, log } = makeHost();
const handlers = makeComposerMentionDragHandlers(host);
const { event, calls } = makeDragEvent({ types: ["Files"] });
handlers.onDragEnter(event);
handlers.onDragOver(event);
handlers.onDrop(event);
expect(calls).toEqual([]);
expect(log).toEqual([]);
});

it("stops the native event too, not just the synthetic one", () => {
// React's stopPropagation only halts synthetic dispatch; without the
// native stop, the editor's own DOM listeners process the drop and sync
// their stale state back over the inserted mention.
const { host } = makeHost();
const handlers = makeComposerMentionDragHandlers(host);
const { event, calls } = makeDragEvent();
handlers.onDrop(event);
expect(calls).toContain("preventDefault");
expect(calls).toContain("stopPropagation");
expect(calls).toContain("nativeStopPropagation");
});

it('answers dragover with the "move" effect the tree allows', () => {
// Naming an effect outside the source's effectAllowed makes the browser
// cancel the drop without ever firing it.
const { host } = makeHost();
const handlers = makeComposerMentionDragHandlers(host);
const { event } = makeDragEvent();
handlers.onDragOver(event);
expect(event.dataTransfer.dropEffect).toBe("move");
});

it("inserts the mention with its trailing space and clears the highlight", () => {
const { host, log } = makeHost();
const handlers = makeComposerMentionDragHandlers(host);
handlers.onDragEnter(makeDragEvent().event);
handlers.onDrop(makeDragEvent().event);
expect(log).toEqual(["active:true", "active:false", "insert:[index.md](docs/index.md) "]);
});

it("reports a rejected insert instead of failing silently", () => {
const { host, log } = makeHost(false);
const handlers = makeComposerMentionDragHandlers(host);
handlers.onDrop(makeDragEvent().event);
expect(log).toContain("rejected");
});

it("ignores a drop whose payload is empty", () => {
const { host, log } = makeHost();
const handlers = makeComposerMentionDragHandlers(host);
handlers.onDrop(makeDragEvent({ mention: "" }).event);
expect(log).toEqual(["active:false"]);
});
});
98 changes: 98 additions & 0 deletions apps/web/src/components/chat/composerMentionDrag.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,98 @@
import { serializeComposerFileLink } from "@t3tools/shared/composerTrigger";

/**
* Drag payload type carrying a serialized composer mention. Set on drags that
* start in the workspace file tree so the composer can tell them apart from
* OS file drags and plain text selections.
*/
export const COMPOSER_MENTION_DRAG_TYPE = "application/x-t3code-composer-mention";

export function composerMentionFromTreePath(treePath: string): string | null {
const relativePath = treePath.replace(/\/+$/, "");
if (relativePath.length === 0) {
return null;
}
return serializeComposerFileLink(relativePath);
}

export function dataTransferHasComposerMention(types: ReadonlyArray<string>): boolean {
return types.includes(COMPOSER_MENTION_DRAG_TYPE);
}

export interface ComposerMentionDragTransfer {
readonly types: ReadonlyArray<string>;
getData(format: string): string;
dropEffect: string;
}

export interface ComposerMentionDragEvent {
readonly dataTransfer: ComposerMentionDragTransfer;
readonly nativeEvent: { stopPropagation(): void };
preventDefault(): void;
stopPropagation(): void;
}

/**
* What a mention drop is allowed to do to the composer. Deliberately narrow:
* there is no way to focus the editor from here. Focusing it synchronously
* during the drop makes the not-yet-reconciled editor sync its stale empty
* state back over the inserted mention; the insert path already focuses on
* the next frame, after the editor has caught up.
*/
export interface ComposerMentionDropHost {
insertMentionAtEnd(text: string): boolean;
setDragActive(active: boolean): void;
onInsertRejected(): void;
}

export interface ComposerMentionDragHandlers {
onDragEnter(event: ComposerMentionDragEvent): void;
onDragOver(event: ComposerMentionDragEvent): void;
onDrop(event: ComposerMentionDragEvent): void;
}

export function makeComposerMentionDragHandlers(
host: ComposerMentionDropHost,
): ComposerMentionDragHandlers {
// Claim the event for the composer: React's stopPropagation only halts the
// synthetic dispatch, so the native event must be stopped too or the
// editor's own DOM listeners still process the drag.
const claim = (event: ComposerMentionDragEvent): boolean => {
if (!dataTransferHasComposerMention(event.dataTransfer.types)) {
return false;
}
event.preventDefault();
event.stopPropagation();
event.nativeEvent.stopPropagation();
return true;
};
return {
onDragEnter(event) {
if (claim(event)) {
host.setDragActive(true);
}
},
onDragOver(event) {
if (!claim(event)) {
return;
}
// The tree constrains its drags to effectAllowed "move"; naming any
// other effect makes the browser cancel the drop without firing it.
event.dataTransfer.dropEffect = "move";
host.setDragActive(true);
},
onDrop(event) {
if (!claim(event)) {
return;
}
host.setDragActive(false);
const mention = event.dataTransfer.getData(COMPOSER_MENTION_DRAG_TYPE);
if (mention.length === 0) {
return;
}
if (!host.insertMentionAtEnd(`${mention} `)) {
host.onInsertRejected();
}
},
};
}
44 changes: 44 additions & 0 deletions apps/web/src/components/files/FileBrowserPanel.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,6 +16,7 @@ import { cn } from "~/lib/utils";
import { readLocalApi } from "~/localApi";
import { T3_PIERRE_ICONS } from "~/pierre-icons";

import { createFileTreeDragMentionController } from "./fileTreeDragMention";
import { useProjectEntriesQuery } from "./projectFilesQueryState";

interface FileBrowserPanelProps {
Expand DownExpand Up@@ -128,6 +129,14 @@ export default function FileBrowserPanel({
showEntryContextMenuRef.current = showEntryContextMenu;
});

const treeModelRef = useRef<ReturnType<typeof useFileTree>["model"] | null>(null);
const dragMention = useMemo(
() =>
createFileTreeDragMentionController({
deselect: (path) => treeModelRef.current?.getItem(path)?.deselect(),
}),
[],
);
const { model } = useFileTree({
composition: {
contextMenu: {
Expand All@@ -137,12 +146,21 @@ export default function FileBrowserPanel({
},
},
},
// Rows only need to be draggable so entries can be dropped into the chat
// composer; rearranging files inside the tree stays off.
dragAndDrop: { canDrop: () => false },
density: "compact",
fileTreeSearchMode: "hide-non-matches",
flattenEmptyDirectories: true,
initialExpansion: 1,
icons: T3_PIERRE_ICONS,
onSelectionChange: (selectedPaths) => {
dragMention.handleSelectionChange(selectedPaths);
// Starting a drag selects the dragged row; that selection is a side
// effect of the gesture, not a request to open the file.
if (dragMention.isDragInProgress()) {
return;
}
const selectedPath = selectedPaths.at(-1)?.replace(/\/$/, "");
if (selectedPath && entryKindsRef.current.get(selectedPath) === "file") {
onOpenFile(selectedPath);
Expand All@@ -165,8 +183,34 @@ export default function FileBrowserPanel({
[entries],
);

// Tag tree drags with the composer mention payload. The row is read from
// the composed event path (the tree's shadow root is open), so this does
// not depend on running after the tree's own dragstart handler; the drag
// data store is writable for every dragstart listener in the dispatch.
// The capture phase runs before the tree's own dragstart handler selects
// the dragged row, so the drag flag is up before that selection emits.
const panelRef = useRef<HTMLDivElement | null>(null);
useEffect(() => {
treeModelRef.current = model;
}, [model]);
useEffect(() => {
const panel = panelRef.current;
if (panel === null) {
return;
}
const handleDragStart = (event: DragEvent) => dragMention.handleDragStart(event);
const handleDragEnd = () => dragMention.handleDragEnd();
panel.addEventListener("dragstart", handleDragStart, true);
panel.addEventListener("dragend", handleDragEnd);
return () => {
panel.removeEventListener("dragstart", handleDragStart, true);
panel.removeEventListener("dragend", handleDragEnd);
};
}, [dragMention]);

return (
<div
ref={panelRef}
className="flex min-h-0 flex-1 flex-col bg-background"
data-file-browser-panel={`${environmentId}:${cwd}`}
>
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 47 additions & 13 deletions apps/web/src/components/chat/ChatComposer.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,6 +43,10 @@ import {
replaceTextRange,
} from "../../composer-logic";
import { deriveComposerSendState, readFileAsDataUrl } from "../ChatView.logic";
import {
dataTransferHasComposerMention,
makeComposerMentionDragHandlers,
} from "./composerMentionDrag";
import {
type ComposerImageAttachment,
type DraftId,
Expand DownExpand Up@@ -1855,6 +1859,44 @@ export const ChatComposer = memo(function ChatComposer(props: ChatComposerProps)
addComposerImages(files);
focusComposer();
};

const insertComposerTextAtEnd = (text: string): boolean => {
// Pending plan questions keep the composer usable (the replacement path
// routes text into the custom answer), so they do not block insertion.
if (
text.length === 0 ||
isConnecting ||
isComposerApprovalState ||
(environmentUnavailable !== null && activePendingProgress === null)
) {
return false;
}
const rangeEnd = promptRef.current.length;
Comment thread
coderabbitai[bot] marked this conversation as resolved.
return applyPromptReplacement(rangeEnd, rangeEnd, text);
};

// File-tree drags land as mentions. Handled in the capture phase so the
// editor never sees the drop; the load-bearing rules (native stop, "move"
// effect, no eager focus) live in makeComposerMentionDragHandlers.
const composerMentionDragHandlers = makeComposerMentionDragHandlers({
insertMentionAtEnd: insertComposerTextAtEnd,
setDragActive: setIsDragOverComposer,
onInsertRejected: () => {
toastManager.add({
type: "error",
title: "Unable to add to chat",
description: "The composer is busy; try again once it is ready.",
});
},
});

const onComposerMentionDragLeaveCapture = (event: React.DragEvent<HTMLDivElement>) => {
if (!dataTransferHasComposerMention(event.dataTransfer.types)) return;
event.stopPropagation();
const nextTarget = event.relatedTarget;
if (nextTarget instanceof Node && event.currentTarget.contains(nextTarget)) return;
setIsDragOverComposer(false);
};
const handleInterruptPrimaryAction = useCallback(() => {
void onInterrupt();
}, [onInterrupt]);
Expand DownExpand Up@@ -1918,19 +1960,7 @@ export const ChatComposer = memo(function ChatComposer(props: ChatComposerProps)
focusAt: (cursor: number) => {
composerEditorRef.current?.focusAt(cursor);
},
insertTextAtEnd: (text: string) => {
if (
text.length === 0 ||
isConnecting ||
isComposerApprovalState ||
pendingUserInputs.length > 0 ||
(environmentUnavailable !== null && activePendingProgress === null)
) {
return false;
}
const rangeEnd = promptRef.current.length;
return applyPromptReplacement(rangeEnd, rangeEnd, text);
},
insertTextAtEnd: insertComposerTextAtEnd,
openModelPicker: () => {
setIsComposerModelPickerOpen(true);
},
Expand DownExpand Up@@ -2056,6 +2086,10 @@ export const ChatComposer = memo(function ChatComposer(props: ChatComposerProps)
onDragOver={onComposerDragOver}
onDragLeave={onComposerDragLeave}
onDrop={onComposerDrop}
onDragEnterCapture={composerMentionDragHandlers.onDragEnter}
onDragOverCapture={composerMentionDragHandlers.onDragOver}
onDragLeaveCapture={onComposerMentionDragLeaveCapture}
onDropCapture={composerMentionDragHandlers.onDrop}
>
<div
ref={composerSurfaceRef}
Expand Down
123 changes: 123 additions & 0 deletions apps/web/src/components/chat/composerMentionDrag.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,123 @@
import { describe, expect, it } from "@effect/vitest";

import {
COMPOSER_MENTION_DRAG_TYPE,
type ComposerMentionDropHost,
composerMentionFromTreePath,
dataTransferHasComposerMention,
makeComposerMentionDragHandlers,
} from "./composerMentionDrag.ts";

const makeDragEvent = (options?: { mention?: string; types?: ReadonlyArray<string> }) => {
const mention = options?.mention ?? "[index.md](docs/index.md)";
const calls: Array<string> = [];
const event = {
dataTransfer: {
types: options?.types ?? [COMPOSER_MENTION_DRAG_TYPE, "text/plain"],
getData: (format: string) => (format === COMPOSER_MENTION_DRAG_TYPE ? mention : ""),
dropEffect: "none",
},
nativeEvent: {
stopPropagation: () => void calls.push("nativeStopPropagation"),
},
preventDefault: () => void calls.push("preventDefault"),
stopPropagation: () => void calls.push("stopPropagation"),
};
return { event, calls };
};

const makeHost = (insertResult = true) => {
const log: Array<string> = [];
const host: ComposerMentionDropHost = {
insertMentionAtEnd: (text) => {
log.push(`insert:${text}`);
return insertResult;
},
setDragActive: (active) => void log.push(`active:${active}`),
onInsertRejected: () => void log.push("rejected"),
};
return { host, log };
};

describe("composerMentionFromTreePath", () => {
it("serializes a file path into a mention", () => {
expect(composerMentionFromTreePath("docs/index.md")).toBe("[index.md](docs/index.md)");
});

it("strips the trailing slash directory rows carry", () => {
expect(composerMentionFromTreePath("docs/architecture/")).toBe(
"[architecture](docs/architecture)",
);
});

it("rejects drags that carry no path", () => {
expect(composerMentionFromTreePath("")).toBeNull();
expect(composerMentionFromTreePath("/")).toBeNull();
});
});

describe("dataTransferHasComposerMention", () => {
it("detects the mention payload among drag types", () => {
expect(dataTransferHasComposerMention([COMPOSER_MENTION_DRAG_TYPE, "text/plain"])).toBe(true);
expect(dataTransferHasComposerMention(["Files"])).toBe(false);
expect(dataTransferHasComposerMention([])).toBe(false);
});
});

describe("makeComposerMentionDragHandlers", () => {
it("leaves drags without the mention payload alone", () => {
const { host, log } = makeHost();
const handlers = makeComposerMentionDragHandlers(host);
const { event, calls } = makeDragEvent({ types: ["Files"] });
handlers.onDragEnter(event);
handlers.onDragOver(event);
handlers.onDrop(event);
expect(calls).toEqual([]);
expect(log).toEqual([]);
});

it("stops the native event too, not just the synthetic one", () => {
// React's stopPropagation only halts synthetic dispatch; without the
// native stop, the editor's own DOM listeners process the drop and sync
// their stale state back over the inserted mention.
const { host } = makeHost();
const handlers = makeComposerMentionDragHandlers(host);
const { event, calls } = makeDragEvent();
handlers.onDrop(event);
expect(calls).toContain("preventDefault");
expect(calls).toContain("stopPropagation");
expect(calls).toContain("nativeStopPropagation");
});

it('answers dragover with the "move" effect the tree allows', () => {
// Naming an effect outside the source's effectAllowed makes the browser
// cancel the drop without ever firing it.
const { host } = makeHost();
const handlers = makeComposerMentionDragHandlers(host);
const { event } = makeDragEvent();
handlers.onDragOver(event);
expect(event.dataTransfer.dropEffect).toBe("move");
});

it("inserts the mention with its trailing space and clears the highlight", () => {
const { host, log } = makeHost();
const handlers = makeComposerMentionDragHandlers(host);
handlers.onDragEnter(makeDragEvent().event);
handlers.onDrop(makeDragEvent().event);
expect(log).toEqual(["active:true", "active:false", "insert:[index.md](docs/index.md) "]);
});

it("reports a rejected insert instead of failing silently", () => {
const { host, log } = makeHost(false);
const handlers = makeComposerMentionDragHandlers(host);
handlers.onDrop(makeDragEvent().event);
expect(log).toContain("rejected");
});

it("ignores a drop whose payload is empty", () => {
const { host, log } = makeHost();
const handlers = makeComposerMentionDragHandlers(host);
handlers.onDrop(makeDragEvent({ mention: "" }).event);
expect(log).toEqual(["active:false"]);
});
});
98 changes: 98 additions & 0 deletions apps/web/src/components/chat/composerMentionDrag.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,98 @@
import { serializeComposerFileLink } from "@t3tools/shared/composerTrigger";

/**
* Drag payload type carrying a serialized composer mention. Set on drags that
* start in the workspace file tree so the composer can tell them apart from
* OS file drags and plain text selections.
*/
export const COMPOSER_MENTION_DRAG_TYPE = "application/x-t3code-composer-mention";

export function composerMentionFromTreePath(treePath: string): string | null {
const relativePath = treePath.replace(/\/+$/, "");
if (relativePath.length === 0) {
return null;
}
return serializeComposerFileLink(relativePath);
}

export function dataTransferHasComposerMention(types: ReadonlyArray<string>): boolean {
return types.includes(COMPOSER_MENTION_DRAG_TYPE);
}

export interface ComposerMentionDragTransfer {
readonly types: ReadonlyArray<string>;
getData(format: string): string;
dropEffect: string;
}

export interface ComposerMentionDragEvent {
readonly dataTransfer: ComposerMentionDragTransfer;
readonly nativeEvent: { stopPropagation(): void };
preventDefault(): void;
stopPropagation(): void;
}

/**
* What a mention drop is allowed to do to the composer. Deliberately narrow:
* there is no way to focus the editor from here. Focusing it synchronously
* during the drop makes the not-yet-reconciled editor sync its stale empty
* state back over the inserted mention; the insert path already focuses on
* the next frame, after the editor has caught up.
*/
export interface ComposerMentionDropHost {
insertMentionAtEnd(text: string): boolean;
setDragActive(active: boolean): void;
onInsertRejected(): void;
}

export interface ComposerMentionDragHandlers {
onDragEnter(event: ComposerMentionDragEvent): void;
onDragOver(event: ComposerMentionDragEvent): void;
onDrop(event: ComposerMentionDragEvent): void;
}

export function makeComposerMentionDragHandlers(
host: ComposerMentionDropHost,
): ComposerMentionDragHandlers {
// Claim the event for the composer: React's stopPropagation only halts the
// synthetic dispatch, so the native event must be stopped too or the
// editor's own DOM listeners still process the drag.
const claim = (event: ComposerMentionDragEvent): boolean => {
if (!dataTransferHasComposerMention(event.dataTransfer.types)) {
return false;
}
event.preventDefault();
event.stopPropagation();
event.nativeEvent.stopPropagation();
return true;
};
return {
onDragEnter(event) {
if (claim(event)) {
host.setDragActive(true);
}
},
onDragOver(event) {
if (!claim(event)) {
return;
}
// The tree constrains its drags to effectAllowed "move"; naming any
// other effect makes the browser cancel the drop without firing it.
event.dataTransfer.dropEffect = "move";
host.setDragActive(true);
},
onDrop(event) {
if (!claim(event)) {
return;
}
host.setDragActive(false);
const mention = event.dataTransfer.getData(COMPOSER_MENTION_DRAG_TYPE);
if (mention.length === 0) {
return;
}
if (!host.insertMentionAtEnd(`${mention} `)) {
host.onInsertRejected();
}
},
};
}
44 changes: 44 additions & 0 deletions apps/web/src/components/files/FileBrowserPanel.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,6 +16,7 @@ import { cn } from "~/lib/utils";
import { readLocalApi } from "~/localApi";
import { T3_PIERRE_ICONS } from "~/pierre-icons";

import { createFileTreeDragMentionController } from "./fileTreeDragMention";
import { useProjectEntriesQuery } from "./projectFilesQueryState";

interface FileBrowserPanelProps {
Expand DownExpand Up@@ -128,6 +129,14 @@ export default function FileBrowserPanel({
showEntryContextMenuRef.current = showEntryContextMenu;
});

const treeModelRef = useRef<ReturnType<typeof useFileTree>["model"] | null>(null);
const dragMention = useMemo(
() =>
createFileTreeDragMentionController({
deselect: (path) => treeModelRef.current?.getItem(path)?.deselect(),
}),
[],
);
const { model } = useFileTree({
composition: {
contextMenu: {
Expand All@@ -137,12 +146,21 @@ export default function FileBrowserPanel({
},
},
},
// Rows only need to be draggable so entries can be dropped into the chat
// composer; rearranging files inside the tree stays off.
dragAndDrop: { canDrop: () => false },
density: "compact",
fileTreeSearchMode: "hide-non-matches",
flattenEmptyDirectories: true,
initialExpansion: 1,
icons: T3_PIERRE_ICONS,
onSelectionChange: (selectedPaths) => {
dragMention.handleSelectionChange(selectedPaths);
// Starting a drag selects the dragged row; that selection is a side
// effect of the gesture, not a request to open the file.
if (dragMention.isDragInProgress()) {
return;
}
const selectedPath = selectedPaths.at(-1)?.replace(/\/$/, "");
if (selectedPath && entryKindsRef.current.get(selectedPath) === "file") {
onOpenFile(selectedPath);
Expand All@@ -165,8 +183,34 @@ export default function FileBrowserPanel({
[entries],
);

// Tag tree drags with the composer mention payload. The row is read from
// the composed event path (the tree's shadow root is open), so this does
// not depend on running after the tree's own dragstart handler; the drag
// data store is writable for every dragstart listener in the dispatch.
// The capture phase runs before the tree's own dragstart handler selects
// the dragged row, so the drag flag is up before that selection emits.
const panelRef = useRef<HTMLDivElement | null>(null);
useEffect(() => {
treeModelRef.current = model;
}, [model]);
useEffect(() => {
const panel = panelRef.current;
if (panel === null) {
return;
}
const handleDragStart = (event: DragEvent) => dragMention.handleDragStart(event);
const handleDragEnd = () => dragMention.handleDragEnd();
panel.addEventListener("dragstart", handleDragStart, true);
panel.addEventListener("dragend", handleDragEnd);
return () => {
panel.removeEventListener("dragstart", handleDragStart, true);
panel.removeEventListener("dragend", handleDragEnd);
};
}, [dragMention]);

return (
<div
ref={panelRef}
className="flex min-h-0 flex-1 flex-col bg-background"
data-file-browser-panel={`${environmentId}:${cwd}`}
>
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 47 additions & 13 deletions apps/web/src/components/chat/ChatComposer.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,6 +43,10 @@ import {
replaceTextRange,
} from "../../composer-logic";
import { deriveComposerSendState, readFileAsDataUrl } from "../ChatView.logic";
import {
dataTransferHasComposerMention,
makeComposerMentionDragHandlers,
} from "./composerMentionDrag";
import {
type ComposerImageAttachment,
type DraftId,
Expand DownExpand Up@@ -1855,6 +1859,44 @@ export const ChatComposer = memo(function ChatComposer(props: ChatComposerProps)
addComposerImages(files);
focusComposer();
};

const insertComposerTextAtEnd = (text: string): boolean => {
// Pending plan questions keep the composer usable (the replacement path
// routes text into the custom answer), so they do not block insertion.
if (
text.length === 0 ||
isConnecting ||
isComposerApprovalState ||
(environmentUnavailable !== null && activePendingProgress === null)
) {
return false;
}
const rangeEnd = promptRef.current.length;
Comment thread
coderabbitai[bot] marked this conversation as resolved.
return applyPromptReplacement(rangeEnd, rangeEnd, text);
};

// File-tree drags land as mentions. Handled in the capture phase so the
// editor never sees the drop; the load-bearing rules (native stop, "move"
// effect, no eager focus) live in makeComposerMentionDragHandlers.
const composerMentionDragHandlers = makeComposerMentionDragHandlers({
insertMentionAtEnd: insertComposerTextAtEnd,
setDragActive: setIsDragOverComposer,
onInsertRejected: () => {
toastManager.add({
type: "error",
title: "Unable to add to chat",
description: "The composer is busy; try again once it is ready.",
});
},
});

const onComposerMentionDragLeaveCapture = (event: React.DragEvent<HTMLDivElement>) => {
if (!dataTransferHasComposerMention(event.dataTransfer.types)) return;
event.stopPropagation();
const nextTarget = event.relatedTarget;
if (nextTarget instanceof Node && event.currentTarget.contains(nextTarget)) return;
setIsDragOverComposer(false);
};
const handleInterruptPrimaryAction = useCallback(() => {
void onInterrupt();
}, [onInterrupt]);
Expand DownExpand Up@@ -1918,19 +1960,7 @@ export const ChatComposer = memo(function ChatComposer(props: ChatComposerProps)
focusAt: (cursor: number) => {
composerEditorRef.current?.focusAt(cursor);
},
insertTextAtEnd: (text: string) => {
if (
text.length === 0 ||
isConnecting ||
isComposerApprovalState ||
pendingUserInputs.length > 0 ||
(environmentUnavailable !== null && activePendingProgress === null)
) {
return false;
}
const rangeEnd = promptRef.current.length;
return applyPromptReplacement(rangeEnd, rangeEnd, text);
},
insertTextAtEnd: insertComposerTextAtEnd,
openModelPicker: () => {
setIsComposerModelPickerOpen(true);
},
Expand DownExpand Up@@ -2056,6 +2086,10 @@ export const ChatComposer = memo(function ChatComposer(props: ChatComposerProps)
onDragOver={onComposerDragOver}
onDragLeave={onComposerDragLeave}
onDrop={onComposerDrop}
onDragEnterCapture={composerMentionDragHandlers.onDragEnter}
onDragOverCapture={composerMentionDragHandlers.onDragOver}
onDragLeaveCapture={onComposerMentionDragLeaveCapture}
onDropCapture={composerMentionDragHandlers.onDrop}
>
<div
ref={composerSurfaceRef}
Expand Down
123 changes: 123 additions & 0 deletions apps/web/src/components/chat/composerMentionDrag.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,123 @@
import { describe, expect, it } from "@effect/vitest";

import {
COMPOSER_MENTION_DRAG_TYPE,
type ComposerMentionDropHost,
composerMentionFromTreePath,
dataTransferHasComposerMention,
makeComposerMentionDragHandlers,
} from "./composerMentionDrag.ts";

const makeDragEvent = (options?: { mention?: string; types?: ReadonlyArray<string> }) => {
const mention = options?.mention ?? "[index.md](docs/index.md)";
const calls: Array<string> = [];
const event = {
dataTransfer: {
types: options?.types ?? [COMPOSER_MENTION_DRAG_TYPE, "text/plain"],
getData: (format: string) => (format === COMPOSER_MENTION_DRAG_TYPE ? mention : ""),
dropEffect: "none",
},
nativeEvent: {
stopPropagation: () => void calls.push("nativeStopPropagation"),
},
preventDefault: () => void calls.push("preventDefault"),
stopPropagation: () => void calls.push("stopPropagation"),
};
return { event, calls };
};

const makeHost = (insertResult = true) => {
const log: Array<string> = [];
const host: ComposerMentionDropHost = {
insertMentionAtEnd: (text) => {
log.push(`insert:${text}`);
return insertResult;
},
setDragActive: (active) => void log.push(`active:${active}`),
onInsertRejected: () => void log.push("rejected"),
};
return { host, log };
};

describe("composerMentionFromTreePath", () => {
it("serializes a file path into a mention", () => {
expect(composerMentionFromTreePath("docs/index.md")).toBe("[index.md](docs/index.md)");
});

it("strips the trailing slash directory rows carry", () => {
expect(composerMentionFromTreePath("docs/architecture/")).toBe(
"[architecture](docs/architecture)",
);
});

it("rejects drags that carry no path", () => {
expect(composerMentionFromTreePath("")).toBeNull();
expect(composerMentionFromTreePath("/")).toBeNull();
});
});

describe("dataTransferHasComposerMention", () => {
it("detects the mention payload among drag types", () => {
expect(dataTransferHasComposerMention([COMPOSER_MENTION_DRAG_TYPE, "text/plain"])).toBe(true);
expect(dataTransferHasComposerMention(["Files"])).toBe(false);
expect(dataTransferHasComposerMention([])).toBe(false);
});
});

describe("makeComposerMentionDragHandlers", () => {
it("leaves drags without the mention payload alone", () => {
const { host, log } = makeHost();
const handlers = makeComposerMentionDragHandlers(host);
const { event, calls } = makeDragEvent({ types: ["Files"] });
handlers.onDragEnter(event);
handlers.onDragOver(event);
handlers.onDrop(event);
expect(calls).toEqual([]);
expect(log).toEqual([]);
});

it("stops the native event too, not just the synthetic one", () => {
// React's stopPropagation only halts synthetic dispatch; without the
// native stop, the editor's own DOM listeners process the drop and sync
// their stale state back over the inserted mention.
const { host } = makeHost();
const handlers = makeComposerMentionDragHandlers(host);
const { event, calls } = makeDragEvent();
handlers.onDrop(event);
expect(calls).toContain("preventDefault");
expect(calls).toContain("stopPropagation");
expect(calls).toContain("nativeStopPropagation");
});

it('answers dragover with the "move" effect the tree allows', () => {
// Naming an effect outside the source's effectAllowed makes the browser
// cancel the drop without ever firing it.
const { host } = makeHost();
const handlers = makeComposerMentionDragHandlers(host);
const { event } = makeDragEvent();
handlers.onDragOver(event);
expect(event.dataTransfer.dropEffect).toBe("move");
});

it("inserts the mention with its trailing space and clears the highlight", () => {
const { host, log } = makeHost();
const handlers = makeComposerMentionDragHandlers(host);
handlers.onDragEnter(makeDragEvent().event);
handlers.onDrop(makeDragEvent().event);
expect(log).toEqual(["active:true", "active:false", "insert:[index.md](docs/index.md) "]);
});

it("reports a rejected insert instead of failing silently", () => {
const { host, log } = makeHost(false);
const handlers = makeComposerMentionDragHandlers(host);
handlers.onDrop(makeDragEvent().event);
expect(log).toContain("rejected");
});

it("ignores a drop whose payload is empty", () => {
const { host, log } = makeHost();
const handlers = makeComposerMentionDragHandlers(host);
handlers.onDrop(makeDragEvent({ mention: "" }).event);
expect(log).toEqual(["active:false"]);
});
});
98 changes: 98 additions & 0 deletions apps/web/src/components/chat/composerMentionDrag.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,98 @@
import { serializeComposerFileLink } from "@t3tools/shared/composerTrigger";

/**
* Drag payload type carrying a serialized composer mention. Set on drags that
* start in the workspace file tree so the composer can tell them apart from
* OS file drags and plain text selections.
*/
export const COMPOSER_MENTION_DRAG_TYPE = "application/x-t3code-composer-mention";

export function composerMentionFromTreePath(treePath: string): string | null {
const relativePath = treePath.replace(/\/+$/, "");
if (relativePath.length === 0) {
return null;
}
return serializeComposerFileLink(relativePath);
}

export function dataTransferHasComposerMention(types: ReadonlyArray<string>): boolean {
return types.includes(COMPOSER_MENTION_DRAG_TYPE);
}

export interface ComposerMentionDragTransfer {
readonly types: ReadonlyArray<string>;
getData(format: string): string;
dropEffect: string;
}

export interface ComposerMentionDragEvent {
readonly dataTransfer: ComposerMentionDragTransfer;
readonly nativeEvent: { stopPropagation(): void };
preventDefault(): void;
stopPropagation(): void;
}

/**
* What a mention drop is allowed to do to the composer. Deliberately narrow:
* there is no way to focus the editor from here. Focusing it synchronously
* during the drop makes the not-yet-reconciled editor sync its stale empty
* state back over the inserted mention; the insert path already focuses on
* the next frame, after the editor has caught up.
*/
export interface ComposerMentionDropHost {
insertMentionAtEnd(text: string): boolean;
setDragActive(active: boolean): void;
onInsertRejected(): void;
}

export interface ComposerMentionDragHandlers {
onDragEnter(event: ComposerMentionDragEvent): void;
onDragOver(event: ComposerMentionDragEvent): void;
onDrop(event: ComposerMentionDragEvent): void;
}

export function makeComposerMentionDragHandlers(
host: ComposerMentionDropHost,
): ComposerMentionDragHandlers {
// Claim the event for the composer: React's stopPropagation only halts the
// synthetic dispatch, so the native event must be stopped too or the
// editor's own DOM listeners still process the drag.
const claim = (event: ComposerMentionDragEvent): boolean => {
if (!dataTransferHasComposerMention(event.dataTransfer.types)) {
return false;
}
event.preventDefault();
event.stopPropagation();
event.nativeEvent.stopPropagation();
return true;
};
return {
onDragEnter(event) {
if (claim(event)) {
host.setDragActive(true);
}
},
onDragOver(event) {
if (!claim(event)) {
return;
}
// The tree constrains its drags to effectAllowed "move"; naming any
// other effect makes the browser cancel the drop without firing it.
event.dataTransfer.dropEffect = "move";
host.setDragActive(true);
},
onDrop(event) {
if (!claim(event)) {
return;
}
host.setDragActive(false);
const mention = event.dataTransfer.getData(COMPOSER_MENTION_DRAG_TYPE);
if (mention.length === 0) {
return;
}
if (!host.insertMentionAtEnd(`${mention} `)) {
host.onInsertRejected();
}
},
};
}
44 changes: 44 additions & 0 deletions apps/web/src/components/files/FileBrowserPanel.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,6 +16,7 @@ import { cn } from "~/lib/utils";
import { readLocalApi } from "~/localApi";
import { T3_PIERRE_ICONS } from "~/pierre-icons";

import { createFileTreeDragMentionController } from "./fileTreeDragMention";
import { useProjectEntriesQuery } from "./projectFilesQueryState";

interface FileBrowserPanelProps {
Expand DownExpand Up@@ -128,6 +129,14 @@ export default function FileBrowserPanel({
showEntryContextMenuRef.current = showEntryContextMenu;
});

const treeModelRef = useRef<ReturnType<typeof useFileTree>["model"] | null>(null);
const dragMention = useMemo(
() =>
createFileTreeDragMentionController({
deselect: (path) => treeModelRef.current?.getItem(path)?.deselect(),
}),
[],
);
const { model } = useFileTree({
composition: {
contextMenu: {
Expand All@@ -137,12 +146,21 @@ export default function FileBrowserPanel({
},
},
},
// Rows only need to be draggable so entries can be dropped into the chat
// composer; rearranging files inside the tree stays off.
dragAndDrop: { canDrop: () => false },
density: "compact",
fileTreeSearchMode: "hide-non-matches",
flattenEmptyDirectories: true,
initialExpansion: 1,
icons: T3_PIERRE_ICONS,
onSelectionChange: (selectedPaths) => {
dragMention.handleSelectionChange(selectedPaths);
// Starting a drag selects the dragged row; that selection is a side
// effect of the gesture, not a request to open the file.
if (dragMention.isDragInProgress()) {
return;
}
const selectedPath = selectedPaths.at(-1)?.replace(/\/$/, "");
if (selectedPath && entryKindsRef.current.get(selectedPath) === "file") {
onOpenFile(selectedPath);
Expand All@@ -165,8 +183,34 @@ export default function FileBrowserPanel({
[entries],
);

// Tag tree drags with the composer mention payload. The row is read from
// the composed event path (the tree's shadow root is open), so this does
// not depend on running after the tree's own dragstart handler; the drag
// data store is writable for every dragstart listener in the dispatch.
// The capture phase runs before the tree's own dragstart handler selects
// the dragged row, so the drag flag is up before that selection emits.
const panelRef = useRef<HTMLDivElement | null>(null);
useEffect(() => {
treeModelRef.current = model;
}, [model]);
useEffect(() => {
const panel = panelRef.current;
if (panel === null) {
return;
}
const handleDragStart = (event: DragEvent) => dragMention.handleDragStart(event);
const handleDragEnd = () => dragMention.handleDragEnd();
panel.addEventListener("dragstart", handleDragStart, true);
panel.addEventListener("dragend", handleDragEnd);
return () => {
panel.removeEventListener("dragstart", handleDragStart, true);
panel.removeEventListener("dragend", handleDragEnd);
};
}, [dragMention]);

return (
<div
ref={panelRef}
className="flex min-h-0 flex-1 flex-col bg-background"
data-file-browser-panel={`${environmentId}:${cwd}`}
>
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 47 additions & 13 deletions apps/web/src/components/chat/ChatComposer.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,6 +43,10 @@ import {
replaceTextRange,
} from "../../composer-logic";
import { deriveComposerSendState, readFileAsDataUrl } from "../ChatView.logic";
import {
dataTransferHasComposerMention,
makeComposerMentionDragHandlers,
} from "./composerMentionDrag";
import {
type ComposerImageAttachment,
type DraftId,
Expand DownExpand Up@@ -1855,6 +1859,44 @@ export const ChatComposer = memo(function ChatComposer(props: ChatComposerProps)
addComposerImages(files);
focusComposer();
};

const insertComposerTextAtEnd = (text: string): boolean => {
// Pending plan questions keep the composer usable (the replacement path
// routes text into the custom answer), so they do not block insertion.
if (
text.length === 0 ||
isConnecting ||
isComposerApprovalState ||
(environmentUnavailable !== null && activePendingProgress === null)
) {
return false;
}
const rangeEnd = promptRef.current.length;
Comment thread
coderabbitai[bot] marked this conversation as resolved.
return applyPromptReplacement(rangeEnd, rangeEnd, text);
};

// File-tree drags land as mentions. Handled in the capture phase so the
// editor never sees the drop; the load-bearing rules (native stop, "move"
// effect, no eager focus) live in makeComposerMentionDragHandlers.
const composerMentionDragHandlers = makeComposerMentionDragHandlers({
insertMentionAtEnd: insertComposerTextAtEnd,
setDragActive: setIsDragOverComposer,
onInsertRejected: () => {
toastManager.add({
type: "error",
title: "Unable to add to chat",
description: "The composer is busy; try again once it is ready.",
});
},
});

const onComposerMentionDragLeaveCapture = (event: React.DragEvent<HTMLDivElement>) => {
if (!dataTransferHasComposerMention(event.dataTransfer.types)) return;
event.stopPropagation();
const nextTarget = event.relatedTarget;
if (nextTarget instanceof Node && event.currentTarget.contains(nextTarget)) return;
setIsDragOverComposer(false);
};
const handleInterruptPrimaryAction = useCallback(() => {
void onInterrupt();
}, [onInterrupt]);
Expand DownExpand Up@@ -1918,19 +1960,7 @@ export const ChatComposer = memo(function ChatComposer(props: ChatComposerProps)
focusAt: (cursor: number) => {
composerEditorRef.current?.focusAt(cursor);
},
insertTextAtEnd: (text: string) => {
if (
text.length === 0 ||
isConnecting ||
isComposerApprovalState ||
pendingUserInputs.length > 0 ||
(environmentUnavailable !== null && activePendingProgress === null)
) {
return false;
}
const rangeEnd = promptRef.current.length;
return applyPromptReplacement(rangeEnd, rangeEnd, text);
},
insertTextAtEnd: insertComposerTextAtEnd,
openModelPicker: () => {
setIsComposerModelPickerOpen(true);
},
Expand DownExpand Up@@ -2056,6 +2086,10 @@ export const ChatComposer = memo(function ChatComposer(props: ChatComposerProps)
onDragOver={onComposerDragOver}
onDragLeave={onComposerDragLeave}
onDrop={onComposerDrop}
onDragEnterCapture={composerMentionDragHandlers.onDragEnter}
onDragOverCapture={composerMentionDragHandlers.onDragOver}
onDragLeaveCapture={onComposerMentionDragLeaveCapture}
onDropCapture={composerMentionDragHandlers.onDrop}
>
<div
ref={composerSurfaceRef}
Expand Down
123 changes: 123 additions & 0 deletions apps/web/src/components/chat/composerMentionDrag.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,123 @@
import { describe, expect, it } from "@effect/vitest";

import {
COMPOSER_MENTION_DRAG_TYPE,
type ComposerMentionDropHost,
composerMentionFromTreePath,
dataTransferHasComposerMention,
makeComposerMentionDragHandlers,
} from "./composerMentionDrag.ts";

const makeDragEvent = (options?: { mention?: string; types?: ReadonlyArray<string> }) => {
const mention = options?.mention ?? "[index.md](docs/index.md)";
const calls: Array<string> = [];
const event = {
dataTransfer: {
types: options?.types ?? [COMPOSER_MENTION_DRAG_TYPE, "text/plain"],
getData: (format: string) => (format === COMPOSER_MENTION_DRAG_TYPE ? mention : ""),
dropEffect: "none",
},
nativeEvent: {
stopPropagation: () => void calls.push("nativeStopPropagation"),
},
preventDefault: () => void calls.push("preventDefault"),
stopPropagation: () => void calls.push("stopPropagation"),
};
return { event, calls };
};

const makeHost = (insertResult = true) => {
const log: Array<string> = [];
const host: ComposerMentionDropHost = {
insertMentionAtEnd: (text) => {
log.push(`insert:${text}`);
return insertResult;
},
setDragActive: (active) => void log.push(`active:${active}`),
onInsertRejected: () => void log.push("rejected"),
};
return { host, log };
};

describe("composerMentionFromTreePath", () => {
it("serializes a file path into a mention", () => {
expect(composerMentionFromTreePath("docs/index.md")).toBe("[index.md](docs/index.md)");
});

it("strips the trailing slash directory rows carry", () => {
expect(composerMentionFromTreePath("docs/architecture/")).toBe(
"[architecture](docs/architecture)",
);
});

it("rejects drags that carry no path", () => {
expect(composerMentionFromTreePath("")).toBeNull();
expect(composerMentionFromTreePath("/")).toBeNull();
});
});

describe("dataTransferHasComposerMention", () => {
it("detects the mention payload among drag types", () => {
expect(dataTransferHasComposerMention([COMPOSER_MENTION_DRAG_TYPE, "text/plain"])).toBe(true);
expect(dataTransferHasComposerMention(["Files"])).toBe(false);
expect(dataTransferHasComposerMention([])).toBe(false);
});
});

describe("makeComposerMentionDragHandlers", () => {
it("leaves drags without the mention payload alone", () => {
const { host, log } = makeHost();
const handlers = makeComposerMentionDragHandlers(host);
const { event, calls } = makeDragEvent({ types: ["Files"] });
handlers.onDragEnter(event);
handlers.onDragOver(event);
handlers.onDrop(event);
expect(calls).toEqual([]);
expect(log).toEqual([]);
});

it("stops the native event too, not just the synthetic one", () => {
// React's stopPropagation only halts synthetic dispatch; without the
// native stop, the editor's own DOM listeners process the drop and sync
// their stale state back over the inserted mention.
const { host } = makeHost();
const handlers = makeComposerMentionDragHandlers(host);
const { event, calls } = makeDragEvent();
handlers.onDrop(event);
expect(calls).toContain("preventDefault");
expect(calls).toContain("stopPropagation");
expect(calls).toContain("nativeStopPropagation");
});

it('answers dragover with the "move" effect the tree allows', () => {
// Naming an effect outside the source's effectAllowed makes the browser
// cancel the drop without ever firing it.
const { host } = makeHost();
const handlers = makeComposerMentionDragHandlers(host);
const { event } = makeDragEvent();
handlers.onDragOver(event);
expect(event.dataTransfer.dropEffect).toBe("move");
});

it("inserts the mention with its trailing space and clears the highlight", () => {
const { host, log } = makeHost();
const handlers = makeComposerMentionDragHandlers(host);
handlers.onDragEnter(makeDragEvent().event);
handlers.onDrop(makeDragEvent().event);
expect(log).toEqual(["active:true", "active:false", "insert:[index.md](docs/index.md) "]);
});

it("reports a rejected insert instead of failing silently", () => {
const { host, log } = makeHost(false);
const handlers = makeComposerMentionDragHandlers(host);
handlers.onDrop(makeDragEvent().event);
expect(log).toContain("rejected");
});

it("ignores a drop whose payload is empty", () => {
const { host, log } = makeHost();
const handlers = makeComposerMentionDragHandlers(host);
handlers.onDrop(makeDragEvent({ mention: "" }).event);
expect(log).toEqual(["active:false"]);
});
});
98 changes: 98 additions & 0 deletions apps/web/src/components/chat/composerMentionDrag.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,98 @@
import { serializeComposerFileLink } from "@t3tools/shared/composerTrigger";

/**
* Drag payload type carrying a serialized composer mention. Set on drags that
* start in the workspace file tree so the composer can tell them apart from
* OS file drags and plain text selections.
*/
export const COMPOSER_MENTION_DRAG_TYPE = "application/x-t3code-composer-mention";

export function composerMentionFromTreePath(treePath: string): string | null {
const relativePath = treePath.replace(/\/+$/, "");
if (relativePath.length === 0) {
return null;
}
return serializeComposerFileLink(relativePath);
}

export function dataTransferHasComposerMention(types: ReadonlyArray<string>): boolean {
return types.includes(COMPOSER_MENTION_DRAG_TYPE);
}

export interface ComposerMentionDragTransfer {
readonly types: ReadonlyArray<string>;
getData(format: string): string;
dropEffect: string;
}

export interface ComposerMentionDragEvent {
readonly dataTransfer: ComposerMentionDragTransfer;
readonly nativeEvent: { stopPropagation(): void };
preventDefault(): void;
stopPropagation(): void;
}

/**
* What a mention drop is allowed to do to the composer. Deliberately narrow:
* there is no way to focus the editor from here. Focusing it synchronously
* during the drop makes the not-yet-reconciled editor sync its stale empty
* state back over the inserted mention; the insert path already focuses on
* the next frame, after the editor has caught up.
*/
export interface ComposerMentionDropHost {
insertMentionAtEnd(text: string): boolean;
setDragActive(active: boolean): void;
onInsertRejected(): void;
}

export interface ComposerMentionDragHandlers {
onDragEnter(event: ComposerMentionDragEvent): void;
onDragOver(event: ComposerMentionDragEvent): void;
onDrop(event: ComposerMentionDragEvent): void;
}

export function makeComposerMentionDragHandlers(
host: ComposerMentionDropHost,
): ComposerMentionDragHandlers {
// Claim the event for the composer: React's stopPropagation only halts the
// synthetic dispatch, so the native event must be stopped too or the
// editor's own DOM listeners still process the drag.
const claim = (event: ComposerMentionDragEvent): boolean => {
if (!dataTransferHasComposerMention(event.dataTransfer.types)) {
return false;
}
event.preventDefault();
event.stopPropagation();
event.nativeEvent.stopPropagation();
return true;
};
return {
onDragEnter(event) {
if (claim(event)) {
host.setDragActive(true);
}
},
onDragOver(event) {
if (!claim(event)) {
return;
}
// The tree constrains its drags to effectAllowed "move"; naming any
// other effect makes the browser cancel the drop without firing it.
event.dataTransfer.dropEffect = "move";
host.setDragActive(true);
},
onDrop(event) {
if (!claim(event)) {
return;
}
host.setDragActive(false);
const mention = event.dataTransfer.getData(COMPOSER_MENTION_DRAG_TYPE);
if (mention.length === 0) {
return;
}
if (!host.insertMentionAtEnd(`${mention} `)) {
host.onInsertRejected();
}
},
};
}
44 changes: 44 additions & 0 deletions apps/web/src/components/files/FileBrowserPanel.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,6 +16,7 @@ import { cn } from "~/lib/utils";
import { readLocalApi } from "~/localApi";
import { T3_PIERRE_ICONS } from "~/pierre-icons";

import { createFileTreeDragMentionController } from "./fileTreeDragMention";
import { useProjectEntriesQuery } from "./projectFilesQueryState";

interface FileBrowserPanelProps {
Expand DownExpand Up@@ -128,6 +129,14 @@ export default function FileBrowserPanel({
showEntryContextMenuRef.current = showEntryContextMenu;
});

const treeModelRef = useRef<ReturnType<typeof useFileTree>["model"] | null>(null);
const dragMention = useMemo(
() =>
createFileTreeDragMentionController({
deselect: (path) => treeModelRef.current?.getItem(path)?.deselect(),
}),
[],
);
const { model } = useFileTree({
composition: {
contextMenu: {
Expand All@@ -137,12 +146,21 @@ export default function FileBrowserPanel({
},
},
},
// Rows only need to be draggable so entries can be dropped into the chat
// composer; rearranging files inside the tree stays off.
dragAndDrop: { canDrop: () => false },
density: "compact",
fileTreeSearchMode: "hide-non-matches",
flattenEmptyDirectories: true,
initialExpansion: 1,
icons: T3_PIERRE_ICONS,
onSelectionChange: (selectedPaths) => {
dragMention.handleSelectionChange(selectedPaths);
// Starting a drag selects the dragged row; that selection is a side
// effect of the gesture, not a request to open the file.
if (dragMention.isDragInProgress()) {
return;
}
const selectedPath = selectedPaths.at(-1)?.replace(/\/$/, "");
if (selectedPath && entryKindsRef.current.get(selectedPath) === "file") {
onOpenFile(selectedPath);
Expand All@@ -165,8 +183,34 @@ export default function FileBrowserPanel({
[entries],
);

// Tag tree drags with the composer mention payload. The row is read from
// the composed event path (the tree's shadow root is open), so this does
// not depend on running after the tree's own dragstart handler; the drag
// data store is writable for every dragstart listener in the dispatch.
// The capture phase runs before the tree's own dragstart handler selects
// the dragged row, so the drag flag is up before that selection emits.
const panelRef = useRef<HTMLDivElement | null>(null);
useEffect(() => {
treeModelRef.current = model;
}, [model]);
useEffect(() => {
const panel = panelRef.current;
if (panel === null) {
return;
}
const handleDragStart = (event: DragEvent) => dragMention.handleDragStart(event);
const handleDragEnd = () => dragMention.handleDragEnd();
panel.addEventListener("dragstart", handleDragStart, true);
panel.addEventListener("dragend", handleDragEnd);
return () => {
panel.removeEventListener("dragstart", handleDragStart, true);
panel.removeEventListener("dragend", handleDragEnd);
};
}, [dragMention]);

return (
<div
ref={panelRef}
className="flex min-h-0 flex-1 flex-col bg-background"
data-file-browser-panel={`${environmentId}:${cwd}`}
>
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 47 additions & 13 deletions apps/web/src/components/chat/ChatComposer.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,6 +43,10 @@ import {
replaceTextRange,
} from "../../composer-logic";
import { deriveComposerSendState, readFileAsDataUrl } from "../ChatView.logic";
import {
dataTransferHasComposerMention,
makeComposerMentionDragHandlers,
} from "./composerMentionDrag";
import {
type ComposerImageAttachment,
type DraftId,
Expand DownExpand Up@@ -1855,6 +1859,44 @@ export const ChatComposer = memo(function ChatComposer(props: ChatComposerProps)
addComposerImages(files);
focusComposer();
};

const insertComposerTextAtEnd = (text: string): boolean => {
// Pending plan questions keep the composer usable (the replacement path
// routes text into the custom answer), so they do not block insertion.
if (
text.length === 0 ||
isConnecting ||
isComposerApprovalState ||
(environmentUnavailable !== null && activePendingProgress === null)
) {
return false;
}
const rangeEnd = promptRef.current.length;
Comment thread
coderabbitai[bot] marked this conversation as resolved.
return applyPromptReplacement(rangeEnd, rangeEnd, text);
};

// File-tree drags land as mentions. Handled in the capture phase so the
// editor never sees the drop; the load-bearing rules (native stop, "move"
// effect, no eager focus) live in makeComposerMentionDragHandlers.
const composerMentionDragHandlers = makeComposerMentionDragHandlers({
insertMentionAtEnd: insertComposerTextAtEnd,
setDragActive: setIsDragOverComposer,
onInsertRejected: () => {
toastManager.add({
type: "error",
title: "Unable to add to chat",
description: "The composer is busy; try again once it is ready.",
});
},
});

const onComposerMentionDragLeaveCapture = (event: React.DragEvent<HTMLDivElement>) => {
if (!dataTransferHasComposerMention(event.dataTransfer.types)) return;
event.stopPropagation();
const nextTarget = event.relatedTarget;
if (nextTarget instanceof Node && event.currentTarget.contains(nextTarget)) return;
setIsDragOverComposer(false);
};
const handleInterruptPrimaryAction = useCallback(() => {
void onInterrupt();
}, [onInterrupt]);
Expand DownExpand Up@@ -1918,19 +1960,7 @@ export const ChatComposer = memo(function ChatComposer(props: ChatComposerProps)
focusAt: (cursor: number) => {
composerEditorRef.current?.focusAt(cursor);
},
insertTextAtEnd: (text: string) => {
if (
text.length === 0 ||
isConnecting ||
isComposerApprovalState ||
pendingUserInputs.length > 0 ||
(environmentUnavailable !== null && activePendingProgress === null)
) {
return false;
}
const rangeEnd = promptRef.current.length;
return applyPromptReplacement(rangeEnd, rangeEnd, text);
},
insertTextAtEnd: insertComposerTextAtEnd,
openModelPicker: () => {
setIsComposerModelPickerOpen(true);
},
Expand DownExpand Up@@ -2056,6 +2086,10 @@ export const ChatComposer = memo(function ChatComposer(props: ChatComposerProps)
onDragOver={onComposerDragOver}
onDragLeave={onComposerDragLeave}
onDrop={onComposerDrop}
onDragEnterCapture={composerMentionDragHandlers.onDragEnter}
onDragOverCapture={composerMentionDragHandlers.onDragOver}
onDragLeaveCapture={onComposerMentionDragLeaveCapture}
onDropCapture={composerMentionDragHandlers.onDrop}
>
<div
ref={composerSurfaceRef}
Expand Down
123 changes: 123 additions & 0 deletions apps/web/src/components/chat/composerMentionDrag.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,123 @@
import { describe, expect, it } from "@effect/vitest";

import {
COMPOSER_MENTION_DRAG_TYPE,
type ComposerMentionDropHost,
composerMentionFromTreePath,
dataTransferHasComposerMention,
makeComposerMentionDragHandlers,
} from "./composerMentionDrag.ts";

const makeDragEvent = (options?: { mention?: string; types?: ReadonlyArray<string> }) => {
const mention = options?.mention ?? "[index.md](docs/index.md)";
const calls: Array<string> = [];
const event = {
dataTransfer: {
types: options?.types ?? [COMPOSER_MENTION_DRAG_TYPE, "text/plain"],
getData: (format: string) => (format === COMPOSER_MENTION_DRAG_TYPE ? mention : ""),
dropEffect: "none",
},
nativeEvent: {
stopPropagation: () => void calls.push("nativeStopPropagation"),
},
preventDefault: () => void calls.push("preventDefault"),
stopPropagation: () => void calls.push("stopPropagation"),
};
return { event, calls };
};

const makeHost = (insertResult = true) => {
const log: Array<string> = [];
const host: ComposerMentionDropHost = {
insertMentionAtEnd: (text) => {
log.push(`insert:${text}`);
return insertResult;
},
setDragActive: (active) => void log.push(`active:${active}`),
onInsertRejected: () => void log.push("rejected"),
};
return { host, log };
};

describe("composerMentionFromTreePath", () => {
it("serializes a file path into a mention", () => {
expect(composerMentionFromTreePath("docs/index.md")).toBe("[index.md](docs/index.md)");
});

it("strips the trailing slash directory rows carry", () => {
expect(composerMentionFromTreePath("docs/architecture/")).toBe(
"[architecture](docs/architecture)",
);
});

it("rejects drags that carry no path", () => {
expect(composerMentionFromTreePath("")).toBeNull();
expect(composerMentionFromTreePath("/")).toBeNull();
});
});

describe("dataTransferHasComposerMention", () => {
it("detects the mention payload among drag types", () => {
expect(dataTransferHasComposerMention([COMPOSER_MENTION_DRAG_TYPE, "text/plain"])).toBe(true);
expect(dataTransferHasComposerMention(["Files"])).toBe(false);
expect(dataTransferHasComposerMention([])).toBe(false);
});
});

describe("makeComposerMentionDragHandlers", () => {
it("leaves drags without the mention payload alone", () => {
const { host, log } = makeHost();
const handlers = makeComposerMentionDragHandlers(host);
const { event, calls } = makeDragEvent({ types: ["Files"] });
handlers.onDragEnter(event);
handlers.onDragOver(event);
handlers.onDrop(event);
expect(calls).toEqual([]);
expect(log).toEqual([]);
});

it("stops the native event too, not just the synthetic one", () => {
// React's stopPropagation only halts synthetic dispatch; without the
// native stop, the editor's own DOM listeners process the drop and sync
// their stale state back over the inserted mention.
const { host } = makeHost();
const handlers = makeComposerMentionDragHandlers(host);
const { event, calls } = makeDragEvent();
handlers.onDrop(event);
expect(calls).toContain("preventDefault");
expect(calls).toContain("stopPropagation");
expect(calls).toContain("nativeStopPropagation");
});

it('answers dragover with the "move" effect the tree allows', () => {
// Naming an effect outside the source's effectAllowed makes the browser
// cancel the drop without ever firing it.
const { host } = makeHost();
const handlers = makeComposerMentionDragHandlers(host);
const { event } = makeDragEvent();
handlers.onDragOver(event);
expect(event.dataTransfer.dropEffect).toBe("move");
});

it("inserts the mention with its trailing space and clears the highlight", () => {
const { host, log } = makeHost();
const handlers = makeComposerMentionDragHandlers(host);
handlers.onDragEnter(makeDragEvent().event);
handlers.onDrop(makeDragEvent().event);
expect(log).toEqual(["active:true", "active:false", "insert:[index.md](docs/index.md) "]);
});

it("reports a rejected insert instead of failing silently", () => {
const { host, log } = makeHost(false);
const handlers = makeComposerMentionDragHandlers(host);
handlers.onDrop(makeDragEvent().event);
expect(log).toContain("rejected");
});

it("ignores a drop whose payload is empty", () => {
const { host, log } = makeHost();
const handlers = makeComposerMentionDragHandlers(host);
handlers.onDrop(makeDragEvent({ mention: "" }).event);
expect(log).toEqual(["active:false"]);
});
});
98 changes: 98 additions & 0 deletions apps/web/src/components/chat/composerMentionDrag.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,98 @@
import { serializeComposerFileLink } from "@t3tools/shared/composerTrigger";

/**
* Drag payload type carrying a serialized composer mention. Set on drags that
* start in the workspace file tree so the composer can tell them apart from
* OS file drags and plain text selections.
*/
export const COMPOSER_MENTION_DRAG_TYPE = "application/x-t3code-composer-mention";

export function composerMentionFromTreePath(treePath: string): string | null {
const relativePath = treePath.replace(/\/+$/, "");
if (relativePath.length === 0) {
return null;
}
return serializeComposerFileLink(relativePath);
}

export function dataTransferHasComposerMention(types: ReadonlyArray<string>): boolean {
return types.includes(COMPOSER_MENTION_DRAG_TYPE);
}

export interface ComposerMentionDragTransfer {
readonly types: ReadonlyArray<string>;
getData(format: string): string;
dropEffect: string;
}

export interface ComposerMentionDragEvent {
readonly dataTransfer: ComposerMentionDragTransfer;
readonly nativeEvent: { stopPropagation(): void };
preventDefault(): void;
stopPropagation(): void;
}

/**
* What a mention drop is allowed to do to the composer. Deliberately narrow:
* there is no way to focus the editor from here. Focusing it synchronously
* during the drop makes the not-yet-reconciled editor sync its stale empty
* state back over the inserted mention; the insert path already focuses on
* the next frame, after the editor has caught up.
*/
export interface ComposerMentionDropHost {
insertMentionAtEnd(text: string): boolean;
setDragActive(active: boolean): void;
onInsertRejected(): void;
}

export interface ComposerMentionDragHandlers {
onDragEnter(event: ComposerMentionDragEvent): void;
onDragOver(event: ComposerMentionDragEvent): void;
onDrop(event: ComposerMentionDragEvent): void;
}

export function makeComposerMentionDragHandlers(
host: ComposerMentionDropHost,
): ComposerMentionDragHandlers {
// Claim the event for the composer: React's stopPropagation only halts the
// synthetic dispatch, so the native event must be stopped too or the
// editor's own DOM listeners still process the drag.
const claim = (event: ComposerMentionDragEvent): boolean => {
if (!dataTransferHasComposerMention(event.dataTransfer.types)) {
return false;
}
event.preventDefault();
event.stopPropagation();
event.nativeEvent.stopPropagation();
return true;
};
return {
onDragEnter(event) {
if (claim(event)) {
host.setDragActive(true);
}
},
onDragOver(event) {
if (!claim(event)) {
return;
}
// The tree constrains its drags to effectAllowed "move"; naming any
// other effect makes the browser cancel the drop without firing it.
event.dataTransfer.dropEffect = "move";
host.setDragActive(true);
},
onDrop(event) {
if (!claim(event)) {
return;
}
host.setDragActive(false);
const mention = event.dataTransfer.getData(COMPOSER_MENTION_DRAG_TYPE);
if (mention.length === 0) {
return;
}
if (!host.insertMentionAtEnd(`${mention} `)) {
host.onInsertRejected();
}
},
};
}
44 changes: 44 additions & 0 deletions apps/web/src/components/files/FileBrowserPanel.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,6 +16,7 @@ import { cn } from "~/lib/utils";
import { readLocalApi } from "~/localApi";
import { T3_PIERRE_ICONS } from "~/pierre-icons";

import { createFileTreeDragMentionController } from "./fileTreeDragMention";
import { useProjectEntriesQuery } from "./projectFilesQueryState";

interface FileBrowserPanelProps {
Expand DownExpand Up@@ -128,6 +129,14 @@ export default function FileBrowserPanel({
showEntryContextMenuRef.current = showEntryContextMenu;
});

const treeModelRef = useRef<ReturnType<typeof useFileTree>["model"] | null>(null);
const dragMention = useMemo(
() =>
createFileTreeDragMentionController({
deselect: (path) => treeModelRef.current?.getItem(path)?.deselect(),
}),
[],
);
const { model } = useFileTree({
composition: {
contextMenu: {
Expand All@@ -137,12 +146,21 @@ export default function FileBrowserPanel({
},
},
},
// Rows only need to be draggable so entries can be dropped into the chat
// composer; rearranging files inside the tree stays off.
dragAndDrop: { canDrop: () => false },
density: "compact",
fileTreeSearchMode: "hide-non-matches",
flattenEmptyDirectories: true,
initialExpansion: 1,
icons: T3_PIERRE_ICONS,
onSelectionChange: (selectedPaths) => {
dragMention.handleSelectionChange(selectedPaths);
// Starting a drag selects the dragged row; that selection is a side
// effect of the gesture, not a request to open the file.
if (dragMention.isDragInProgress()) {
return;
}
const selectedPath = selectedPaths.at(-1)?.replace(/\/$/, "");
if (selectedPath && entryKindsRef.current.get(selectedPath) === "file") {
onOpenFile(selectedPath);
Expand All@@ -165,8 +183,34 @@ export default function FileBrowserPanel({
[entries],
);

// Tag tree drags with the composer mention payload. The row is read from
// the composed event path (the tree's shadow root is open), so this does
// not depend on running after the tree's own dragstart handler; the drag
// data store is writable for every dragstart listener in the dispatch.
// The capture phase runs before the tree's own dragstart handler selects
// the dragged row, so the drag flag is up before that selection emits.
const panelRef = useRef<HTMLDivElement | null>(null);
useEffect(() => {
treeModelRef.current = model;
}, [model]);
useEffect(() => {
const panel = panelRef.current;
if (panel === null) {
return;
}
const handleDragStart = (event: DragEvent) => dragMention.handleDragStart(event);
const handleDragEnd = () => dragMention.handleDragEnd();
panel.addEventListener("dragstart", handleDragStart, true);
panel.addEventListener("dragend", handleDragEnd);
return () => {
panel.removeEventListener("dragstart", handleDragStart, true);
panel.removeEventListener("dragend", handleDragEnd);
};
}, [dragMention]);

return (
<div
ref={panelRef}
className="flex min-h-0 flex-1 flex-col bg-background"
data-file-browser-panel={`${environmentId}:${cwd}`}
>
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 47 additions & 13 deletions apps/web/src/components/chat/ChatComposer.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,6 +43,10 @@ import {
replaceTextRange,
} from "../../composer-logic";
import { deriveComposerSendState, readFileAsDataUrl } from "../ChatView.logic";
import {
dataTransferHasComposerMention,
makeComposerMentionDragHandlers,
} from "./composerMentionDrag";
import {
type ComposerImageAttachment,
type DraftId,
Expand DownExpand Up@@ -1855,6 +1859,44 @@ export const ChatComposer = memo(function ChatComposer(props: ChatComposerProps)
addComposerImages(files);
focusComposer();
};

const insertComposerTextAtEnd = (text: string): boolean => {
// Pending plan questions keep the composer usable (the replacement path
// routes text into the custom answer), so they do not block insertion.
if (
text.length === 0 ||
isConnecting ||
isComposerApprovalState ||
(environmentUnavailable !== null && activePendingProgress === null)
) {
return false;
}
const rangeEnd = promptRef.current.length;
Comment thread
coderabbitai[bot] marked this conversation as resolved.
return applyPromptReplacement(rangeEnd, rangeEnd, text);
};

// File-tree drags land as mentions. Handled in the capture phase so the
// editor never sees the drop; the load-bearing rules (native stop, "move"
// effect, no eager focus) live in makeComposerMentionDragHandlers.
const composerMentionDragHandlers = makeComposerMentionDragHandlers({
insertMentionAtEnd: insertComposerTextAtEnd,
setDragActive: setIsDragOverComposer,
onInsertRejected: () => {
toastManager.add({
type: "error",
title: "Unable to add to chat",
description: "The composer is busy; try again once it is ready.",
});
},
});

const onComposerMentionDragLeaveCapture = (event: React.DragEvent<HTMLDivElement>) => {
if (!dataTransferHasComposerMention(event.dataTransfer.types)) return;
event.stopPropagation();
const nextTarget = event.relatedTarget;
if (nextTarget instanceof Node && event.currentTarget.contains(nextTarget)) return;
setIsDragOverComposer(false);
};
const handleInterruptPrimaryAction = useCallback(() => {
void onInterrupt();
}, [onInterrupt]);
Expand DownExpand Up@@ -1918,19 +1960,7 @@ export const ChatComposer = memo(function ChatComposer(props: ChatComposerProps)
focusAt: (cursor: number) => {
composerEditorRef.current?.focusAt(cursor);
},
insertTextAtEnd: (text: string) => {
if (
text.length === 0 ||
isConnecting ||
isComposerApprovalState ||
pendingUserInputs.length > 0 ||
(environmentUnavailable !== null && activePendingProgress === null)
) {
return false;
}
const rangeEnd = promptRef.current.length;
return applyPromptReplacement(rangeEnd, rangeEnd, text);
},
insertTextAtEnd: insertComposerTextAtEnd,
openModelPicker: () => {
setIsComposerModelPickerOpen(true);
},
Expand DownExpand Up@@ -2056,6 +2086,10 @@ export const ChatComposer = memo(function ChatComposer(props: ChatComposerProps)
onDragOver={onComposerDragOver}
onDragLeave={onComposerDragLeave}
onDrop={onComposerDrop}
onDragEnterCapture={composerMentionDragHandlers.onDragEnter}
onDragOverCapture={composerMentionDragHandlers.onDragOver}
onDragLeaveCapture={onComposerMentionDragLeaveCapture}
onDropCapture={composerMentionDragHandlers.onDrop}
>
<div
ref={composerSurfaceRef}
Expand Down
123 changes: 123 additions & 0 deletions apps/web/src/components/chat/composerMentionDrag.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,123 @@
import { describe, expect, it } from "@effect/vitest";

import {
COMPOSER_MENTION_DRAG_TYPE,
type ComposerMentionDropHost,
composerMentionFromTreePath,
dataTransferHasComposerMention,
makeComposerMentionDragHandlers,
} from "./composerMentionDrag.ts";

const makeDragEvent = (options?: { mention?: string; types?: ReadonlyArray<string> }) => {
const mention = options?.mention ?? "[index.md](docs/index.md)";
const calls: Array<string> = [];
const event = {
dataTransfer: {
types: options?.types ?? [COMPOSER_MENTION_DRAG_TYPE, "text/plain"],
getData: (format: string) => (format === COMPOSER_MENTION_DRAG_TYPE ? mention : ""),
dropEffect: "none",
},
nativeEvent: {
stopPropagation: () => void calls.push("nativeStopPropagation"),
},
preventDefault: () => void calls.push("preventDefault"),
stopPropagation: () => void calls.push("stopPropagation"),
};
return { event, calls };
};

const makeHost = (insertResult = true) => {
const log: Array<string> = [];
const host: ComposerMentionDropHost = {
insertMentionAtEnd: (text) => {
log.push(`insert:${text}`);
return insertResult;
},
setDragActive: (active) => void log.push(`active:${active}`),
onInsertRejected: () => void log.push("rejected"),
};
return { host, log };
};

describe("composerMentionFromTreePath", () => {
it("serializes a file path into a mention", () => {
expect(composerMentionFromTreePath("docs/index.md")).toBe("[index.md](docs/index.md)");
});

it("strips the trailing slash directory rows carry", () => {
expect(composerMentionFromTreePath("docs/architecture/")).toBe(
"[architecture](docs/architecture)",
);
});

it("rejects drags that carry no path", () => {
expect(composerMentionFromTreePath("")).toBeNull();
expect(composerMentionFromTreePath("/")).toBeNull();
});
});

describe("dataTransferHasComposerMention", () => {
it("detects the mention payload among drag types", () => {
expect(dataTransferHasComposerMention([COMPOSER_MENTION_DRAG_TYPE, "text/plain"])).toBe(true);
expect(dataTransferHasComposerMention(["Files"])).toBe(false);
expect(dataTransferHasComposerMention([])).toBe(false);
});
});

describe("makeComposerMentionDragHandlers", () => {
it("leaves drags without the mention payload alone", () => {
const { host, log } = makeHost();
const handlers = makeComposerMentionDragHandlers(host);
const { event, calls } = makeDragEvent({ types: ["Files"] });
handlers.onDragEnter(event);
handlers.onDragOver(event);
handlers.onDrop(event);
expect(calls).toEqual([]);
expect(log).toEqual([]);
});

it("stops the native event too, not just the synthetic one", () => {
// React's stopPropagation only halts synthetic dispatch; without the
// native stop, the editor's own DOM listeners process the drop and sync
// their stale state back over the inserted mention.
const { host } = makeHost();
const handlers = makeComposerMentionDragHandlers(host);
const { event, calls } = makeDragEvent();
handlers.onDrop(event);
expect(calls).toContain("preventDefault");
expect(calls).toContain("stopPropagation");
expect(calls).toContain("nativeStopPropagation");
});

it('answers dragover with the "move" effect the tree allows', () => {
// Naming an effect outside the source's effectAllowed makes the browser
// cancel the drop without ever firing it.
const { host } = makeHost();
const handlers = makeComposerMentionDragHandlers(host);
const { event } = makeDragEvent();
handlers.onDragOver(event);
expect(event.dataTransfer.dropEffect).toBe("move");
});

it("inserts the mention with its trailing space and clears the highlight", () => {
const { host, log } = makeHost();
const handlers = makeComposerMentionDragHandlers(host);
handlers.onDragEnter(makeDragEvent().event);
handlers.onDrop(makeDragEvent().event);
expect(log).toEqual(["active:true", "active:false", "insert:[index.md](docs/index.md) "]);
});

it("reports a rejected insert instead of failing silently", () => {
const { host, log } = makeHost(false);
const handlers = makeComposerMentionDragHandlers(host);
handlers.onDrop(makeDragEvent().event);
expect(log).toContain("rejected");
});

it("ignores a drop whose payload is empty", () => {
const { host, log } = makeHost();
const handlers = makeComposerMentionDragHandlers(host);
handlers.onDrop(makeDragEvent({ mention: "" }).event);
expect(log).toEqual(["active:false"]);
});
});
98 changes: 98 additions & 0 deletions apps/web/src/components/chat/composerMentionDrag.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,98 @@
import { serializeComposerFileLink } from "@t3tools/shared/composerTrigger";

/**
* Drag payload type carrying a serialized composer mention. Set on drags that
* start in the workspace file tree so the composer can tell them apart from
* OS file drags and plain text selections.
*/
export const COMPOSER_MENTION_DRAG_TYPE = "application/x-t3code-composer-mention";

export function composerMentionFromTreePath(treePath: string): string | null {
const relativePath = treePath.replace(/\/+$/, "");
if (relativePath.length === 0) {
return null;
}
return serializeComposerFileLink(relativePath);
}

export function dataTransferHasComposerMention(types: ReadonlyArray<string>): boolean {
return types.includes(COMPOSER_MENTION_DRAG_TYPE);
}

export interface ComposerMentionDragTransfer {
readonly types: ReadonlyArray<string>;
getData(format: string): string;
dropEffect: string;
}

export interface ComposerMentionDragEvent {
readonly dataTransfer: ComposerMentionDragTransfer;
readonly nativeEvent: { stopPropagation(): void };
preventDefault(): void;
stopPropagation(): void;
}

/**
* What a mention drop is allowed to do to the composer. Deliberately narrow:
* there is no way to focus the editor from here. Focusing it synchronously
* during the drop makes the not-yet-reconciled editor sync its stale empty
* state back over the inserted mention; the insert path already focuses on
* the next frame, after the editor has caught up.
*/
export interface ComposerMentionDropHost {
insertMentionAtEnd(text: string): boolean;
setDragActive(active: boolean): void;
onInsertRejected(): void;
}

export interface ComposerMentionDragHandlers {
onDragEnter(event: ComposerMentionDragEvent): void;
onDragOver(event: ComposerMentionDragEvent): void;
onDrop(event: ComposerMentionDragEvent): void;
}

export function makeComposerMentionDragHandlers(
host: ComposerMentionDropHost,
): ComposerMentionDragHandlers {
// Claim the event for the composer: React's stopPropagation only halts the
// synthetic dispatch, so the native event must be stopped too or the
// editor's own DOM listeners still process the drag.
const claim = (event: ComposerMentionDragEvent): boolean => {
if (!dataTransferHasComposerMention(event.dataTransfer.types)) {
return false;
}
event.preventDefault();
event.stopPropagation();
event.nativeEvent.stopPropagation();
return true;
};
return {
onDragEnter(event) {
if (claim(event)) {
host.setDragActive(true);
}
},
onDragOver(event) {
if (!claim(event)) {
return;
}
// The tree constrains its drags to effectAllowed "move"; naming any
// other effect makes the browser cancel the drop without firing it.
event.dataTransfer.dropEffect = "move";
host.setDragActive(true);
},
onDrop(event) {
if (!claim(event)) {
return;
}
host.setDragActive(false);
const mention = event.dataTransfer.getData(COMPOSER_MENTION_DRAG_TYPE);
if (mention.length === 0) {
return;
}
if (!host.insertMentionAtEnd(`${mention} `)) {
host.onInsertRejected();
}
},
};
}
44 changes: 44 additions & 0 deletions apps/web/src/components/files/FileBrowserPanel.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,6 +16,7 @@ import { cn } from "~/lib/utils";
import { readLocalApi } from "~/localApi";
import { T3_PIERRE_ICONS } from "~/pierre-icons";

import { createFileTreeDragMentionController } from "./fileTreeDragMention";
import { useProjectEntriesQuery } from "./projectFilesQueryState";

interface FileBrowserPanelProps {
Expand DownExpand Up@@ -128,6 +129,14 @@ export default function FileBrowserPanel({
showEntryContextMenuRef.current = showEntryContextMenu;
});

const treeModelRef = useRef<ReturnType<typeof useFileTree>["model"] | null>(null);
const dragMention = useMemo(
() =>
createFileTreeDragMentionController({
deselect: (path) => treeModelRef.current?.getItem(path)?.deselect(),
}),
[],
);
const { model } = useFileTree({
composition: {
contextMenu: {
Expand All@@ -137,12 +146,21 @@ export default function FileBrowserPanel({
},
},
},
// Rows only need to be draggable so entries can be dropped into the chat
// composer; rearranging files inside the tree stays off.
dragAndDrop: { canDrop: () => false },
density: "compact",
fileTreeSearchMode: "hide-non-matches",
flattenEmptyDirectories: true,
initialExpansion: 1,
icons: T3_PIERRE_ICONS,
onSelectionChange: (selectedPaths) => {
dragMention.handleSelectionChange(selectedPaths);
// Starting a drag selects the dragged row; that selection is a side
// effect of the gesture, not a request to open the file.
if (dragMention.isDragInProgress()) {
return;
}
const selectedPath = selectedPaths.at(-1)?.replace(/\/$/, "");
if (selectedPath && entryKindsRef.current.get(selectedPath) === "file") {
onOpenFile(selectedPath);
Expand All@@ -165,8 +183,34 @@ export default function FileBrowserPanel({
[entries],
);

// Tag tree drags with the composer mention payload. The row is read from
// the composed event path (the tree's shadow root is open), so this does
// not depend on running after the tree's own dragstart handler; the drag
// data store is writable for every dragstart listener in the dispatch.
// The capture phase runs before the tree's own dragstart handler selects
// the dragged row, so the drag flag is up before that selection emits.
const panelRef = useRef<HTMLDivElement | null>(null);
useEffect(() => {
treeModelRef.current = model;
}, [model]);
useEffect(() => {
const panel = panelRef.current;
if (panel === null) {
return;
}
const handleDragStart = (event: DragEvent) => dragMention.handleDragStart(event);
const handleDragEnd = () => dragMention.handleDragEnd();
panel.addEventListener("dragstart", handleDragStart, true);
panel.addEventListener("dragend", handleDragEnd);
return () => {
panel.removeEventListener("dragstart", handleDragStart, true);
panel.removeEventListener("dragend", handleDragEnd);
};
}, [dragMention]);

return (
<div
ref={panelRef}
className="flex min-h-0 flex-1 flex-col bg-background"
data-file-browser-panel={`${environmentId}:${cwd}`}
>
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 47 additions & 13 deletions apps/web/src/components/chat/ChatComposer.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,6 +43,10 @@ import {
replaceTextRange,
} from "../../composer-logic";
import { deriveComposerSendState, readFileAsDataUrl } from "../ChatView.logic";
import {
dataTransferHasComposerMention,
makeComposerMentionDragHandlers,
} from "./composerMentionDrag";
import {
type ComposerImageAttachment,
type DraftId,
Expand DownExpand Up@@ -1855,6 +1859,44 @@ export const ChatComposer = memo(function ChatComposer(props: ChatComposerProps)
addComposerImages(files);
focusComposer();
};

const insertComposerTextAtEnd = (text: string): boolean => {
// Pending plan questions keep the composer usable (the replacement path
// routes text into the custom answer), so they do not block insertion.
if (
text.length === 0 ||
isConnecting ||
isComposerApprovalState ||
(environmentUnavailable !== null && activePendingProgress === null)
) {
return false;
}
const rangeEnd = promptRef.current.length;
Comment thread
coderabbitai[bot] marked this conversation as resolved.
return applyPromptReplacement(rangeEnd, rangeEnd, text);
};

// File-tree drags land as mentions. Handled in the capture phase so the
// editor never sees the drop; the load-bearing rules (native stop, "move"
// effect, no eager focus) live in makeComposerMentionDragHandlers.
const composerMentionDragHandlers = makeComposerMentionDragHandlers({
insertMentionAtEnd: insertComposerTextAtEnd,
setDragActive: setIsDragOverComposer,
onInsertRejected: () => {
toastManager.add({
type: "error",
title: "Unable to add to chat",
description: "The composer is busy; try again once it is ready.",
});
},
});

const onComposerMentionDragLeaveCapture = (event: React.DragEvent<HTMLDivElement>) => {
if (!dataTransferHasComposerMention(event.dataTransfer.types)) return;
event.stopPropagation();
const nextTarget = event.relatedTarget;
if (nextTarget instanceof Node && event.currentTarget.contains(nextTarget)) return;
setIsDragOverComposer(false);
};
const handleInterruptPrimaryAction = useCallback(() => {
void onInterrupt();
}, [onInterrupt]);
Expand DownExpand Up@@ -1918,19 +1960,7 @@ export const ChatComposer = memo(function ChatComposer(props: ChatComposerProps)
focusAt: (cursor: number) => {
composerEditorRef.current?.focusAt(cursor);
},
insertTextAtEnd: (text: string) => {
if (
text.length === 0 ||
isConnecting ||
isComposerApprovalState ||
pendingUserInputs.length > 0 ||
(environmentUnavailable !== null && activePendingProgress === null)
) {
return false;
}
const rangeEnd = promptRef.current.length;
return applyPromptReplacement(rangeEnd, rangeEnd, text);
},
insertTextAtEnd: insertComposerTextAtEnd,
openModelPicker: () => {
setIsComposerModelPickerOpen(true);
},
Expand DownExpand Up@@ -2056,6 +2086,10 @@ export const ChatComposer = memo(function ChatComposer(props: ChatComposerProps)
onDragOver={onComposerDragOver}
onDragLeave={onComposerDragLeave}
onDrop={onComposerDrop}
onDragEnterCapture={composerMentionDragHandlers.onDragEnter}
onDragOverCapture={composerMentionDragHandlers.onDragOver}
onDragLeaveCapture={onComposerMentionDragLeaveCapture}
onDropCapture={composerMentionDragHandlers.onDrop}
>
<div
ref={composerSurfaceRef}
Expand Down
123 changes: 123 additions & 0 deletions apps/web/src/components/chat/composerMentionDrag.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,123 @@
import { describe, expect, it } from "@effect/vitest";

import {
COMPOSER_MENTION_DRAG_TYPE,
type ComposerMentionDropHost,
composerMentionFromTreePath,
dataTransferHasComposerMention,
makeComposerMentionDragHandlers,
} from "./composerMentionDrag.ts";

const makeDragEvent = (options?: { mention?: string; types?: ReadonlyArray<string> }) => {
const mention = options?.mention ?? "[index.md](docs/index.md)";
const calls: Array<string> = [];
const event = {
dataTransfer: {
types: options?.types ?? [COMPOSER_MENTION_DRAG_TYPE, "text/plain"],
getData: (format: string) => (format === COMPOSER_MENTION_DRAG_TYPE ? mention : ""),
dropEffect: "none",
},
nativeEvent: {
stopPropagation: () => void calls.push("nativeStopPropagation"),
},
preventDefault: () => void calls.push("preventDefault"),
stopPropagation: () => void calls.push("stopPropagation"),
};
return { event, calls };
};

const makeHost = (insertResult = true) => {
const log: Array<string> = [];
const host: ComposerMentionDropHost = {
insertMentionAtEnd: (text) => {
log.push(`insert:${text}`);
return insertResult;
},
setDragActive: (active) => void log.push(`active:${active}`),
onInsertRejected: () => void log.push("rejected"),
};
return { host, log };
};

describe("composerMentionFromTreePath", () => {
it("serializes a file path into a mention", () => {
expect(composerMentionFromTreePath("docs/index.md")).toBe("[index.md](docs/index.md)");
});

it("strips the trailing slash directory rows carry", () => {
expect(composerMentionFromTreePath("docs/architecture/")).toBe(
"[architecture](docs/architecture)",
);
});

it("rejects drags that carry no path", () => {
expect(composerMentionFromTreePath("")).toBeNull();
expect(composerMentionFromTreePath("/")).toBeNull();
});
});

describe("dataTransferHasComposerMention", () => {
it("detects the mention payload among drag types", () => {
expect(dataTransferHasComposerMention([COMPOSER_MENTION_DRAG_TYPE, "text/plain"])).toBe(true);
expect(dataTransferHasComposerMention(["Files"])).toBe(false);
expect(dataTransferHasComposerMention([])).toBe(false);
});
});

describe("makeComposerMentionDragHandlers", () => {
it("leaves drags without the mention payload alone", () => {
const { host, log } = makeHost();
const handlers = makeComposerMentionDragHandlers(host);
const { event, calls } = makeDragEvent({ types: ["Files"] });
handlers.onDragEnter(event);
handlers.onDragOver(event);
handlers.onDrop(event);
expect(calls).toEqual([]);
expect(log).toEqual([]);
});

it("stops the native event too, not just the synthetic one", () => {
// React's stopPropagation only halts synthetic dispatch; without the
// native stop, the editor's own DOM listeners process the drop and sync
// their stale state back over the inserted mention.
const { host } = makeHost();
const handlers = makeComposerMentionDragHandlers(host);
const { event, calls } = makeDragEvent();
handlers.onDrop(event);
expect(calls).toContain("preventDefault");
expect(calls).toContain("stopPropagation");
expect(calls).toContain("nativeStopPropagation");
});

it('answers dragover with the "move" effect the tree allows', () => {
// Naming an effect outside the source's effectAllowed makes the browser
// cancel the drop without ever firing it.
const { host } = makeHost();
const handlers = makeComposerMentionDragHandlers(host);
const { event } = makeDragEvent();
handlers.onDragOver(event);
expect(event.dataTransfer.dropEffect).toBe("move");
});

it("inserts the mention with its trailing space and clears the highlight", () => {
const { host, log } = makeHost();
const handlers = makeComposerMentionDragHandlers(host);
handlers.onDragEnter(makeDragEvent().event);
handlers.onDrop(makeDragEvent().event);
expect(log).toEqual(["active:true", "active:false", "insert:[index.md](docs/index.md) "]);
});

it("reports a rejected insert instead of failing silently", () => {
const { host, log } = makeHost(false);
const handlers = makeComposerMentionDragHandlers(host);
handlers.onDrop(makeDragEvent().event);
expect(log).toContain("rejected");
});

it("ignores a drop whose payload is empty", () => {
const { host, log } = makeHost();
const handlers = makeComposerMentionDragHandlers(host);
handlers.onDrop(makeDragEvent({ mention: "" }).event);
expect(log).toEqual(["active:false"]);
});
});
98 changes: 98 additions & 0 deletions apps/web/src/components/chat/composerMentionDrag.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,98 @@
import { serializeComposerFileLink } from "@t3tools/shared/composerTrigger";

/**
* Drag payload type carrying a serialized composer mention. Set on drags that
* start in the workspace file tree so the composer can tell them apart from
* OS file drags and plain text selections.
*/
export const COMPOSER_MENTION_DRAG_TYPE = "application/x-t3code-composer-mention";

export function composerMentionFromTreePath(treePath: string): string | null {
const relativePath = treePath.replace(/\/+$/, "");
if (relativePath.length === 0) {
return null;
}
return serializeComposerFileLink(relativePath);
}

export function dataTransferHasComposerMention(types: ReadonlyArray<string>): boolean {
return types.includes(COMPOSER_MENTION_DRAG_TYPE);
}

export interface ComposerMentionDragTransfer {
readonly types: ReadonlyArray<string>;
getData(format: string): string;
dropEffect: string;
}

export interface ComposerMentionDragEvent {
readonly dataTransfer: ComposerMentionDragTransfer;
readonly nativeEvent: { stopPropagation(): void };
preventDefault(): void;
stopPropagation(): void;
}

/**
* What a mention drop is allowed to do to the composer. Deliberately narrow:
* there is no way to focus the editor from here. Focusing it synchronously
* during the drop makes the not-yet-reconciled editor sync its stale empty
* state back over the inserted mention; the insert path already focuses on
* the next frame, after the editor has caught up.
*/
export interface ComposerMentionDropHost {
insertMentionAtEnd(text: string): boolean;
setDragActive(active: boolean): void;
onInsertRejected(): void;
}

export interface ComposerMentionDragHandlers {
onDragEnter(event: ComposerMentionDragEvent): void;
onDragOver(event: ComposerMentionDragEvent): void;
onDrop(event: ComposerMentionDragEvent): void;
}

export function makeComposerMentionDragHandlers(
host: ComposerMentionDropHost,
): ComposerMentionDragHandlers {
// Claim the event for the composer: React's stopPropagation only halts the
// synthetic dispatch, so the native event must be stopped too or the
// editor's own DOM listeners still process the drag.
const claim = (event: ComposerMentionDragEvent): boolean => {
if (!dataTransferHasComposerMention(event.dataTransfer.types)) {
return false;
}
event.preventDefault();
event.stopPropagation();
event.nativeEvent.stopPropagation();
return true;
};
return {
onDragEnter(event) {
if (claim(event)) {
host.setDragActive(true);
}
},
onDragOver(event) {
if (!claim(event)) {
return;
}
// The tree constrains its drags to effectAllowed "move"; naming any
// other effect makes the browser cancel the drop without firing it.
event.dataTransfer.dropEffect = "move";
host.setDragActive(true);
},
onDrop(event) {
if (!claim(event)) {
return;
}
host.setDragActive(false);
const mention = event.dataTransfer.getData(COMPOSER_MENTION_DRAG_TYPE);
if (mention.length === 0) {
return;
}
if (!host.insertMentionAtEnd(`${mention} `)) {
host.onInsertRejected();
}
},
};
}
44 changes: 44 additions & 0 deletions apps/web/src/components/files/FileBrowserPanel.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,6 +16,7 @@ import { cn } from "~/lib/utils";
import { readLocalApi } from "~/localApi";
import { T3_PIERRE_ICONS } from "~/pierre-icons";

import { createFileTreeDragMentionController } from "./fileTreeDragMention";
import { useProjectEntriesQuery } from "./projectFilesQueryState";

interface FileBrowserPanelProps {
Expand DownExpand Up@@ -128,6 +129,14 @@ export default function FileBrowserPanel({
showEntryContextMenuRef.current = showEntryContextMenu;
});

const treeModelRef = useRef<ReturnType<typeof useFileTree>["model"] | null>(null);
const dragMention = useMemo(
() =>
createFileTreeDragMentionController({
deselect: (path) => treeModelRef.current?.getItem(path)?.deselect(),
}),
[],
);
const { model } = useFileTree({
composition: {
contextMenu: {
Expand All@@ -137,12 +146,21 @@ export default function FileBrowserPanel({
},
},
},
// Rows only need to be draggable so entries can be dropped into the chat
// composer; rearranging files inside the tree stays off.
dragAndDrop: { canDrop: () => false },
density: "compact",
fileTreeSearchMode: "hide-non-matches",
flattenEmptyDirectories: true,
initialExpansion: 1,
icons: T3_PIERRE_ICONS,
onSelectionChange: (selectedPaths) => {
dragMention.handleSelectionChange(selectedPaths);
// Starting a drag selects the dragged row; that selection is a side
// effect of the gesture, not a request to open the file.
if (dragMention.isDragInProgress()) {
return;
}
const selectedPath = selectedPaths.at(-1)?.replace(/\/$/, "");
if (selectedPath && entryKindsRef.current.get(selectedPath) === "file") {
onOpenFile(selectedPath);
Expand All@@ -165,8 +183,34 @@ export default function FileBrowserPanel({
[entries],
);

// Tag tree drags with the composer mention payload. The row is read from
// the composed event path (the tree's shadow root is open), so this does
// not depend on running after the tree's own dragstart handler; the drag
// data store is writable for every dragstart listener in the dispatch.
// The capture phase runs before the tree's own dragstart handler selects
// the dragged row, so the drag flag is up before that selection emits.
const panelRef = useRef<HTMLDivElement | null>(null);
useEffect(() => {
treeModelRef.current = model;
}, [model]);
useEffect(() => {
const panel = panelRef.current;
if (panel === null) {
return;
}
const handleDragStart = (event: DragEvent) => dragMention.handleDragStart(event);
const handleDragEnd = () => dragMention.handleDragEnd();
panel.addEventListener("dragstart", handleDragStart, true);
panel.addEventListener("dragend", handleDragEnd);
return () => {
panel.removeEventListener("dragstart", handleDragStart, true);
panel.removeEventListener("dragend", handleDragEnd);
};
}, [dragMention]);

return (
<div
ref={panelRef}
className="flex min-h-0 flex-1 flex-col bg-background"
data-file-browser-panel={`${environmentId}:${cwd}`}
>
Expand Down
Loading