Skip to content
This repository was archived by the owner on Jul 1, 2026. It is now read-only.

Fix addListener('insert/update/delete') events - #1174

Closed
131 wants to merge 2 commits into
TryGhost:masterfrom
131:master
Closed

Fix addListener('insert/update/delete') events#1174
131 wants to merge 2 commits into
TryGhost:masterfrom
131:master

Conversation

@131

@131131 commented Jun 5, 2019

Copy link
Copy Markdown

The `addListener('insert /update/delete') API throw

Error: update is not a valid configuration option
at Database.addListener.Database.on (D:\dvp\study_stack\cloudfs\node_modules\sqlite3\lib\sqlite3.js:154:14)
at SQLITE.on (D:\dvp\study_stack\cloudfs\libs\sql.js:74:15)
at test.run (D:\dvp\study_stack\cloudfs\test.js:12:14)
at <anonymous> Error: update is not a valid configuration option
at Database.addListener.Database.on (D:\dvp\study_stack\cloudfs\node_modules\sqlite3\lib\sqlite3.js:154:14)
at SQLITE.on (D:\dvp\study_stack\cloudfs\libs\sql.js:74:15)
at test.run (D:\dvp\study_stack\cloudfs\test.js:12:14)
at <anonymous>

The following adjustement in Database::Configure make it work !

@131

131 commented Jun 5, 2019

Copy link
Copy Markdown
Author

I can add tests & documentation if requested

@kewde

Copy link
Copy Markdown
Collaborator

Thank you for your pull request.
Additional tests and documentation are required for small changes to make sure that it works as intended.

@little-brother

Copy link
Copy Markdown

Any updates?

@daniellockyer

Copy link
Copy Markdown
Contributor

Hey @131, this uses NAN but we've since switched to N-API. Would you be able to rework your PR? 🙂

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@131@kewde@little-brother@daniellockyer