fix(ui): stop syntect lazy-regex panics from aborting the app mid-render - #181

Merged
Tryanks merged 2 commits into
mainfrom
fix/syntect-fancy-regex-panics
Jul 28, 2026
Merged

fix(ui): stop syntect lazy-regex panics from aborting the app mid-render#181
Tryanks merged 2 commits into
mainfrom
fix/syntect-fancy-regex-panics

Conversation

@Tryanks

Copy link
Copy Markdown
Owner

Root cause

The app crashed in the field with an instant SIGABRT while switching to a running child thread (crash report tcode-2026-07-28-044740.ips, v0.1.33). Binary forensics on the stripped release binary recovered the chain:

  1. assets/syntaxes.bin comes from bat v0.26.1, whose syntax set is pre-tested against Oniguruma — but this crate compiles syntect 5.3.0 with the fancy-regex backend. 21 patterns (JS Babel \g<-1> subroutine calls, variable-length look-behind, \o{} escapes, ...) cannot compile under fancy-regex.
  2. syntect compiles grammar regexes lazily on first use and panics with regex string should be pre-tested (regex.rs:70) the first time content exercises such a rule. One ordinary jsx arrow function is enough — reproduced: const f = async (a, b) => a + b; panics through tcode's exact highlight path.
  3. The panic fired mid-GPUI-draw; unwinding through the element tree escalated into a double panic ("panic in a destructor during cleanup") → abort() → instant exit with no log. Lazy per-rule compilation plus the highlight cache is why it looked non-deterministic.

Fix (defense in depth)

  • Data: regenerate syntaxes.bin via the new examples/sanitize_syntaxes.rs — patterns the shipped backend cannot compile are replaced with never-matching (?!) (22 replacements; 220 syntaxes and all 22,300 patterns preserved). Capture back-reference patterns are validated the way syntect's own YAML loader does (placeholder substitution before try_compile); all 44 such patterns pass.
  • Runtime: highlight_source wraps syntect in catch_unwind, falls back to unhighlighted text, and poisons the offending syntax for the process (fail-closed on mutex poisoning) so a streaming code block cannot re-panic every frame.
  • Latent sibling bug: the chat list's entry_range slice into the live timeline is now guarded with .get() — the snapshot can trail the timeline by a frame when adopting a running background thread.
  • Regression tests: shipped_syntax_set_compiles_under_active_regex_backend fails CI whenever a future dump contains patterns the active backend rejects; the jsx repro test calls the unguarded parser directly so the fallback cannot mask a dirty dump.

Verification

  • cargo fmt --all --check, cargo clippy --workspace --all-targets --locked -- -D warnings, cargo test --workspace --locked — all green locally (macOS arm64).
  • Repro snippet panics on the old dump, clean on the new one; sanitizer output re-verified by reloading the exact shipped bytes.
  • Independently reviewed; review findings (fail-open poison lock, capture-pattern validation gap, fallback-masked test) addressed in the second commit.

🤖 Generated with Claude Code

Tryanksand others added 2 commits July 28, 2026 11:59
The bundled syntaxes.bin comes from bat, whose syntax set is pre-tested
against Oniguruma, but syntect is compiled here with the fancy-regex
backend. syntect compiles grammar regexes lazily and panics with "regex
string should be pre-tested" the first time content exercises a pattern
the active backend rejects (21 such patterns: subroutine calls,
variable-length look-behind, \o{} escapes, ...). One ordinary jsx arrow
function was enough to panic mid-draw; unwinding through the GPUI
element tree turned it into a double panic and SIGABRT.
- regenerate syntaxes.bin with the new sanitize_syntaxes example, which
replaces patterns the shipped backend cannot compile with a
never-matching placeholder (raw-compiled patterns only; capture
back-reference patterns are substituted before compiling and are left
alone)
- wrap the syntect work in catch_unwind and fall back to unhighlighted
text, poisoning the offending syntax for the rest of the process so a
streaming code block cannot re-panic every frame
- guard the chat list's entry_range slice against a stale turn-items
snapshot racing the live timeline (a second latent mid-render panic,
seen when adopting a running background thread)
- add a regression test that fails CI whenever a future syntaxes.bin
contains patterns the active regex backend cannot compile
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- fail closed when the poisoned-syntax set's mutex is poisoned: recover
the guard with PoisonError::into_inner instead of silently retrying a
panicking parse every frame
- validate capture back-reference patterns the way syntect's YAML loader
does (placeholder substitution before try_compile) in both the
sanitizer and the regression test, instead of skipping them wholesale;
the shipped dump is unchanged — all 44 such patterns compile after
substitution
- call the unguarded parser directly in the jsx regression test so the
catch_unwind fallback cannot mask a dirty dump
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@Tryanks
Tryanks enabled auto-merge July 28, 2026 04:07
@Tryanks
Tryanks merged commit 257cd32 into mainJul 28, 2026
3 checks passed
@Tryanks
Tryanks deleted the fix/syntect-fancy-regex-panics branch July 28, 2026 04:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Tryanks
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all \u003cpre\u003e\u003ccode\u003e blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks"); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); (function(){ try { var __m = "github.com"; var __re = new RegExp('^' + "github\\.com" + '
Skip to content

fix(ui): stop syntect lazy-regex panics from aborting the app mid-render - #181

Merged
Tryanks merged 2 commits into
mainfrom
fix/syntect-fancy-regex-panics
Jul 28, 2026
Merged

fix(ui): stop syntect lazy-regex panics from aborting the app mid-render#181
Tryanks merged 2 commits into
mainfrom
fix/syntect-fancy-regex-panics

Conversation

@Tryanks

Copy link
Copy Markdown
Owner

Root cause

The app crashed in the field with an instant SIGABRT while switching to a running child thread (crash report tcode-2026-07-28-044740.ips, v0.1.33). Binary forensics on the stripped release binary recovered the chain:

  1. assets/syntaxes.bin comes from bat v0.26.1, whose syntax set is pre-tested against Oniguruma — but this crate compiles syntect 5.3.0 with the fancy-regex backend. 21 patterns (JS Babel \g<-1> subroutine calls, variable-length look-behind, \o{} escapes, ...) cannot compile under fancy-regex.
  2. syntect compiles grammar regexes lazily on first use and panics with regex string should be pre-tested (regex.rs:70) the first time content exercises such a rule. One ordinary jsx arrow function is enough — reproduced: const f = async (a, b) => a + b; panics through tcode's exact highlight path.
  3. The panic fired mid-GPUI-draw; unwinding through the element tree escalated into a double panic ("panic in a destructor during cleanup") → abort() → instant exit with no log. Lazy per-rule compilation plus the highlight cache is why it looked non-deterministic.

Fix (defense in depth)

  • Data: regenerate syntaxes.bin via the new examples/sanitize_syntaxes.rs — patterns the shipped backend cannot compile are replaced with never-matching (?!) (22 replacements; 220 syntaxes and all 22,300 patterns preserved). Capture back-reference patterns are validated the way syntect's own YAML loader does (placeholder substitution before try_compile); all 44 such patterns pass.
  • Runtime: highlight_source wraps syntect in catch_unwind, falls back to unhighlighted text, and poisons the offending syntax for the process (fail-closed on mutex poisoning) so a streaming code block cannot re-panic every frame.
  • Latent sibling bug: the chat list's entry_range slice into the live timeline is now guarded with .get() — the snapshot can trail the timeline by a frame when adopting a running background thread.
  • Regression tests: shipped_syntax_set_compiles_under_active_regex_backend fails CI whenever a future dump contains patterns the active backend rejects; the jsx repro test calls the unguarded parser directly so the fallback cannot mask a dirty dump.

Verification

  • cargo fmt --all --check, cargo clippy --workspace --all-targets --locked -- -D warnings, cargo test --workspace --locked — all green locally (macOS arm64).
  • Repro snippet panics on the old dump, clean on the new one; sanitizer output re-verified by reloading the exact shipped bytes.
  • Independently reviewed; review findings (fail-open poison lock, capture-pattern validation gap, fallback-masked test) addressed in the second commit.

🤖 Generated with Claude Code

Tryanksand others added 2 commits July 28, 2026 11:59
The bundled syntaxes.bin comes from bat, whose syntax set is pre-tested
against Oniguruma, but syntect is compiled here with the fancy-regex
backend. syntect compiles grammar regexes lazily and panics with "regex
string should be pre-tested" the first time content exercises a pattern
the active backend rejects (21 such patterns: subroutine calls,
variable-length look-behind, \o{} escapes, ...). One ordinary jsx arrow
function was enough to panic mid-draw; unwinding through the GPUI
element tree turned it into a double panic and SIGABRT.
- regenerate syntaxes.bin with the new sanitize_syntaxes example, which
replaces patterns the shipped backend cannot compile with a
never-matching placeholder (raw-compiled patterns only; capture
back-reference patterns are substituted before compiling and are left
alone)
- wrap the syntect work in catch_unwind and fall back to unhighlighted
text, poisoning the offending syntax for the rest of the process so a
streaming code block cannot re-panic every frame
- guard the chat list's entry_range slice against a stale turn-items
snapshot racing the live timeline (a second latent mid-render panic,
seen when adopting a running background thread)
- add a regression test that fails CI whenever a future syntaxes.bin
contains patterns the active regex backend cannot compile
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- fail closed when the poisoned-syntax set's mutex is poisoned: recover
the guard with PoisonError::into_inner instead of silently retrying a
panicking parse every frame
- validate capture back-reference patterns the way syntect's YAML loader
does (placeholder substitution before try_compile) in both the
sanitizer and the regression test, instead of skipping them wholesale;
the shipped dump is unchanged — all 44 such patterns compile after
substitution
- call the unguarded parser directly in the jsx regression test so the
catch_unwind fallback cannot mask a dirty dump
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@Tryanks
Tryanks enabled auto-merge July 28, 2026 04:07
@Tryanks
Tryanks merged commit 257cd32 into mainJul 28, 2026
3 checks passed
@Tryanks
Tryanks deleted the fix/syntect-fancy-regex-panics branch July 28, 2026 04:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Tryanks
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(ui): stop syntect lazy-regex panics from aborting the app mid-render - #181

Merged
Tryanks merged 2 commits into
mainfrom
fix/syntect-fancy-regex-panics
Jul 28, 2026
Merged

fix(ui): stop syntect lazy-regex panics from aborting the app mid-render#181
Tryanks merged 2 commits into
mainfrom
fix/syntect-fancy-regex-panics

Conversation

@Tryanks

Copy link
Copy Markdown
Owner

Root cause

The app crashed in the field with an instant SIGABRT while switching to a running child thread (crash report tcode-2026-07-28-044740.ips, v0.1.33). Binary forensics on the stripped release binary recovered the chain:

  1. assets/syntaxes.bin comes from bat v0.26.1, whose syntax set is pre-tested against Oniguruma — but this crate compiles syntect 5.3.0 with the fancy-regex backend. 21 patterns (JS Babel \g<-1> subroutine calls, variable-length look-behind, \o{} escapes, ...) cannot compile under fancy-regex.
  2. syntect compiles grammar regexes lazily on first use and panics with regex string should be pre-tested (regex.rs:70) the first time content exercises such a rule. One ordinary jsx arrow function is enough — reproduced: const f = async (a, b) => a + b; panics through tcode's exact highlight path.
  3. The panic fired mid-GPUI-draw; unwinding through the element tree escalated into a double panic ("panic in a destructor during cleanup") → abort() → instant exit with no log. Lazy per-rule compilation plus the highlight cache is why it looked non-deterministic.

Fix (defense in depth)

  • Data: regenerate syntaxes.bin via the new examples/sanitize_syntaxes.rs — patterns the shipped backend cannot compile are replaced with never-matching (?!) (22 replacements; 220 syntaxes and all 22,300 patterns preserved). Capture back-reference patterns are validated the way syntect's own YAML loader does (placeholder substitution before try_compile); all 44 such patterns pass.
  • Runtime: highlight_source wraps syntect in catch_unwind, falls back to unhighlighted text, and poisons the offending syntax for the process (fail-closed on mutex poisoning) so a streaming code block cannot re-panic every frame.
  • Latent sibling bug: the chat list's entry_range slice into the live timeline is now guarded with .get() — the snapshot can trail the timeline by a frame when adopting a running background thread.
  • Regression tests: shipped_syntax_set_compiles_under_active_regex_backend fails CI whenever a future dump contains patterns the active backend rejects; the jsx repro test calls the unguarded parser directly so the fallback cannot mask a dirty dump.

Verification

  • cargo fmt --all --check, cargo clippy --workspace --all-targets --locked -- -D warnings, cargo test --workspace --locked — all green locally (macOS arm64).
  • Repro snippet panics on the old dump, clean on the new one; sanitizer output re-verified by reloading the exact shipped bytes.
  • Independently reviewed; review findings (fail-open poison lock, capture-pattern validation gap, fallback-masked test) addressed in the second commit.

🤖 Generated with Claude Code

Tryanksand others added 2 commits July 28, 2026 11:59
The bundled syntaxes.bin comes from bat, whose syntax set is pre-tested
against Oniguruma, but syntect is compiled here with the fancy-regex
backend. syntect compiles grammar regexes lazily and panics with "regex
string should be pre-tested" the first time content exercises a pattern
the active backend rejects (21 such patterns: subroutine calls,
variable-length look-behind, \o{} escapes, ...). One ordinary jsx arrow
function was enough to panic mid-draw; unwinding through the GPUI
element tree turned it into a double panic and SIGABRT.
- regenerate syntaxes.bin with the new sanitize_syntaxes example, which
replaces patterns the shipped backend cannot compile with a
never-matching placeholder (raw-compiled patterns only; capture
back-reference patterns are substituted before compiling and are left
alone)
- wrap the syntect work in catch_unwind and fall back to unhighlighted
text, poisoning the offending syntax for the rest of the process so a
streaming code block cannot re-panic every frame
- guard the chat list's entry_range slice against a stale turn-items
snapshot racing the live timeline (a second latent mid-render panic,
seen when adopting a running background thread)
- add a regression test that fails CI whenever a future syntaxes.bin
contains patterns the active regex backend cannot compile
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- fail closed when the poisoned-syntax set's mutex is poisoned: recover
the guard with PoisonError::into_inner instead of silently retrying a
panicking parse every frame
- validate capture back-reference patterns the way syntect's YAML loader
does (placeholder substitution before try_compile) in both the
sanitizer and the regression test, instead of skipping them wholesale;
the shipped dump is unchanged — all 44 such patterns compile after
substitution
- call the unguarded parser directly in the jsx regression test so the
catch_unwind fallback cannot mask a dirty dump
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@Tryanks
Tryanks enabled auto-merge July 28, 2026 04:07
@Tryanks
Tryanks merged commit 257cd32 into mainJul 28, 2026
3 checks passed
@Tryanks
Tryanks deleted the fix/syntect-fancy-regex-panics branch July 28, 2026 04:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Tryanks
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length \u003e 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(ui): stop syntect lazy-regex panics from aborting the app mid-render - #181

Merged
Tryanks merged 2 commits into
mainfrom
fix/syntect-fancy-regex-panics
Jul 28, 2026
Merged

fix(ui): stop syntect lazy-regex panics from aborting the app mid-render#181
Tryanks merged 2 commits into
mainfrom
fix/syntect-fancy-regex-panics

Conversation

@Tryanks

Copy link
Copy Markdown
Owner

Root cause

The app crashed in the field with an instant SIGABRT while switching to a running child thread (crash report tcode-2026-07-28-044740.ips, v0.1.33). Binary forensics on the stripped release binary recovered the chain:

  1. assets/syntaxes.bin comes from bat v0.26.1, whose syntax set is pre-tested against Oniguruma — but this crate compiles syntect 5.3.0 with the fancy-regex backend. 21 patterns (JS Babel \g<-1> subroutine calls, variable-length look-behind, \o{} escapes, ...) cannot compile under fancy-regex.
  2. syntect compiles grammar regexes lazily on first use and panics with regex string should be pre-tested (regex.rs:70) the first time content exercises such a rule. One ordinary jsx arrow function is enough — reproduced: const f = async (a, b) => a + b; panics through tcode's exact highlight path.
  3. The panic fired mid-GPUI-draw; unwinding through the element tree escalated into a double panic ("panic in a destructor during cleanup") → abort() → instant exit with no log. Lazy per-rule compilation plus the highlight cache is why it looked non-deterministic.

Fix (defense in depth)

  • Data: regenerate syntaxes.bin via the new examples/sanitize_syntaxes.rs — patterns the shipped backend cannot compile are replaced with never-matching (?!) (22 replacements; 220 syntaxes and all 22,300 patterns preserved). Capture back-reference patterns are validated the way syntect's own YAML loader does (placeholder substitution before try_compile); all 44 such patterns pass.
  • Runtime: highlight_source wraps syntect in catch_unwind, falls back to unhighlighted text, and poisons the offending syntax for the process (fail-closed on mutex poisoning) so a streaming code block cannot re-panic every frame.
  • Latent sibling bug: the chat list's entry_range slice into the live timeline is now guarded with .get() — the snapshot can trail the timeline by a frame when adopting a running background thread.
  • Regression tests: shipped_syntax_set_compiles_under_active_regex_backend fails CI whenever a future dump contains patterns the active backend rejects; the jsx repro test calls the unguarded parser directly so the fallback cannot mask a dirty dump.

Verification

  • cargo fmt --all --check, cargo clippy --workspace --all-targets --locked -- -D warnings, cargo test --workspace --locked — all green locally (macOS arm64).
  • Repro snippet panics on the old dump, clean on the new one; sanitizer output re-verified by reloading the exact shipped bytes.
  • Independently reviewed; review findings (fail-open poison lock, capture-pattern validation gap, fallback-masked test) addressed in the second commit.

🤖 Generated with Claude Code

Tryanksand others added 2 commits July 28, 2026 11:59
The bundled syntaxes.bin comes from bat, whose syntax set is pre-tested
against Oniguruma, but syntect is compiled here with the fancy-regex
backend. syntect compiles grammar regexes lazily and panics with "regex
string should be pre-tested" the first time content exercises a pattern
the active backend rejects (21 such patterns: subroutine calls,
variable-length look-behind, \o{} escapes, ...). One ordinary jsx arrow
function was enough to panic mid-draw; unwinding through the GPUI
element tree turned it into a double panic and SIGABRT.
- regenerate syntaxes.bin with the new sanitize_syntaxes example, which
replaces patterns the shipped backend cannot compile with a
never-matching placeholder (raw-compiled patterns only; capture
back-reference patterns are substituted before compiling and are left
alone)
- wrap the syntect work in catch_unwind and fall back to unhighlighted
text, poisoning the offending syntax for the rest of the process so a
streaming code block cannot re-panic every frame
- guard the chat list's entry_range slice against a stale turn-items
snapshot racing the live timeline (a second latent mid-render panic,
seen when adopting a running background thread)
- add a regression test that fails CI whenever a future syntaxes.bin
contains patterns the active regex backend cannot compile
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- fail closed when the poisoned-syntax set's mutex is poisoned: recover
the guard with PoisonError::into_inner instead of silently retrying a
panicking parse every frame
- validate capture back-reference patterns the way syntect's YAML loader
does (placeholder substitution before try_compile) in both the
sanitizer and the regression test, instead of skipping them wholesale;
the shipped dump is unchanged — all 44 such patterns compile after
substitution
- call the unguarded parser directly in the jsx regression test so the
catch_unwind fallback cannot mask a dirty dump
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@Tryanks
Tryanks enabled auto-merge July 28, 2026 04:07
@Tryanks
Tryanks merged commit 257cd32 into mainJul 28, 2026
3 checks passed
@Tryanks
Tryanks deleted the fix/syntect-fancy-regex-panics branch July 28, 2026 04:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Tryanks
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

fix(ui): stop syntect lazy-regex panics from aborting the app mid-render - #181

Merged
Tryanks merged 2 commits into
mainfrom
fix/syntect-fancy-regex-panics
Jul 28, 2026
Merged

fix(ui): stop syntect lazy-regex panics from aborting the app mid-render#181
Tryanks merged 2 commits into
mainfrom
fix/syntect-fancy-regex-panics

Conversation

@Tryanks

Copy link
Copy Markdown
Owner

Root cause

The app crashed in the field with an instant SIGABRT while switching to a running child thread (crash report tcode-2026-07-28-044740.ips, v0.1.33). Binary forensics on the stripped release binary recovered the chain:

  1. assets/syntaxes.bin comes from bat v0.26.1, whose syntax set is pre-tested against Oniguruma — but this crate compiles syntect 5.3.0 with the fancy-regex backend. 21 patterns (JS Babel \g<-1> subroutine calls, variable-length look-behind, \o{} escapes, ...) cannot compile under fancy-regex.
  2. syntect compiles grammar regexes lazily on first use and panics with regex string should be pre-tested (regex.rs:70) the first time content exercises such a rule. One ordinary jsx arrow function is enough — reproduced: const f = async (a, b) => a + b; panics through tcode's exact highlight path.
  3. The panic fired mid-GPUI-draw; unwinding through the element tree escalated into a double panic ("panic in a destructor during cleanup") → abort() → instant exit with no log. Lazy per-rule compilation plus the highlight cache is why it looked non-deterministic.

Fix (defense in depth)

  • Data: regenerate syntaxes.bin via the new examples/sanitize_syntaxes.rs — patterns the shipped backend cannot compile are replaced with never-matching (?!) (22 replacements; 220 syntaxes and all 22,300 patterns preserved). Capture back-reference patterns are validated the way syntect's own YAML loader does (placeholder substitution before try_compile); all 44 such patterns pass.
  • Runtime: highlight_source wraps syntect in catch_unwind, falls back to unhighlighted text, and poisons the offending syntax for the process (fail-closed on mutex poisoning) so a streaming code block cannot re-panic every frame.
  • Latent sibling bug: the chat list's entry_range slice into the live timeline is now guarded with .get() — the snapshot can trail the timeline by a frame when adopting a running background thread.
  • Regression tests: shipped_syntax_set_compiles_under_active_regex_backend fails CI whenever a future dump contains patterns the active backend rejects; the jsx repro test calls the unguarded parser directly so the fallback cannot mask a dirty dump.

Verification

  • cargo fmt --all --check, cargo clippy --workspace --all-targets --locked -- -D warnings, cargo test --workspace --locked — all green locally (macOS arm64).
  • Repro snippet panics on the old dump, clean on the new one; sanitizer output re-verified by reloading the exact shipped bytes.
  • Independently reviewed; review findings (fail-open poison lock, capture-pattern validation gap, fallback-masked test) addressed in the second commit.

🤖 Generated with Claude Code

Tryanksand others added 2 commits July 28, 2026 11:59
The bundled syntaxes.bin comes from bat, whose syntax set is pre-tested
against Oniguruma, but syntect is compiled here with the fancy-regex
backend. syntect compiles grammar regexes lazily and panics with "regex
string should be pre-tested" the first time content exercises a pattern
the active backend rejects (21 such patterns: subroutine calls,
variable-length look-behind, \o{} escapes, ...). One ordinary jsx arrow
function was enough to panic mid-draw; unwinding through the GPUI
element tree turned it into a double panic and SIGABRT.
- regenerate syntaxes.bin with the new sanitize_syntaxes example, which
replaces patterns the shipped backend cannot compile with a
never-matching placeholder (raw-compiled patterns only; capture
back-reference patterns are substituted before compiling and are left
alone)
- wrap the syntect work in catch_unwind and fall back to unhighlighted
text, poisoning the offending syntax for the rest of the process so a
streaming code block cannot re-panic every frame
- guard the chat list's entry_range slice against a stale turn-items
snapshot racing the live timeline (a second latent mid-render panic,
seen when adopting a running background thread)
- add a regression test that fails CI whenever a future syntaxes.bin
contains patterns the active regex backend cannot compile
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- fail closed when the poisoned-syntax set's mutex is poisoned: recover
the guard with PoisonError::into_inner instead of silently retrying a
panicking parse every frame
- validate capture back-reference patterns the way syntect's YAML loader
does (placeholder substitution before try_compile) in both the
sanitizer and the regression test, instead of skipping them wholesale;
the shipped dump is unchanged — all 44 such patterns compile after
substitution
- call the unguarded parser directly in the jsx regression test so the
catch_unwind fallback cannot mask a dirty dump
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@Tryanks
Tryanks enabled auto-merge July 28, 2026 04:07
@Tryanks
Tryanks merged commit 257cd32 into mainJul 28, 2026
3 checks passed
@Tryanks
Tryanks deleted the fix/syntect-fancy-regex-panics branch July 28, 2026 04:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Tryanks
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(ui): stop syntect lazy-regex panics from aborting the app mid-render - #181

Merged
Tryanks merged 2 commits into
mainfrom
fix/syntect-fancy-regex-panics
Jul 28, 2026
Merged

fix(ui): stop syntect lazy-regex panics from aborting the app mid-render#181
Tryanks merged 2 commits into
mainfrom
fix/syntect-fancy-regex-panics

Conversation

@Tryanks

Copy link
Copy Markdown
Owner

Root cause

The app crashed in the field with an instant SIGABRT while switching to a running child thread (crash report tcode-2026-07-28-044740.ips, v0.1.33). Binary forensics on the stripped release binary recovered the chain:

  1. assets/syntaxes.bin comes from bat v0.26.1, whose syntax set is pre-tested against Oniguruma — but this crate compiles syntect 5.3.0 with the fancy-regex backend. 21 patterns (JS Babel \g<-1> subroutine calls, variable-length look-behind, \o{} escapes, ...) cannot compile under fancy-regex.
  2. syntect compiles grammar regexes lazily on first use and panics with regex string should be pre-tested (regex.rs:70) the first time content exercises such a rule. One ordinary jsx arrow function is enough — reproduced: const f = async (a, b) => a + b; panics through tcode's exact highlight path.
  3. The panic fired mid-GPUI-draw; unwinding through the element tree escalated into a double panic ("panic in a destructor during cleanup") → abort() → instant exit with no log. Lazy per-rule compilation plus the highlight cache is why it looked non-deterministic.

Fix (defense in depth)

  • Data: regenerate syntaxes.bin via the new examples/sanitize_syntaxes.rs — patterns the shipped backend cannot compile are replaced with never-matching (?!) (22 replacements; 220 syntaxes and all 22,300 patterns preserved). Capture back-reference patterns are validated the way syntect's own YAML loader does (placeholder substitution before try_compile); all 44 such patterns pass.
  • Runtime: highlight_source wraps syntect in catch_unwind, falls back to unhighlighted text, and poisons the offending syntax for the process (fail-closed on mutex poisoning) so a streaming code block cannot re-panic every frame.
  • Latent sibling bug: the chat list's entry_range slice into the live timeline is now guarded with .get() — the snapshot can trail the timeline by a frame when adopting a running background thread.
  • Regression tests: shipped_syntax_set_compiles_under_active_regex_backend fails CI whenever a future dump contains patterns the active backend rejects; the jsx repro test calls the unguarded parser directly so the fallback cannot mask a dirty dump.

Verification

  • cargo fmt --all --check, cargo clippy --workspace --all-targets --locked -- -D warnings, cargo test --workspace --locked — all green locally (macOS arm64).
  • Repro snippet panics on the old dump, clean on the new one; sanitizer output re-verified by reloading the exact shipped bytes.
  • Independently reviewed; review findings (fail-open poison lock, capture-pattern validation gap, fallback-masked test) addressed in the second commit.

🤖 Generated with Claude Code

Tryanksand others added 2 commits July 28, 2026 11:59
The bundled syntaxes.bin comes from bat, whose syntax set is pre-tested
against Oniguruma, but syntect is compiled here with the fancy-regex
backend. syntect compiles grammar regexes lazily and panics with "regex
string should be pre-tested" the first time content exercises a pattern
the active backend rejects (21 such patterns: subroutine calls,
variable-length look-behind, \o{} escapes, ...). One ordinary jsx arrow
function was enough to panic mid-draw; unwinding through the GPUI
element tree turned it into a double panic and SIGABRT.
- regenerate syntaxes.bin with the new sanitize_syntaxes example, which
replaces patterns the shipped backend cannot compile with a
never-matching placeholder (raw-compiled patterns only; capture
back-reference patterns are substituted before compiling and are left
alone)
- wrap the syntect work in catch_unwind and fall back to unhighlighted
text, poisoning the offending syntax for the rest of the process so a
streaming code block cannot re-panic every frame
- guard the chat list's entry_range slice against a stale turn-items
snapshot racing the live timeline (a second latent mid-render panic,
seen when adopting a running background thread)
- add a regression test that fails CI whenever a future syntaxes.bin
contains patterns the active regex backend cannot compile
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- fail closed when the poisoned-syntax set's mutex is poisoned: recover
the guard with PoisonError::into_inner instead of silently retrying a
panicking parse every frame
- validate capture back-reference patterns the way syntect's YAML loader
does (placeholder substitution before try_compile) in both the
sanitizer and the regression test, instead of skipping them wholesale;
the shipped dump is unchanged — all 44 such patterns compile after
substitution
- call the unguarded parser directly in the jsx regression test so the
catch_unwind fallback cannot mask a dirty dump
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@Tryanks
Tryanks enabled auto-merge July 28, 2026 04:07
@Tryanks
Tryanks merged commit 257cd32 into mainJul 28, 2026
3 checks passed
@Tryanks
Tryanks deleted the fix/syntect-fancy-regex-panics branch July 28, 2026 04:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Tryanks
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(ui): stop syntect lazy-regex panics from aborting the app mid-render - #181

Merged
Tryanks merged 2 commits into
mainfrom
fix/syntect-fancy-regex-panics
Jul 28, 2026
Merged

fix(ui): stop syntect lazy-regex panics from aborting the app mid-render#181
Tryanks merged 2 commits into
mainfrom
fix/syntect-fancy-regex-panics

Conversation

@Tryanks

Copy link
Copy Markdown
Owner

Root cause

The app crashed in the field with an instant SIGABRT while switching to a running child thread (crash report tcode-2026-07-28-044740.ips, v0.1.33). Binary forensics on the stripped release binary recovered the chain:

  1. assets/syntaxes.bin comes from bat v0.26.1, whose syntax set is pre-tested against Oniguruma — but this crate compiles syntect 5.3.0 with the fancy-regex backend. 21 patterns (JS Babel \g<-1> subroutine calls, variable-length look-behind, \o{} escapes, ...) cannot compile under fancy-regex.
  2. syntect compiles grammar regexes lazily on first use and panics with regex string should be pre-tested (regex.rs:70) the first time content exercises such a rule. One ordinary jsx arrow function is enough — reproduced: const f = async (a, b) => a + b; panics through tcode's exact highlight path.
  3. The panic fired mid-GPUI-draw; unwinding through the element tree escalated into a double panic ("panic in a destructor during cleanup") → abort() → instant exit with no log. Lazy per-rule compilation plus the highlight cache is why it looked non-deterministic.

Fix (defense in depth)

  • Data: regenerate syntaxes.bin via the new examples/sanitize_syntaxes.rs — patterns the shipped backend cannot compile are replaced with never-matching (?!) (22 replacements; 220 syntaxes and all 22,300 patterns preserved). Capture back-reference patterns are validated the way syntect's own YAML loader does (placeholder substitution before try_compile); all 44 such patterns pass.
  • Runtime: highlight_source wraps syntect in catch_unwind, falls back to unhighlighted text, and poisons the offending syntax for the process (fail-closed on mutex poisoning) so a streaming code block cannot re-panic every frame.
  • Latent sibling bug: the chat list's entry_range slice into the live timeline is now guarded with .get() — the snapshot can trail the timeline by a frame when adopting a running background thread.
  • Regression tests: shipped_syntax_set_compiles_under_active_regex_backend fails CI whenever a future dump contains patterns the active backend rejects; the jsx repro test calls the unguarded parser directly so the fallback cannot mask a dirty dump.

Verification

  • cargo fmt --all --check, cargo clippy --workspace --all-targets --locked -- -D warnings, cargo test --workspace --locked — all green locally (macOS arm64).
  • Repro snippet panics on the old dump, clean on the new one; sanitizer output re-verified by reloading the exact shipped bytes.
  • Independently reviewed; review findings (fail-open poison lock, capture-pattern validation gap, fallback-masked test) addressed in the second commit.

🤖 Generated with Claude Code

Tryanksand others added 2 commits July 28, 2026 11:59
The bundled syntaxes.bin comes from bat, whose syntax set is pre-tested
against Oniguruma, but syntect is compiled here with the fancy-regex
backend. syntect compiles grammar regexes lazily and panics with "regex
string should be pre-tested" the first time content exercises a pattern
the active backend rejects (21 such patterns: subroutine calls,
variable-length look-behind, \o{} escapes, ...). One ordinary jsx arrow
function was enough to panic mid-draw; unwinding through the GPUI
element tree turned it into a double panic and SIGABRT.
- regenerate syntaxes.bin with the new sanitize_syntaxes example, which
replaces patterns the shipped backend cannot compile with a
never-matching placeholder (raw-compiled patterns only; capture
back-reference patterns are substituted before compiling and are left
alone)
- wrap the syntect work in catch_unwind and fall back to unhighlighted
text, poisoning the offending syntax for the rest of the process so a
streaming code block cannot re-panic every frame
- guard the chat list's entry_range slice against a stale turn-items
snapshot racing the live timeline (a second latent mid-render panic,
seen when adopting a running background thread)
- add a regression test that fails CI whenever a future syntaxes.bin
contains patterns the active regex backend cannot compile
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- fail closed when the poisoned-syntax set's mutex is poisoned: recover
the guard with PoisonError::into_inner instead of silently retrying a
panicking parse every frame
- validate capture back-reference patterns the way syntect's YAML loader
does (placeholder substitution before try_compile) in both the
sanitizer and the regression test, instead of skipping them wholesale;
the shipped dump is unchanged — all 44 such patterns compile after
substitution
- call the unguarded parser directly in the jsx regression test so the
catch_unwind fallback cannot mask a dirty dump
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@Tryanks
Tryanks enabled auto-merge July 28, 2026 04:07
@Tryanks
Tryanks merged commit 257cd32 into mainJul 28, 2026
3 checks passed
@Tryanks
Tryanks deleted the fix/syntect-fancy-regex-panics branch July 28, 2026 04:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Tryanks
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

fix(ui): stop syntect lazy-regex panics from aborting the app mid-render - #181

Merged
Tryanks merged 2 commits into
mainfrom
fix/syntect-fancy-regex-panics
Jul 28, 2026
Merged

fix(ui): stop syntect lazy-regex panics from aborting the app mid-render#181
Tryanks merged 2 commits into
mainfrom
fix/syntect-fancy-regex-panics

Conversation

@Tryanks

Copy link
Copy Markdown
Owner

Root cause

The app crashed in the field with an instant SIGABRT while switching to a running child thread (crash report tcode-2026-07-28-044740.ips, v0.1.33). Binary forensics on the stripped release binary recovered the chain:

  1. assets/syntaxes.bin comes from bat v0.26.1, whose syntax set is pre-tested against Oniguruma — but this crate compiles syntect 5.3.0 with the fancy-regex backend. 21 patterns (JS Babel \g<-1> subroutine calls, variable-length look-behind, \o{} escapes, ...) cannot compile under fancy-regex.
  2. syntect compiles grammar regexes lazily on first use and panics with regex string should be pre-tested (regex.rs:70) the first time content exercises such a rule. One ordinary jsx arrow function is enough — reproduced: const f = async (a, b) => a + b; panics through tcode's exact highlight path.
  3. The panic fired mid-GPUI-draw; unwinding through the element tree escalated into a double panic ("panic in a destructor during cleanup") → abort() → instant exit with no log. Lazy per-rule compilation plus the highlight cache is why it looked non-deterministic.

Fix (defense in depth)

  • Data: regenerate syntaxes.bin via the new examples/sanitize_syntaxes.rs — patterns the shipped backend cannot compile are replaced with never-matching (?!) (22 replacements; 220 syntaxes and all 22,300 patterns preserved). Capture back-reference patterns are validated the way syntect's own YAML loader does (placeholder substitution before try_compile); all 44 such patterns pass.
  • Runtime: highlight_source wraps syntect in catch_unwind, falls back to unhighlighted text, and poisons the offending syntax for the process (fail-closed on mutex poisoning) so a streaming code block cannot re-panic every frame.
  • Latent sibling bug: the chat list's entry_range slice into the live timeline is now guarded with .get() — the snapshot can trail the timeline by a frame when adopting a running background thread.
  • Regression tests: shipped_syntax_set_compiles_under_active_regex_backend fails CI whenever a future dump contains patterns the active backend rejects; the jsx repro test calls the unguarded parser directly so the fallback cannot mask a dirty dump.

Verification

  • cargo fmt --all --check, cargo clippy --workspace --all-targets --locked -- -D warnings, cargo test --workspace --locked — all green locally (macOS arm64).
  • Repro snippet panics on the old dump, clean on the new one; sanitizer output re-verified by reloading the exact shipped bytes.
  • Independently reviewed; review findings (fail-open poison lock, capture-pattern validation gap, fallback-masked test) addressed in the second commit.

🤖 Generated with Claude Code

Tryanksand others added 2 commits July 28, 2026 11:59
The bundled syntaxes.bin comes from bat, whose syntax set is pre-tested
against Oniguruma, but syntect is compiled here with the fancy-regex
backend. syntect compiles grammar regexes lazily and panics with "regex
string should be pre-tested" the first time content exercises a pattern
the active backend rejects (21 such patterns: subroutine calls,
variable-length look-behind, \o{} escapes, ...). One ordinary jsx arrow
function was enough to panic mid-draw; unwinding through the GPUI
element tree turned it into a double panic and SIGABRT.
- regenerate syntaxes.bin with the new sanitize_syntaxes example, which
replaces patterns the shipped backend cannot compile with a
never-matching placeholder (raw-compiled patterns only; capture
back-reference patterns are substituted before compiling and are left
alone)
- wrap the syntect work in catch_unwind and fall back to unhighlighted
text, poisoning the offending syntax for the rest of the process so a
streaming code block cannot re-panic every frame
- guard the chat list's entry_range slice against a stale turn-items
snapshot racing the live timeline (a second latent mid-render panic,
seen when adopting a running background thread)
- add a regression test that fails CI whenever a future syntaxes.bin
contains patterns the active regex backend cannot compile
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- fail closed when the poisoned-syntax set's mutex is poisoned: recover
the guard with PoisonError::into_inner instead of silently retrying a
panicking parse every frame
- validate capture back-reference patterns the way syntect's YAML loader
does (placeholder substitution before try_compile) in both the
sanitizer and the regression test, instead of skipping them wholesale;
the shipped dump is unchanged — all 44 such patterns compile after
substitution
- call the unguarded parser directly in the jsx regression test so the
catch_unwind fallback cannot mask a dirty dump
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@Tryanks
Tryanks enabled auto-merge July 28, 2026 04:07
@Tryanks
Tryanks merged commit 257cd32 into mainJul 28, 2026
3 checks passed
@Tryanks
Tryanks deleted the fix/syntect-fancy-regex-panics branch July 28, 2026 04:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Tryanks