feat(preview): --preview-smoke lifecycle harness#244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tryanks merged 3 commits into from
Aug 22, 2026
Merged

feat(preview): --preview-smoke lifecycle harness #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
15cd94b
feat(preview): --preview-smoke lifecycle harness; prune webviews of d…
Tryanks Aug 22, 2026
39fd872
feat(preview): tee preview-smoke phase log to TCODE_SMOKE_LOG file
Tryanks Aug 22, 2026
bbc4bb5
fix(ui): allow preview_live_keys dead_code on Linux (preview compiled…
Tryanks Aug 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions crates/app/src/main.rs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,9 @@ use tcode_ui::{assets, settings};
use tcode_ui::overlay::{DialogActions, OverlayExt as _, OverlayHost};
use tcode_ui::widgets::button::{Button, ButtonVariants as _};

#[cfg(not(target_os = "linux"))]
mod preview_smoke;

const TCODE_THEME: &str = include_str!("../../../themes/tcode.json");

/// macOS vibrancy can be disabled with `TCODE_NO_VIBRANCY=1` as a diagnostic
Expand DownExpand Up@@ -169,6 +172,17 @@ fn handle_quit(
fn main() {
env_logger::init();

let preview_smoke = std::env::args().any(|arg| arg == "--preview-smoke");
#[cfg(target_os = "linux")]
if preview_smoke {
use std::io::Write as _;
eprintln!("preview-smoke: SKIP (no native webview)");
let _ = std::io::stderr().flush();
return;
}
#[cfg(not(target_os = "linux"))]
let preview_smoke_watchdog = preview_smoke.then(preview_smoke::Watchdog::start);

// A Finder/Dock launch inherits launchd's minimal PATH, under which none of
// the provider CLIs resolve — import the login shell's environment first,
// before anything (probes, sessions, the terminal) reads PATH. Must stay
Expand DownExpand Up@@ -330,6 +344,8 @@ fn main() {
};

cx.spawn(async move |cx| {
let smoke_shell = std::rc::Rc::new(std::cell::RefCell::new(None));
let smoke_shell_for_window = smoke_shell.clone();
let window = cx
.open_window(window_options, {
let theme_store = workspace_store.clone();
Expand All@@ -349,6 +365,7 @@ fn main() {
}
let shell = cx
.new(|cx| AppShell::new(workspace_store, window_state, window, cx));
*smoke_shell_for_window.borrow_mut() = Some(shell.clone());
cx.new(|cx| OverlayHost::new(shell, window, cx))
}
})
Expand All@@ -359,6 +376,16 @@ fn main() {
window.activate_window();
});

#[cfg(not(target_os = "linux"))]
if let Some(watchdog) = preview_smoke_watchdog {
let shell = smoke_shell
.borrow_mut()
.take()
.expect("preview smoke shell was not captured");
preview_smoke::run(watchdog, shell, window, cx).await;
return;
}

if open_latest {
let _ = host.dispatch(Command::OpenLatestSession);
for _ in 0..100 {
Expand Down
194 changes: 194 additions & 0 deletions crates/app/src/preview_smoke.rs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,194 @@
use std::io::Write as _;
use std::sync::{
Arc, Mutex,
atomic::{AtomicBool, Ordering},
};
use std::time::Duration;

use gpui::{AsyncApp, Entity, WindowHandle, px, size};
use tcode_ui::{AppShell, overlay::OverlayHost};

const STEP_DELAY: Duration = Duration::from_millis(20);
const RAPID_DELAY: Duration = Duration::from_millis(5);
const WATCHDOG_TIMEOUT: Duration = Duration::from_secs(120);
const KEYS: [&str; 6] = [
"preview-smoke-0",
"preview-smoke-1",
"preview-smoke-2",
"preview-smoke-3",
"preview-smoke-4",
"preview-smoke-5",
];

fn log_line(message: &str) {
eprintln!("{message}");
let _ = std::io::stderr().flush();
// Windows-subsystem builds have no console under a scheduled task, so the
// on-device runner reads phases from this file instead of stderr.
if let Ok(path) = std::env::var("TCODE_SMOKE_LOG")
&& let Ok(mut file) = std::fs::OpenOptions::new()
.create(true)
.append(true)
.open(path)
{
let _ = writeln!(file, "{message}");
let _ = file.sync_all();
}
}

pub struct Watchdog {
phase: Arc<Mutex<&'static str>>,
finished: Arc<AtomicBool>,
}

impl Watchdog {
pub fn start() -> Self {
let phase = Arc::new(Mutex::new("startup"));
let finished = Arc::new(AtomicBool::new(false));
let watchdog_phase = phase.clone();
let watchdog_finished = finished.clone();
std::thread::spawn(move || {
std::thread::sleep(WATCHDOG_TIMEOUT);
if !watchdog_finished.load(Ordering::SeqCst) {
let phase = *watchdog_phase
.lock()
.unwrap_or_else(|error| error.into_inner());
log_line(&format!("preview-smoke: TIMEOUT phase {phase}"));
std::process::exit(124);
}
});
Self { phase, finished }
}

fn start_phase(&self, phase: &'static str) {
*self.phase.lock().unwrap_or_else(|error| error.into_inner()) = phase;
log_line(&format!("preview-smoke: phase {phase} start"));
}

fn finish_phase(&self, phase: &'static str) {
log_line(&format!("preview-smoke: phase {phase} ok"));
}

fn pass(&self) {
log_line("preview-smoke: PASS");
self.finished.store(true, Ordering::SeqCst);
}
}

async fn yield_for(cx: &AsyncApp, delay: Duration) {
cx.background_executor().timer(delay).await;
}

pub async fn run(
watchdog: Watchdog,
shell: Entity<AppShell>,
window: WindowHandle<OverlayHost>,
cx: &mut AsyncApp,
) {
watchdog.start_phase("create-first");
window
.update(cx, |_, window, cx| {
shell.update(cx, |shell, cx| {
shell.preview_smoke_create(KEYS[0], "about:blank", window, cx)
})
})
.expect("preview smoke window closed during create-first")
.expect("native preview webview creation failed");
yield_for(cx, STEP_DELAY).await;
watchdog.finish_phase("create-first");

watchdog.start_phase("show-hide-churn");
for _ in 0..20 {
shell.update(cx, |shell, cx| shell.preview_smoke_set_visible(None, cx));
yield_for(cx, RAPID_DELAY).await;
shell.update(cx, |shell, cx| {
shell.preview_smoke_set_visible(Some(KEYS[0]), cx)
});
yield_for(cx, RAPID_DELAY).await;
}
watchdog.finish_phase("show-hide-churn");

watchdog.start_phase("multi-create");
for key in &KEYS[1..] {
window
.update(cx, |_, window, cx| {
shell.update(cx, |shell, cx| {
shell.preview_smoke_create(key, "about:blank", window, cx)
})
})
.expect("preview smoke window closed during multi-create")
.expect("native preview webview creation failed");
yield_for(cx, STEP_DELAY).await;
}
watchdog.finish_phase("multi-create");

watchdog.start_phase("rapid-switch");
for ix in 0..30 {
shell.update(cx, |shell, cx| {
shell.preview_smoke_set_visible(Some(KEYS[ix % KEYS.len()]), cx)
});
yield_for(cx, RAPID_DELAY).await;
}
watchdog.finish_phase("rapid-switch");

watchdog.start_phase("resize-churn");
for (width, height) in [(1100., 720.), (940., 640.), (1280., 820.), (1000., 700.)] {
window
.update(cx, |_, window, _| {
window.resize(size(px(width), px(height)))
})
.expect("preview smoke window closed during resize-churn");
yield_for(cx, STEP_DELAY).await;
}
watchdog.finish_phase("resize-churn");

watchdog.start_phase("navigate-all");
for (ix, key) in KEYS.iter().enumerate() {
let url = format!("about:blank#preview-smoke-{ix}");
window
.update(cx, |_, window, cx| {
shell.update(cx, |shell, cx| {
shell.preview_smoke_create(key, &url, window, cx)
})
})
.expect("preview smoke window closed during navigate-all")
.expect("native preview navigation failed");
yield_for(cx, STEP_DELAY).await;
}
watchdog.finish_phase("navigate-all");

watchdog.start_phase("drop-one");
shell.update(cx, |shell, cx| {
shell.preview_smoke_set_visible(Some(KEYS[1]), cx);
shell.preview_smoke_drop(KEYS[0], cx);
});
yield_for(cx, STEP_DELAY).await;
watchdog.finish_phase("drop-one");

watchdog.start_phase("drop-during-create");
let close_window = window;
window
.update(cx, |_, window, cx| {
shell.update(cx, |shell, cx| {
cx.defer(move |cx| {
let _ = close_window.update(cx, |_, window, _| window.remove_window());
});
shell.preview_smoke_create(
"preview-smoke-drop-during-create",
"about:blank#drop-during-create",
window,
cx,
)
})
})
.expect("preview smoke window closed before drop-during-create")
.expect("native preview webview creation failed");
drop(shell);
yield_for(cx, STEP_DELAY).await;
watchdog.finish_phase("drop-during-create");

watchdog.start_phase("quit");
watchdog.finish_phase("quit");
watchdog.pass();
cx.update(|cx| cx.quit());
}
73 changes: 70 additions & 3 deletions crates/ui/src/preview_panel.rs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -130,6 +130,10 @@ mod native {
/// WebView2 runtime). Set once; the tab then explains itself instead of
/// retrying on every frame.
webview_error: Option<String>,
/// Harness-only routing override. Normal runs leave this unset and use
/// the active conversation identity from `WorkspaceStore`.
smoke_active_key: Option<String>,
smoke_visible: bool,
_subscriptions: Vec<Subscription>,
}

Expand All@@ -148,6 +152,7 @@ mod native {
// Native child views outlive GPUI layout nodes. Visibility
// therefore follows WorkspaceStore directly, even while this
// entity is no longer mounted in the right-panel tree.
this.prune_deleted_webviews(cx);
this.sync_visibility(cx);
cx.notify();
}),
Expand All@@ -164,6 +169,8 @@ mod native {
dev_ports: Vec::new(),
port_scan_generation: 0,
webview_error: None,
smoke_active_key: None,
smoke_visible: false,
_subscriptions: subscriptions,
}
}
Expand All@@ -172,6 +179,9 @@ mod native {
/// Draft -> stored-thread commits retain the same session id, so move
/// all cached browser state across that one key transition.
fn active_key(&mut self, cx: &Context<Self>) -> Option<String> {
if let Some(key) = &self.smoke_active_key {
return Some(key.clone());
}
let current = self.store.read(cx).preview_active_identity();

if let (Some((old_session, old_key)), Some((session, key))) =
Expand DownExpand Up@@ -224,7 +234,9 @@ mod native {

fn update_visibility(&mut self, allow_show: bool, cx: &mut Context<Self>) {
let active = self.active_key(cx);
let visible = {
let visible = if self.smoke_active_key.is_some() {
self.smoke_visible.then_some(active).flatten()
} else {
let window_state = self.window_state.read(cx);
visible_preview_key(
active.as_deref(),
Expand DownExpand Up@@ -296,6 +308,62 @@ mod native {
Some(webview)
}

pub(crate) fn smoke_create(
&mut self,
key: &str,
url: &str,
window: &mut Window,
cx: &mut Context<Self>,
) -> Result<(), String> {
self.smoke_active_key = Some(key.to_string());
self.smoke_visible = true;
self.navigate(key, url, window, cx);
match &self.webview_error {
Some(error) => Err(error.clone()),
None => Ok(()),
}
}

pub(crate) fn smoke_set_visible(&mut self, key: Option<&str>, cx: &mut Context<Self>) {
if let Some(key) = key {
self.smoke_active_key = Some(key.to_string());
self.smoke_visible = true;
} else {
self.smoke_visible = false;
}
self.update_visibility(true, cx);
cx.notify();
}

pub(crate) fn smoke_drop(&mut self, key: &str, cx: &mut Context<Self>) {
self.drop_webview(key);
cx.notify();
}

fn drop_webview(&mut self, key: &str) {
self.webviews.remove(key);
self.warm.remove(key);
if self.mirrored.as_deref() == Some(key) {
self.mirrored = None;
}
}

fn prune_deleted_webviews(&mut self, cx: &Context<Self>) {
if self.smoke_active_key.is_some() {
return;
}
let live = self.store.read(cx).preview_live_keys();
let deleted = self
.webviews
.keys()
.filter(|key| !live.contains(*key))
.cloned()
.collect::<Vec<_>>();
for key in deleted {
self.drop_webview(&key);
}
}

/// Navigate one conversation's WebView to `url`, remembering it.
fn navigate(&mut self, key: &str, url: &str, window: &mut Window, cx: &mut Context<Self>) {
let url = normalize_url(url);
Expand DownExpand Up@@ -377,8 +445,7 @@ mod native {
/// recreates a fresh webview on demand.
fn close_panel(&mut self, cx: &mut Context<Self>) {
if let Some(key) = self.active_key(cx) {
self.webviews.remove(&key);
self.warm.remove(&key);
self.drop_webview(&key);
self.store
.update(cx, |store, cx| store.clear_preview_chrome(&key, cx));
}
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
feat(preview): --preview-smoke lifecycle harness#244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Tryanks
merged 3 commits into

from

Aug 22, 2026
 Merged


feat(preview): --preview-smoke lifecycle harness
#244
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
15cd94b

feat(preview): --preview-smoke lifecycle harness; prune webviews of d…


Tryanks Aug 22, 2026
39fd872

feat(preview): tee preview-smoke phase log to TCODE_SMOKE_LOG file


Tryanks Aug 22, 2026
bbc4bb5

fix(ui): allow preview_live_keys dead_code on Linux (preview compiled…


Tryanks Aug 22, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


27 changes: 27 additions & 0 deletions
crates/app/src/main.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,9 @@ use tcode_ui::{assets, settings};
use tcode_ui::overlay::{DialogActions, OverlayExt as _, OverlayHost};
use tcode_ui::widgets::button::{Button, ButtonVariants as _};

#[cfg(not(target_os = "linux"))]
mod preview_smoke;

const TCODE_THEME: &str = include_str!("../../../themes/tcode.json");

/// macOS vibrancy can be disabled with `TCODE_NO_VIBRANCY=1` as a diagnostic
Expand DownExpand Up@@ -169,6 +172,17 @@ fn handle_quit(
fn main() {
 env_logger::init();

 let preview_smoke = std::env::args().any(|arg| arg == "--preview-smoke");
 #[cfg(target_os = "linux")]
 if preview_smoke {
 use std::io::Write as _;
 eprintln!("preview-smoke: SKIP (no native webview)");
 let _ = std::io::stderr().flush();
 return;
 }
 #[cfg(not(target_os = "linux"))]
 let preview_smoke_watchdog = preview_smoke.then(preview_smoke::Watchdog::start);

 // A Finder/Dock launch inherits launchd's minimal PATH, under which none of
 // the provider CLIs resolve — import the login shell's environment first,
 // before anything (probes, sessions, the terminal) reads PATH. Must stay
Expand DownExpand Up@@ -330,6 +344,8 @@ fn main() {
 };

 cx.spawn(async move |cx| {
 let smoke_shell = std::rc::Rc::new(std::cell::RefCell::new(None));
 let smoke_shell_for_window = smoke_shell.clone();
 let window = cx
 .open_window(window_options, {
 let theme_store = workspace_store.clone();
Expand All@@ -349,6 +365,7 @@ fn main() {
 }
 let shell = cx
 .new(|cx| AppShell::new(workspace_store, window_state, window, cx));
 *smoke_shell_for_window.borrow_mut() = Some(shell.clone());
 cx.new(|cx| OverlayHost::new(shell, window, cx))
 }
 })
Expand All@@ -359,6 +376,16 @@ fn main() {
 window.activate_window();
 });

 #[cfg(not(target_os = "linux"))]
 if let Some(watchdog) = preview_smoke_watchdog {
 let shell = smoke_shell
 .borrow_mut()
 .take()
 .expect("preview smoke shell was not captured");
 preview_smoke::run(watchdog, shell, window, cx).await;
 return;
 }

 if open_latest {
 let _ = host.dispatch(Command::OpenLatestSession);
 for _ in 0..100 {
Expand Down

194 changes: 194 additions & 0 deletions
crates/app/src/preview_smoke.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,194 @@
use std::io::Write as _;
use std::sync::{
 Arc, Mutex,
 atomic::{AtomicBool, Ordering},
};
use std::time::Duration;

use gpui::{AsyncApp, Entity, WindowHandle, px, size};
use tcode_ui::{AppShell, overlay::OverlayHost};

const STEP_DELAY: Duration = Duration::from_millis(20);
const RAPID_DELAY: Duration = Duration::from_millis(5);
const WATCHDOG_TIMEOUT: Duration = Duration::from_secs(120);
const KEYS: [&str; 6] = [
 "preview-smoke-0",
 "preview-smoke-1",
 "preview-smoke-2",
 "preview-smoke-3",
 "preview-smoke-4",
 "preview-smoke-5",
];

fn log_line(message: &str) {
 eprintln!("{message}");
 let _ = std::io::stderr().flush();
 // Windows-subsystem builds have no console under a scheduled task, so the
 // on-device runner reads phases from this file instead of stderr.
 if let Ok(path) = std::env::var("TCODE_SMOKE_LOG")
 && let Ok(mut file) = std::fs::OpenOptions::new()
 .create(true)
 .append(true)
 .open(path)
 {
 let _ = writeln!(file, "{message}");
 let _ = file.sync_all();
 }
}

pub struct Watchdog {
 phase: Arc<Mutex<&'static str>>,
 finished: Arc<AtomicBool>,
}

impl Watchdog {
 pub fn start() -> Self {
 let phase = Arc::new(Mutex::new("startup"));
 let finished = Arc::new(AtomicBool::new(false));
 let watchdog_phase = phase.clone();
 let watchdog_finished = finished.clone();
 std::thread::spawn(move || {
 std::thread::sleep(WATCHDOG_TIMEOUT);
 if !watchdog_finished.load(Ordering::SeqCst) {
 let phase = *watchdog_phase
 .lock()
 .unwrap_or_else(|error| error.into_inner());
 log_line(&format!("preview-smoke: TIMEOUT phase {phase}"));
 std::process::exit(124);
 }
 });
 Self { phase, finished }
 }

 fn start_phase(&self, phase: &'static str) {
 *self.phase.lock().unwrap_or_else(|error| error.into_inner()) = phase;
 log_line(&format!("preview-smoke: phase {phase} start"));
 }

 fn finish_phase(&self, phase: &'static str) {
 log_line(&format!("preview-smoke: phase {phase} ok"));
 }

 fn pass(&self) {
 log_line("preview-smoke: PASS");
 self.finished.store(true, Ordering::SeqCst);
 }
}

async fn yield_for(cx: &AsyncApp, delay: Duration) {
 cx.background_executor().timer(delay).await;
}

pub async fn run(
 watchdog: Watchdog,
 shell: Entity<AppShell>,
 window: WindowHandle<OverlayHost>,
 cx: &mut AsyncApp,
) {
 watchdog.start_phase("create-first");
 window
 .update(cx, |_, window, cx| {
 shell.update(cx, |shell, cx| {
 shell.preview_smoke_create(KEYS[0], "about:blank", window, cx)
 })
 })
 .expect("preview smoke window closed during create-first")
 .expect("native preview webview creation failed");
 yield_for(cx, STEP_DELAY).await;
 watchdog.finish_phase("create-first");

 watchdog.start_phase("show-hide-churn");
 for _ in 0..20 {
 shell.update(cx, |shell, cx| shell.preview_smoke_set_visible(None, cx));
 yield_for(cx, RAPID_DELAY).await;
 shell.update(cx, |shell, cx| {
 shell.preview_smoke_set_visible(Some(KEYS[0]), cx)
 });
 yield_for(cx, RAPID_DELAY).await;
 }
 watchdog.finish_phase("show-hide-churn");

 watchdog.start_phase("multi-create");
 for key in &KEYS[1..] {
 window
 .update(cx, |_, window, cx| {
 shell.update(cx, |shell, cx| {
 shell.preview_smoke_create(key, "about:blank", window, cx)
 })
 })
 .expect("preview smoke window closed during multi-create")
 .expect("native preview webview creation failed");
 yield_for(cx, STEP_DELAY).await;
 }
 watchdog.finish_phase("multi-create");

 watchdog.start_phase("rapid-switch");
 for ix in 0..30 {
 shell.update(cx, |shell, cx| {
 shell.preview_smoke_set_visible(Some(KEYS[ix % KEYS.len()]), cx)
 });
 yield_for(cx, RAPID_DELAY).await;
 }
 watchdog.finish_phase("rapid-switch");

 watchdog.start_phase("resize-churn");
 for (width, height) in [(1100., 720.), (940., 640.), (1280., 820.), (1000., 700.)] {
 window
 .update(cx, |_, window, _| {
 window.resize(size(px(width), px(height)))
 })
 .expect("preview smoke window closed during resize-churn");
 yield_for(cx, STEP_DELAY).await;
 }
 watchdog.finish_phase("resize-churn");

 watchdog.start_phase("navigate-all");
 for (ix, key) in KEYS.iter().enumerate() {
 let url = format!("about:blank#preview-smoke-{ix}");
 window
 .update(cx, |_, window, cx| {
 shell.update(cx, |shell, cx| {
 shell.preview_smoke_create(key, &url, window, cx)
 })
 })
 .expect("preview smoke window closed during navigate-all")
 .expect("native preview navigation failed");
 yield_for(cx, STEP_DELAY).await;
 }
 watchdog.finish_phase("navigate-all");

 watchdog.start_phase("drop-one");
 shell.update(cx, |shell, cx| {
 shell.preview_smoke_set_visible(Some(KEYS[1]), cx);
 shell.preview_smoke_drop(KEYS[0], cx);
 });
 yield_for(cx, STEP_DELAY).await;
 watchdog.finish_phase("drop-one");

 watchdog.start_phase("drop-during-create");
 let close_window = window;
 window
 .update(cx, |_, window, cx| {
 shell.update(cx, |shell, cx| {
 cx.defer(move |cx| {
 let _ = close_window.update(cx, |_, window, _| window.remove_window());
 });
 shell.preview_smoke_create(
 "preview-smoke-drop-during-create",
 "about:blank#drop-during-create",
 window,
 cx,
 )
 })
 })
 .expect("preview smoke window closed before drop-during-create")
 .expect("native preview webview creation failed");
 drop(shell);
 yield_for(cx, STEP_DELAY).await;
 watchdog.finish_phase("drop-during-create");

 watchdog.start_phase("quit");
 watchdog.finish_phase("quit");
 watchdog.pass();
 cx.update(|cx| cx.quit());
}

73 changes: 70 additions & 3 deletions
crates/ui/src/preview_panel.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -130,6 +130,10 @@ mod native {
 /// WebView2 runtime). Set once; the tab then explains itself instead of
 /// retrying on every frame.
 webview_error: Option<String>,
 /// Harness-only routing override. Normal runs leave this unset and use
 /// the active conversation identity from `WorkspaceStore`.
 smoke_active_key: Option<String>,
 smoke_visible: bool,
 _subscriptions: Vec<Subscription>,
 }

Expand All@@ -148,6 +152,7 @@ mod native {
 // Native child views outlive GPUI layout nodes. Visibility
 // therefore follows WorkspaceStore directly, even while this
 // entity is no longer mounted in the right-panel tree.
 this.prune_deleted_webviews(cx);
 this.sync_visibility(cx);
 cx.notify();
 }),
Expand All@@ -164,6 +169,8 @@ mod native {
 dev_ports: Vec::new(),
 port_scan_generation: 0,
 webview_error: None,
 smoke_active_key: None,
 smoke_visible: false,
 _subscriptions: subscriptions,
 }
 }
Expand All@@ -172,6 +179,9 @@ mod native {
 /// Draft -> stored-thread commits retain the same session id, so move
 /// all cached browser state across that one key transition.
 fn active_key(&mut self, cx: &Context<Self>) -> Option<String> {
 if let Some(key) = &self.smoke_active_key {
 return Some(key.clone());
 }
 let current = self.store.read(cx).preview_active_identity();

 if let (Some((old_session, old_key)), Some((session, key))) =
Expand DownExpand Up@@ -224,7 +234,9 @@ mod native {

 fn update_visibility(&mut self, allow_show: bool, cx: &mut Context<Self>) {
 let active = self.active_key(cx);
 let visible = {
 let visible = if self.smoke_active_key.is_some() {
 self.smoke_visible.then_some(active).flatten()
 } else {
 let window_state = self.window_state.read(cx);
 visible_preview_key(
 active.as_deref(),
Expand DownExpand Up@@ -296,6 +308,62 @@ mod native {
 Some(webview)
 }

 pub(crate) fn smoke_create(
 &mut self,
 key: &str,
 url: &str,
 window: &mut Window,
 cx: &mut Context<Self>,
 ) -> Result<(), String> {
 self.smoke_active_key = Some(key.to_string());
 self.smoke_visible = true;
 self.navigate(key, url, window, cx);
 match &self.webview_error {
 Some(error) => Err(error.clone()),
 None => Ok(()),
 }
 }

 pub(crate) fn smoke_set_visible(&mut self, key: Option<&str>, cx: &mut Context<Self>) {
 if let Some(key) = key {
 self.smoke_active_key = Some(key.to_string());
 self.smoke_visible = true;
 } else {
 self.smoke_visible = false;
 }
 self.update_visibility(true, cx);
 cx.notify();
 }

 pub(crate) fn smoke_drop(&mut self, key: &str, cx: &mut Context<Self>) {
 self.drop_webview(key);
 cx.notify();
 }

 fn drop_webview(&mut self, key: &str) {
 self.webviews.remove(key);
 self.warm.remove(key);
 if self.mirrored.as_deref() == Some(key) {
 self.mirrored = None;
 }
 }

 fn prune_deleted_webviews(&mut self, cx: &Context<Self>) {
 if self.smoke_active_key.is_some() {
 return;
 }
 let live = self.store.read(cx).preview_live_keys();
 let deleted = self
 .webviews
 .keys()
 .filter(|key| !live.contains(*key))
 .cloned()
 .collect::<Vec<_>>();
 for key in deleted {
 self.drop_webview(&key);
 }
 }

 /// Navigate one conversation's WebView to `url`, remembering it.
 fn navigate(&mut self, key: &str, url: &str, window: &mut Window, cx: &mut Context<Self>) {
 let url = normalize_url(url);
Expand DownExpand Up@@ -377,8 +445,7 @@ mod native {
 /// recreates a fresh webview on demand.
 fn close_panel(&mut self, cx: &mut Context<Self>) {
 if let Some(key) = self.active_key(cx) {
 self.webviews.remove(&key);
 self.warm.remove(&key);
 self.drop_webview(&key);
 self.store
 .update(cx, |store, cx| store.clear_preview_chrome(&key, cx));
 }
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(preview): --preview-smoke lifecycle harness#244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Tryanks
merged 3 commits into

from

Aug 22, 2026
 Merged


feat(preview): --preview-smoke lifecycle harness
#244
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
15cd94b

feat(preview): --preview-smoke lifecycle harness; prune webviews of d…


Tryanks Aug 22, 2026
39fd872

feat(preview): tee preview-smoke phase log to TCODE_SMOKE_LOG file


Tryanks Aug 22, 2026
bbc4bb5

fix(ui): allow preview_live_keys dead_code on Linux (preview compiled…


Tryanks Aug 22, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


27 changes: 27 additions & 0 deletions
crates/app/src/main.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,9 @@ use tcode_ui::{assets, settings};
use tcode_ui::overlay::{DialogActions, OverlayExt as _, OverlayHost};
use tcode_ui::widgets::button::{Button, ButtonVariants as _};

#[cfg(not(target_os = "linux"))]
mod preview_smoke;

const TCODE_THEME: &str = include_str!("../../../themes/tcode.json");

/// macOS vibrancy can be disabled with `TCODE_NO_VIBRANCY=1` as a diagnostic
Expand DownExpand Up@@ -169,6 +172,17 @@ fn handle_quit(
fn main() {
 env_logger::init();

 let preview_smoke = std::env::args().any(|arg| arg == "--preview-smoke");
 #[cfg(target_os = "linux")]
 if preview_smoke {
 use std::io::Write as _;
 eprintln!("preview-smoke: SKIP (no native webview)");
 let _ = std::io::stderr().flush();
 return;
 }
 #[cfg(not(target_os = "linux"))]
 let preview_smoke_watchdog = preview_smoke.then(preview_smoke::Watchdog::start);

 // A Finder/Dock launch inherits launchd's minimal PATH, under which none of
 // the provider CLIs resolve — import the login shell's environment first,
 // before anything (probes, sessions, the terminal) reads PATH. Must stay
Expand DownExpand Up@@ -330,6 +344,8 @@ fn main() {
 };

 cx.spawn(async move |cx| {
 let smoke_shell = std::rc::Rc::new(std::cell::RefCell::new(None));
 let smoke_shell_for_window = smoke_shell.clone();
 let window = cx
 .open_window(window_options, {
 let theme_store = workspace_store.clone();
Expand All@@ -349,6 +365,7 @@ fn main() {
 }
 let shell = cx
 .new(|cx| AppShell::new(workspace_store, window_state, window, cx));
 *smoke_shell_for_window.borrow_mut() = Some(shell.clone());
 cx.new(|cx| OverlayHost::new(shell, window, cx))
 }
 })
Expand All@@ -359,6 +376,16 @@ fn main() {
 window.activate_window();
 });

 #[cfg(not(target_os = "linux"))]
 if let Some(watchdog) = preview_smoke_watchdog {
 let shell = smoke_shell
 .borrow_mut()
 .take()
 .expect("preview smoke shell was not captured");
 preview_smoke::run(watchdog, shell, window, cx).await;
 return;
 }

 if open_latest {
 let _ = host.dispatch(Command::OpenLatestSession);
 for _ in 0..100 {
Expand Down

194 changes: 194 additions & 0 deletions
crates/app/src/preview_smoke.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,194 @@
use std::io::Write as _;
use std::sync::{
 Arc, Mutex,
 atomic::{AtomicBool, Ordering},
};
use std::time::Duration;

use gpui::{AsyncApp, Entity, WindowHandle, px, size};
use tcode_ui::{AppShell, overlay::OverlayHost};

const STEP_DELAY: Duration = Duration::from_millis(20);
const RAPID_DELAY: Duration = Duration::from_millis(5);
const WATCHDOG_TIMEOUT: Duration = Duration::from_secs(120);
const KEYS: [&str; 6] = [
 "preview-smoke-0",
 "preview-smoke-1",
 "preview-smoke-2",
 "preview-smoke-3",
 "preview-smoke-4",
 "preview-smoke-5",
];

fn log_line(message: &str) {
 eprintln!("{message}");
 let _ = std::io::stderr().flush();
 // Windows-subsystem builds have no console under a scheduled task, so the
 // on-device runner reads phases from this file instead of stderr.
 if let Ok(path) = std::env::var("TCODE_SMOKE_LOG")
 && let Ok(mut file) = std::fs::OpenOptions::new()
 .create(true)
 .append(true)
 .open(path)
 {
 let _ = writeln!(file, "{message}");
 let _ = file.sync_all();
 }
}

pub struct Watchdog {
 phase: Arc<Mutex<&'static str>>,
 finished: Arc<AtomicBool>,
}

impl Watchdog {
 pub fn start() -> Self {
 let phase = Arc::new(Mutex::new("startup"));
 let finished = Arc::new(AtomicBool::new(false));
 let watchdog_phase = phase.clone();
 let watchdog_finished = finished.clone();
 std::thread::spawn(move || {
 std::thread::sleep(WATCHDOG_TIMEOUT);
 if !watchdog_finished.load(Ordering::SeqCst) {
 let phase = *watchdog_phase
 .lock()
 .unwrap_or_else(|error| error.into_inner());
 log_line(&format!("preview-smoke: TIMEOUT phase {phase}"));
 std::process::exit(124);
 }
 });
 Self { phase, finished }
 }

 fn start_phase(&self, phase: &'static str) {
 *self.phase.lock().unwrap_or_else(|error| error.into_inner()) = phase;
 log_line(&format!("preview-smoke: phase {phase} start"));
 }

 fn finish_phase(&self, phase: &'static str) {
 log_line(&format!("preview-smoke: phase {phase} ok"));
 }

 fn pass(&self) {
 log_line("preview-smoke: PASS");
 self.finished.store(true, Ordering::SeqCst);
 }
}

async fn yield_for(cx: &AsyncApp, delay: Duration) {
 cx.background_executor().timer(delay).await;
}

pub async fn run(
 watchdog: Watchdog,
 shell: Entity<AppShell>,
 window: WindowHandle<OverlayHost>,
 cx: &mut AsyncApp,
) {
 watchdog.start_phase("create-first");
 window
 .update(cx, |_, window, cx| {
 shell.update(cx, |shell, cx| {
 shell.preview_smoke_create(KEYS[0], "about:blank", window, cx)
 })
 })
 .expect("preview smoke window closed during create-first")
 .expect("native preview webview creation failed");
 yield_for(cx, STEP_DELAY).await;
 watchdog.finish_phase("create-first");

 watchdog.start_phase("show-hide-churn");
 for _ in 0..20 {
 shell.update(cx, |shell, cx| shell.preview_smoke_set_visible(None, cx));
 yield_for(cx, RAPID_DELAY).await;
 shell.update(cx, |shell, cx| {
 shell.preview_smoke_set_visible(Some(KEYS[0]), cx)
 });
 yield_for(cx, RAPID_DELAY).await;
 }
 watchdog.finish_phase("show-hide-churn");

 watchdog.start_phase("multi-create");
 for key in &KEYS[1..] {
 window
 .update(cx, |_, window, cx| {
 shell.update(cx, |shell, cx| {
 shell.preview_smoke_create(key, "about:blank", window, cx)
 })
 })
 .expect("preview smoke window closed during multi-create")
 .expect("native preview webview creation failed");
 yield_for(cx, STEP_DELAY).await;
 }
 watchdog.finish_phase("multi-create");

 watchdog.start_phase("rapid-switch");
 for ix in 0..30 {
 shell.update(cx, |shell, cx| {
 shell.preview_smoke_set_visible(Some(KEYS[ix % KEYS.len()]), cx)
 });
 yield_for(cx, RAPID_DELAY).await;
 }
 watchdog.finish_phase("rapid-switch");

 watchdog.start_phase("resize-churn");
 for (width, height) in [(1100., 720.), (940., 640.), (1280., 820.), (1000., 700.)] {
 window
 .update(cx, |_, window, _| {
 window.resize(size(px(width), px(height)))
 })
 .expect("preview smoke window closed during resize-churn");
 yield_for(cx, STEP_DELAY).await;
 }
 watchdog.finish_phase("resize-churn");

 watchdog.start_phase("navigate-all");
 for (ix, key) in KEYS.iter().enumerate() {
 let url = format!("about:blank#preview-smoke-{ix}");
 window
 .update(cx, |_, window, cx| {
 shell.update(cx, |shell, cx| {
 shell.preview_smoke_create(key, &url, window, cx)
 })
 })
 .expect("preview smoke window closed during navigate-all")
 .expect("native preview navigation failed");
 yield_for(cx, STEP_DELAY).await;
 }
 watchdog.finish_phase("navigate-all");

 watchdog.start_phase("drop-one");
 shell.update(cx, |shell, cx| {
 shell.preview_smoke_set_visible(Some(KEYS[1]), cx);
 shell.preview_smoke_drop(KEYS[0], cx);
 });
 yield_for(cx, STEP_DELAY).await;
 watchdog.finish_phase("drop-one");

 watchdog.start_phase("drop-during-create");
 let close_window = window;
 window
 .update(cx, |_, window, cx| {
 shell.update(cx, |shell, cx| {
 cx.defer(move |cx| {
 let _ = close_window.update(cx, |_, window, _| window.remove_window());
 });
 shell.preview_smoke_create(
 "preview-smoke-drop-during-create",
 "about:blank#drop-during-create",
 window,
 cx,
 )
 })
 })
 .expect("preview smoke window closed before drop-during-create")
 .expect("native preview webview creation failed");
 drop(shell);
 yield_for(cx, STEP_DELAY).await;
 watchdog.finish_phase("drop-during-create");

 watchdog.start_phase("quit");
 watchdog.finish_phase("quit");
 watchdog.pass();
 cx.update(|cx| cx.quit());
}

73 changes: 70 additions & 3 deletions
crates/ui/src/preview_panel.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -130,6 +130,10 @@ mod native {
 /// WebView2 runtime). Set once; the tab then explains itself instead of
 /// retrying on every frame.
 webview_error: Option<String>,
 /// Harness-only routing override. Normal runs leave this unset and use
 /// the active conversation identity from `WorkspaceStore`.
 smoke_active_key: Option<String>,
 smoke_visible: bool,
 _subscriptions: Vec<Subscription>,
 }

Expand All@@ -148,6 +152,7 @@ mod native {
 // Native child views outlive GPUI layout nodes. Visibility
 // therefore follows WorkspaceStore directly, even while this
 // entity is no longer mounted in the right-panel tree.
 this.prune_deleted_webviews(cx);
 this.sync_visibility(cx);
 cx.notify();
 }),
Expand All@@ -164,6 +169,8 @@ mod native {
 dev_ports: Vec::new(),
 port_scan_generation: 0,
 webview_error: None,
 smoke_active_key: None,
 smoke_visible: false,
 _subscriptions: subscriptions,
 }
 }
Expand All@@ -172,6 +179,9 @@ mod native {
 /// Draft -> stored-thread commits retain the same session id, so move
 /// all cached browser state across that one key transition.
 fn active_key(&mut self, cx: &Context<Self>) -> Option<String> {
 if let Some(key) = &self.smoke_active_key {
 return Some(key.clone());
 }
 let current = self.store.read(cx).preview_active_identity();

 if let (Some((old_session, old_key)), Some((session, key))) =
Expand DownExpand Up@@ -224,7 +234,9 @@ mod native {

 fn update_visibility(&mut self, allow_show: bool, cx: &mut Context<Self>) {
 let active = self.active_key(cx);
 let visible = {
 let visible = if self.smoke_active_key.is_some() {
 self.smoke_visible.then_some(active).flatten()
 } else {
 let window_state = self.window_state.read(cx);
 visible_preview_key(
 active.as_deref(),
Expand DownExpand Up@@ -296,6 +308,62 @@ mod native {
 Some(webview)
 }

 pub(crate) fn smoke_create(
 &mut self,
 key: &str,
 url: &str,
 window: &mut Window,
 cx: &mut Context<Self>,
 ) -> Result<(), String> {
 self.smoke_active_key = Some(key.to_string());
 self.smoke_visible = true;
 self.navigate(key, url, window, cx);
 match &self.webview_error {
 Some(error) => Err(error.clone()),
 None => Ok(()),
 }
 }

 pub(crate) fn smoke_set_visible(&mut self, key: Option<&str>, cx: &mut Context<Self>) {
 if let Some(key) = key {
 self.smoke_active_key = Some(key.to_string());
 self.smoke_visible = true;
 } else {
 self.smoke_visible = false;
 }
 self.update_visibility(true, cx);
 cx.notify();
 }

 pub(crate) fn smoke_drop(&mut self, key: &str, cx: &mut Context<Self>) {
 self.drop_webview(key);
 cx.notify();
 }

 fn drop_webview(&mut self, key: &str) {
 self.webviews.remove(key);
 self.warm.remove(key);
 if self.mirrored.as_deref() == Some(key) {
 self.mirrored = None;
 }
 }

 fn prune_deleted_webviews(&mut self, cx: &Context<Self>) {
 if self.smoke_active_key.is_some() {
 return;
 }
 let live = self.store.read(cx).preview_live_keys();
 let deleted = self
 .webviews
 .keys()
 .filter(|key| !live.contains(*key))
 .cloned()
 .collect::<Vec<_>>();
 for key in deleted {
 self.drop_webview(&key);
 }
 }

 /// Navigate one conversation's WebView to `url`, remembering it.
 fn navigate(&mut self, key: &str, url: &str, window: &mut Window, cx: &mut Context<Self>) {
 let url = normalize_url(url);
Expand DownExpand Up@@ -377,8 +445,7 @@ mod native {
 /// recreates a fresh webview on demand.
 fn close_panel(&mut self, cx: &mut Context<Self>) {
 if let Some(key) = self.active_key(cx) {
 self.webviews.remove(&key);
 self.warm.remove(&key);
 self.drop_webview(&key);
 self.store
 .update(cx, |store, cx| store.clear_preview_chrome(&key, cx));
 }
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(preview): --preview-smoke lifecycle harness#244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Tryanks
merged 3 commits into

from

Aug 22, 2026
 Merged


feat(preview): --preview-smoke lifecycle harness
#244
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
15cd94b

feat(preview): --preview-smoke lifecycle harness; prune webviews of d…


Tryanks Aug 22, 2026
39fd872

feat(preview): tee preview-smoke phase log to TCODE_SMOKE_LOG file


Tryanks Aug 22, 2026
bbc4bb5

fix(ui): allow preview_live_keys dead_code on Linux (preview compiled…


Tryanks Aug 22, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


27 changes: 27 additions & 0 deletions
crates/app/src/main.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,9 @@ use tcode_ui::{assets, settings};
use tcode_ui::overlay::{DialogActions, OverlayExt as _, OverlayHost};
use tcode_ui::widgets::button::{Button, ButtonVariants as _};

#[cfg(not(target_os = "linux"))]
mod preview_smoke;

const TCODE_THEME: &str = include_str!("../../../themes/tcode.json");

/// macOS vibrancy can be disabled with `TCODE_NO_VIBRANCY=1` as a diagnostic
Expand DownExpand Up@@ -169,6 +172,17 @@ fn handle_quit(
fn main() {
 env_logger::init();

 let preview_smoke = std::env::args().any(|arg| arg == "--preview-smoke");
 #[cfg(target_os = "linux")]
 if preview_smoke {
 use std::io::Write as _;
 eprintln!("preview-smoke: SKIP (no native webview)");
 let _ = std::io::stderr().flush();
 return;
 }
 #[cfg(not(target_os = "linux"))]
 let preview_smoke_watchdog = preview_smoke.then(preview_smoke::Watchdog::start);

 // A Finder/Dock launch inherits launchd's minimal PATH, under which none of
 // the provider CLIs resolve — import the login shell's environment first,
 // before anything (probes, sessions, the terminal) reads PATH. Must stay
Expand DownExpand Up@@ -330,6 +344,8 @@ fn main() {
 };

 cx.spawn(async move |cx| {
 let smoke_shell = std::rc::Rc::new(std::cell::RefCell::new(None));
 let smoke_shell_for_window = smoke_shell.clone();
 let window = cx
 .open_window(window_options, {
 let theme_store = workspace_store.clone();
Expand All@@ -349,6 +365,7 @@ fn main() {
 }
 let shell = cx
 .new(|cx| AppShell::new(workspace_store, window_state, window, cx));
 *smoke_shell_for_window.borrow_mut() = Some(shell.clone());
 cx.new(|cx| OverlayHost::new(shell, window, cx))
 }
 })
Expand All@@ -359,6 +376,16 @@ fn main() {
 window.activate_window();
 });

 #[cfg(not(target_os = "linux"))]
 if let Some(watchdog) = preview_smoke_watchdog {
 let shell = smoke_shell
 .borrow_mut()
 .take()
 .expect("preview smoke shell was not captured");
 preview_smoke::run(watchdog, shell, window, cx).await;
 return;
 }

 if open_latest {
 let _ = host.dispatch(Command::OpenLatestSession);
 for _ in 0..100 {
Expand Down

194 changes: 194 additions & 0 deletions
crates/app/src/preview_smoke.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,194 @@
use std::io::Write as _;
use std::sync::{
 Arc, Mutex,
 atomic::{AtomicBool, Ordering},
};
use std::time::Duration;

use gpui::{AsyncApp, Entity, WindowHandle, px, size};
use tcode_ui::{AppShell, overlay::OverlayHost};

const STEP_DELAY: Duration = Duration::from_millis(20);
const RAPID_DELAY: Duration = Duration::from_millis(5);
const WATCHDOG_TIMEOUT: Duration = Duration::from_secs(120);
const KEYS: [&str; 6] = [
 "preview-smoke-0",
 "preview-smoke-1",
 "preview-smoke-2",
 "preview-smoke-3",
 "preview-smoke-4",
 "preview-smoke-5",
];

fn log_line(message: &str) {
 eprintln!("{message}");
 let _ = std::io::stderr().flush();
 // Windows-subsystem builds have no console under a scheduled task, so the
 // on-device runner reads phases from this file instead of stderr.
 if let Ok(path) = std::env::var("TCODE_SMOKE_LOG")
 && let Ok(mut file) = std::fs::OpenOptions::new()
 .create(true)
 .append(true)
 .open(path)
 {
 let _ = writeln!(file, "{message}");
 let _ = file.sync_all();
 }
}

pub struct Watchdog {
 phase: Arc<Mutex<&'static str>>,
 finished: Arc<AtomicBool>,
}

impl Watchdog {
 pub fn start() -> Self {
 let phase = Arc::new(Mutex::new("startup"));
 let finished = Arc::new(AtomicBool::new(false));
 let watchdog_phase = phase.clone();
 let watchdog_finished = finished.clone();
 std::thread::spawn(move || {
 std::thread::sleep(WATCHDOG_TIMEOUT);
 if !watchdog_finished.load(Ordering::SeqCst) {
 let phase = *watchdog_phase
 .lock()
 .unwrap_or_else(|error| error.into_inner());
 log_line(&format!("preview-smoke: TIMEOUT phase {phase}"));
 std::process::exit(124);
 }
 });
 Self { phase, finished }
 }

 fn start_phase(&self, phase: &'static str) {
 *self.phase.lock().unwrap_or_else(|error| error.into_inner()) = phase;
 log_line(&format!("preview-smoke: phase {phase} start"));
 }

 fn finish_phase(&self, phase: &'static str) {
 log_line(&format!("preview-smoke: phase {phase} ok"));
 }

 fn pass(&self) {
 log_line("preview-smoke: PASS");
 self.finished.store(true, Ordering::SeqCst);
 }
}

async fn yield_for(cx: &AsyncApp, delay: Duration) {
 cx.background_executor().timer(delay).await;
}

pub async fn run(
 watchdog: Watchdog,
 shell: Entity<AppShell>,
 window: WindowHandle<OverlayHost>,
 cx: &mut AsyncApp,
) {
 watchdog.start_phase("create-first");
 window
 .update(cx, |_, window, cx| {
 shell.update(cx, |shell, cx| {
 shell.preview_smoke_create(KEYS[0], "about:blank", window, cx)
 })
 })
 .expect("preview smoke window closed during create-first")
 .expect("native preview webview creation failed");
 yield_for(cx, STEP_DELAY).await;
 watchdog.finish_phase("create-first");

 watchdog.start_phase("show-hide-churn");
 for _ in 0..20 {
 shell.update(cx, |shell, cx| shell.preview_smoke_set_visible(None, cx));
 yield_for(cx, RAPID_DELAY).await;
 shell.update(cx, |shell, cx| {
 shell.preview_smoke_set_visible(Some(KEYS[0]), cx)
 });
 yield_for(cx, RAPID_DELAY).await;
 }
 watchdog.finish_phase("show-hide-churn");

 watchdog.start_phase("multi-create");
 for key in &KEYS[1..] {
 window
 .update(cx, |_, window, cx| {
 shell.update(cx, |shell, cx| {
 shell.preview_smoke_create(key, "about:blank", window, cx)
 })
 })
 .expect("preview smoke window closed during multi-create")
 .expect("native preview webview creation failed");
 yield_for(cx, STEP_DELAY).await;
 }
 watchdog.finish_phase("multi-create");

 watchdog.start_phase("rapid-switch");
 for ix in 0..30 {
 shell.update(cx, |shell, cx| {
 shell.preview_smoke_set_visible(Some(KEYS[ix % KEYS.len()]), cx)
 });
 yield_for(cx, RAPID_DELAY).await;
 }
 watchdog.finish_phase("rapid-switch");

 watchdog.start_phase("resize-churn");
 for (width, height) in [(1100., 720.), (940., 640.), (1280., 820.), (1000., 700.)] {
 window
 .update(cx, |_, window, _| {
 window.resize(size(px(width), px(height)))
 })
 .expect("preview smoke window closed during resize-churn");
 yield_for(cx, STEP_DELAY).await;
 }
 watchdog.finish_phase("resize-churn");

 watchdog.start_phase("navigate-all");
 for (ix, key) in KEYS.iter().enumerate() {
 let url = format!("about:blank#preview-smoke-{ix}");
 window
 .update(cx, |_, window, cx| {
 shell.update(cx, |shell, cx| {
 shell.preview_smoke_create(key, &url, window, cx)
 })
 })
 .expect("preview smoke window closed during navigate-all")
 .expect("native preview navigation failed");
 yield_for(cx, STEP_DELAY).await;
 }
 watchdog.finish_phase("navigate-all");

 watchdog.start_phase("drop-one");
 shell.update(cx, |shell, cx| {
 shell.preview_smoke_set_visible(Some(KEYS[1]), cx);
 shell.preview_smoke_drop(KEYS[0], cx);
 });
 yield_for(cx, STEP_DELAY).await;
 watchdog.finish_phase("drop-one");

 watchdog.start_phase("drop-during-create");
 let close_window = window;
 window
 .update(cx, |_, window, cx| {
 shell.update(cx, |shell, cx| {
 cx.defer(move |cx| {
 let _ = close_window.update(cx, |_, window, _| window.remove_window());
 });
 shell.preview_smoke_create(
 "preview-smoke-drop-during-create",
 "about:blank#drop-during-create",
 window,
 cx,
 )
 })
 })
 .expect("preview smoke window closed before drop-during-create")
 .expect("native preview webview creation failed");
 drop(shell);
 yield_for(cx, STEP_DELAY).await;
 watchdog.finish_phase("drop-during-create");

 watchdog.start_phase("quit");
 watchdog.finish_phase("quit");
 watchdog.pass();
 cx.update(|cx| cx.quit());
}

73 changes: 70 additions & 3 deletions
crates/ui/src/preview_panel.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -130,6 +130,10 @@ mod native {
 /// WebView2 runtime). Set once; the tab then explains itself instead of
 /// retrying on every frame.
 webview_error: Option<String>,
 /// Harness-only routing override. Normal runs leave this unset and use
 /// the active conversation identity from `WorkspaceStore`.
 smoke_active_key: Option<String>,
 smoke_visible: bool,
 _subscriptions: Vec<Subscription>,
 }

Expand All@@ -148,6 +152,7 @@ mod native {
 // Native child views outlive GPUI layout nodes. Visibility
 // therefore follows WorkspaceStore directly, even while this
 // entity is no longer mounted in the right-panel tree.
 this.prune_deleted_webviews(cx);
 this.sync_visibility(cx);
 cx.notify();
 }),
Expand All@@ -164,6 +169,8 @@ mod native {
 dev_ports: Vec::new(),
 port_scan_generation: 0,
 webview_error: None,
 smoke_active_key: None,
 smoke_visible: false,
 _subscriptions: subscriptions,
 }
 }
Expand All@@ -172,6 +179,9 @@ mod native {
 /// Draft -> stored-thread commits retain the same session id, so move
 /// all cached browser state across that one key transition.
 fn active_key(&mut self, cx: &Context<Self>) -> Option<String> {
 if let Some(key) = &self.smoke_active_key {
 return Some(key.clone());
 }
 let current = self.store.read(cx).preview_active_identity();

 if let (Some((old_session, old_key)), Some((session, key))) =
Expand DownExpand Up@@ -224,7 +234,9 @@ mod native {

 fn update_visibility(&mut self, allow_show: bool, cx: &mut Context<Self>) {
 let active = self.active_key(cx);
 let visible = {
 let visible = if self.smoke_active_key.is_some() {
 self.smoke_visible.then_some(active).flatten()
 } else {
 let window_state = self.window_state.read(cx);
 visible_preview_key(
 active.as_deref(),
Expand DownExpand Up@@ -296,6 +308,62 @@ mod native {
 Some(webview)
 }

 pub(crate) fn smoke_create(
 &mut self,
 key: &str,
 url: &str,
 window: &mut Window,
 cx: &mut Context<Self>,
 ) -> Result<(), String> {
 self.smoke_active_key = Some(key.to_string());
 self.smoke_visible = true;
 self.navigate(key, url, window, cx);
 match &self.webview_error {
 Some(error) => Err(error.clone()),
 None => Ok(()),
 }
 }

 pub(crate) fn smoke_set_visible(&mut self, key: Option<&str>, cx: &mut Context<Self>) {
 if let Some(key) = key {
 self.smoke_active_key = Some(key.to_string());
 self.smoke_visible = true;
 } else {
 self.smoke_visible = false;
 }
 self.update_visibility(true, cx);
 cx.notify();
 }

 pub(crate) fn smoke_drop(&mut self, key: &str, cx: &mut Context<Self>) {
 self.drop_webview(key);
 cx.notify();
 }

 fn drop_webview(&mut self, key: &str) {
 self.webviews.remove(key);
 self.warm.remove(key);
 if self.mirrored.as_deref() == Some(key) {
 self.mirrored = None;
 }
 }

 fn prune_deleted_webviews(&mut self, cx: &Context<Self>) {
 if self.smoke_active_key.is_some() {
 return;
 }
 let live = self.store.read(cx).preview_live_keys();
 let deleted = self
 .webviews
 .keys()
 .filter(|key| !live.contains(*key))
 .cloned()
 .collect::<Vec<_>>();
 for key in deleted {
 self.drop_webview(&key);
 }
 }

 /// Navigate one conversation's WebView to `url`, remembering it.
 fn navigate(&mut self, key: &str, url: &str, window: &mut Window, cx: &mut Context<Self>) {
 let url = normalize_url(url);
Expand DownExpand Up@@ -377,8 +445,7 @@ mod native {
 /// recreates a fresh webview on demand.
 fn close_panel(&mut self, cx: &mut Context<Self>) {
 if let Some(key) = self.active_key(cx) {
 self.webviews.remove(&key);
 self.warm.remove(&key);
 self.drop_webview(&key);
 self.store
 .update(cx, |store, cx| store.clear_preview_chrome(&key, cx));
 }
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
feat(preview): --preview-smoke lifecycle harness#244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Tryanks
merged 3 commits into

from

Aug 22, 2026
 Merged


feat(preview): --preview-smoke lifecycle harness
#244
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
15cd94b

feat(preview): --preview-smoke lifecycle harness; prune webviews of d…


Tryanks Aug 22, 2026
39fd872

feat(preview): tee preview-smoke phase log to TCODE_SMOKE_LOG file


Tryanks Aug 22, 2026
bbc4bb5

fix(ui): allow preview_live_keys dead_code on Linux (preview compiled…


Tryanks Aug 22, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


27 changes: 27 additions & 0 deletions
crates/app/src/main.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,9 @@ use tcode_ui::{assets, settings};
use tcode_ui::overlay::{DialogActions, OverlayExt as _, OverlayHost};
use tcode_ui::widgets::button::{Button, ButtonVariants as _};

#[cfg(not(target_os = "linux"))]
mod preview_smoke;

const TCODE_THEME: &str = include_str!("../../../themes/tcode.json");

/// macOS vibrancy can be disabled with `TCODE_NO_VIBRANCY=1` as a diagnostic
Expand DownExpand Up@@ -169,6 +172,17 @@ fn handle_quit(
fn main() {
 env_logger::init();

 let preview_smoke = std::env::args().any(|arg| arg == "--preview-smoke");
 #[cfg(target_os = "linux")]
 if preview_smoke {
 use std::io::Write as _;
 eprintln!("preview-smoke: SKIP (no native webview)");
 let _ = std::io::stderr().flush();
 return;
 }
 #[cfg(not(target_os = "linux"))]
 let preview_smoke_watchdog = preview_smoke.then(preview_smoke::Watchdog::start);

 // A Finder/Dock launch inherits launchd's minimal PATH, under which none of
 // the provider CLIs resolve — import the login shell's environment first,
 // before anything (probes, sessions, the terminal) reads PATH. Must stay
Expand DownExpand Up@@ -330,6 +344,8 @@ fn main() {
 };

 cx.spawn(async move |cx| {
 let smoke_shell = std::rc::Rc::new(std::cell::RefCell::new(None));
 let smoke_shell_for_window = smoke_shell.clone();
 let window = cx
 .open_window(window_options, {
 let theme_store = workspace_store.clone();
Expand All@@ -349,6 +365,7 @@ fn main() {
 }
 let shell = cx
 .new(|cx| AppShell::new(workspace_store, window_state, window, cx));
 *smoke_shell_for_window.borrow_mut() = Some(shell.clone());
 cx.new(|cx| OverlayHost::new(shell, window, cx))
 }
 })
Expand All@@ -359,6 +376,16 @@ fn main() {
 window.activate_window();
 });

 #[cfg(not(target_os = "linux"))]
 if let Some(watchdog) = preview_smoke_watchdog {
 let shell = smoke_shell
 .borrow_mut()
 .take()
 .expect("preview smoke shell was not captured");
 preview_smoke::run(watchdog, shell, window, cx).await;
 return;
 }

 if open_latest {
 let _ = host.dispatch(Command::OpenLatestSession);
 for _ in 0..100 {
Expand Down

194 changes: 194 additions & 0 deletions
crates/app/src/preview_smoke.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,194 @@
use std::io::Write as _;
use std::sync::{
 Arc, Mutex,
 atomic::{AtomicBool, Ordering},
};
use std::time::Duration;

use gpui::{AsyncApp, Entity, WindowHandle, px, size};
use tcode_ui::{AppShell, overlay::OverlayHost};

const STEP_DELAY: Duration = Duration::from_millis(20);
const RAPID_DELAY: Duration = Duration::from_millis(5);
const WATCHDOG_TIMEOUT: Duration = Duration::from_secs(120);
const KEYS: [&str; 6] = [
 "preview-smoke-0",
 "preview-smoke-1",
 "preview-smoke-2",
 "preview-smoke-3",
 "preview-smoke-4",
 "preview-smoke-5",
];

fn log_line(message: &str) {
 eprintln!("{message}");
 let _ = std::io::stderr().flush();
 // Windows-subsystem builds have no console under a scheduled task, so the
 // on-device runner reads phases from this file instead of stderr.
 if let Ok(path) = std::env::var("TCODE_SMOKE_LOG")
 && let Ok(mut file) = std::fs::OpenOptions::new()
 .create(true)
 .append(true)
 .open(path)
 {
 let _ = writeln!(file, "{message}");
 let _ = file.sync_all();
 }
}

pub struct Watchdog {
 phase: Arc<Mutex<&'static str>>,
 finished: Arc<AtomicBool>,
}

impl Watchdog {
 pub fn start() -> Self {
 let phase = Arc::new(Mutex::new("startup"));
 let finished = Arc::new(AtomicBool::new(false));
 let watchdog_phase = phase.clone();
 let watchdog_finished = finished.clone();
 std::thread::spawn(move || {
 std::thread::sleep(WATCHDOG_TIMEOUT);
 if !watchdog_finished.load(Ordering::SeqCst) {
 let phase = *watchdog_phase
 .lock()
 .unwrap_or_else(|error| error.into_inner());
 log_line(&format!("preview-smoke: TIMEOUT phase {phase}"));
 std::process::exit(124);
 }
 });
 Self { phase, finished }
 }

 fn start_phase(&self, phase: &'static str) {
 *self.phase.lock().unwrap_or_else(|error| error.into_inner()) = phase;
 log_line(&format!("preview-smoke: phase {phase} start"));
 }

 fn finish_phase(&self, phase: &'static str) {
 log_line(&format!("preview-smoke: phase {phase} ok"));
 }

 fn pass(&self) {
 log_line("preview-smoke: PASS");
 self.finished.store(true, Ordering::SeqCst);
 }
}

async fn yield_for(cx: &AsyncApp, delay: Duration) {
 cx.background_executor().timer(delay).await;
}

pub async fn run(
 watchdog: Watchdog,
 shell: Entity<AppShell>,
 window: WindowHandle<OverlayHost>,
 cx: &mut AsyncApp,
) {
 watchdog.start_phase("create-first");
 window
 .update(cx, |_, window, cx| {
 shell.update(cx, |shell, cx| {
 shell.preview_smoke_create(KEYS[0], "about:blank", window, cx)
 })
 })
 .expect("preview smoke window closed during create-first")
 .expect("native preview webview creation failed");
 yield_for(cx, STEP_DELAY).await;
 watchdog.finish_phase("create-first");

 watchdog.start_phase("show-hide-churn");
 for _ in 0..20 {
 shell.update(cx, |shell, cx| shell.preview_smoke_set_visible(None, cx));
 yield_for(cx, RAPID_DELAY).await;
 shell.update(cx, |shell, cx| {
 shell.preview_smoke_set_visible(Some(KEYS[0]), cx)
 });
 yield_for(cx, RAPID_DELAY).await;
 }
 watchdog.finish_phase("show-hide-churn");

 watchdog.start_phase("multi-create");
 for key in &KEYS[1..] {
 window
 .update(cx, |_, window, cx| {
 shell.update(cx, |shell, cx| {
 shell.preview_smoke_create(key, "about:blank", window, cx)
 })
 })
 .expect("preview smoke window closed during multi-create")
 .expect("native preview webview creation failed");
 yield_for(cx, STEP_DELAY).await;
 }
 watchdog.finish_phase("multi-create");

 watchdog.start_phase("rapid-switch");
 for ix in 0..30 {
 shell.update(cx, |shell, cx| {
 shell.preview_smoke_set_visible(Some(KEYS[ix % KEYS.len()]), cx)
 });
 yield_for(cx, RAPID_DELAY).await;
 }
 watchdog.finish_phase("rapid-switch");

 watchdog.start_phase("resize-churn");
 for (width, height) in [(1100., 720.), (940., 640.), (1280., 820.), (1000., 700.)] {
 window
 .update(cx, |_, window, _| {
 window.resize(size(px(width), px(height)))
 })
 .expect("preview smoke window closed during resize-churn");
 yield_for(cx, STEP_DELAY).await;
 }
 watchdog.finish_phase("resize-churn");

 watchdog.start_phase("navigate-all");
 for (ix, key) in KEYS.iter().enumerate() {
 let url = format!("about:blank#preview-smoke-{ix}");
 window
 .update(cx, |_, window, cx| {
 shell.update(cx, |shell, cx| {
 shell.preview_smoke_create(key, &url, window, cx)
 })
 })
 .expect("preview smoke window closed during navigate-all")
 .expect("native preview navigation failed");
 yield_for(cx, STEP_DELAY).await;
 }
 watchdog.finish_phase("navigate-all");

 watchdog.start_phase("drop-one");
 shell.update(cx, |shell, cx| {
 shell.preview_smoke_set_visible(Some(KEYS[1]), cx);
 shell.preview_smoke_drop(KEYS[0], cx);
 });
 yield_for(cx, STEP_DELAY).await;
 watchdog.finish_phase("drop-one");

 watchdog.start_phase("drop-during-create");
 let close_window = window;
 window
 .update(cx, |_, window, cx| {
 shell.update(cx, |shell, cx| {
 cx.defer(move |cx| {
 let _ = close_window.update(cx, |_, window, _| window.remove_window());
 });
 shell.preview_smoke_create(
 "preview-smoke-drop-during-create",
 "about:blank#drop-during-create",
 window,
 cx,
 )
 })
 })
 .expect("preview smoke window closed before drop-during-create")
 .expect("native preview webview creation failed");
 drop(shell);
 yield_for(cx, STEP_DELAY).await;
 watchdog.finish_phase("drop-during-create");

 watchdog.start_phase("quit");
 watchdog.finish_phase("quit");
 watchdog.pass();
 cx.update(|cx| cx.quit());
}

73 changes: 70 additions & 3 deletions
crates/ui/src/preview_panel.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -130,6 +130,10 @@ mod native {
 /// WebView2 runtime). Set once; the tab then explains itself instead of
 /// retrying on every frame.
 webview_error: Option<String>,
 /// Harness-only routing override. Normal runs leave this unset and use
 /// the active conversation identity from `WorkspaceStore`.
 smoke_active_key: Option<String>,
 smoke_visible: bool,
 _subscriptions: Vec<Subscription>,
 }

Expand All@@ -148,6 +152,7 @@ mod native {
 // Native child views outlive GPUI layout nodes. Visibility
 // therefore follows WorkspaceStore directly, even while this
 // entity is no longer mounted in the right-panel tree.
 this.prune_deleted_webviews(cx);
 this.sync_visibility(cx);
 cx.notify();
 }),
Expand All@@ -164,6 +169,8 @@ mod native {
 dev_ports: Vec::new(),
 port_scan_generation: 0,
 webview_error: None,
 smoke_active_key: None,
 smoke_visible: false,
 _subscriptions: subscriptions,
 }
 }
Expand All@@ -172,6 +179,9 @@ mod native {
 /// Draft -> stored-thread commits retain the same session id, so move
 /// all cached browser state across that one key transition.
 fn active_key(&mut self, cx: &Context<Self>) -> Option<String> {
 if let Some(key) = &self.smoke_active_key {
 return Some(key.clone());
 }
 let current = self.store.read(cx).preview_active_identity();

 if let (Some((old_session, old_key)), Some((session, key))) =
Expand DownExpand Up@@ -224,7 +234,9 @@ mod native {

 fn update_visibility(&mut self, allow_show: bool, cx: &mut Context<Self>) {
 let active = self.active_key(cx);
 let visible = {
 let visible = if self.smoke_active_key.is_some() {
 self.smoke_visible.then_some(active).flatten()
 } else {
 let window_state = self.window_state.read(cx);
 visible_preview_key(
 active.as_deref(),
Expand DownExpand Up@@ -296,6 +308,62 @@ mod native {
 Some(webview)
 }

 pub(crate) fn smoke_create(
 &mut self,
 key: &str,
 url: &str,
 window: &mut Window,
 cx: &mut Context<Self>,
 ) -> Result<(), String> {
 self.smoke_active_key = Some(key.to_string());
 self.smoke_visible = true;
 self.navigate(key, url, window, cx);
 match &self.webview_error {
 Some(error) => Err(error.clone()),
 None => Ok(()),
 }
 }

 pub(crate) fn smoke_set_visible(&mut self, key: Option<&str>, cx: &mut Context<Self>) {
 if let Some(key) = key {
 self.smoke_active_key = Some(key.to_string());
 self.smoke_visible = true;
 } else {
 self.smoke_visible = false;
 }
 self.update_visibility(true, cx);
 cx.notify();
 }

 pub(crate) fn smoke_drop(&mut self, key: &str, cx: &mut Context<Self>) {
 self.drop_webview(key);
 cx.notify();
 }

 fn drop_webview(&mut self, key: &str) {
 self.webviews.remove(key);
 self.warm.remove(key);
 if self.mirrored.as_deref() == Some(key) {
 self.mirrored = None;
 }
 }

 fn prune_deleted_webviews(&mut self, cx: &Context<Self>) {
 if self.smoke_active_key.is_some() {
 return;
 }
 let live = self.store.read(cx).preview_live_keys();
 let deleted = self
 .webviews
 .keys()
 .filter(|key| !live.contains(*key))
 .cloned()
 .collect::<Vec<_>>();
 for key in deleted {
 self.drop_webview(&key);
 }
 }

 /// Navigate one conversation's WebView to `url`, remembering it.
 fn navigate(&mut self, key: &str, url: &str, window: &mut Window, cx: &mut Context<Self>) {
 let url = normalize_url(url);
Expand DownExpand Up@@ -377,8 +445,7 @@ mod native {
 /// recreates a fresh webview on demand.
 fn close_panel(&mut self, cx: &mut Context<Self>) {
 if let Some(key) = self.active_key(cx) {
 self.webviews.remove(&key);
 self.warm.remove(&key);
 self.drop_webview(&key);
 self.store
 .update(cx, |store, cx| store.clear_preview_chrome(&key, cx));
 }
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(preview): --preview-smoke lifecycle harness#244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Tryanks
merged 3 commits into

from

Aug 22, 2026
 Merged


feat(preview): --preview-smoke lifecycle harness
#244
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
15cd94b

feat(preview): --preview-smoke lifecycle harness; prune webviews of d…


Tryanks Aug 22, 2026
39fd872

feat(preview): tee preview-smoke phase log to TCODE_SMOKE_LOG file


Tryanks Aug 22, 2026
bbc4bb5

fix(ui): allow preview_live_keys dead_code on Linux (preview compiled…


Tryanks Aug 22, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


27 changes: 27 additions & 0 deletions
crates/app/src/main.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,9 @@ use tcode_ui::{assets, settings};
use tcode_ui::overlay::{DialogActions, OverlayExt as _, OverlayHost};
use tcode_ui::widgets::button::{Button, ButtonVariants as _};

#[cfg(not(target_os = "linux"))]
mod preview_smoke;

const TCODE_THEME: &str = include_str!("../../../themes/tcode.json");

/// macOS vibrancy can be disabled with `TCODE_NO_VIBRANCY=1` as a diagnostic
Expand DownExpand Up@@ -169,6 +172,17 @@ fn handle_quit(
fn main() {
 env_logger::init();

 let preview_smoke = std::env::args().any(|arg| arg == "--preview-smoke");
 #[cfg(target_os = "linux")]
 if preview_smoke {
 use std::io::Write as _;
 eprintln!("preview-smoke: SKIP (no native webview)");
 let _ = std::io::stderr().flush();
 return;
 }
 #[cfg(not(target_os = "linux"))]
 let preview_smoke_watchdog = preview_smoke.then(preview_smoke::Watchdog::start);

 // A Finder/Dock launch inherits launchd's minimal PATH, under which none of
 // the provider CLIs resolve — import the login shell's environment first,
 // before anything (probes, sessions, the terminal) reads PATH. Must stay
Expand DownExpand Up@@ -330,6 +344,8 @@ fn main() {
 };

 cx.spawn(async move |cx| {
 let smoke_shell = std::rc::Rc::new(std::cell::RefCell::new(None));
 let smoke_shell_for_window = smoke_shell.clone();
 let window = cx
 .open_window(window_options, {
 let theme_store = workspace_store.clone();
Expand All@@ -349,6 +365,7 @@ fn main() {
 }
 let shell = cx
 .new(|cx| AppShell::new(workspace_store, window_state, window, cx));
 *smoke_shell_for_window.borrow_mut() = Some(shell.clone());
 cx.new(|cx| OverlayHost::new(shell, window, cx))
 }
 })
Expand All@@ -359,6 +376,16 @@ fn main() {
 window.activate_window();
 });

 #[cfg(not(target_os = "linux"))]
 if let Some(watchdog) = preview_smoke_watchdog {
 let shell = smoke_shell
 .borrow_mut()
 .take()
 .expect("preview smoke shell was not captured");
 preview_smoke::run(watchdog, shell, window, cx).await;
 return;
 }

 if open_latest {
 let _ = host.dispatch(Command::OpenLatestSession);
 for _ in 0..100 {
Expand Down

194 changes: 194 additions & 0 deletions
crates/app/src/preview_smoke.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,194 @@
use std::io::Write as _;
use std::sync::{
 Arc, Mutex,
 atomic::{AtomicBool, Ordering},
};
use std::time::Duration;

use gpui::{AsyncApp, Entity, WindowHandle, px, size};
use tcode_ui::{AppShell, overlay::OverlayHost};

const STEP_DELAY: Duration = Duration::from_millis(20);
const RAPID_DELAY: Duration = Duration::from_millis(5);
const WATCHDOG_TIMEOUT: Duration = Duration::from_secs(120);
const KEYS: [&str; 6] = [
 "preview-smoke-0",
 "preview-smoke-1",
 "preview-smoke-2",
 "preview-smoke-3",
 "preview-smoke-4",
 "preview-smoke-5",
];

fn log_line(message: &str) {
 eprintln!("{message}");
 let _ = std::io::stderr().flush();
 // Windows-subsystem builds have no console under a scheduled task, so the
 // on-device runner reads phases from this file instead of stderr.
 if let Ok(path) = std::env::var("TCODE_SMOKE_LOG")
 && let Ok(mut file) = std::fs::OpenOptions::new()
 .create(true)
 .append(true)
 .open(path)
 {
 let _ = writeln!(file, "{message}");
 let _ = file.sync_all();
 }
}

pub struct Watchdog {
 phase: Arc<Mutex<&'static str>>,
 finished: Arc<AtomicBool>,
}

impl Watchdog {
 pub fn start() -> Self {
 let phase = Arc::new(Mutex::new("startup"));
 let finished = Arc::new(AtomicBool::new(false));
 let watchdog_phase = phase.clone();
 let watchdog_finished = finished.clone();
 std::thread::spawn(move || {
 std::thread::sleep(WATCHDOG_TIMEOUT);
 if !watchdog_finished.load(Ordering::SeqCst) {
 let phase = *watchdog_phase
 .lock()
 .unwrap_or_else(|error| error.into_inner());
 log_line(&format!("preview-smoke: TIMEOUT phase {phase}"));
 std::process::exit(124);
 }
 });
 Self { phase, finished }
 }

 fn start_phase(&self, phase: &'static str) {
 *self.phase.lock().unwrap_or_else(|error| error.into_inner()) = phase;
 log_line(&format!("preview-smoke: phase {phase} start"));
 }

 fn finish_phase(&self, phase: &'static str) {
 log_line(&format!("preview-smoke: phase {phase} ok"));
 }

 fn pass(&self) {
 log_line("preview-smoke: PASS");
 self.finished.store(true, Ordering::SeqCst);
 }
}

async fn yield_for(cx: &AsyncApp, delay: Duration) {
 cx.background_executor().timer(delay).await;
}

pub async fn run(
 watchdog: Watchdog,
 shell: Entity<AppShell>,
 window: WindowHandle<OverlayHost>,
 cx: &mut AsyncApp,
) {
 watchdog.start_phase("create-first");
 window
 .update(cx, |_, window, cx| {
 shell.update(cx, |shell, cx| {
 shell.preview_smoke_create(KEYS[0], "about:blank", window, cx)
 })
 })
 .expect("preview smoke window closed during create-first")
 .expect("native preview webview creation failed");
 yield_for(cx, STEP_DELAY).await;
 watchdog.finish_phase("create-first");

 watchdog.start_phase("show-hide-churn");
 for _ in 0..20 {
 shell.update(cx, |shell, cx| shell.preview_smoke_set_visible(None, cx));
 yield_for(cx, RAPID_DELAY).await;
 shell.update(cx, |shell, cx| {
 shell.preview_smoke_set_visible(Some(KEYS[0]), cx)
 });
 yield_for(cx, RAPID_DELAY).await;
 }
 watchdog.finish_phase("show-hide-churn");

 watchdog.start_phase("multi-create");
 for key in &KEYS[1..] {
 window
 .update(cx, |_, window, cx| {
 shell.update(cx, |shell, cx| {
 shell.preview_smoke_create(key, "about:blank", window, cx)
 })
 })
 .expect("preview smoke window closed during multi-create")
 .expect("native preview webview creation failed");
 yield_for(cx, STEP_DELAY).await;
 }
 watchdog.finish_phase("multi-create");

 watchdog.start_phase("rapid-switch");
 for ix in 0..30 {
 shell.update(cx, |shell, cx| {
 shell.preview_smoke_set_visible(Some(KEYS[ix % KEYS.len()]), cx)
 });
 yield_for(cx, RAPID_DELAY).await;
 }
 watchdog.finish_phase("rapid-switch");

 watchdog.start_phase("resize-churn");
 for (width, height) in [(1100., 720.), (940., 640.), (1280., 820.), (1000., 700.)] {
 window
 .update(cx, |_, window, _| {
 window.resize(size(px(width), px(height)))
 })
 .expect("preview smoke window closed during resize-churn");
 yield_for(cx, STEP_DELAY).await;
 }
 watchdog.finish_phase("resize-churn");

 watchdog.start_phase("navigate-all");
 for (ix, key) in KEYS.iter().enumerate() {
 let url = format!("about:blank#preview-smoke-{ix}");
 window
 .update(cx, |_, window, cx| {
 shell.update(cx, |shell, cx| {
 shell.preview_smoke_create(key, &url, window, cx)
 })
 })
 .expect("preview smoke window closed during navigate-all")
 .expect("native preview navigation failed");
 yield_for(cx, STEP_DELAY).await;
 }
 watchdog.finish_phase("navigate-all");

 watchdog.start_phase("drop-one");
 shell.update(cx, |shell, cx| {
 shell.preview_smoke_set_visible(Some(KEYS[1]), cx);
 shell.preview_smoke_drop(KEYS[0], cx);
 });
 yield_for(cx, STEP_DELAY).await;
 watchdog.finish_phase("drop-one");

 watchdog.start_phase("drop-during-create");
 let close_window = window;
 window
 .update(cx, |_, window, cx| {
 shell.update(cx, |shell, cx| {
 cx.defer(move |cx| {
 let _ = close_window.update(cx, |_, window, _| window.remove_window());
 });
 shell.preview_smoke_create(
 "preview-smoke-drop-during-create",
 "about:blank#drop-during-create",
 window,
 cx,
 )
 })
 })
 .expect("preview smoke window closed before drop-during-create")
 .expect("native preview webview creation failed");
 drop(shell);
 yield_for(cx, STEP_DELAY).await;
 watchdog.finish_phase("drop-during-create");

 watchdog.start_phase("quit");
 watchdog.finish_phase("quit");
 watchdog.pass();
 cx.update(|cx| cx.quit());
}

73 changes: 70 additions & 3 deletions
crates/ui/src/preview_panel.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -130,6 +130,10 @@ mod native {
 /// WebView2 runtime). Set once; the tab then explains itself instead of
 /// retrying on every frame.
 webview_error: Option<String>,
 /// Harness-only routing override. Normal runs leave this unset and use
 /// the active conversation identity from `WorkspaceStore`.
 smoke_active_key: Option<String>,
 smoke_visible: bool,
 _subscriptions: Vec<Subscription>,
 }

Expand All@@ -148,6 +152,7 @@ mod native {
 // Native child views outlive GPUI layout nodes. Visibility
 // therefore follows WorkspaceStore directly, even while this
 // entity is no longer mounted in the right-panel tree.
 this.prune_deleted_webviews(cx);
 this.sync_visibility(cx);
 cx.notify();
 }),
Expand All@@ -164,6 +169,8 @@ mod native {
 dev_ports: Vec::new(),
 port_scan_generation: 0,
 webview_error: None,
 smoke_active_key: None,
 smoke_visible: false,
 _subscriptions: subscriptions,
 }
 }
Expand All@@ -172,6 +179,9 @@ mod native {
 /// Draft -> stored-thread commits retain the same session id, so move
 /// all cached browser state across that one key transition.
 fn active_key(&mut self, cx: &Context<Self>) -> Option<String> {
 if let Some(key) = &self.smoke_active_key {
 return Some(key.clone());
 }
 let current = self.store.read(cx).preview_active_identity();

 if let (Some((old_session, old_key)), Some((session, key))) =
Expand DownExpand Up@@ -224,7 +234,9 @@ mod native {

 fn update_visibility(&mut self, allow_show: bool, cx: &mut Context<Self>) {
 let active = self.active_key(cx);
 let visible = {
 let visible = if self.smoke_active_key.is_some() {
 self.smoke_visible.then_some(active).flatten()
 } else {
 let window_state = self.window_state.read(cx);
 visible_preview_key(
 active.as_deref(),
Expand DownExpand Up@@ -296,6 +308,62 @@ mod native {
 Some(webview)
 }

 pub(crate) fn smoke_create(
 &mut self,
 key: &str,
 url: &str,
 window: &mut Window,
 cx: &mut Context<Self>,
 ) -> Result<(), String> {
 self.smoke_active_key = Some(key.to_string());
 self.smoke_visible = true;
 self.navigate(key, url, window, cx);
 match &self.webview_error {
 Some(error) => Err(error.clone()),
 None => Ok(()),
 }
 }

 pub(crate) fn smoke_set_visible(&mut self, key: Option<&str>, cx: &mut Context<Self>) {
 if let Some(key) = key {
 self.smoke_active_key = Some(key.to_string());
 self.smoke_visible = true;
 } else {
 self.smoke_visible = false;
 }
 self.update_visibility(true, cx);
 cx.notify();
 }

 pub(crate) fn smoke_drop(&mut self, key: &str, cx: &mut Context<Self>) {
 self.drop_webview(key);
 cx.notify();
 }

 fn drop_webview(&mut self, key: &str) {
 self.webviews.remove(key);
 self.warm.remove(key);
 if self.mirrored.as_deref() == Some(key) {
 self.mirrored = None;
 }
 }

 fn prune_deleted_webviews(&mut self, cx: &Context<Self>) {
 if self.smoke_active_key.is_some() {
 return;
 }
 let live = self.store.read(cx).preview_live_keys();
 let deleted = self
 .webviews
 .keys()
 .filter(|key| !live.contains(*key))
 .cloned()
 .collect::<Vec<_>>();
 for key in deleted {
 self.drop_webview(&key);
 }
 }

 /// Navigate one conversation's WebView to `url`, remembering it.
 fn navigate(&mut self, key: &str, url: &str, window: &mut Window, cx: &mut Context<Self>) {
 let url = normalize_url(url);
Expand DownExpand Up@@ -377,8 +445,7 @@ mod native {
 /// recreates a fresh webview on demand.
 fn close_panel(&mut self, cx: &mut Context<Self>) {
 if let Some(key) = self.active_key(cx) {
 self.webviews.remove(&key);
 self.warm.remove(&key);
 self.drop_webview(&key);
 self.store
 .update(cx, |store, cx| store.clear_preview_chrome(&key, cx));
 }
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(preview): --preview-smoke lifecycle harness#244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Tryanks
merged 3 commits into

from

Aug 22, 2026
 Merged


feat(preview): --preview-smoke lifecycle harness
#244
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
15cd94b

feat(preview): --preview-smoke lifecycle harness; prune webviews of d…


Tryanks Aug 22, 2026
39fd872

feat(preview): tee preview-smoke phase log to TCODE_SMOKE_LOG file


Tryanks Aug 22, 2026
bbc4bb5

fix(ui): allow preview_live_keys dead_code on Linux (preview compiled…


Tryanks Aug 22, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


27 changes: 27 additions & 0 deletions
crates/app/src/main.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,9 @@ use tcode_ui::{assets, settings};
use tcode_ui::overlay::{DialogActions, OverlayExt as _, OverlayHost};
use tcode_ui::widgets::button::{Button, ButtonVariants as _};

#[cfg(not(target_os = "linux"))]
mod preview_smoke;

const TCODE_THEME: &str = include_str!("../../../themes/tcode.json");

/// macOS vibrancy can be disabled with `TCODE_NO_VIBRANCY=1` as a diagnostic
Expand DownExpand Up@@ -169,6 +172,17 @@ fn handle_quit(
fn main() {
 env_logger::init();

 let preview_smoke = std::env::args().any(|arg| arg == "--preview-smoke");
 #[cfg(target_os = "linux")]
 if preview_smoke {
 use std::io::Write as _;
 eprintln!("preview-smoke: SKIP (no native webview)");
 let _ = std::io::stderr().flush();
 return;
 }
 #[cfg(not(target_os = "linux"))]
 let preview_smoke_watchdog = preview_smoke.then(preview_smoke::Watchdog::start);

 // A Finder/Dock launch inherits launchd's minimal PATH, under which none of
 // the provider CLIs resolve — import the login shell's environment first,
 // before anything (probes, sessions, the terminal) reads PATH. Must stay
Expand DownExpand Up@@ -330,6 +344,8 @@ fn main() {
 };

 cx.spawn(async move |cx| {
 let smoke_shell = std::rc::Rc::new(std::cell::RefCell::new(None));
 let smoke_shell_for_window = smoke_shell.clone();
 let window = cx
 .open_window(window_options, {
 let theme_store = workspace_store.clone();
Expand All@@ -349,6 +365,7 @@ fn main() {
 }
 let shell = cx
 .new(|cx| AppShell::new(workspace_store, window_state, window, cx));
 *smoke_shell_for_window.borrow_mut() = Some(shell.clone());
 cx.new(|cx| OverlayHost::new(shell, window, cx))
 }
 })
Expand All@@ -359,6 +376,16 @@ fn main() {
 window.activate_window();
 });

 #[cfg(not(target_os = "linux"))]
 if let Some(watchdog) = preview_smoke_watchdog {
 let shell = smoke_shell
 .borrow_mut()
 .take()
 .expect("preview smoke shell was not captured");
 preview_smoke::run(watchdog, shell, window, cx).await;
 return;
 }

 if open_latest {
 let _ = host.dispatch(Command::OpenLatestSession);
 for _ in 0..100 {
Expand Down

194 changes: 194 additions & 0 deletions
crates/app/src/preview_smoke.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,194 @@
use std::io::Write as _;
use std::sync::{
 Arc, Mutex,
 atomic::{AtomicBool, Ordering},
};
use std::time::Duration;

use gpui::{AsyncApp, Entity, WindowHandle, px, size};
use tcode_ui::{AppShell, overlay::OverlayHost};

const STEP_DELAY: Duration = Duration::from_millis(20);
const RAPID_DELAY: Duration = Duration::from_millis(5);
const WATCHDOG_TIMEOUT: Duration = Duration::from_secs(120);
const KEYS: [&str; 6] = [
 "preview-smoke-0",
 "preview-smoke-1",
 "preview-smoke-2",
 "preview-smoke-3",
 "preview-smoke-4",
 "preview-smoke-5",
];

fn log_line(message: &str) {
 eprintln!("{message}");
 let _ = std::io::stderr().flush();
 // Windows-subsystem builds have no console under a scheduled task, so the
 // on-device runner reads phases from this file instead of stderr.
 if let Ok(path) = std::env::var("TCODE_SMOKE_LOG")
 && let Ok(mut file) = std::fs::OpenOptions::new()
 .create(true)
 .append(true)
 .open(path)
 {
 let _ = writeln!(file, "{message}");
 let _ = file.sync_all();
 }
}

pub struct Watchdog {
 phase: Arc<Mutex<&'static str>>,
 finished: Arc<AtomicBool>,
}

impl Watchdog {
 pub fn start() -> Self {
 let phase = Arc::new(Mutex::new("startup"));
 let finished = Arc::new(AtomicBool::new(false));
 let watchdog_phase = phase.clone();
 let watchdog_finished = finished.clone();
 std::thread::spawn(move || {
 std::thread::sleep(WATCHDOG_TIMEOUT);
 if !watchdog_finished.load(Ordering::SeqCst) {
 let phase = *watchdog_phase
 .lock()
 .unwrap_or_else(|error| error.into_inner());
 log_line(&format!("preview-smoke: TIMEOUT phase {phase}"));
 std::process::exit(124);
 }
 });
 Self { phase, finished }
 }

 fn start_phase(&self, phase: &'static str) {
 *self.phase.lock().unwrap_or_else(|error| error.into_inner()) = phase;
 log_line(&format!("preview-smoke: phase {phase} start"));
 }

 fn finish_phase(&self, phase: &'static str) {
 log_line(&format!("preview-smoke: phase {phase} ok"));
 }

 fn pass(&self) {
 log_line("preview-smoke: PASS");
 self.finished.store(true, Ordering::SeqCst);
 }
}

async fn yield_for(cx: &AsyncApp, delay: Duration) {
 cx.background_executor().timer(delay).await;
}

pub async fn run(
 watchdog: Watchdog,
 shell: Entity<AppShell>,
 window: WindowHandle<OverlayHost>,
 cx: &mut AsyncApp,
) {
 watchdog.start_phase("create-first");
 window
 .update(cx, |_, window, cx| {
 shell.update(cx, |shell, cx| {
 shell.preview_smoke_create(KEYS[0], "about:blank", window, cx)
 })
 })
 .expect("preview smoke window closed during create-first")
 .expect("native preview webview creation failed");
 yield_for(cx, STEP_DELAY).await;
 watchdog.finish_phase("create-first");

 watchdog.start_phase("show-hide-churn");
 for _ in 0..20 {
 shell.update(cx, |shell, cx| shell.preview_smoke_set_visible(None, cx));
 yield_for(cx, RAPID_DELAY).await;
 shell.update(cx, |shell, cx| {
 shell.preview_smoke_set_visible(Some(KEYS[0]), cx)
 });
 yield_for(cx, RAPID_DELAY).await;
 }
 watchdog.finish_phase("show-hide-churn");

 watchdog.start_phase("multi-create");
 for key in &KEYS[1..] {
 window
 .update(cx, |_, window, cx| {
 shell.update(cx, |shell, cx| {
 shell.preview_smoke_create(key, "about:blank", window, cx)
 })
 })
 .expect("preview smoke window closed during multi-create")
 .expect("native preview webview creation failed");
 yield_for(cx, STEP_DELAY).await;
 }
 watchdog.finish_phase("multi-create");

 watchdog.start_phase("rapid-switch");
 for ix in 0..30 {
 shell.update(cx, |shell, cx| {
 shell.preview_smoke_set_visible(Some(KEYS[ix % KEYS.len()]), cx)
 });
 yield_for(cx, RAPID_DELAY).await;
 }
 watchdog.finish_phase("rapid-switch");

 watchdog.start_phase("resize-churn");
 for (width, height) in [(1100., 720.), (940., 640.), (1280., 820.), (1000., 700.)] {
 window
 .update(cx, |_, window, _| {
 window.resize(size(px(width), px(height)))
 })
 .expect("preview smoke window closed during resize-churn");
 yield_for(cx, STEP_DELAY).await;
 }
 watchdog.finish_phase("resize-churn");

 watchdog.start_phase("navigate-all");
 for (ix, key) in KEYS.iter().enumerate() {
 let url = format!("about:blank#preview-smoke-{ix}");
 window
 .update(cx, |_, window, cx| {
 shell.update(cx, |shell, cx| {
 shell.preview_smoke_create(key, &url, window, cx)
 })
 })
 .expect("preview smoke window closed during navigate-all")
 .expect("native preview navigation failed");
 yield_for(cx, STEP_DELAY).await;
 }
 watchdog.finish_phase("navigate-all");

 watchdog.start_phase("drop-one");
 shell.update(cx, |shell, cx| {
 shell.preview_smoke_set_visible(Some(KEYS[1]), cx);
 shell.preview_smoke_drop(KEYS[0], cx);
 });
 yield_for(cx, STEP_DELAY).await;
 watchdog.finish_phase("drop-one");

 watchdog.start_phase("drop-during-create");
 let close_window = window;
 window
 .update(cx, |_, window, cx| {
 shell.update(cx, |shell, cx| {
 cx.defer(move |cx| {
 let _ = close_window.update(cx, |_, window, _| window.remove_window());
 });
 shell.preview_smoke_create(
 "preview-smoke-drop-during-create",
 "about:blank#drop-during-create",
 window,
 cx,
 )
 })
 })
 .expect("preview smoke window closed before drop-during-create")
 .expect("native preview webview creation failed");
 drop(shell);
 yield_for(cx, STEP_DELAY).await;
 watchdog.finish_phase("drop-during-create");

 watchdog.start_phase("quit");
 watchdog.finish_phase("quit");
 watchdog.pass();
 cx.update(|cx| cx.quit());
}

73 changes: 70 additions & 3 deletions
crates/ui/src/preview_panel.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -130,6 +130,10 @@ mod native {
 /// WebView2 runtime). Set once; the tab then explains itself instead of
 /// retrying on every frame.
 webview_error: Option<String>,
 /// Harness-only routing override. Normal runs leave this unset and use
 /// the active conversation identity from `WorkspaceStore`.
 smoke_active_key: Option<String>,
 smoke_visible: bool,
 _subscriptions: Vec<Subscription>,
 }

Expand All@@ -148,6 +152,7 @@ mod native {
 // Native child views outlive GPUI layout nodes. Visibility
 // therefore follows WorkspaceStore directly, even while this
 // entity is no longer mounted in the right-panel tree.
 this.prune_deleted_webviews(cx);
 this.sync_visibility(cx);
 cx.notify();
 }),
Expand All@@ -164,6 +169,8 @@ mod native {
 dev_ports: Vec::new(),
 port_scan_generation: 0,
 webview_error: None,
 smoke_active_key: None,
 smoke_visible: false,
 _subscriptions: subscriptions,
 }
 }
Expand All@@ -172,6 +179,9 @@ mod native {
 /// Draft -> stored-thread commits retain the same session id, so move
 /// all cached browser state across that one key transition.
 fn active_key(&mut self, cx: &Context<Self>) -> Option<String> {
 if let Some(key) = &self.smoke_active_key {
 return Some(key.clone());
 }
 let current = self.store.read(cx).preview_active_identity();

 if let (Some((old_session, old_key)), Some((session, key))) =
Expand DownExpand Up@@ -224,7 +234,9 @@ mod native {

 fn update_visibility(&mut self, allow_show: bool, cx: &mut Context<Self>) {
 let active = self.active_key(cx);
 let visible = {
 let visible = if self.smoke_active_key.is_some() {
 self.smoke_visible.then_some(active).flatten()
 } else {
 let window_state = self.window_state.read(cx);
 visible_preview_key(
 active.as_deref(),
Expand DownExpand Up@@ -296,6 +308,62 @@ mod native {
 Some(webview)
 }

 pub(crate) fn smoke_create(
 &mut self,
 key: &str,
 url: &str,
 window: &mut Window,
 cx: &mut Context<Self>,
 ) -> Result<(), String> {
 self.smoke_active_key = Some(key.to_string());
 self.smoke_visible = true;
 self.navigate(key, url, window, cx);
 match &self.webview_error {
 Some(error) => Err(error.clone()),
 None => Ok(()),
 }
 }

 pub(crate) fn smoke_set_visible(&mut self, key: Option<&str>, cx: &mut Context<Self>) {
 if let Some(key) = key {
 self.smoke_active_key = Some(key.to_string());
 self.smoke_visible = true;
 } else {
 self.smoke_visible = false;
 }
 self.update_visibility(true, cx);
 cx.notify();
 }

 pub(crate) fn smoke_drop(&mut self, key: &str, cx: &mut Context<Self>) {
 self.drop_webview(key);
 cx.notify();
 }

 fn drop_webview(&mut self, key: &str) {
 self.webviews.remove(key);
 self.warm.remove(key);
 if self.mirrored.as_deref() == Some(key) {
 self.mirrored = None;
 }
 }

 fn prune_deleted_webviews(&mut self, cx: &Context<Self>) {
 if self.smoke_active_key.is_some() {
 return;
 }
 let live = self.store.read(cx).preview_live_keys();
 let deleted = self
 .webviews
 .keys()
 .filter(|key| !live.contains(*key))
 .cloned()
 .collect::<Vec<_>>();
 for key in deleted {
 self.drop_webview(&key);
 }
 }

 /// Navigate one conversation's WebView to `url`, remembering it.
 fn navigate(&mut self, key: &str, url: &str, window: &mut Window, cx: &mut Context<Self>) {
 let url = normalize_url(url);
Expand DownExpand Up@@ -377,8 +445,7 @@ mod native {
 /// recreates a fresh webview on demand.
 fn close_panel(&mut self, cx: &mut Context<Self>) {
 if let Some(key) = self.active_key(cx) {
 self.webviews.remove(&key);
 self.warm.remove(&key);
 self.drop_webview(&key);
 self.store
 .update(cx, |store, cx| store.clear_preview_chrome(&key, cx));
 }
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
feat(preview): --preview-smoke lifecycle harness#244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Tryanks
merged 3 commits into

from

Aug 22, 2026
 Merged


feat(preview): --preview-smoke lifecycle harness
#244
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
15cd94b

feat(preview): --preview-smoke lifecycle harness; prune webviews of d…


Tryanks Aug 22, 2026
39fd872

feat(preview): tee preview-smoke phase log to TCODE_SMOKE_LOG file


Tryanks Aug 22, 2026
bbc4bb5

fix(ui): allow preview_live_keys dead_code on Linux (preview compiled…


Tryanks Aug 22, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


27 changes: 27 additions & 0 deletions
crates/app/src/main.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,9 @@ use tcode_ui::{assets, settings};
use tcode_ui::overlay::{DialogActions, OverlayExt as _, OverlayHost};
use tcode_ui::widgets::button::{Button, ButtonVariants as _};

#[cfg(not(target_os = "linux"))]
mod preview_smoke;

const TCODE_THEME: &str = include_str!("../../../themes/tcode.json");

/// macOS vibrancy can be disabled with `TCODE_NO_VIBRANCY=1` as a diagnostic
Expand DownExpand Up@@ -169,6 +172,17 @@ fn handle_quit(
fn main() {
 env_logger::init();

 let preview_smoke = std::env::args().any(|arg| arg == "--preview-smoke");
 #[cfg(target_os = "linux")]
 if preview_smoke {
 use std::io::Write as _;
 eprintln!("preview-smoke: SKIP (no native webview)");
 let _ = std::io::stderr().flush();
 return;
 }
 #[cfg(not(target_os = "linux"))]
 let preview_smoke_watchdog = preview_smoke.then(preview_smoke::Watchdog::start);

 // A Finder/Dock launch inherits launchd's minimal PATH, under which none of
 // the provider CLIs resolve — import the login shell's environment first,
 // before anything (probes, sessions, the terminal) reads PATH. Must stay
Expand DownExpand Up@@ -330,6 +344,8 @@ fn main() {
 };

 cx.spawn(async move |cx| {
 let smoke_shell = std::rc::Rc::new(std::cell::RefCell::new(None));
 let smoke_shell_for_window = smoke_shell.clone();
 let window = cx
 .open_window(window_options, {
 let theme_store = workspace_store.clone();
Expand All@@ -349,6 +365,7 @@ fn main() {
 }
 let shell = cx
 .new(|cx| AppShell::new(workspace_store, window_state, window, cx));
 *smoke_shell_for_window.borrow_mut() = Some(shell.clone());
 cx.new(|cx| OverlayHost::new(shell, window, cx))
 }
 })
Expand All@@ -359,6 +376,16 @@ fn main() {
 window.activate_window();
 });

 #[cfg(not(target_os = "linux"))]
 if let Some(watchdog) = preview_smoke_watchdog {
 let shell = smoke_shell
 .borrow_mut()
 .take()
 .expect("preview smoke shell was not captured");
 preview_smoke::run(watchdog, shell, window, cx).await;
 return;
 }

 if open_latest {
 let _ = host.dispatch(Command::OpenLatestSession);
 for _ in 0..100 {
Expand Down

194 changes: 194 additions & 0 deletions
crates/app/src/preview_smoke.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,194 @@
use std::io::Write as _;
use std::sync::{
 Arc, Mutex,
 atomic::{AtomicBool, Ordering},
};
use std::time::Duration;

use gpui::{AsyncApp, Entity, WindowHandle, px, size};
use tcode_ui::{AppShell, overlay::OverlayHost};

const STEP_DELAY: Duration = Duration::from_millis(20);
const RAPID_DELAY: Duration = Duration::from_millis(5);
const WATCHDOG_TIMEOUT: Duration = Duration::from_secs(120);
const KEYS: [&str; 6] = [
 "preview-smoke-0",
 "preview-smoke-1",
 "preview-smoke-2",
 "preview-smoke-3",
 "preview-smoke-4",
 "preview-smoke-5",
];

fn log_line(message: &str) {
 eprintln!("{message}");
 let _ = std::io::stderr().flush();
 // Windows-subsystem builds have no console under a scheduled task, so the
 // on-device runner reads phases from this file instead of stderr.
 if let Ok(path) = std::env::var("TCODE_SMOKE_LOG")
 && let Ok(mut file) = std::fs::OpenOptions::new()
 .create(true)
 .append(true)
 .open(path)
 {
 let _ = writeln!(file, "{message}");
 let _ = file.sync_all();
 }
}

pub struct Watchdog {
 phase: Arc<Mutex<&'static str>>,
 finished: Arc<AtomicBool>,
}

impl Watchdog {
 pub fn start() -> Self {
 let phase = Arc::new(Mutex::new("startup"));
 let finished = Arc::new(AtomicBool::new(false));
 let watchdog_phase = phase.clone();
 let watchdog_finished = finished.clone();
 std::thread::spawn(move || {
 std::thread::sleep(WATCHDOG_TIMEOUT);
 if !watchdog_finished.load(Ordering::SeqCst) {
 let phase = *watchdog_phase
 .lock()
 .unwrap_or_else(|error| error.into_inner());
 log_line(&format!("preview-smoke: TIMEOUT phase {phase}"));
 std::process::exit(124);
 }
 });
 Self { phase, finished }
 }

 fn start_phase(&self, phase: &'static str) {
 *self.phase.lock().unwrap_or_else(|error| error.into_inner()) = phase;
 log_line(&format!("preview-smoke: phase {phase} start"));
 }

 fn finish_phase(&self, phase: &'static str) {
 log_line(&format!("preview-smoke: phase {phase} ok"));
 }

 fn pass(&self) {
 log_line("preview-smoke: PASS");
 self.finished.store(true, Ordering::SeqCst);
 }
}

async fn yield_for(cx: &AsyncApp, delay: Duration) {
 cx.background_executor().timer(delay).await;
}

pub async fn run(
 watchdog: Watchdog,
 shell: Entity<AppShell>,
 window: WindowHandle<OverlayHost>,
 cx: &mut AsyncApp,
) {
 watchdog.start_phase("create-first");
 window
 .update(cx, |_, window, cx| {
 shell.update(cx, |shell, cx| {
 shell.preview_smoke_create(KEYS[0], "about:blank", window, cx)
 })
 })
 .expect("preview smoke window closed during create-first")
 .expect("native preview webview creation failed");
 yield_for(cx, STEP_DELAY).await;
 watchdog.finish_phase("create-first");

 watchdog.start_phase("show-hide-churn");
 for _ in 0..20 {
 shell.update(cx, |shell, cx| shell.preview_smoke_set_visible(None, cx));
 yield_for(cx, RAPID_DELAY).await;
 shell.update(cx, |shell, cx| {
 shell.preview_smoke_set_visible(Some(KEYS[0]), cx)
 });
 yield_for(cx, RAPID_DELAY).await;
 }
 watchdog.finish_phase("show-hide-churn");

 watchdog.start_phase("multi-create");
 for key in &KEYS[1..] {
 window
 .update(cx, |_, window, cx| {
 shell.update(cx, |shell, cx| {
 shell.preview_smoke_create(key, "about:blank", window, cx)
 })
 })
 .expect("preview smoke window closed during multi-create")
 .expect("native preview webview creation failed");
 yield_for(cx, STEP_DELAY).await;
 }
 watchdog.finish_phase("multi-create");

 watchdog.start_phase("rapid-switch");
 for ix in 0..30 {
 shell.update(cx, |shell, cx| {
 shell.preview_smoke_set_visible(Some(KEYS[ix % KEYS.len()]), cx)
 });
 yield_for(cx, RAPID_DELAY).await;
 }
 watchdog.finish_phase("rapid-switch");

 watchdog.start_phase("resize-churn");
 for (width, height) in [(1100., 720.), (940., 640.), (1280., 820.), (1000., 700.)] {
 window
 .update(cx, |_, window, _| {
 window.resize(size(px(width), px(height)))
 })
 .expect("preview smoke window closed during resize-churn");
 yield_for(cx, STEP_DELAY).await;
 }
 watchdog.finish_phase("resize-churn");

 watchdog.start_phase("navigate-all");
 for (ix, key) in KEYS.iter().enumerate() {
 let url = format!("about:blank#preview-smoke-{ix}");
 window
 .update(cx, |_, window, cx| {
 shell.update(cx, |shell, cx| {
 shell.preview_smoke_create(key, &url, window, cx)
 })
 })
 .expect("preview smoke window closed during navigate-all")
 .expect("native preview navigation failed");
 yield_for(cx, STEP_DELAY).await;
 }
 watchdog.finish_phase("navigate-all");

 watchdog.start_phase("drop-one");
 shell.update(cx, |shell, cx| {
 shell.preview_smoke_set_visible(Some(KEYS[1]), cx);
 shell.preview_smoke_drop(KEYS[0], cx);
 });
 yield_for(cx, STEP_DELAY).await;
 watchdog.finish_phase("drop-one");

 watchdog.start_phase("drop-during-create");
 let close_window = window;
 window
 .update(cx, |_, window, cx| {
 shell.update(cx, |shell, cx| {
 cx.defer(move |cx| {
 let _ = close_window.update(cx, |_, window, _| window.remove_window());
 });
 shell.preview_smoke_create(
 "preview-smoke-drop-during-create",
 "about:blank#drop-during-create",
 window,
 cx,
 )
 })
 })
 .expect("preview smoke window closed before drop-during-create")
 .expect("native preview webview creation failed");
 drop(shell);
 yield_for(cx, STEP_DELAY).await;
 watchdog.finish_phase("drop-during-create");

 watchdog.start_phase("quit");
 watchdog.finish_phase("quit");
 watchdog.pass();
 cx.update(|cx| cx.quit());
}

73 changes: 70 additions & 3 deletions
crates/ui/src/preview_panel.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -130,6 +130,10 @@ mod native {
 /// WebView2 runtime). Set once; the tab then explains itself instead of
 /// retrying on every frame.
 webview_error: Option<String>,
 /// Harness-only routing override. Normal runs leave this unset and use
 /// the active conversation identity from `WorkspaceStore`.
 smoke_active_key: Option<String>,
 smoke_visible: bool,
 _subscriptions: Vec<Subscription>,
 }

Expand All@@ -148,6 +152,7 @@ mod native {
 // Native child views outlive GPUI layout nodes. Visibility
 // therefore follows WorkspaceStore directly, even while this
 // entity is no longer mounted in the right-panel tree.
 this.prune_deleted_webviews(cx);
 this.sync_visibility(cx);
 cx.notify();
 }),
Expand All@@ -164,6 +169,8 @@ mod native {
 dev_ports: Vec::new(),
 port_scan_generation: 0,
 webview_error: None,
 smoke_active_key: None,
 smoke_visible: false,
 _subscriptions: subscriptions,
 }
 }
Expand All@@ -172,6 +179,9 @@ mod native {
 /// Draft -> stored-thread commits retain the same session id, so move
 /// all cached browser state across that one key transition.
 fn active_key(&mut self, cx: &Context<Self>) -> Option<String> {
 if let Some(key) = &self.smoke_active_key {
 return Some(key.clone());
 }
 let current = self.store.read(cx).preview_active_identity();

 if let (Some((old_session, old_key)), Some((session, key))) =
Expand DownExpand Up@@ -224,7 +234,9 @@ mod native {

 fn update_visibility(&mut self, allow_show: bool, cx: &mut Context<Self>) {
 let active = self.active_key(cx);
 let visible = {
 let visible = if self.smoke_active_key.is_some() {
 self.smoke_visible.then_some(active).flatten()
 } else {
 let window_state = self.window_state.read(cx);
 visible_preview_key(
 active.as_deref(),
Expand DownExpand Up@@ -296,6 +308,62 @@ mod native {
 Some(webview)
 }

 pub(crate) fn smoke_create(
 &mut self,
 key: &str,
 url: &str,
 window: &mut Window,
 cx: &mut Context<Self>,
 ) -> Result<(), String> {
 self.smoke_active_key = Some(key.to_string());
 self.smoke_visible = true;
 self.navigate(key, url, window, cx);
 match &self.webview_error {
 Some(error) => Err(error.clone()),
 None => Ok(()),
 }
 }

 pub(crate) fn smoke_set_visible(&mut self, key: Option<&str>, cx: &mut Context<Self>) {
 if let Some(key) = key {
 self.smoke_active_key = Some(key.to_string());
 self.smoke_visible = true;
 } else {
 self.smoke_visible = false;
 }
 self.update_visibility(true, cx);
 cx.notify();
 }

 pub(crate) fn smoke_drop(&mut self, key: &str, cx: &mut Context<Self>) {
 self.drop_webview(key);
 cx.notify();
 }

 fn drop_webview(&mut self, key: &str) {
 self.webviews.remove(key);
 self.warm.remove(key);
 if self.mirrored.as_deref() == Some(key) {
 self.mirrored = None;
 }
 }

 fn prune_deleted_webviews(&mut self, cx: &Context<Self>) {
 if self.smoke_active_key.is_some() {
 return;
 }
 let live = self.store.read(cx).preview_live_keys();
 let deleted = self
 .webviews
 .keys()
 .filter(|key| !live.contains(*key))
 .cloned()
 .collect::<Vec<_>>();
 for key in deleted {
 self.drop_webview(&key);
 }
 }

 /// Navigate one conversation's WebView to `url`, remembering it.
 fn navigate(&mut self, key: &str, url: &str, window: &mut Window, cx: &mut Context<Self>) {
 let url = normalize_url(url);
Expand DownExpand Up@@ -377,8 +445,7 @@ mod native {
 /// recreates a fresh webview on demand.
 fn close_panel(&mut self, cx: &mut Context<Self>) {
 if let Some(key) = self.active_key(cx) {
 self.webviews.remove(&key);
 self.warm.remove(&key);
 self.drop_webview(&key);
 self.store
 .update(cx, |store, cx| store.clear_preview_chrome(&key, cx));
 }
Expand Down
Loading