Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions crates/agent/src/lib.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,6 +45,8 @@ pub struct Caps {
pub options_apply_live: bool,
pub live_approval_mode_switch: bool,
pub live_option_push: LiveOptionPush,
/// Whether this adapter can attach tcode's HTTP MCP servers to a session.
pub mcp_servers: bool,
pub preview_mcp: bool,
pub launch_args: bool,
pub downgrade_approval_without_native_approvals: bool,
Expand DownExpand Up@@ -91,6 +93,7 @@ impl ProviderKind {
options_apply_live: false,
live_approval_mode_switch: true,
live_option_push: LiveOptionPush::None,
mcp_servers: true,
preview_mcp: true,
launch_args: true,
downgrade_approval_without_native_approvals: false,
Expand All@@ -106,6 +109,7 @@ impl ProviderKind {
options_apply_live: false,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::None,
mcp_servers: true,
preview_mcp: true,
launch_args: false,
downgrade_approval_without_native_approvals: false,
Expand All@@ -121,6 +125,9 @@ impl ProviderKind {
options_apply_live: true,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::All,
// ACP support is negotiated per agent; capable agents receive
// every tcode HTTP MCP registration in session/new or load.
mcp_servers: true,
preview_mcp: true,
launch_args: true,
downgrade_approval_without_native_approvals: false,
Expand All@@ -136,6 +143,7 @@ impl ProviderKind {
options_apply_live: false,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::Only(&["reasoningEffort"]),
mcp_servers: false,
preview_mcp: false,
launch_args: true,
downgrade_approval_without_native_approvals: true,
Expand All@@ -151,6 +159,7 @@ impl ProviderKind {
options_apply_live: false,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::None,
mcp_servers: true,
preview_mcp: true,
launch_args: true,
downgrade_approval_without_native_approvals: false,
Expand DownExpand Up@@ -188,6 +197,7 @@ mod provider_caps_tests {
options_apply_live: false,
live_approval_mode_switch: true,
live_option_push: LiveOptionPush::None,
mcp_servers: true,
preview_mcp: true,
launch_args: true,
downgrade_approval_without_native_approvals: false,
Expand All@@ -206,6 +216,7 @@ mod provider_caps_tests {
options_apply_live: false,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::None,
mcp_servers: true,
preview_mcp: true,
launch_args: false,
downgrade_approval_without_native_approvals: false,
Expand All@@ -224,6 +235,7 @@ mod provider_caps_tests {
options_apply_live: true,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::All,
mcp_servers: true,
preview_mcp: true,
launch_args: true,
downgrade_approval_without_native_approvals: false,
Expand All@@ -242,6 +254,7 @@ mod provider_caps_tests {
options_apply_live: false,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::Only(&["reasoningEffort"]),
mcp_servers: false,
preview_mcp: false,
launch_args: true,
downgrade_approval_without_native_approvals: true,
Expand All@@ -260,6 +273,7 @@ mod provider_caps_tests {
options_apply_live: false,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::None,
mcp_servers: true,
preview_mcp: true,
launch_args: true,
downgrade_approval_without_native_approvals: false,
Expand All@@ -269,6 +283,12 @@ mod provider_caps_tests {
}
);
}

#[test]
fn pi_cannot_attach_mcp_servers_but_claude_can() {
assert!(!ProviderKind::Pi.caps().mcp_servers);
assert!(ProviderKind::ClaudeCode.caps().mcp_servers);
}
}

/// Registry agents we never surface because they duplicate richer native
Expand Down
8 changes: 8 additions & 0 deletions crates/ui/src/composer/components/pickers.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -776,6 +776,14 @@ fn render_model_row(
.text_color(muted)
.child(glyph.xsmall())
.child(label)
})
.when(!row.provider.caps().mcp_servers, |this| {
this.child(
div()
.text_size(px(11.))
.text_color(muted)
.child(crate::tr!("providers.mcp_unavailable")),
)
}),
)
.when(index < 9, |this| {
Expand Down
10 changes: 9 additions & 1 deletion crates/ui/src/provider_card.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -167,7 +167,15 @@ impl ProviderCard {
.min_w_0()
.gap_0p5()
.child(title)
.child(self.render_summary_line(&summary, cx)),
.child(self.render_summary_line(&summary, cx))
.when(!provider.caps().mcp_servers, |this| {
this.child(
div()
.text_size(px(11.))
.text_color(muted)
.child(crate::tr!("providers.mcp_unavailable")),
)
}),
)
.tooltip({
let name = name.clone();
Expand Down
24 changes: 22 additions & 2 deletions crates/ui/src/runtime_event.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,6 +11,7 @@ use crate::toast::ToastKind;
pub(super) enum RuntimeEventSeverity {
Error,
Success,
Warning,
}

#[derive(Clone, Debug, PartialEq, Eq)]
Expand DownExpand Up@@ -138,7 +139,12 @@ pub(super) fn present_runtime_event(event: &RuntimeEvent) -> PresentedRuntimeEve
}
_ => format!("Unknown runtime notice: {notice:?}"),
};
(RuntimeEventSeverity::Success, message)
let severity = if matches!(notice, RuntimeNotice::ProviderMessage(_)) {
RuntimeEventSeverity::Warning
} else {
RuntimeEventSeverity::Success
};
(severity, message)
}
RuntimeEvent::Toast(_) => unreachable!("rich toasts use present_runtime_toast"),
RuntimeEvent::Effect(_) => unreachable!("runtime effects are not presentable"),
Expand DownExpand Up@@ -418,7 +424,12 @@ mod tests {
}
for notice in &notices {
let presented = present_runtime_event(&RuntimeEvent::Notice(notice.clone()));
assert_eq!(presented.severity, RuntimeEventSeverity::Success);
let expected = if matches!(notice, RuntimeNotice::ProviderMessage(_)) {
RuntimeEventSeverity::Warning
} else {
RuntimeEventSeverity::Success
};
assert_eq!(presented.severity, expected);
assert!(!presented.message.is_empty());
}
for toast in &toasts {
Expand DownExpand Up@@ -570,4 +581,13 @@ mod tests {

crate::set_locale(crate::LANGUAGE_ENGLISH);
}

#[test]
fn provider_warning_notice_is_presented_as_warning() {
let presented = present_runtime_event(&RuntimeEvent::Notice(
RuntimeNotice::ProviderMessage("pi MCP tools unavailable".into()),
));

assert_eq!(presented.severity, RuntimeEventSeverity::Warning);
}
}
1 change: 1 addition & 0 deletions crates/ui/src/shell.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -264,6 +264,7 @@ impl AppShell {
let notification = match presented.severity {
RuntimeEventSeverity::Error => Notification::error(presented.message),
RuntimeEventSeverity::Success => Notification::success(presented.message),
RuntimeEventSeverity::Warning => Notification::warning(presented.message),
};
window.push_notification(notification, cx);
return;
Expand Down
13 changes: 8 additions & 5 deletions docs/computer-use.md
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
# Computer use

tcode gives every provider (Claude Code, Codex, and all ACP agents that advertise
`mcpCapabilities.http`) a set of desktop computer-use tools, served by the in-process
`tcode_computer_use` MCP server. The design follows
tcode gives MCP-capable providers (Claude Code, Codex, OpenCode, and ACP agents that
advertise `mcpCapabilities.http`) a set of desktop computer-use tools, served by the
in-process `tcode_computer_use` MCP server. pi has no MCP client, so its provider card
and model-picker rows identify computer use, preview, and orchestrate as unavailable
before a session starts. The design follows
[pi-computer-use](https://github.com/injaneity/pi-computer-use): accessibility-tree-first,
state-scoped observation, transactional actions — not blind pixel clicking.

Expand DownExpand Up@@ -50,8 +52,9 @@ simplified successor-diff heuristic.
- `permissions.rs` — TCC checks/requests (see below), public API also consumed by the
settings UI.
- Registration: `SessionOptions.computer_use_server: Option<McpRegistration>` threaded exactly
like `orchestrate_server` — Claude via `--mcp-config`, Codex via `-c mcp_servers.*`, ACP via
`session/new` `mcpServers` (HTTP-capability-gated). Enabled/disabled per
like `orchestrate_server` — Claude via `--mcp-config`, Codex via `-c mcp_servers.*`, OpenCode
via its server config, and ACP via `session/new` `mcpServers` (HTTP-capability-gated).
Enabled/disabled per
`Settings.computer_use.enabled`.

Unlike pi-computer-use, tcode needs **no helper app**: tcode is itself a signed `.app`, so
Expand Down
1 change: 1 addition & 0 deletions locales/en.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -329,6 +329,7 @@ providers:
enable: "Enable %{name}"
reveal_email: "Click to reveal email"
hide_email: "Click to hide email"
mcp_unavailable: "MCP tools (computer use / preview / orchestrate) unavailable"
# Status dot + summary copy (T3 §2)
status:
checking: "Checking provider status"
Expand Down
1 change: 1 addition & 0 deletions locales/zh-CN.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -328,6 +328,7 @@ providers:
enable: "启用 %{name}"
reveal_email: "点击显示邮箱"
hide_email: "点击隐藏邮箱"
mcp_unavailable: "MCP 工具(电脑操作 / 预览 / 编排)不可用"
status:
checking: "正在检查提供方状态"
checking_detail: "正在等待服务返回安装与认证详情。"
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions crates/agent/src/lib.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,6 +45,8 @@ pub struct Caps {
pub options_apply_live: bool,
pub live_approval_mode_switch: bool,
pub live_option_push: LiveOptionPush,
/// Whether this adapter can attach tcode's HTTP MCP servers to a session.
pub mcp_servers: bool,
pub preview_mcp: bool,
pub launch_args: bool,
pub downgrade_approval_without_native_approvals: bool,
Expand DownExpand Up@@ -91,6 +93,7 @@ impl ProviderKind {
options_apply_live: false,
live_approval_mode_switch: true,
live_option_push: LiveOptionPush::None,
mcp_servers: true,
preview_mcp: true,
launch_args: true,
downgrade_approval_without_native_approvals: false,
Expand All@@ -106,6 +109,7 @@ impl ProviderKind {
options_apply_live: false,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::None,
mcp_servers: true,
preview_mcp: true,
launch_args: false,
downgrade_approval_without_native_approvals: false,
Expand All@@ -121,6 +125,9 @@ impl ProviderKind {
options_apply_live: true,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::All,
// ACP support is negotiated per agent; capable agents receive
// every tcode HTTP MCP registration in session/new or load.
mcp_servers: true,
preview_mcp: true,
launch_args: true,
downgrade_approval_without_native_approvals: false,
Expand All@@ -136,6 +143,7 @@ impl ProviderKind {
options_apply_live: false,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::Only(&["reasoningEffort"]),
mcp_servers: false,
preview_mcp: false,
launch_args: true,
downgrade_approval_without_native_approvals: true,
Expand All@@ -151,6 +159,7 @@ impl ProviderKind {
options_apply_live: false,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::None,
mcp_servers: true,
preview_mcp: true,
launch_args: true,
downgrade_approval_without_native_approvals: false,
Expand DownExpand Up@@ -188,6 +197,7 @@ mod provider_caps_tests {
options_apply_live: false,
live_approval_mode_switch: true,
live_option_push: LiveOptionPush::None,
mcp_servers: true,
preview_mcp: true,
launch_args: true,
downgrade_approval_without_native_approvals: false,
Expand All@@ -206,6 +216,7 @@ mod provider_caps_tests {
options_apply_live: false,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::None,
mcp_servers: true,
preview_mcp: true,
launch_args: false,
downgrade_approval_without_native_approvals: false,
Expand All@@ -224,6 +235,7 @@ mod provider_caps_tests {
options_apply_live: true,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::All,
mcp_servers: true,
preview_mcp: true,
launch_args: true,
downgrade_approval_without_native_approvals: false,
Expand All@@ -242,6 +254,7 @@ mod provider_caps_tests {
options_apply_live: false,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::Only(&["reasoningEffort"]),
mcp_servers: false,
preview_mcp: false,
launch_args: true,
downgrade_approval_without_native_approvals: true,
Expand All@@ -260,6 +273,7 @@ mod provider_caps_tests {
options_apply_live: false,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::None,
mcp_servers: true,
preview_mcp: true,
launch_args: true,
downgrade_approval_without_native_approvals: false,
Expand All@@ -269,6 +283,12 @@ mod provider_caps_tests {
}
);
}

#[test]
fn pi_cannot_attach_mcp_servers_but_claude_can() {
assert!(!ProviderKind::Pi.caps().mcp_servers);
assert!(ProviderKind::ClaudeCode.caps().mcp_servers);
}
}

/// Registry agents we never surface because they duplicate richer native
Expand Down
8 changes: 8 additions & 0 deletions crates/ui/src/composer/components/pickers.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -776,6 +776,14 @@ fn render_model_row(
.text_color(muted)
.child(glyph.xsmall())
.child(label)
})
.when(!row.provider.caps().mcp_servers, |this| {
this.child(
div()
.text_size(px(11.))
.text_color(muted)
.child(crate::tr!("providers.mcp_unavailable")),
)
}),
)
.when(index < 9, |this| {
Expand Down
10 changes: 9 additions & 1 deletion crates/ui/src/provider_card.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -167,7 +167,15 @@ impl ProviderCard {
.min_w_0()
.gap_0p5()
.child(title)
.child(self.render_summary_line(&summary, cx)),
.child(self.render_summary_line(&summary, cx))
.when(!provider.caps().mcp_servers, |this| {
this.child(
div()
.text_size(px(11.))
.text_color(muted)
.child(crate::tr!("providers.mcp_unavailable")),
)
}),
)
.tooltip({
let name = name.clone();
Expand Down
24 changes: 22 additions & 2 deletions crates/ui/src/runtime_event.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,6 +11,7 @@ use crate::toast::ToastKind;
pub(super) enum RuntimeEventSeverity {
Error,
Success,
Warning,
}

#[derive(Clone, Debug, PartialEq, Eq)]
Expand DownExpand Up@@ -138,7 +139,12 @@ pub(super) fn present_runtime_event(event: &RuntimeEvent) -> PresentedRuntimeEve
}
_ => format!("Unknown runtime notice: {notice:?}"),
};
(RuntimeEventSeverity::Success, message)
let severity = if matches!(notice, RuntimeNotice::ProviderMessage(_)) {
RuntimeEventSeverity::Warning
} else {
RuntimeEventSeverity::Success
};
(severity, message)
}
RuntimeEvent::Toast(_) => unreachable!("rich toasts use present_runtime_toast"),
RuntimeEvent::Effect(_) => unreachable!("runtime effects are not presentable"),
Expand DownExpand Up@@ -418,7 +424,12 @@ mod tests {
}
for notice in &notices {
let presented = present_runtime_event(&RuntimeEvent::Notice(notice.clone()));
assert_eq!(presented.severity, RuntimeEventSeverity::Success);
let expected = if matches!(notice, RuntimeNotice::ProviderMessage(_)) {
RuntimeEventSeverity::Warning
} else {
RuntimeEventSeverity::Success
};
assert_eq!(presented.severity, expected);
assert!(!presented.message.is_empty());
}
for toast in &toasts {
Expand DownExpand Up@@ -570,4 +581,13 @@ mod tests {

crate::set_locale(crate::LANGUAGE_ENGLISH);
}

#[test]
fn provider_warning_notice_is_presented_as_warning() {
let presented = present_runtime_event(&RuntimeEvent::Notice(
RuntimeNotice::ProviderMessage("pi MCP tools unavailable".into()),
));

assert_eq!(presented.severity, RuntimeEventSeverity::Warning);
}
}
1 change: 1 addition & 0 deletions crates/ui/src/shell.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -264,6 +264,7 @@ impl AppShell {
let notification = match presented.severity {
RuntimeEventSeverity::Error => Notification::error(presented.message),
RuntimeEventSeverity::Success => Notification::success(presented.message),
RuntimeEventSeverity::Warning => Notification::warning(presented.message),
};
window.push_notification(notification, cx);
return;
Expand Down
13 changes: 8 additions & 5 deletions docs/computer-use.md
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
# Computer use

tcode gives every provider (Claude Code, Codex, and all ACP agents that advertise
`mcpCapabilities.http`) a set of desktop computer-use tools, served by the in-process
`tcode_computer_use` MCP server. The design follows
tcode gives MCP-capable providers (Claude Code, Codex, OpenCode, and ACP agents that
advertise `mcpCapabilities.http`) a set of desktop computer-use tools, served by the
in-process `tcode_computer_use` MCP server. pi has no MCP client, so its provider card
and model-picker rows identify computer use, preview, and orchestrate as unavailable
before a session starts. The design follows
[pi-computer-use](https://github.com/injaneity/pi-computer-use): accessibility-tree-first,
state-scoped observation, transactional actions — not blind pixel clicking.

Expand DownExpand Up@@ -50,8 +52,9 @@ simplified successor-diff heuristic.
- `permissions.rs` — TCC checks/requests (see below), public API also consumed by the
settings UI.
- Registration: `SessionOptions.computer_use_server: Option<McpRegistration>` threaded exactly
like `orchestrate_server` — Claude via `--mcp-config`, Codex via `-c mcp_servers.*`, ACP via
`session/new` `mcpServers` (HTTP-capability-gated). Enabled/disabled per
like `orchestrate_server` — Claude via `--mcp-config`, Codex via `-c mcp_servers.*`, OpenCode
via its server config, and ACP via `session/new` `mcpServers` (HTTP-capability-gated).
Enabled/disabled per
`Settings.computer_use.enabled`.

Unlike pi-computer-use, tcode needs **no helper app**: tcode is itself a signed `.app`, so
Expand Down
1 change: 1 addition & 0 deletions locales/en.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -329,6 +329,7 @@ providers:
enable: "Enable %{name}"
reveal_email: "Click to reveal email"
hide_email: "Click to hide email"
mcp_unavailable: "MCP tools (computer use / preview / orchestrate) unavailable"
# Status dot + summary copy (T3 §2)
status:
checking: "Checking provider status"
Expand Down
1 change: 1 addition & 0 deletions locales/zh-CN.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -328,6 +328,7 @@ providers:
enable: "启用 %{name}"
reveal_email: "点击显示邮箱"
hide_email: "点击隐藏邮箱"
mcp_unavailable: "MCP 工具(电脑操作 / 预览 / 编排)不可用"
status:
checking: "正在检查提供方状态"
checking_detail: "正在等待服务返回安装与认证详情。"
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions crates/agent/src/lib.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,6 +45,8 @@ pub struct Caps {
pub options_apply_live: bool,
pub live_approval_mode_switch: bool,
pub live_option_push: LiveOptionPush,
/// Whether this adapter can attach tcode's HTTP MCP servers to a session.
pub mcp_servers: bool,
pub preview_mcp: bool,
pub launch_args: bool,
pub downgrade_approval_without_native_approvals: bool,
Expand DownExpand Up@@ -91,6 +93,7 @@ impl ProviderKind {
options_apply_live: false,
live_approval_mode_switch: true,
live_option_push: LiveOptionPush::None,
mcp_servers: true,
preview_mcp: true,
launch_args: true,
downgrade_approval_without_native_approvals: false,
Expand All@@ -106,6 +109,7 @@ impl ProviderKind {
options_apply_live: false,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::None,
mcp_servers: true,
preview_mcp: true,
launch_args: false,
downgrade_approval_without_native_approvals: false,
Expand All@@ -121,6 +125,9 @@ impl ProviderKind {
options_apply_live: true,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::All,
// ACP support is negotiated per agent; capable agents receive
// every tcode HTTP MCP registration in session/new or load.
mcp_servers: true,
preview_mcp: true,
launch_args: true,
downgrade_approval_without_native_approvals: false,
Expand All@@ -136,6 +143,7 @@ impl ProviderKind {
options_apply_live: false,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::Only(&["reasoningEffort"]),
mcp_servers: false,
preview_mcp: false,
launch_args: true,
downgrade_approval_without_native_approvals: true,
Expand All@@ -151,6 +159,7 @@ impl ProviderKind {
options_apply_live: false,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::None,
mcp_servers: true,
preview_mcp: true,
launch_args: true,
downgrade_approval_without_native_approvals: false,
Expand DownExpand Up@@ -188,6 +197,7 @@ mod provider_caps_tests {
options_apply_live: false,
live_approval_mode_switch: true,
live_option_push: LiveOptionPush::None,
mcp_servers: true,
preview_mcp: true,
launch_args: true,
downgrade_approval_without_native_approvals: false,
Expand All@@ -206,6 +216,7 @@ mod provider_caps_tests {
options_apply_live: false,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::None,
mcp_servers: true,
preview_mcp: true,
launch_args: false,
downgrade_approval_without_native_approvals: false,
Expand All@@ -224,6 +235,7 @@ mod provider_caps_tests {
options_apply_live: true,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::All,
mcp_servers: true,
preview_mcp: true,
launch_args: true,
downgrade_approval_without_native_approvals: false,
Expand All@@ -242,6 +254,7 @@ mod provider_caps_tests {
options_apply_live: false,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::Only(&["reasoningEffort"]),
mcp_servers: false,
preview_mcp: false,
launch_args: true,
downgrade_approval_without_native_approvals: true,
Expand All@@ -260,6 +273,7 @@ mod provider_caps_tests {
options_apply_live: false,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::None,
mcp_servers: true,
preview_mcp: true,
launch_args: true,
downgrade_approval_without_native_approvals: false,
Expand All@@ -269,6 +283,12 @@ mod provider_caps_tests {
}
);
}

#[test]
fn pi_cannot_attach_mcp_servers_but_claude_can() {
assert!(!ProviderKind::Pi.caps().mcp_servers);
assert!(ProviderKind::ClaudeCode.caps().mcp_servers);
}
}

/// Registry agents we never surface because they duplicate richer native
Expand Down
8 changes: 8 additions & 0 deletions crates/ui/src/composer/components/pickers.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -776,6 +776,14 @@ fn render_model_row(
.text_color(muted)
.child(glyph.xsmall())
.child(label)
})
.when(!row.provider.caps().mcp_servers, |this| {
this.child(
div()
.text_size(px(11.))
.text_color(muted)
.child(crate::tr!("providers.mcp_unavailable")),
)
}),
)
.when(index < 9, |this| {
Expand Down
10 changes: 9 additions & 1 deletion crates/ui/src/provider_card.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -167,7 +167,15 @@ impl ProviderCard {
.min_w_0()
.gap_0p5()
.child(title)
.child(self.render_summary_line(&summary, cx)),
.child(self.render_summary_line(&summary, cx))
.when(!provider.caps().mcp_servers, |this| {
this.child(
div()
.text_size(px(11.))
.text_color(muted)
.child(crate::tr!("providers.mcp_unavailable")),
)
}),
)
.tooltip({
let name = name.clone();
Expand Down
24 changes: 22 additions & 2 deletions crates/ui/src/runtime_event.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,6 +11,7 @@ use crate::toast::ToastKind;
pub(super) enum RuntimeEventSeverity {
Error,
Success,
Warning,
}

#[derive(Clone, Debug, PartialEq, Eq)]
Expand DownExpand Up@@ -138,7 +139,12 @@ pub(super) fn present_runtime_event(event: &RuntimeEvent) -> PresentedRuntimeEve
}
_ => format!("Unknown runtime notice: {notice:?}"),
};
(RuntimeEventSeverity::Success, message)
let severity = if matches!(notice, RuntimeNotice::ProviderMessage(_)) {
RuntimeEventSeverity::Warning
} else {
RuntimeEventSeverity::Success
};
(severity, message)
}
RuntimeEvent::Toast(_) => unreachable!("rich toasts use present_runtime_toast"),
RuntimeEvent::Effect(_) => unreachable!("runtime effects are not presentable"),
Expand DownExpand Up@@ -418,7 +424,12 @@ mod tests {
}
for notice in &notices {
let presented = present_runtime_event(&RuntimeEvent::Notice(notice.clone()));
assert_eq!(presented.severity, RuntimeEventSeverity::Success);
let expected = if matches!(notice, RuntimeNotice::ProviderMessage(_)) {
RuntimeEventSeverity::Warning
} else {
RuntimeEventSeverity::Success
};
assert_eq!(presented.severity, expected);
assert!(!presented.message.is_empty());
}
for toast in &toasts {
Expand DownExpand Up@@ -570,4 +581,13 @@ mod tests {

crate::set_locale(crate::LANGUAGE_ENGLISH);
}

#[test]
fn provider_warning_notice_is_presented_as_warning() {
let presented = present_runtime_event(&RuntimeEvent::Notice(
RuntimeNotice::ProviderMessage("pi MCP tools unavailable".into()),
));

assert_eq!(presented.severity, RuntimeEventSeverity::Warning);
}
}
1 change: 1 addition & 0 deletions crates/ui/src/shell.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -264,6 +264,7 @@ impl AppShell {
let notification = match presented.severity {
RuntimeEventSeverity::Error => Notification::error(presented.message),
RuntimeEventSeverity::Success => Notification::success(presented.message),
RuntimeEventSeverity::Warning => Notification::warning(presented.message),
};
window.push_notification(notification, cx);
return;
Expand Down
13 changes: 8 additions & 5 deletions docs/computer-use.md
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
# Computer use

tcode gives every provider (Claude Code, Codex, and all ACP agents that advertise
`mcpCapabilities.http`) a set of desktop computer-use tools, served by the in-process
`tcode_computer_use` MCP server. The design follows
tcode gives MCP-capable providers (Claude Code, Codex, OpenCode, and ACP agents that
advertise `mcpCapabilities.http`) a set of desktop computer-use tools, served by the
in-process `tcode_computer_use` MCP server. pi has no MCP client, so its provider card
and model-picker rows identify computer use, preview, and orchestrate as unavailable
before a session starts. The design follows
[pi-computer-use](https://github.com/injaneity/pi-computer-use): accessibility-tree-first,
state-scoped observation, transactional actions — not blind pixel clicking.

Expand DownExpand Up@@ -50,8 +52,9 @@ simplified successor-diff heuristic.
- `permissions.rs` — TCC checks/requests (see below), public API also consumed by the
settings UI.
- Registration: `SessionOptions.computer_use_server: Option<McpRegistration>` threaded exactly
like `orchestrate_server` — Claude via `--mcp-config`, Codex via `-c mcp_servers.*`, ACP via
`session/new` `mcpServers` (HTTP-capability-gated). Enabled/disabled per
like `orchestrate_server` — Claude via `--mcp-config`, Codex via `-c mcp_servers.*`, OpenCode
via its server config, and ACP via `session/new` `mcpServers` (HTTP-capability-gated).
Enabled/disabled per
`Settings.computer_use.enabled`.

Unlike pi-computer-use, tcode needs **no helper app**: tcode is itself a signed `.app`, so
Expand Down
1 change: 1 addition & 0 deletions locales/en.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -329,6 +329,7 @@ providers:
enable: "Enable %{name}"
reveal_email: "Click to reveal email"
hide_email: "Click to hide email"
mcp_unavailable: "MCP tools (computer use / preview / orchestrate) unavailable"
# Status dot + summary copy (T3 §2)
status:
checking: "Checking provider status"
Expand Down
1 change: 1 addition & 0 deletions locales/zh-CN.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -328,6 +328,7 @@ providers:
enable: "启用 %{name}"
reveal_email: "点击显示邮箱"
hide_email: "点击隐藏邮箱"
mcp_unavailable: "MCP 工具(电脑操作 / 预览 / 编排)不可用"
status:
checking: "正在检查提供方状态"
checking_detail: "正在等待服务返回安装与认证详情。"
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions crates/agent/src/lib.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,6 +45,8 @@ pub struct Caps {
pub options_apply_live: bool,
pub live_approval_mode_switch: bool,
pub live_option_push: LiveOptionPush,
/// Whether this adapter can attach tcode's HTTP MCP servers to a session.
pub mcp_servers: bool,
pub preview_mcp: bool,
pub launch_args: bool,
pub downgrade_approval_without_native_approvals: bool,
Expand DownExpand Up@@ -91,6 +93,7 @@ impl ProviderKind {
options_apply_live: false,
live_approval_mode_switch: true,
live_option_push: LiveOptionPush::None,
mcp_servers: true,
preview_mcp: true,
launch_args: true,
downgrade_approval_without_native_approvals: false,
Expand All@@ -106,6 +109,7 @@ impl ProviderKind {
options_apply_live: false,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::None,
mcp_servers: true,
preview_mcp: true,
launch_args: false,
downgrade_approval_without_native_approvals: false,
Expand All@@ -121,6 +125,9 @@ impl ProviderKind {
options_apply_live: true,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::All,
// ACP support is negotiated per agent; capable agents receive
// every tcode HTTP MCP registration in session/new or load.
mcp_servers: true,
preview_mcp: true,
launch_args: true,
downgrade_approval_without_native_approvals: false,
Expand All@@ -136,6 +143,7 @@ impl ProviderKind {
options_apply_live: false,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::Only(&["reasoningEffort"]),
mcp_servers: false,
preview_mcp: false,
launch_args: true,
downgrade_approval_without_native_approvals: true,
Expand All@@ -151,6 +159,7 @@ impl ProviderKind {
options_apply_live: false,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::None,
mcp_servers: true,
preview_mcp: true,
launch_args: true,
downgrade_approval_without_native_approvals: false,
Expand DownExpand Up@@ -188,6 +197,7 @@ mod provider_caps_tests {
options_apply_live: false,
live_approval_mode_switch: true,
live_option_push: LiveOptionPush::None,
mcp_servers: true,
preview_mcp: true,
launch_args: true,
downgrade_approval_without_native_approvals: false,
Expand All@@ -206,6 +216,7 @@ mod provider_caps_tests {
options_apply_live: false,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::None,
mcp_servers: true,
preview_mcp: true,
launch_args: false,
downgrade_approval_without_native_approvals: false,
Expand All@@ -224,6 +235,7 @@ mod provider_caps_tests {
options_apply_live: true,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::All,
mcp_servers: true,
preview_mcp: true,
launch_args: true,
downgrade_approval_without_native_approvals: false,
Expand All@@ -242,6 +254,7 @@ mod provider_caps_tests {
options_apply_live: false,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::Only(&["reasoningEffort"]),
mcp_servers: false,
preview_mcp: false,
launch_args: true,
downgrade_approval_without_native_approvals: true,
Expand All@@ -260,6 +273,7 @@ mod provider_caps_tests {
options_apply_live: false,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::None,
mcp_servers: true,
preview_mcp: true,
launch_args: true,
downgrade_approval_without_native_approvals: false,
Expand All@@ -269,6 +283,12 @@ mod provider_caps_tests {
}
);
}

#[test]
fn pi_cannot_attach_mcp_servers_but_claude_can() {
assert!(!ProviderKind::Pi.caps().mcp_servers);
assert!(ProviderKind::ClaudeCode.caps().mcp_servers);
}
}

/// Registry agents we never surface because they duplicate richer native
Expand Down
8 changes: 8 additions & 0 deletions crates/ui/src/composer/components/pickers.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -776,6 +776,14 @@ fn render_model_row(
.text_color(muted)
.child(glyph.xsmall())
.child(label)
})
.when(!row.provider.caps().mcp_servers, |this| {
this.child(
div()
.text_size(px(11.))
.text_color(muted)
.child(crate::tr!("providers.mcp_unavailable")),
)
}),
)
.when(index < 9, |this| {
Expand Down
10 changes: 9 additions & 1 deletion crates/ui/src/provider_card.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -167,7 +167,15 @@ impl ProviderCard {
.min_w_0()
.gap_0p5()
.child(title)
.child(self.render_summary_line(&summary, cx)),
.child(self.render_summary_line(&summary, cx))
.when(!provider.caps().mcp_servers, |this| {
this.child(
div()
.text_size(px(11.))
.text_color(muted)
.child(crate::tr!("providers.mcp_unavailable")),
)
}),
)
.tooltip({
let name = name.clone();
Expand Down
24 changes: 22 additions & 2 deletions crates/ui/src/runtime_event.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,6 +11,7 @@ use crate::toast::ToastKind;
pub(super) enum RuntimeEventSeverity {
Error,
Success,
Warning,
}

#[derive(Clone, Debug, PartialEq, Eq)]
Expand DownExpand Up@@ -138,7 +139,12 @@ pub(super) fn present_runtime_event(event: &RuntimeEvent) -> PresentedRuntimeEve
}
_ => format!("Unknown runtime notice: {notice:?}"),
};
(RuntimeEventSeverity::Success, message)
let severity = if matches!(notice, RuntimeNotice::ProviderMessage(_)) {
RuntimeEventSeverity::Warning
} else {
RuntimeEventSeverity::Success
};
(severity, message)
}
RuntimeEvent::Toast(_) => unreachable!("rich toasts use present_runtime_toast"),
RuntimeEvent::Effect(_) => unreachable!("runtime effects are not presentable"),
Expand DownExpand Up@@ -418,7 +424,12 @@ mod tests {
}
for notice in &notices {
let presented = present_runtime_event(&RuntimeEvent::Notice(notice.clone()));
assert_eq!(presented.severity, RuntimeEventSeverity::Success);
let expected = if matches!(notice, RuntimeNotice::ProviderMessage(_)) {
RuntimeEventSeverity::Warning
} else {
RuntimeEventSeverity::Success
};
assert_eq!(presented.severity, expected);
assert!(!presented.message.is_empty());
}
for toast in &toasts {
Expand DownExpand Up@@ -570,4 +581,13 @@ mod tests {

crate::set_locale(crate::LANGUAGE_ENGLISH);
}

#[test]
fn provider_warning_notice_is_presented_as_warning() {
let presented = present_runtime_event(&RuntimeEvent::Notice(
RuntimeNotice::ProviderMessage("pi MCP tools unavailable".into()),
));

assert_eq!(presented.severity, RuntimeEventSeverity::Warning);
}
}
1 change: 1 addition & 0 deletions crates/ui/src/shell.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -264,6 +264,7 @@ impl AppShell {
let notification = match presented.severity {
RuntimeEventSeverity::Error => Notification::error(presented.message),
RuntimeEventSeverity::Success => Notification::success(presented.message),
RuntimeEventSeverity::Warning => Notification::warning(presented.message),
};
window.push_notification(notification, cx);
return;
Expand Down
13 changes: 8 additions & 5 deletions docs/computer-use.md
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
# Computer use

tcode gives every provider (Claude Code, Codex, and all ACP agents that advertise
`mcpCapabilities.http`) a set of desktop computer-use tools, served by the in-process
`tcode_computer_use` MCP server. The design follows
tcode gives MCP-capable providers (Claude Code, Codex, OpenCode, and ACP agents that
advertise `mcpCapabilities.http`) a set of desktop computer-use tools, served by the
in-process `tcode_computer_use` MCP server. pi has no MCP client, so its provider card
and model-picker rows identify computer use, preview, and orchestrate as unavailable
before a session starts. The design follows
[pi-computer-use](https://github.com/injaneity/pi-computer-use): accessibility-tree-first,
state-scoped observation, transactional actions — not blind pixel clicking.

Expand DownExpand Up@@ -50,8 +52,9 @@ simplified successor-diff heuristic.
- `permissions.rs` — TCC checks/requests (see below), public API also consumed by the
settings UI.
- Registration: `SessionOptions.computer_use_server: Option<McpRegistration>` threaded exactly
like `orchestrate_server` — Claude via `--mcp-config`, Codex via `-c mcp_servers.*`, ACP via
`session/new` `mcpServers` (HTTP-capability-gated). Enabled/disabled per
like `orchestrate_server` — Claude via `--mcp-config`, Codex via `-c mcp_servers.*`, OpenCode
via its server config, and ACP via `session/new` `mcpServers` (HTTP-capability-gated).
Enabled/disabled per
`Settings.computer_use.enabled`.

Unlike pi-computer-use, tcode needs **no helper app**: tcode is itself a signed `.app`, so
Expand Down
1 change: 1 addition & 0 deletions locales/en.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -329,6 +329,7 @@ providers:
enable: "Enable %{name}"
reveal_email: "Click to reveal email"
hide_email: "Click to hide email"
mcp_unavailable: "MCP tools (computer use / preview / orchestrate) unavailable"
# Status dot + summary copy (T3 §2)
status:
checking: "Checking provider status"
Expand Down
1 change: 1 addition & 0 deletions locales/zh-CN.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -328,6 +328,7 @@ providers:
enable: "启用 %{name}"
reveal_email: "点击显示邮箱"
hide_email: "点击隐藏邮箱"
mcp_unavailable: "MCP 工具(电脑操作 / 预览 / 编排)不可用"
status:
checking: "正在检查提供方状态"
checking_detail: "正在等待服务返回安装与认证详情。"
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions crates/agent/src/lib.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,6 +45,8 @@ pub struct Caps {
pub options_apply_live: bool,
pub live_approval_mode_switch: bool,
pub live_option_push: LiveOptionPush,
/// Whether this adapter can attach tcode's HTTP MCP servers to a session.
pub mcp_servers: bool,
pub preview_mcp: bool,
pub launch_args: bool,
pub downgrade_approval_without_native_approvals: bool,
Expand DownExpand Up@@ -91,6 +93,7 @@ impl ProviderKind {
options_apply_live: false,
live_approval_mode_switch: true,
live_option_push: LiveOptionPush::None,
mcp_servers: true,
preview_mcp: true,
launch_args: true,
downgrade_approval_without_native_approvals: false,
Expand All@@ -106,6 +109,7 @@ impl ProviderKind {
options_apply_live: false,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::None,
mcp_servers: true,
preview_mcp: true,
launch_args: false,
downgrade_approval_without_native_approvals: false,
Expand All@@ -121,6 +125,9 @@ impl ProviderKind {
options_apply_live: true,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::All,
// ACP support is negotiated per agent; capable agents receive
// every tcode HTTP MCP registration in session/new or load.
mcp_servers: true,
preview_mcp: true,
launch_args: true,
downgrade_approval_without_native_approvals: false,
Expand All@@ -136,6 +143,7 @@ impl ProviderKind {
options_apply_live: false,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::Only(&["reasoningEffort"]),
mcp_servers: false,
preview_mcp: false,
launch_args: true,
downgrade_approval_without_native_approvals: true,
Expand All@@ -151,6 +159,7 @@ impl ProviderKind {
options_apply_live: false,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::None,
mcp_servers: true,
preview_mcp: true,
launch_args: true,
downgrade_approval_without_native_approvals: false,
Expand DownExpand Up@@ -188,6 +197,7 @@ mod provider_caps_tests {
options_apply_live: false,
live_approval_mode_switch: true,
live_option_push: LiveOptionPush::None,
mcp_servers: true,
preview_mcp: true,
launch_args: true,
downgrade_approval_without_native_approvals: false,
Expand All@@ -206,6 +216,7 @@ mod provider_caps_tests {
options_apply_live: false,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::None,
mcp_servers: true,
preview_mcp: true,
launch_args: false,
downgrade_approval_without_native_approvals: false,
Expand All@@ -224,6 +235,7 @@ mod provider_caps_tests {
options_apply_live: true,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::All,
mcp_servers: true,
preview_mcp: true,
launch_args: true,
downgrade_approval_without_native_approvals: false,
Expand All@@ -242,6 +254,7 @@ mod provider_caps_tests {
options_apply_live: false,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::Only(&["reasoningEffort"]),
mcp_servers: false,
preview_mcp: false,
launch_args: true,
downgrade_approval_without_native_approvals: true,
Expand All@@ -260,6 +273,7 @@ mod provider_caps_tests {
options_apply_live: false,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::None,
mcp_servers: true,
preview_mcp: true,
launch_args: true,
downgrade_approval_without_native_approvals: false,
Expand All@@ -269,6 +283,12 @@ mod provider_caps_tests {
}
);
}

#[test]
fn pi_cannot_attach_mcp_servers_but_claude_can() {
assert!(!ProviderKind::Pi.caps().mcp_servers);
assert!(ProviderKind::ClaudeCode.caps().mcp_servers);
}
}

/// Registry agents we never surface because they duplicate richer native
Expand Down
8 changes: 8 additions & 0 deletions crates/ui/src/composer/components/pickers.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -776,6 +776,14 @@ fn render_model_row(
.text_color(muted)
.child(glyph.xsmall())
.child(label)
})
.when(!row.provider.caps().mcp_servers, |this| {
this.child(
div()
.text_size(px(11.))
.text_color(muted)
.child(crate::tr!("providers.mcp_unavailable")),
)
}),
)
.when(index < 9, |this| {
Expand Down
10 changes: 9 additions & 1 deletion crates/ui/src/provider_card.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -167,7 +167,15 @@ impl ProviderCard {
.min_w_0()
.gap_0p5()
.child(title)
.child(self.render_summary_line(&summary, cx)),
.child(self.render_summary_line(&summary, cx))
.when(!provider.caps().mcp_servers, |this| {
this.child(
div()
.text_size(px(11.))
.text_color(muted)
.child(crate::tr!("providers.mcp_unavailable")),
)
}),
)
.tooltip({
let name = name.clone();
Expand Down
24 changes: 22 additions & 2 deletions crates/ui/src/runtime_event.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,6 +11,7 @@ use crate::toast::ToastKind;
pub(super) enum RuntimeEventSeverity {
Error,
Success,
Warning,
}

#[derive(Clone, Debug, PartialEq, Eq)]
Expand DownExpand Up@@ -138,7 +139,12 @@ pub(super) fn present_runtime_event(event: &RuntimeEvent) -> PresentedRuntimeEve
}
_ => format!("Unknown runtime notice: {notice:?}"),
};
(RuntimeEventSeverity::Success, message)
let severity = if matches!(notice, RuntimeNotice::ProviderMessage(_)) {
RuntimeEventSeverity::Warning
} else {
RuntimeEventSeverity::Success
};
(severity, message)
}
RuntimeEvent::Toast(_) => unreachable!("rich toasts use present_runtime_toast"),
RuntimeEvent::Effect(_) => unreachable!("runtime effects are not presentable"),
Expand DownExpand Up@@ -418,7 +424,12 @@ mod tests {
}
for notice in &notices {
let presented = present_runtime_event(&RuntimeEvent::Notice(notice.clone()));
assert_eq!(presented.severity, RuntimeEventSeverity::Success);
let expected = if matches!(notice, RuntimeNotice::ProviderMessage(_)) {
RuntimeEventSeverity::Warning
} else {
RuntimeEventSeverity::Success
};
assert_eq!(presented.severity, expected);
assert!(!presented.message.is_empty());
}
for toast in &toasts {
Expand DownExpand Up@@ -570,4 +581,13 @@ mod tests {

crate::set_locale(crate::LANGUAGE_ENGLISH);
}

#[test]
fn provider_warning_notice_is_presented_as_warning() {
let presented = present_runtime_event(&RuntimeEvent::Notice(
RuntimeNotice::ProviderMessage("pi MCP tools unavailable".into()),
));

assert_eq!(presented.severity, RuntimeEventSeverity::Warning);
}
}
1 change: 1 addition & 0 deletions crates/ui/src/shell.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -264,6 +264,7 @@ impl AppShell {
let notification = match presented.severity {
RuntimeEventSeverity::Error => Notification::error(presented.message),
RuntimeEventSeverity::Success => Notification::success(presented.message),
RuntimeEventSeverity::Warning => Notification::warning(presented.message),
};
window.push_notification(notification, cx);
return;
Expand Down
13 changes: 8 additions & 5 deletions docs/computer-use.md
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
# Computer use

tcode gives every provider (Claude Code, Codex, and all ACP agents that advertise
`mcpCapabilities.http`) a set of desktop computer-use tools, served by the in-process
`tcode_computer_use` MCP server. The design follows
tcode gives MCP-capable providers (Claude Code, Codex, OpenCode, and ACP agents that
advertise `mcpCapabilities.http`) a set of desktop computer-use tools, served by the
in-process `tcode_computer_use` MCP server. pi has no MCP client, so its provider card
and model-picker rows identify computer use, preview, and orchestrate as unavailable
before a session starts. The design follows
[pi-computer-use](https://github.com/injaneity/pi-computer-use): accessibility-tree-first,
state-scoped observation, transactional actions — not blind pixel clicking.

Expand DownExpand Up@@ -50,8 +52,9 @@ simplified successor-diff heuristic.
- `permissions.rs` — TCC checks/requests (see below), public API also consumed by the
settings UI.
- Registration: `SessionOptions.computer_use_server: Option<McpRegistration>` threaded exactly
like `orchestrate_server` — Claude via `--mcp-config`, Codex via `-c mcp_servers.*`, ACP via
`session/new` `mcpServers` (HTTP-capability-gated). Enabled/disabled per
like `orchestrate_server` — Claude via `--mcp-config`, Codex via `-c mcp_servers.*`, OpenCode
via its server config, and ACP via `session/new` `mcpServers` (HTTP-capability-gated).
Enabled/disabled per
`Settings.computer_use.enabled`.

Unlike pi-computer-use, tcode needs **no helper app**: tcode is itself a signed `.app`, so
Expand Down
1 change: 1 addition & 0 deletions locales/en.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -329,6 +329,7 @@ providers:
enable: "Enable %{name}"
reveal_email: "Click to reveal email"
hide_email: "Click to hide email"
mcp_unavailable: "MCP tools (computer use / preview / orchestrate) unavailable"
# Status dot + summary copy (T3 §2)
status:
checking: "Checking provider status"
Expand Down
1 change: 1 addition & 0 deletions locales/zh-CN.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -328,6 +328,7 @@ providers:
enable: "启用 %{name}"
reveal_email: "点击显示邮箱"
hide_email: "点击隐藏邮箱"
mcp_unavailable: "MCP 工具(电脑操作 / 预览 / 编排)不可用"
status:
checking: "正在检查提供方状态"
checking_detail: "正在等待服务返回安装与认证详情。"
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions crates/agent/src/lib.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,6 +45,8 @@ pub struct Caps {
pub options_apply_live: bool,
pub live_approval_mode_switch: bool,
pub live_option_push: LiveOptionPush,
/// Whether this adapter can attach tcode's HTTP MCP servers to a session.
pub mcp_servers: bool,
pub preview_mcp: bool,
pub launch_args: bool,
pub downgrade_approval_without_native_approvals: bool,
Expand DownExpand Up@@ -91,6 +93,7 @@ impl ProviderKind {
options_apply_live: false,
live_approval_mode_switch: true,
live_option_push: LiveOptionPush::None,
mcp_servers: true,
preview_mcp: true,
launch_args: true,
downgrade_approval_without_native_approvals: false,
Expand All@@ -106,6 +109,7 @@ impl ProviderKind {
options_apply_live: false,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::None,
mcp_servers: true,
preview_mcp: true,
launch_args: false,
downgrade_approval_without_native_approvals: false,
Expand All@@ -121,6 +125,9 @@ impl ProviderKind {
options_apply_live: true,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::All,
// ACP support is negotiated per agent; capable agents receive
// every tcode HTTP MCP registration in session/new or load.
mcp_servers: true,
preview_mcp: true,
launch_args: true,
downgrade_approval_without_native_approvals: false,
Expand All@@ -136,6 +143,7 @@ impl ProviderKind {
options_apply_live: false,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::Only(&["reasoningEffort"]),
mcp_servers: false,
preview_mcp: false,
launch_args: true,
downgrade_approval_without_native_approvals: true,
Expand All@@ -151,6 +159,7 @@ impl ProviderKind {
options_apply_live: false,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::None,
mcp_servers: true,
preview_mcp: true,
launch_args: true,
downgrade_approval_without_native_approvals: false,
Expand DownExpand Up@@ -188,6 +197,7 @@ mod provider_caps_tests {
options_apply_live: false,
live_approval_mode_switch: true,
live_option_push: LiveOptionPush::None,
mcp_servers: true,
preview_mcp: true,
launch_args: true,
downgrade_approval_without_native_approvals: false,
Expand All@@ -206,6 +216,7 @@ mod provider_caps_tests {
options_apply_live: false,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::None,
mcp_servers: true,
preview_mcp: true,
launch_args: false,
downgrade_approval_without_native_approvals: false,
Expand All@@ -224,6 +235,7 @@ mod provider_caps_tests {
options_apply_live: true,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::All,
mcp_servers: true,
preview_mcp: true,
launch_args: true,
downgrade_approval_without_native_approvals: false,
Expand All@@ -242,6 +254,7 @@ mod provider_caps_tests {
options_apply_live: false,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::Only(&["reasoningEffort"]),
mcp_servers: false,
preview_mcp: false,
launch_args: true,
downgrade_approval_without_native_approvals: true,
Expand All@@ -260,6 +273,7 @@ mod provider_caps_tests {
options_apply_live: false,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::None,
mcp_servers: true,
preview_mcp: true,
launch_args: true,
downgrade_approval_without_native_approvals: false,
Expand All@@ -269,6 +283,12 @@ mod provider_caps_tests {
}
);
}

#[test]
fn pi_cannot_attach_mcp_servers_but_claude_can() {
assert!(!ProviderKind::Pi.caps().mcp_servers);
assert!(ProviderKind::ClaudeCode.caps().mcp_servers);
}
}

/// Registry agents we never surface because they duplicate richer native
Expand Down
8 changes: 8 additions & 0 deletions crates/ui/src/composer/components/pickers.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -776,6 +776,14 @@ fn render_model_row(
.text_color(muted)
.child(glyph.xsmall())
.child(label)
})
.when(!row.provider.caps().mcp_servers, |this| {
this.child(
div()
.text_size(px(11.))
.text_color(muted)
.child(crate::tr!("providers.mcp_unavailable")),
)
}),
)
.when(index < 9, |this| {
Expand Down
10 changes: 9 additions & 1 deletion crates/ui/src/provider_card.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -167,7 +167,15 @@ impl ProviderCard {
.min_w_0()
.gap_0p5()
.child(title)
.child(self.render_summary_line(&summary, cx)),
.child(self.render_summary_line(&summary, cx))
.when(!provider.caps().mcp_servers, |this| {
this.child(
div()
.text_size(px(11.))
.text_color(muted)
.child(crate::tr!("providers.mcp_unavailable")),
)
}),
)
.tooltip({
let name = name.clone();
Expand Down
24 changes: 22 additions & 2 deletions crates/ui/src/runtime_event.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,6 +11,7 @@ use crate::toast::ToastKind;
pub(super) enum RuntimeEventSeverity {
Error,
Success,
Warning,
}

#[derive(Clone, Debug, PartialEq, Eq)]
Expand DownExpand Up@@ -138,7 +139,12 @@ pub(super) fn present_runtime_event(event: &RuntimeEvent) -> PresentedRuntimeEve
}
_ => format!("Unknown runtime notice: {notice:?}"),
};
(RuntimeEventSeverity::Success, message)
let severity = if matches!(notice, RuntimeNotice::ProviderMessage(_)) {
RuntimeEventSeverity::Warning
} else {
RuntimeEventSeverity::Success
};
(severity, message)
}
RuntimeEvent::Toast(_) => unreachable!("rich toasts use present_runtime_toast"),
RuntimeEvent::Effect(_) => unreachable!("runtime effects are not presentable"),
Expand DownExpand Up@@ -418,7 +424,12 @@ mod tests {
}
for notice in &notices {
let presented = present_runtime_event(&RuntimeEvent::Notice(notice.clone()));
assert_eq!(presented.severity, RuntimeEventSeverity::Success);
let expected = if matches!(notice, RuntimeNotice::ProviderMessage(_)) {
RuntimeEventSeverity::Warning
} else {
RuntimeEventSeverity::Success
};
assert_eq!(presented.severity, expected);
assert!(!presented.message.is_empty());
}
for toast in &toasts {
Expand DownExpand Up@@ -570,4 +581,13 @@ mod tests {

crate::set_locale(crate::LANGUAGE_ENGLISH);
}

#[test]
fn provider_warning_notice_is_presented_as_warning() {
let presented = present_runtime_event(&RuntimeEvent::Notice(
RuntimeNotice::ProviderMessage("pi MCP tools unavailable".into()),
));

assert_eq!(presented.severity, RuntimeEventSeverity::Warning);
}
}
1 change: 1 addition & 0 deletions crates/ui/src/shell.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -264,6 +264,7 @@ impl AppShell {
let notification = match presented.severity {
RuntimeEventSeverity::Error => Notification::error(presented.message),
RuntimeEventSeverity::Success => Notification::success(presented.message),
RuntimeEventSeverity::Warning => Notification::warning(presented.message),
};
window.push_notification(notification, cx);
return;
Expand Down
13 changes: 8 additions & 5 deletions docs/computer-use.md
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
# Computer use

tcode gives every provider (Claude Code, Codex, and all ACP agents that advertise
`mcpCapabilities.http`) a set of desktop computer-use tools, served by the in-process
`tcode_computer_use` MCP server. The design follows
tcode gives MCP-capable providers (Claude Code, Codex, OpenCode, and ACP agents that
advertise `mcpCapabilities.http`) a set of desktop computer-use tools, served by the
in-process `tcode_computer_use` MCP server. pi has no MCP client, so its provider card
and model-picker rows identify computer use, preview, and orchestrate as unavailable
before a session starts. The design follows
[pi-computer-use](https://github.com/injaneity/pi-computer-use): accessibility-tree-first,
state-scoped observation, transactional actions — not blind pixel clicking.

Expand DownExpand Up@@ -50,8 +52,9 @@ simplified successor-diff heuristic.
- `permissions.rs` — TCC checks/requests (see below), public API also consumed by the
settings UI.
- Registration: `SessionOptions.computer_use_server: Option<McpRegistration>` threaded exactly
like `orchestrate_server` — Claude via `--mcp-config`, Codex via `-c mcp_servers.*`, ACP via
`session/new` `mcpServers` (HTTP-capability-gated). Enabled/disabled per
like `orchestrate_server` — Claude via `--mcp-config`, Codex via `-c mcp_servers.*`, OpenCode
via its server config, and ACP via `session/new` `mcpServers` (HTTP-capability-gated).
Enabled/disabled per
`Settings.computer_use.enabled`.

Unlike pi-computer-use, tcode needs **no helper app**: tcode is itself a signed `.app`, so
Expand Down
1 change: 1 addition & 0 deletions locales/en.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -329,6 +329,7 @@ providers:
enable: "Enable %{name}"
reveal_email: "Click to reveal email"
hide_email: "Click to hide email"
mcp_unavailable: "MCP tools (computer use / preview / orchestrate) unavailable"
# Status dot + summary copy (T3 §2)
status:
checking: "Checking provider status"
Expand Down
1 change: 1 addition & 0 deletions locales/zh-CN.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -328,6 +328,7 @@ providers:
enable: "启用 %{name}"
reveal_email: "点击显示邮箱"
hide_email: "点击隐藏邮箱"
mcp_unavailable: "MCP 工具(电脑操作 / 预览 / 编排)不可用"
status:
checking: "正在检查提供方状态"
checking_detail: "正在等待服务返回安装与认证详情。"
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions crates/agent/src/lib.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,6 +45,8 @@ pub struct Caps {
pub options_apply_live: bool,
pub live_approval_mode_switch: bool,
pub live_option_push: LiveOptionPush,
/// Whether this adapter can attach tcode's HTTP MCP servers to a session.
pub mcp_servers: bool,
pub preview_mcp: bool,
pub launch_args: bool,
pub downgrade_approval_without_native_approvals: bool,
Expand DownExpand Up@@ -91,6 +93,7 @@ impl ProviderKind {
options_apply_live: false,
live_approval_mode_switch: true,
live_option_push: LiveOptionPush::None,
mcp_servers: true,
preview_mcp: true,
launch_args: true,
downgrade_approval_without_native_approvals: false,
Expand All@@ -106,6 +109,7 @@ impl ProviderKind {
options_apply_live: false,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::None,
mcp_servers: true,
preview_mcp: true,
launch_args: false,
downgrade_approval_without_native_approvals: false,
Expand All@@ -121,6 +125,9 @@ impl ProviderKind {
options_apply_live: true,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::All,
// ACP support is negotiated per agent; capable agents receive
// every tcode HTTP MCP registration in session/new or load.
mcp_servers: true,
preview_mcp: true,
launch_args: true,
downgrade_approval_without_native_approvals: false,
Expand All@@ -136,6 +143,7 @@ impl ProviderKind {
options_apply_live: false,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::Only(&["reasoningEffort"]),
mcp_servers: false,
preview_mcp: false,
launch_args: true,
downgrade_approval_without_native_approvals: true,
Expand All@@ -151,6 +159,7 @@ impl ProviderKind {
options_apply_live: false,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::None,
mcp_servers: true,
preview_mcp: true,
launch_args: true,
downgrade_approval_without_native_approvals: false,
Expand DownExpand Up@@ -188,6 +197,7 @@ mod provider_caps_tests {
options_apply_live: false,
live_approval_mode_switch: true,
live_option_push: LiveOptionPush::None,
mcp_servers: true,
preview_mcp: true,
launch_args: true,
downgrade_approval_without_native_approvals: false,
Expand All@@ -206,6 +216,7 @@ mod provider_caps_tests {
options_apply_live: false,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::None,
mcp_servers: true,
preview_mcp: true,
launch_args: false,
downgrade_approval_without_native_approvals: false,
Expand All@@ -224,6 +235,7 @@ mod provider_caps_tests {
options_apply_live: true,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::All,
mcp_servers: true,
preview_mcp: true,
launch_args: true,
downgrade_approval_without_native_approvals: false,
Expand All@@ -242,6 +254,7 @@ mod provider_caps_tests {
options_apply_live: false,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::Only(&["reasoningEffort"]),
mcp_servers: false,
preview_mcp: false,
launch_args: true,
downgrade_approval_without_native_approvals: true,
Expand All@@ -260,6 +273,7 @@ mod provider_caps_tests {
options_apply_live: false,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::None,
mcp_servers: true,
preview_mcp: true,
launch_args: true,
downgrade_approval_without_native_approvals: false,
Expand All@@ -269,6 +283,12 @@ mod provider_caps_tests {
}
);
}

#[test]
fn pi_cannot_attach_mcp_servers_but_claude_can() {
assert!(!ProviderKind::Pi.caps().mcp_servers);
assert!(ProviderKind::ClaudeCode.caps().mcp_servers);
}
}

/// Registry agents we never surface because they duplicate richer native
Expand Down
8 changes: 8 additions & 0 deletions crates/ui/src/composer/components/pickers.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -776,6 +776,14 @@ fn render_model_row(
.text_color(muted)
.child(glyph.xsmall())
.child(label)
})
.when(!row.provider.caps().mcp_servers, |this| {
this.child(
div()
.text_size(px(11.))
.text_color(muted)
.child(crate::tr!("providers.mcp_unavailable")),
)
}),
)
.when(index < 9, |this| {
Expand Down
10 changes: 9 additions & 1 deletion crates/ui/src/provider_card.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -167,7 +167,15 @@ impl ProviderCard {
.min_w_0()
.gap_0p5()
.child(title)
.child(self.render_summary_line(&summary, cx)),
.child(self.render_summary_line(&summary, cx))
.when(!provider.caps().mcp_servers, |this| {
this.child(
div()
.text_size(px(11.))
.text_color(muted)
.child(crate::tr!("providers.mcp_unavailable")),
)
}),
)
.tooltip({
let name = name.clone();
Expand Down
24 changes: 22 additions & 2 deletions crates/ui/src/runtime_event.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,6 +11,7 @@ use crate::toast::ToastKind;
pub(super) enum RuntimeEventSeverity {
Error,
Success,
Warning,
}

#[derive(Clone, Debug, PartialEq, Eq)]
Expand DownExpand Up@@ -138,7 +139,12 @@ pub(super) fn present_runtime_event(event: &RuntimeEvent) -> PresentedRuntimeEve
}
_ => format!("Unknown runtime notice: {notice:?}"),
};
(RuntimeEventSeverity::Success, message)
let severity = if matches!(notice, RuntimeNotice::ProviderMessage(_)) {
RuntimeEventSeverity::Warning
} else {
RuntimeEventSeverity::Success
};
(severity, message)
}
RuntimeEvent::Toast(_) => unreachable!("rich toasts use present_runtime_toast"),
RuntimeEvent::Effect(_) => unreachable!("runtime effects are not presentable"),
Expand DownExpand Up@@ -418,7 +424,12 @@ mod tests {
}
for notice in &notices {
let presented = present_runtime_event(&RuntimeEvent::Notice(notice.clone()));
assert_eq!(presented.severity, RuntimeEventSeverity::Success);
let expected = if matches!(notice, RuntimeNotice::ProviderMessage(_)) {
RuntimeEventSeverity::Warning
} else {
RuntimeEventSeverity::Success
};
assert_eq!(presented.severity, expected);
assert!(!presented.message.is_empty());
}
for toast in &toasts {
Expand DownExpand Up@@ -570,4 +581,13 @@ mod tests {

crate::set_locale(crate::LANGUAGE_ENGLISH);
}

#[test]
fn provider_warning_notice_is_presented_as_warning() {
let presented = present_runtime_event(&RuntimeEvent::Notice(
RuntimeNotice::ProviderMessage("pi MCP tools unavailable".into()),
));

assert_eq!(presented.severity, RuntimeEventSeverity::Warning);
}
}
1 change: 1 addition & 0 deletions crates/ui/src/shell.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -264,6 +264,7 @@ impl AppShell {
let notification = match presented.severity {
RuntimeEventSeverity::Error => Notification::error(presented.message),
RuntimeEventSeverity::Success => Notification::success(presented.message),
RuntimeEventSeverity::Warning => Notification::warning(presented.message),
};
window.push_notification(notification, cx);
return;
Expand Down
13 changes: 8 additions & 5 deletions docs/computer-use.md
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
# Computer use

tcode gives every provider (Claude Code, Codex, and all ACP agents that advertise
`mcpCapabilities.http`) a set of desktop computer-use tools, served by the in-process
`tcode_computer_use` MCP server. The design follows
tcode gives MCP-capable providers (Claude Code, Codex, OpenCode, and ACP agents that
advertise `mcpCapabilities.http`) a set of desktop computer-use tools, served by the
in-process `tcode_computer_use` MCP server. pi has no MCP client, so its provider card
and model-picker rows identify computer use, preview, and orchestrate as unavailable
before a session starts. The design follows
[pi-computer-use](https://github.com/injaneity/pi-computer-use): accessibility-tree-first,
state-scoped observation, transactional actions — not blind pixel clicking.

Expand DownExpand Up@@ -50,8 +52,9 @@ simplified successor-diff heuristic.
- `permissions.rs` — TCC checks/requests (see below), public API also consumed by the
settings UI.
- Registration: `SessionOptions.computer_use_server: Option<McpRegistration>` threaded exactly
like `orchestrate_server` — Claude via `--mcp-config`, Codex via `-c mcp_servers.*`, ACP via
`session/new` `mcpServers` (HTTP-capability-gated). Enabled/disabled per
like `orchestrate_server` — Claude via `--mcp-config`, Codex via `-c mcp_servers.*`, OpenCode
via its server config, and ACP via `session/new` `mcpServers` (HTTP-capability-gated).
Enabled/disabled per
`Settings.computer_use.enabled`.

Unlike pi-computer-use, tcode needs **no helper app**: tcode is itself a signed `.app`, so
Expand Down
1 change: 1 addition & 0 deletions locales/en.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -329,6 +329,7 @@ providers:
enable: "Enable %{name}"
reveal_email: "Click to reveal email"
hide_email: "Click to hide email"
mcp_unavailable: "MCP tools (computer use / preview / orchestrate) unavailable"
# Status dot + summary copy (T3 §2)
status:
checking: "Checking provider status"
Expand Down
1 change: 1 addition & 0 deletions locales/zh-CN.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -328,6 +328,7 @@ providers:
enable: "启用 %{name}"
reveal_email: "点击显示邮箱"
hide_email: "点击隐藏邮箱"
mcp_unavailable: "MCP 工具(电脑操作 / 预览 / 编排)不可用"
status:
checking: "正在检查提供方状态"
checking_detail: "正在等待服务返回安装与认证详情。"
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions crates/agent/src/lib.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,6 +45,8 @@ pub struct Caps {
pub options_apply_live: bool,
pub live_approval_mode_switch: bool,
pub live_option_push: LiveOptionPush,
/// Whether this adapter can attach tcode's HTTP MCP servers to a session.
pub mcp_servers: bool,
pub preview_mcp: bool,
pub launch_args: bool,
pub downgrade_approval_without_native_approvals: bool,
Expand DownExpand Up@@ -91,6 +93,7 @@ impl ProviderKind {
options_apply_live: false,
live_approval_mode_switch: true,
live_option_push: LiveOptionPush::None,
mcp_servers: true,
preview_mcp: true,
launch_args: true,
downgrade_approval_without_native_approvals: false,
Expand All@@ -106,6 +109,7 @@ impl ProviderKind {
options_apply_live: false,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::None,
mcp_servers: true,
preview_mcp: true,
launch_args: false,
downgrade_approval_without_native_approvals: false,
Expand All@@ -121,6 +125,9 @@ impl ProviderKind {
options_apply_live: true,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::All,
// ACP support is negotiated per agent; capable agents receive
// every tcode HTTP MCP registration in session/new or load.
mcp_servers: true,
preview_mcp: true,
launch_args: true,
downgrade_approval_without_native_approvals: false,
Expand All@@ -136,6 +143,7 @@ impl ProviderKind {
options_apply_live: false,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::Only(&["reasoningEffort"]),
mcp_servers: false,
preview_mcp: false,
launch_args: true,
downgrade_approval_without_native_approvals: true,
Expand All@@ -151,6 +159,7 @@ impl ProviderKind {
options_apply_live: false,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::None,
mcp_servers: true,
preview_mcp: true,
launch_args: true,
downgrade_approval_without_native_approvals: false,
Expand DownExpand Up@@ -188,6 +197,7 @@ mod provider_caps_tests {
options_apply_live: false,
live_approval_mode_switch: true,
live_option_push: LiveOptionPush::None,
mcp_servers: true,
preview_mcp: true,
launch_args: true,
downgrade_approval_without_native_approvals: false,
Expand All@@ -206,6 +216,7 @@ mod provider_caps_tests {
options_apply_live: false,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::None,
mcp_servers: true,
preview_mcp: true,
launch_args: false,
downgrade_approval_without_native_approvals: false,
Expand All@@ -224,6 +235,7 @@ mod provider_caps_tests {
options_apply_live: true,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::All,
mcp_servers: true,
preview_mcp: true,
launch_args: true,
downgrade_approval_without_native_approvals: false,
Expand All@@ -242,6 +254,7 @@ mod provider_caps_tests {
options_apply_live: false,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::Only(&["reasoningEffort"]),
mcp_servers: false,
preview_mcp: false,
launch_args: true,
downgrade_approval_without_native_approvals: true,
Expand All@@ -260,6 +273,7 @@ mod provider_caps_tests {
options_apply_live: false,
live_approval_mode_switch: false,
live_option_push: LiveOptionPush::None,
mcp_servers: true,
preview_mcp: true,
launch_args: true,
downgrade_approval_without_native_approvals: false,
Expand All@@ -269,6 +283,12 @@ mod provider_caps_tests {
}
);
}

#[test]
fn pi_cannot_attach_mcp_servers_but_claude_can() {
assert!(!ProviderKind::Pi.caps().mcp_servers);
assert!(ProviderKind::ClaudeCode.caps().mcp_servers);
}
}

/// Registry agents we never surface because they duplicate richer native
Expand Down
8 changes: 8 additions & 0 deletions crates/ui/src/composer/components/pickers.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -776,6 +776,14 @@ fn render_model_row(
.text_color(muted)
.child(glyph.xsmall())
.child(label)
})
.when(!row.provider.caps().mcp_servers, |this| {
this.child(
div()
.text_size(px(11.))
.text_color(muted)
.child(crate::tr!("providers.mcp_unavailable")),
)
}),
)
.when(index < 9, |this| {
Expand Down
10 changes: 9 additions & 1 deletion crates/ui/src/provider_card.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -167,7 +167,15 @@ impl ProviderCard {
.min_w_0()
.gap_0p5()
.child(title)
.child(self.render_summary_line(&summary, cx)),
.child(self.render_summary_line(&summary, cx))
.when(!provider.caps().mcp_servers, |this| {
this.child(
div()
.text_size(px(11.))
.text_color(muted)
.child(crate::tr!("providers.mcp_unavailable")),
)
}),
)
.tooltip({
let name = name.clone();
Expand Down
24 changes: 22 additions & 2 deletions crates/ui/src/runtime_event.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,6 +11,7 @@ use crate::toast::ToastKind;
pub(super) enum RuntimeEventSeverity {
Error,
Success,
Warning,
}

#[derive(Clone, Debug, PartialEq, Eq)]
Expand DownExpand Up@@ -138,7 +139,12 @@ pub(super) fn present_runtime_event(event: &RuntimeEvent) -> PresentedRuntimeEve
}
_ => format!("Unknown runtime notice: {notice:?}"),
};
(RuntimeEventSeverity::Success, message)
let severity = if matches!(notice, RuntimeNotice::ProviderMessage(_)) {
RuntimeEventSeverity::Warning
} else {
RuntimeEventSeverity::Success
};
(severity, message)
}
RuntimeEvent::Toast(_) => unreachable!("rich toasts use present_runtime_toast"),
RuntimeEvent::Effect(_) => unreachable!("runtime effects are not presentable"),
Expand DownExpand Up@@ -418,7 +424,12 @@ mod tests {
}
for notice in &notices {
let presented = present_runtime_event(&RuntimeEvent::Notice(notice.clone()));
assert_eq!(presented.severity, RuntimeEventSeverity::Success);
let expected = if matches!(notice, RuntimeNotice::ProviderMessage(_)) {
RuntimeEventSeverity::Warning
} else {
RuntimeEventSeverity::Success
};
assert_eq!(presented.severity, expected);
assert!(!presented.message.is_empty());
}
for toast in &toasts {
Expand DownExpand Up@@ -570,4 +581,13 @@ mod tests {

crate::set_locale(crate::LANGUAGE_ENGLISH);
}

#[test]
fn provider_warning_notice_is_presented_as_warning() {
let presented = present_runtime_event(&RuntimeEvent::Notice(
RuntimeNotice::ProviderMessage("pi MCP tools unavailable".into()),
));

assert_eq!(presented.severity, RuntimeEventSeverity::Warning);
}
}
1 change: 1 addition & 0 deletions crates/ui/src/shell.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -264,6 +264,7 @@ impl AppShell {
let notification = match presented.severity {
RuntimeEventSeverity::Error => Notification::error(presented.message),
RuntimeEventSeverity::Success => Notification::success(presented.message),
RuntimeEventSeverity::Warning => Notification::warning(presented.message),
};
window.push_notification(notification, cx);
return;
Expand Down
13 changes: 8 additions & 5 deletions docs/computer-use.md
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
# Computer use

tcode gives every provider (Claude Code, Codex, and all ACP agents that advertise
`mcpCapabilities.http`) a set of desktop computer-use tools, served by the in-process
`tcode_computer_use` MCP server. The design follows
tcode gives MCP-capable providers (Claude Code, Codex, OpenCode, and ACP agents that
advertise `mcpCapabilities.http`) a set of desktop computer-use tools, served by the
in-process `tcode_computer_use` MCP server. pi has no MCP client, so its provider card
and model-picker rows identify computer use, preview, and orchestrate as unavailable
before a session starts. The design follows
[pi-computer-use](https://github.com/injaneity/pi-computer-use): accessibility-tree-first,
state-scoped observation, transactional actions — not blind pixel clicking.

Expand DownExpand Up@@ -50,8 +52,9 @@ simplified successor-diff heuristic.
- `permissions.rs` — TCC checks/requests (see below), public API also consumed by the
settings UI.
- Registration: `SessionOptions.computer_use_server: Option<McpRegistration>` threaded exactly
like `orchestrate_server` — Claude via `--mcp-config`, Codex via `-c mcp_servers.*`, ACP via
`session/new` `mcpServers` (HTTP-capability-gated). Enabled/disabled per
like `orchestrate_server` — Claude via `--mcp-config`, Codex via `-c mcp_servers.*`, OpenCode
via its server config, and ACP via `session/new` `mcpServers` (HTTP-capability-gated).
Enabled/disabled per
`Settings.computer_use.enabled`.

Unlike pi-computer-use, tcode needs **no helper app**: tcode is itself a signed `.app`, so
Expand Down
1 change: 1 addition & 0 deletions locales/en.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -329,6 +329,7 @@ providers:
enable: "Enable %{name}"
reveal_email: "Click to reveal email"
hide_email: "Click to hide email"
mcp_unavailable: "MCP tools (computer use / preview / orchestrate) unavailable"
# Status dot + summary copy (T3 §2)
status:
checking: "Checking provider status"
Expand Down
1 change: 1 addition & 0 deletions locales/zh-CN.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -328,6 +328,7 @@ providers:
enable: "启用 %{name}"
reveal_email: "点击显示邮箱"
hide_email: "点击隐藏邮箱"
mcp_unavailable: "MCP 工具(电脑操作 / 预览 / 编排)不可用"
status:
checking: "正在检查提供方状态"
checking_detail: "正在等待服务返回安装与认证详情。"
Expand Down