Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions crates/core/src/settings.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -323,6 +323,10 @@ pub struct OrchestrateSettings {
pub child_models: Vec<OrchestrateChildModel>,
#[serde(default)]
pub child_approval: ChildApprovalMode,
/// Give dispatched children dedicated Git worktrees when their resolved cwd
/// is itself a repository root. Dispatch-level `worktree` overrides this.
#[serde(default)]
pub child_worktrees: bool,
/// Archive completed children automatically once their terminal result has
/// been delivered to the parent. Per-dispatch `archive_on_complete`
/// overrides this; failed children always stay visible for retries.
Expand DownExpand Up@@ -393,6 +397,7 @@ impl Default for OrchestrateSettings {
},
],
child_approval: ChildApprovalMode::default(),
child_worktrees: false,
archive_on_complete: true,
}
}
Expand DownExpand Up@@ -1171,6 +1176,23 @@ mod tests {
}
}

#[test]
fn orchestrate_child_worktrees_default_false_and_round_trip() {
let legacy: OrchestrateSettings = serde_json::from_str("{}").unwrap();
assert!(!legacy.child_worktrees);

let settings = OrchestrateSettings {
child_worktrees: true,
..Default::default()
};
let json = serde_json::to_string(&settings).unwrap();
assert!(json.contains(r#""child_worktrees":true"#));
assert_eq!(
serde_json::from_str::<OrchestrateSettings>(&json).unwrap(),
settings
);
}

#[test]
fn orchestrate_child_legacy_default_effort_alias_parses() {
let settings: OrchestrateSettings = serde_json::from_str(
Expand Down
1 change: 1 addition & 0 deletions crates/orchestrate-mcp/src/lib.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,6 +16,7 @@ pub enum OrchestrateOp {
title: String,
brief: String,
cwd: Option<String>,
worktree: Option<bool>,
archive_on_complete: Option<bool>,
result_max_chars: Option<u32>,
},
Expand Down
8 changes: 7 additions & 1 deletion crates/orchestrate-mcp/src/tools.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,6 +28,11 @@ struct DispatchParams {
#[serde(default)]
cwd: Option<String>,
#[serde(default)]
#[schemars(
description = "Override Settings → Orchestrate child-worktree isolation for this dispatch. When true and cwd resolves to a Git repository root, the child runs on branch tcode/<thread-id> in a dedicated worktree. The response includes its path and branch. Non-Git cwd or creation failure falls back to cwd and reports a warning."
)]
worktree: Option<bool>,
#[serde(default)]
#[schemars(
description = "Override the auto-archive policy for this child. By default (per Settings → Orchestrate) a completed child is archived once its terminal result reaches you; failed children always stay visible. Set false to keep a completed child in the sidebar; send to an archived child unarchives it."
)]
Expand DownExpand Up@@ -82,7 +87,7 @@ impl OrchestrateTools {
}

#[tool(
description = "Dispatch a brief to a new child tcode thread and return its thread id. profile is the provider-profile id from the fleet table, required when the entry names one. access is one of read_only (review/investigation: read-only actions run without prompts; anything that mutates pauses for user approval), workspace_write (edits auto-approved inside the workspace), or full (default; no approval prompts). Completed children are auto-archived after their result is delivered unless archive_on_complete: false; failed children stay visible for retries."
description = "Dispatch a brief to a new child tcode thread and return its thread id. profile is the provider-profile id from the fleet table, required when the entry names one. access is one of read_only (review/investigation: read-only actions run without prompts; anything that mutates pauses for user approval), workspace_write (edits auto-approved inside the workspace), or full (default; no approval prompts). worktree optionally isolates the child in tcode/<thread-id> and overrides the Orchestrate setting; the response identifies the path and branch or explains fallback. Completed children are auto-archived after their result is delivered unless archive_on_complete: false; failed children stay visible for retries."
)]
async fn dispatch(
&self,
Expand All@@ -99,6 +104,7 @@ impl OrchestrateTools {
title: p.title,
brief: p.brief,
cwd: p.cwd,
worktree: p.worktree,
archive_on_complete: p.archive_on_complete,
result_max_chars: p.result_max_chars,
})
Expand Down
4 changes: 4 additions & 0 deletions crates/protocol/src/command.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -40,6 +40,7 @@ pub enum SettingsPatch {
AutoArchiveKeepCount(usize),
AutoArchiveNoticeShown(bool),
Orchestrate(OrchestrateSettings),
OrchestrateChildWorktrees(bool),
ComputerUse(ComputerUseSettings),
Browser(BrowserSettings),
TitleGeneration(TitleGenerationSettings),
Expand DownExpand Up@@ -196,6 +197,9 @@ pub enum Command {
session_id: String,
remove_worktree: bool,
},
MergeWorktree {
session_id: String,
},
DeleteProject {
project_id: String,
},
Expand Down
17 changes: 17 additions & 0 deletions crates/protocol/src/event.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -252,6 +252,17 @@ pub struct GitActionRequest {
pub feature_branch: Option<String>,
}

#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)]
#[serde(rename_all = "snake_case")]
pub enum MergeWorktreeFailure {
Missing,
DirtyWorktree,
DestinationDetached,
DirtyDestination,
DivergedConflict,
Git,
}

#[non_exhaustive]
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
#[serde(tag = "type", content = "content", rename_all = "snake_case")]
Expand DownExpand Up@@ -354,4 +365,10 @@ pub enum RuntimeNotice {
skipped: Vec<String>,
limit_reached: bool,
},
WorktreeMergedFastForward,
WorktreeMergedCommit,
WorktreeMergeFailed {
reason: MergeWorktreeFailure,
detail: Option<String>,
},
}
8 changes: 4 additions & 4 deletions crates/protocol/src/lib.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,10 +12,10 @@ mod wire;
pub use command::{Command, CommandResponse, SettingsPatch, ThreadExportFormat};
pub use event::{
AcpMarketplaceItem, EventEnvelope, GitActionRequest, GitStatusStatus, IndexSnapshot,
ProviderVersionStatus, ProvidersStatus, QueuedMessageStatus, RuntimeEffect, RuntimeError,
RuntimeNotice, RuntimeNotification, RuntimeOperationId, RuntimeToast, ServerEvent,
SessionEventRecord, SessionStatus, TcodeUpdateStatus, TerminalContextStatus,
TerminalSplitStatus, TerminalStatus, Topic,
MergeWorktreeFailure, ProviderVersionStatus, ProvidersStatus, QueuedMessageStatus,
RuntimeEffect, RuntimeError, RuntimeNotice, RuntimeNotification, RuntimeOperationId,
RuntimeToast, ServerEvent, SessionEventRecord, SessionStatus, TcodeUpdateStatus,
TerminalContextStatus, TerminalSplitStatus, TerminalStatus, Topic,
};
pub use query::{
ExternalThread, GitDiffResult, GitDiffScope, GitFileText, PathEntry, Query, QueryResponse,
Expand Down
6 changes: 6 additions & 0 deletions crates/protocol/src/tests.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -227,6 +227,11 @@ fn round_trips_top_level_wire_types() {
});
}

#[test]
fn orchestrate_child_worktrees_patch_round_trips() {
round_trip(&SettingsPatch::OrchestrateChildWorktrees(true));
}

fn assert_command_crosses_ndjson(id: u64, command: Command) {
match &command {
Command::ApplyPendingRelaunch => {}
Expand DownExpand Up@@ -275,6 +280,7 @@ fn assert_command_crosses_ndjson(id: u64, command: Command) {
Command::AutoArchiveSweep { .. } => {}
Command::RenameSession { .. } => {}
Command::ForkThread { .. } => {}
Command::MergeWorktree { .. } => {}
Command::DeleteSession { .. } => {}
Command::DeleteProject { .. } => {}
Command::MarkSessionUnread { .. } => {}
Expand Down
16 changes: 9 additions & 7 deletions crates/runtime/src/app/mod.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,20 +48,22 @@ use tcode_core::ui::{
};
use tcode_protocol::ThreadExportFormat;
use tcode_protocol::{
AcpMarketplaceItem, EventEnvelope, ExternalThread, GitStatusStatus, IndexSnapshot, PathEntry,
ProviderVersionStatus as ProtocolProviderVersionStatus, ProvidersStatus, QueuedMessageStatus,
RecentDir, ServerEvent, SessionEventRecord, SessionStatus, TcodeUpdateStatus,
TerminalContextStatus, TerminalSplitStatus, TerminalStatus, Topic,
AcpMarketplaceItem, EventEnvelope, ExternalThread, GitStatusStatus, IndexSnapshot,
MergeWorktreeFailure, PathEntry, ProviderVersionStatus as ProtocolProviderVersionStatus,
ProvidersStatus, QueuedMessageStatus, RecentDir, ServerEvent, SessionEventRecord,
SessionStatus, TcodeUpdateStatus, TerminalContextStatus, TerminalSplitStatus, TerminalStatus,
Topic,
};
use tcode_services::acp_registry::{
Registry, RegistryAgent, cached, install, load, platform_key, resolve_recipe, uninstall,
visible_agents,
};
use tcode_services::export;
use tcode_services::git::{
CheckoutError, checkout_if_clean, cleanup_orphaned_worktrees, commit_diff_context,
create_git_worktree, list_git_branches, perform_action, read_git_branch, read_status,
remove_git_worktree, run_claude_headless, worktree_path_for,
CheckoutError, MergeWorktreeError, MergeWorktreeOutcome, checkout_if_clean,
cleanup_orphaned_worktrees, commit_diff_context, create_git_worktree, list_git_branches,
merge_worktree_back, perform_action, read_git_branch, read_status, remove_git_worktree,
run_claude_headless, run_git, worktree_path_for,
};
use tcode_services::import::{
ExternalImportUpdate, ExternalRoots, ImportOutcome, existing_external_ids, import_thread,
Expand Down
130 changes: 107 additions & 23 deletions crates/runtime/src/app/orchestrate.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -252,6 +252,15 @@ impl AppState {
result_max_chars,
);
meta.title = title;
self.install_child_session(meta, brief, cx)
}

fn install_child_session(
&mut self,
meta: SessionMeta,
brief: String,
cx: &mut HostCx,
) -> Result<String, String> {
self.enqueue_store_write(
StoreWrite::UpsertMeta {
meta: Box::new(meta.clone()),
Expand DownExpand Up@@ -307,6 +316,7 @@ impl AppState {
title,
brief,
cwd,
worktree,
archive_on_complete,
result_max_chars,
} => {
Expand DownExpand Up@@ -335,7 +345,8 @@ impl AppState {
};
let archive_on_complete =
archive_on_complete.unwrap_or(self.settings.orchestrate.archive_on_complete);
let Some(cwd) = cwd else {
let isolate = worktree.unwrap_or(self.settings.orchestrate.child_worktrees);
if cwd.is_none() && !isolate {
let result = self
.create_child_session(
&parent_id,
Expand All@@ -354,17 +365,32 @@ impl AppState {
.map(|id| serde_json::json!({ "thread_id": id }));
let _ = reply.try_send(result);
return;
};
let Some(parent_cwd) = self.find_meta(&parent_id).map(|meta| meta.cwd) else {
}
let Some(parent) = self.find_meta(&parent_id) else {
let _ = reply.try_send(Err("unknown parent session".to_string()));
return;
};
let path = PathBuf::from(cwd);
let path = if path.is_absolute() {
let path = PathBuf::from(cwd.unwrap_or_default());
let path = if path.as_os_str().is_empty() {
parent.cwd.clone()
} else if path.is_absolute() {
path
} else {
parent_cwd.join(path)
parent.cwd.join(path)
};
let mut meta = build_child_meta(
&parent,
provider,
Some(model),
effort,
profile_id,
approval_mode,
path.clone(),
archive_on_complete,
result_max_chars,
);
meta.title = title;
let child_id = meta.id.clone();
let host_cx = cx.clone();
HostCx::spawn_detached(cx, async move {
let resolved_cwd = host_cx
Expand All@@ -375,30 +401,39 @@ impl AppState {
if !canonical.is_dir() {
return Err(format!("invalid cwd: {}", canonical.display()));
}
Ok(canonical)
if isolate {
Ok(resolve_child_worktree(canonical, &child_id))
} else {
Ok((canonical, None, None))
}
})
.await;
let result = match resolved_cwd {
Ok(cwd) => host_cx
Ok((cwd, worktree, warning)) => host_cx
.enqueue_and_wait(move |state, cx| {
state.create_child_session(
&parent_id,
provider,
Some(model),
effort,
profile_id,
approval_mode,
title,
Some(cwd),
brief,
archive_on_complete,
result_max_chars,
cx,
)
meta.cwd = cwd;
meta.worktree = worktree;
let worktree_info = meta.worktree.clone();
state
.install_child_session(meta, brief, cx)
.map(|id| (id, worktree_info, warning))
})
.await
.unwrap_or_else(|_| Err("application closed".to_string()))
.map(|id| serde_json::json!({ "thread_id": id })),
.map(|(id, worktree, warning)| {
let mut response = serde_json::json!({ "thread_id": id });
if let Some(worktree) = worktree {
response["worktree_path"] = serde_json::json!(
worktree_path_for(&id).display().to_string()
);
response["worktree_branch"] =
serde_json::json!(worktree.branch);
}
if let Some(warning) = warning {
response["warning"] = serde_json::json!(warning);
}
response
}),
Err(err) => Err(err),
};
let _ = reply.try_send(result);
Expand DownExpand Up@@ -1211,6 +1246,55 @@ pub(super) fn provider_name(provider: ProviderKind) -> &'static str {
}
}

fn resolve_child_worktree(
cwd: PathBuf,
child_id: &str,
) -> (PathBuf, Option<WorktreeInfo>, Option<String>) {
let repo_root = run_git(&cwd, &["rev-parse", "--show-toplevel"])
.ok()
.map(|root| PathBuf::from(root.trim()))
.and_then(|root| root.canonicalize().ok());
if repo_root.as_ref() != Some(&cwd) {
let warning = format!(
"worktree isolation unavailable: {} is not a Git repository root; using the plain cwd",
cwd.display()
);
log::warn!("orchestrate dispatch: {warning}");
return (cwd, None, Some(warning));
}

let base = run_git(&cwd, &["symbolic-ref", "--quiet", "--short", "HEAD"])
.or_else(|_| run_git(&cwd, &["rev-parse", "HEAD"]))
.map(|base| base.trim().to_string());
let base = match base {
Ok(base) => base,
Err(error) => {
let warning = format!(
"worktree isolation unavailable: could not resolve the base revision ({error}); using the plain cwd"
);
log::warn!("orchestrate dispatch: {warning}");
return (cwd, None, Some(warning));
}
};
let path = worktree_path_for(child_id);
let requested_branch = format!("tcode/{child_id}");
match create_git_worktree(&cwd, &path, &requested_branch, &base) {
Ok(created) => {
let info = WorktreeInfo {
root_project_path: cwd,
base,
branch: created.branch,
};
(created.path, Some(info), None)
}
Err(error) => {
let warning = format!("worktree isolation failed ({error}); using the plain cwd");
log::warn!("orchestrate dispatch: {warning}");
(cwd, None, Some(warning))
}
}
}

#[allow(clippy::too_many_arguments)] // mirrors the MCP dispatch schema
pub(super) fn build_child_meta(
parent: &SessionMeta,
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions crates/core/src/settings.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -323,6 +323,10 @@ pub struct OrchestrateSettings {
pub child_models: Vec<OrchestrateChildModel>,
#[serde(default)]
pub child_approval: ChildApprovalMode,
/// Give dispatched children dedicated Git worktrees when their resolved cwd
/// is itself a repository root. Dispatch-level `worktree` overrides this.
#[serde(default)]
pub child_worktrees: bool,
/// Archive completed children automatically once their terminal result has
/// been delivered to the parent. Per-dispatch `archive_on_complete`
/// overrides this; failed children always stay visible for retries.
Expand DownExpand Up@@ -393,6 +397,7 @@ impl Default for OrchestrateSettings {
},
],
child_approval: ChildApprovalMode::default(),
child_worktrees: false,
archive_on_complete: true,
}
}
Expand DownExpand Up@@ -1171,6 +1176,23 @@ mod tests {
}
}

#[test]
fn orchestrate_child_worktrees_default_false_and_round_trip() {
let legacy: OrchestrateSettings = serde_json::from_str("{}").unwrap();
assert!(!legacy.child_worktrees);

let settings = OrchestrateSettings {
child_worktrees: true,
..Default::default()
};
let json = serde_json::to_string(&settings).unwrap();
assert!(json.contains(r#""child_worktrees":true"#));
assert_eq!(
serde_json::from_str::<OrchestrateSettings>(&json).unwrap(),
settings
);
}

#[test]
fn orchestrate_child_legacy_default_effort_alias_parses() {
let settings: OrchestrateSettings = serde_json::from_str(
Expand Down
1 change: 1 addition & 0 deletions crates/orchestrate-mcp/src/lib.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,6 +16,7 @@ pub enum OrchestrateOp {
title: String,
brief: String,
cwd: Option<String>,
worktree: Option<bool>,
archive_on_complete: Option<bool>,
result_max_chars: Option<u32>,
},
Expand Down
8 changes: 7 additions & 1 deletion crates/orchestrate-mcp/src/tools.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,6 +28,11 @@ struct DispatchParams {
#[serde(default)]
cwd: Option<String>,
#[serde(default)]
#[schemars(
description = "Override Settings → Orchestrate child-worktree isolation for this dispatch. When true and cwd resolves to a Git repository root, the child runs on branch tcode/<thread-id> in a dedicated worktree. The response includes its path and branch. Non-Git cwd or creation failure falls back to cwd and reports a warning."
)]
worktree: Option<bool>,
#[serde(default)]
#[schemars(
description = "Override the auto-archive policy for this child. By default (per Settings → Orchestrate) a completed child is archived once its terminal result reaches you; failed children always stay visible. Set false to keep a completed child in the sidebar; send to an archived child unarchives it."
)]
Expand DownExpand Up@@ -82,7 +87,7 @@ impl OrchestrateTools {
}

#[tool(
description = "Dispatch a brief to a new child tcode thread and return its thread id. profile is the provider-profile id from the fleet table, required when the entry names one. access is one of read_only (review/investigation: read-only actions run without prompts; anything that mutates pauses for user approval), workspace_write (edits auto-approved inside the workspace), or full (default; no approval prompts). Completed children are auto-archived after their result is delivered unless archive_on_complete: false; failed children stay visible for retries."
description = "Dispatch a brief to a new child tcode thread and return its thread id. profile is the provider-profile id from the fleet table, required when the entry names one. access is one of read_only (review/investigation: read-only actions run without prompts; anything that mutates pauses for user approval), workspace_write (edits auto-approved inside the workspace), or full (default; no approval prompts). worktree optionally isolates the child in tcode/<thread-id> and overrides the Orchestrate setting; the response identifies the path and branch or explains fallback. Completed children are auto-archived after their result is delivered unless archive_on_complete: false; failed children stay visible for retries."
)]
async fn dispatch(
&self,
Expand All@@ -99,6 +104,7 @@ impl OrchestrateTools {
title: p.title,
brief: p.brief,
cwd: p.cwd,
worktree: p.worktree,
archive_on_complete: p.archive_on_complete,
result_max_chars: p.result_max_chars,
})
Expand Down
4 changes: 4 additions & 0 deletions crates/protocol/src/command.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -40,6 +40,7 @@ pub enum SettingsPatch {
AutoArchiveKeepCount(usize),
AutoArchiveNoticeShown(bool),
Orchestrate(OrchestrateSettings),
OrchestrateChildWorktrees(bool),
ComputerUse(ComputerUseSettings),
Browser(BrowserSettings),
TitleGeneration(TitleGenerationSettings),
Expand DownExpand Up@@ -196,6 +197,9 @@ pub enum Command {
session_id: String,
remove_worktree: bool,
},
MergeWorktree {
session_id: String,
},
DeleteProject {
project_id: String,
},
Expand Down
17 changes: 17 additions & 0 deletions crates/protocol/src/event.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -252,6 +252,17 @@ pub struct GitActionRequest {
pub feature_branch: Option<String>,
}

#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)]
#[serde(rename_all = "snake_case")]
pub enum MergeWorktreeFailure {
Missing,
DirtyWorktree,
DestinationDetached,
DirtyDestination,
DivergedConflict,
Git,
}

#[non_exhaustive]
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
#[serde(tag = "type", content = "content", rename_all = "snake_case")]
Expand DownExpand Up@@ -354,4 +365,10 @@ pub enum RuntimeNotice {
skipped: Vec<String>,
limit_reached: bool,
},
WorktreeMergedFastForward,
WorktreeMergedCommit,
WorktreeMergeFailed {
reason: MergeWorktreeFailure,
detail: Option<String>,
},
}
8 changes: 4 additions & 4 deletions crates/protocol/src/lib.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,10 +12,10 @@ mod wire;
pub use command::{Command, CommandResponse, SettingsPatch, ThreadExportFormat};
pub use event::{
AcpMarketplaceItem, EventEnvelope, GitActionRequest, GitStatusStatus, IndexSnapshot,
ProviderVersionStatus, ProvidersStatus, QueuedMessageStatus, RuntimeEffect, RuntimeError,
RuntimeNotice, RuntimeNotification, RuntimeOperationId, RuntimeToast, ServerEvent,
SessionEventRecord, SessionStatus, TcodeUpdateStatus, TerminalContextStatus,
TerminalSplitStatus, TerminalStatus, Topic,
MergeWorktreeFailure, ProviderVersionStatus, ProvidersStatus, QueuedMessageStatus,
RuntimeEffect, RuntimeError, RuntimeNotice, RuntimeNotification, RuntimeOperationId,
RuntimeToast, ServerEvent, SessionEventRecord, SessionStatus, TcodeUpdateStatus,
TerminalContextStatus, TerminalSplitStatus, TerminalStatus, Topic,
};
pub use query::{
ExternalThread, GitDiffResult, GitDiffScope, GitFileText, PathEntry, Query, QueryResponse,
Expand Down
6 changes: 6 additions & 0 deletions crates/protocol/src/tests.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -227,6 +227,11 @@ fn round_trips_top_level_wire_types() {
});
}

#[test]
fn orchestrate_child_worktrees_patch_round_trips() {
round_trip(&SettingsPatch::OrchestrateChildWorktrees(true));
}

fn assert_command_crosses_ndjson(id: u64, command: Command) {
match &command {
Command::ApplyPendingRelaunch => {}
Expand DownExpand Up@@ -275,6 +280,7 @@ fn assert_command_crosses_ndjson(id: u64, command: Command) {
Command::AutoArchiveSweep { .. } => {}
Command::RenameSession { .. } => {}
Command::ForkThread { .. } => {}
Command::MergeWorktree { .. } => {}
Command::DeleteSession { .. } => {}
Command::DeleteProject { .. } => {}
Command::MarkSessionUnread { .. } => {}
Expand Down
16 changes: 9 additions & 7 deletions crates/runtime/src/app/mod.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,20 +48,22 @@ use tcode_core::ui::{
};
use tcode_protocol::ThreadExportFormat;
use tcode_protocol::{
AcpMarketplaceItem, EventEnvelope, ExternalThread, GitStatusStatus, IndexSnapshot, PathEntry,
ProviderVersionStatus as ProtocolProviderVersionStatus, ProvidersStatus, QueuedMessageStatus,
RecentDir, ServerEvent, SessionEventRecord, SessionStatus, TcodeUpdateStatus,
TerminalContextStatus, TerminalSplitStatus, TerminalStatus, Topic,
AcpMarketplaceItem, EventEnvelope, ExternalThread, GitStatusStatus, IndexSnapshot,
MergeWorktreeFailure, PathEntry, ProviderVersionStatus as ProtocolProviderVersionStatus,
ProvidersStatus, QueuedMessageStatus, RecentDir, ServerEvent, SessionEventRecord,
SessionStatus, TcodeUpdateStatus, TerminalContextStatus, TerminalSplitStatus, TerminalStatus,
Topic,
};
use tcode_services::acp_registry::{
Registry, RegistryAgent, cached, install, load, platform_key, resolve_recipe, uninstall,
visible_agents,
};
use tcode_services::export;
use tcode_services::git::{
CheckoutError, checkout_if_clean, cleanup_orphaned_worktrees, commit_diff_context,
create_git_worktree, list_git_branches, perform_action, read_git_branch, read_status,
remove_git_worktree, run_claude_headless, worktree_path_for,
CheckoutError, MergeWorktreeError, MergeWorktreeOutcome, checkout_if_clean,
cleanup_orphaned_worktrees, commit_diff_context, create_git_worktree, list_git_branches,
merge_worktree_back, perform_action, read_git_branch, read_status, remove_git_worktree,
run_claude_headless, run_git, worktree_path_for,
};
use tcode_services::import::{
ExternalImportUpdate, ExternalRoots, ImportOutcome, existing_external_ids, import_thread,
Expand Down
130 changes: 107 additions & 23 deletions crates/runtime/src/app/orchestrate.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -252,6 +252,15 @@ impl AppState {
result_max_chars,
);
meta.title = title;
self.install_child_session(meta, brief, cx)
}

fn install_child_session(
&mut self,
meta: SessionMeta,
brief: String,
cx: &mut HostCx,
) -> Result<String, String> {
self.enqueue_store_write(
StoreWrite::UpsertMeta {
meta: Box::new(meta.clone()),
Expand DownExpand Up@@ -307,6 +316,7 @@ impl AppState {
title,
brief,
cwd,
worktree,
archive_on_complete,
result_max_chars,
} => {
Expand DownExpand Up@@ -335,7 +345,8 @@ impl AppState {
};
let archive_on_complete =
archive_on_complete.unwrap_or(self.settings.orchestrate.archive_on_complete);
let Some(cwd) = cwd else {
let isolate = worktree.unwrap_or(self.settings.orchestrate.child_worktrees);
if cwd.is_none() && !isolate {
let result = self
.create_child_session(
&parent_id,
Expand All@@ -354,17 +365,32 @@ impl AppState {
.map(|id| serde_json::json!({ "thread_id": id }));
let _ = reply.try_send(result);
return;
};
let Some(parent_cwd) = self.find_meta(&parent_id).map(|meta| meta.cwd) else {
}
let Some(parent) = self.find_meta(&parent_id) else {
let _ = reply.try_send(Err("unknown parent session".to_string()));
return;
};
let path = PathBuf::from(cwd);
let path = if path.is_absolute() {
let path = PathBuf::from(cwd.unwrap_or_default());
let path = if path.as_os_str().is_empty() {
parent.cwd.clone()
} else if path.is_absolute() {
path
} else {
parent_cwd.join(path)
parent.cwd.join(path)
};
let mut meta = build_child_meta(
&parent,
provider,
Some(model),
effort,
profile_id,
approval_mode,
path.clone(),
archive_on_complete,
result_max_chars,
);
meta.title = title;
let child_id = meta.id.clone();
let host_cx = cx.clone();
HostCx::spawn_detached(cx, async move {
let resolved_cwd = host_cx
Expand All@@ -375,30 +401,39 @@ impl AppState {
if !canonical.is_dir() {
return Err(format!("invalid cwd: {}", canonical.display()));
}
Ok(canonical)
if isolate {
Ok(resolve_child_worktree(canonical, &child_id))
} else {
Ok((canonical, None, None))
}
})
.await;
let result = match resolved_cwd {
Ok(cwd) => host_cx
Ok((cwd, worktree, warning)) => host_cx
.enqueue_and_wait(move |state, cx| {
state.create_child_session(
&parent_id,
provider,
Some(model),
effort,
profile_id,
approval_mode,
title,
Some(cwd),
brief,
archive_on_complete,
result_max_chars,
cx,
)
meta.cwd = cwd;
meta.worktree = worktree;
let worktree_info = meta.worktree.clone();
state
.install_child_session(meta, brief, cx)
.map(|id| (id, worktree_info, warning))
})
.await
.unwrap_or_else(|_| Err("application closed".to_string()))
.map(|id| serde_json::json!({ "thread_id": id })),
.map(|(id, worktree, warning)| {
let mut response = serde_json::json!({ "thread_id": id });
if let Some(worktree) = worktree {
response["worktree_path"] = serde_json::json!(
worktree_path_for(&id).display().to_string()
);
response["worktree_branch"] =
serde_json::json!(worktree.branch);
}
if let Some(warning) = warning {
response["warning"] = serde_json::json!(warning);
}
response
}),
Err(err) => Err(err),
};
let _ = reply.try_send(result);
Expand DownExpand Up@@ -1211,6 +1246,55 @@ pub(super) fn provider_name(provider: ProviderKind) -> &'static str {
}
}

fn resolve_child_worktree(
cwd: PathBuf,
child_id: &str,
) -> (PathBuf, Option<WorktreeInfo>, Option<String>) {
let repo_root = run_git(&cwd, &["rev-parse", "--show-toplevel"])
.ok()
.map(|root| PathBuf::from(root.trim()))
.and_then(|root| root.canonicalize().ok());
if repo_root.as_ref() != Some(&cwd) {
let warning = format!(
"worktree isolation unavailable: {} is not a Git repository root; using the plain cwd",
cwd.display()
);
log::warn!("orchestrate dispatch: {warning}");
return (cwd, None, Some(warning));
}

let base = run_git(&cwd, &["symbolic-ref", "--quiet", "--short", "HEAD"])
.or_else(|_| run_git(&cwd, &["rev-parse", "HEAD"]))
.map(|base| base.trim().to_string());
let base = match base {
Ok(base) => base,
Err(error) => {
let warning = format!(
"worktree isolation unavailable: could not resolve the base revision ({error}); using the plain cwd"
);
log::warn!("orchestrate dispatch: {warning}");
return (cwd, None, Some(warning));
}
};
let path = worktree_path_for(child_id);
let requested_branch = format!("tcode/{child_id}");
match create_git_worktree(&cwd, &path, &requested_branch, &base) {
Ok(created) => {
let info = WorktreeInfo {
root_project_path: cwd,
base,
branch: created.branch,
};
(created.path, Some(info), None)
}
Err(error) => {
let warning = format!("worktree isolation failed ({error}); using the plain cwd");
log::warn!("orchestrate dispatch: {warning}");
(cwd, None, Some(warning))
}
}
}

#[allow(clippy::too_many_arguments)] // mirrors the MCP dispatch schema
pub(super) fn build_child_meta(
parent: &SessionMeta,
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions crates/core/src/settings.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -323,6 +323,10 @@ pub struct OrchestrateSettings {
pub child_models: Vec<OrchestrateChildModel>,
#[serde(default)]
pub child_approval: ChildApprovalMode,
/// Give dispatched children dedicated Git worktrees when their resolved cwd
/// is itself a repository root. Dispatch-level `worktree` overrides this.
#[serde(default)]
pub child_worktrees: bool,
/// Archive completed children automatically once their terminal result has
/// been delivered to the parent. Per-dispatch `archive_on_complete`
/// overrides this; failed children always stay visible for retries.
Expand DownExpand Up@@ -393,6 +397,7 @@ impl Default for OrchestrateSettings {
},
],
child_approval: ChildApprovalMode::default(),
child_worktrees: false,
archive_on_complete: true,
}
}
Expand DownExpand Up@@ -1171,6 +1176,23 @@ mod tests {
}
}

#[test]
fn orchestrate_child_worktrees_default_false_and_round_trip() {
let legacy: OrchestrateSettings = serde_json::from_str("{}").unwrap();
assert!(!legacy.child_worktrees);

let settings = OrchestrateSettings {
child_worktrees: true,
..Default::default()
};
let json = serde_json::to_string(&settings).unwrap();
assert!(json.contains(r#""child_worktrees":true"#));
assert_eq!(
serde_json::from_str::<OrchestrateSettings>(&json).unwrap(),
settings
);
}

#[test]
fn orchestrate_child_legacy_default_effort_alias_parses() {
let settings: OrchestrateSettings = serde_json::from_str(
Expand Down
1 change: 1 addition & 0 deletions crates/orchestrate-mcp/src/lib.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,6 +16,7 @@ pub enum OrchestrateOp {
title: String,
brief: String,
cwd: Option<String>,
worktree: Option<bool>,
archive_on_complete: Option<bool>,
result_max_chars: Option<u32>,
},
Expand Down
8 changes: 7 additions & 1 deletion crates/orchestrate-mcp/src/tools.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,6 +28,11 @@ struct DispatchParams {
#[serde(default)]
cwd: Option<String>,
#[serde(default)]
#[schemars(
description = "Override Settings → Orchestrate child-worktree isolation for this dispatch. When true and cwd resolves to a Git repository root, the child runs on branch tcode/<thread-id> in a dedicated worktree. The response includes its path and branch. Non-Git cwd or creation failure falls back to cwd and reports a warning."
)]
worktree: Option<bool>,
#[serde(default)]
#[schemars(
description = "Override the auto-archive policy for this child. By default (per Settings → Orchestrate) a completed child is archived once its terminal result reaches you; failed children always stay visible. Set false to keep a completed child in the sidebar; send to an archived child unarchives it."
)]
Expand DownExpand Up@@ -82,7 +87,7 @@ impl OrchestrateTools {
}

#[tool(
description = "Dispatch a brief to a new child tcode thread and return its thread id. profile is the provider-profile id from the fleet table, required when the entry names one. access is one of read_only (review/investigation: read-only actions run without prompts; anything that mutates pauses for user approval), workspace_write (edits auto-approved inside the workspace), or full (default; no approval prompts). Completed children are auto-archived after their result is delivered unless archive_on_complete: false; failed children stay visible for retries."
description = "Dispatch a brief to a new child tcode thread and return its thread id. profile is the provider-profile id from the fleet table, required when the entry names one. access is one of read_only (review/investigation: read-only actions run without prompts; anything that mutates pauses for user approval), workspace_write (edits auto-approved inside the workspace), or full (default; no approval prompts). worktree optionally isolates the child in tcode/<thread-id> and overrides the Orchestrate setting; the response identifies the path and branch or explains fallback. Completed children are auto-archived after their result is delivered unless archive_on_complete: false; failed children stay visible for retries."
)]
async fn dispatch(
&self,
Expand All@@ -99,6 +104,7 @@ impl OrchestrateTools {
title: p.title,
brief: p.brief,
cwd: p.cwd,
worktree: p.worktree,
archive_on_complete: p.archive_on_complete,
result_max_chars: p.result_max_chars,
})
Expand Down
4 changes: 4 additions & 0 deletions crates/protocol/src/command.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -40,6 +40,7 @@ pub enum SettingsPatch {
AutoArchiveKeepCount(usize),
AutoArchiveNoticeShown(bool),
Orchestrate(OrchestrateSettings),
OrchestrateChildWorktrees(bool),
ComputerUse(ComputerUseSettings),
Browser(BrowserSettings),
TitleGeneration(TitleGenerationSettings),
Expand DownExpand Up@@ -196,6 +197,9 @@ pub enum Command {
session_id: String,
remove_worktree: bool,
},
MergeWorktree {
session_id: String,
},
DeleteProject {
project_id: String,
},
Expand Down
17 changes: 17 additions & 0 deletions crates/protocol/src/event.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -252,6 +252,17 @@ pub struct GitActionRequest {
pub feature_branch: Option<String>,
}

#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)]
#[serde(rename_all = "snake_case")]
pub enum MergeWorktreeFailure {
Missing,
DirtyWorktree,
DestinationDetached,
DirtyDestination,
DivergedConflict,
Git,
}

#[non_exhaustive]
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
#[serde(tag = "type", content = "content", rename_all = "snake_case")]
Expand DownExpand Up@@ -354,4 +365,10 @@ pub enum RuntimeNotice {
skipped: Vec<String>,
limit_reached: bool,
},
WorktreeMergedFastForward,
WorktreeMergedCommit,
WorktreeMergeFailed {
reason: MergeWorktreeFailure,
detail: Option<String>,
},
}
8 changes: 4 additions & 4 deletions crates/protocol/src/lib.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,10 +12,10 @@ mod wire;
pub use command::{Command, CommandResponse, SettingsPatch, ThreadExportFormat};
pub use event::{
AcpMarketplaceItem, EventEnvelope, GitActionRequest, GitStatusStatus, IndexSnapshot,
ProviderVersionStatus, ProvidersStatus, QueuedMessageStatus, RuntimeEffect, RuntimeError,
RuntimeNotice, RuntimeNotification, RuntimeOperationId, RuntimeToast, ServerEvent,
SessionEventRecord, SessionStatus, TcodeUpdateStatus, TerminalContextStatus,
TerminalSplitStatus, TerminalStatus, Topic,
MergeWorktreeFailure, ProviderVersionStatus, ProvidersStatus, QueuedMessageStatus,
RuntimeEffect, RuntimeError, RuntimeNotice, RuntimeNotification, RuntimeOperationId,
RuntimeToast, ServerEvent, SessionEventRecord, SessionStatus, TcodeUpdateStatus,
TerminalContextStatus, TerminalSplitStatus, TerminalStatus, Topic,
};
pub use query::{
ExternalThread, GitDiffResult, GitDiffScope, GitFileText, PathEntry, Query, QueryResponse,
Expand Down
6 changes: 6 additions & 0 deletions crates/protocol/src/tests.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -227,6 +227,11 @@ fn round_trips_top_level_wire_types() {
});
}

#[test]
fn orchestrate_child_worktrees_patch_round_trips() {
round_trip(&SettingsPatch::OrchestrateChildWorktrees(true));
}

fn assert_command_crosses_ndjson(id: u64, command: Command) {
match &command {
Command::ApplyPendingRelaunch => {}
Expand DownExpand Up@@ -275,6 +280,7 @@ fn assert_command_crosses_ndjson(id: u64, command: Command) {
Command::AutoArchiveSweep { .. } => {}
Command::RenameSession { .. } => {}
Command::ForkThread { .. } => {}
Command::MergeWorktree { .. } => {}
Command::DeleteSession { .. } => {}
Command::DeleteProject { .. } => {}
Command::MarkSessionUnread { .. } => {}
Expand Down
16 changes: 9 additions & 7 deletions crates/runtime/src/app/mod.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,20 +48,22 @@ use tcode_core::ui::{
};
use tcode_protocol::ThreadExportFormat;
use tcode_protocol::{
AcpMarketplaceItem, EventEnvelope, ExternalThread, GitStatusStatus, IndexSnapshot, PathEntry,
ProviderVersionStatus as ProtocolProviderVersionStatus, ProvidersStatus, QueuedMessageStatus,
RecentDir, ServerEvent, SessionEventRecord, SessionStatus, TcodeUpdateStatus,
TerminalContextStatus, TerminalSplitStatus, TerminalStatus, Topic,
AcpMarketplaceItem, EventEnvelope, ExternalThread, GitStatusStatus, IndexSnapshot,
MergeWorktreeFailure, PathEntry, ProviderVersionStatus as ProtocolProviderVersionStatus,
ProvidersStatus, QueuedMessageStatus, RecentDir, ServerEvent, SessionEventRecord,
SessionStatus, TcodeUpdateStatus, TerminalContextStatus, TerminalSplitStatus, TerminalStatus,
Topic,
};
use tcode_services::acp_registry::{
Registry, RegistryAgent, cached, install, load, platform_key, resolve_recipe, uninstall,
visible_agents,
};
use tcode_services::export;
use tcode_services::git::{
CheckoutError, checkout_if_clean, cleanup_orphaned_worktrees, commit_diff_context,
create_git_worktree, list_git_branches, perform_action, read_git_branch, read_status,
remove_git_worktree, run_claude_headless, worktree_path_for,
CheckoutError, MergeWorktreeError, MergeWorktreeOutcome, checkout_if_clean,
cleanup_orphaned_worktrees, commit_diff_context, create_git_worktree, list_git_branches,
merge_worktree_back, perform_action, read_git_branch, read_status, remove_git_worktree,
run_claude_headless, run_git, worktree_path_for,
};
use tcode_services::import::{
ExternalImportUpdate, ExternalRoots, ImportOutcome, existing_external_ids, import_thread,
Expand Down
130 changes: 107 additions & 23 deletions crates/runtime/src/app/orchestrate.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -252,6 +252,15 @@ impl AppState {
result_max_chars,
);
meta.title = title;
self.install_child_session(meta, brief, cx)
}

fn install_child_session(
&mut self,
meta: SessionMeta,
brief: String,
cx: &mut HostCx,
) -> Result<String, String> {
self.enqueue_store_write(
StoreWrite::UpsertMeta {
meta: Box::new(meta.clone()),
Expand DownExpand Up@@ -307,6 +316,7 @@ impl AppState {
title,
brief,
cwd,
worktree,
archive_on_complete,
result_max_chars,
} => {
Expand DownExpand Up@@ -335,7 +345,8 @@ impl AppState {
};
let archive_on_complete =
archive_on_complete.unwrap_or(self.settings.orchestrate.archive_on_complete);
let Some(cwd) = cwd else {
let isolate = worktree.unwrap_or(self.settings.orchestrate.child_worktrees);
if cwd.is_none() && !isolate {
let result = self
.create_child_session(
&parent_id,
Expand All@@ -354,17 +365,32 @@ impl AppState {
.map(|id| serde_json::json!({ "thread_id": id }));
let _ = reply.try_send(result);
return;
};
let Some(parent_cwd) = self.find_meta(&parent_id).map(|meta| meta.cwd) else {
}
let Some(parent) = self.find_meta(&parent_id) else {
let _ = reply.try_send(Err("unknown parent session".to_string()));
return;
};
let path = PathBuf::from(cwd);
let path = if path.is_absolute() {
let path = PathBuf::from(cwd.unwrap_or_default());
let path = if path.as_os_str().is_empty() {
parent.cwd.clone()
} else if path.is_absolute() {
path
} else {
parent_cwd.join(path)
parent.cwd.join(path)
};
let mut meta = build_child_meta(
&parent,
provider,
Some(model),
effort,
profile_id,
approval_mode,
path.clone(),
archive_on_complete,
result_max_chars,
);
meta.title = title;
let child_id = meta.id.clone();
let host_cx = cx.clone();
HostCx::spawn_detached(cx, async move {
let resolved_cwd = host_cx
Expand All@@ -375,30 +401,39 @@ impl AppState {
if !canonical.is_dir() {
return Err(format!("invalid cwd: {}", canonical.display()));
}
Ok(canonical)
if isolate {
Ok(resolve_child_worktree(canonical, &child_id))
} else {
Ok((canonical, None, None))
}
})
.await;
let result = match resolved_cwd {
Ok(cwd) => host_cx
Ok((cwd, worktree, warning)) => host_cx
.enqueue_and_wait(move |state, cx| {
state.create_child_session(
&parent_id,
provider,
Some(model),
effort,
profile_id,
approval_mode,
title,
Some(cwd),
brief,
archive_on_complete,
result_max_chars,
cx,
)
meta.cwd = cwd;
meta.worktree = worktree;
let worktree_info = meta.worktree.clone();
state
.install_child_session(meta, brief, cx)
.map(|id| (id, worktree_info, warning))
})
.await
.unwrap_or_else(|_| Err("application closed".to_string()))
.map(|id| serde_json::json!({ "thread_id": id })),
.map(|(id, worktree, warning)| {
let mut response = serde_json::json!({ "thread_id": id });
if let Some(worktree) = worktree {
response["worktree_path"] = serde_json::json!(
worktree_path_for(&id).display().to_string()
);
response["worktree_branch"] =
serde_json::json!(worktree.branch);
}
if let Some(warning) = warning {
response["warning"] = serde_json::json!(warning);
}
response
}),
Err(err) => Err(err),
};
let _ = reply.try_send(result);
Expand DownExpand Up@@ -1211,6 +1246,55 @@ pub(super) fn provider_name(provider: ProviderKind) -> &'static str {
}
}

fn resolve_child_worktree(
cwd: PathBuf,
child_id: &str,
) -> (PathBuf, Option<WorktreeInfo>, Option<String>) {
let repo_root = run_git(&cwd, &["rev-parse", "--show-toplevel"])
.ok()
.map(|root| PathBuf::from(root.trim()))
.and_then(|root| root.canonicalize().ok());
if repo_root.as_ref() != Some(&cwd) {
let warning = format!(
"worktree isolation unavailable: {} is not a Git repository root; using the plain cwd",
cwd.display()
);
log::warn!("orchestrate dispatch: {warning}");
return (cwd, None, Some(warning));
}

let base = run_git(&cwd, &["symbolic-ref", "--quiet", "--short", "HEAD"])
.or_else(|_| run_git(&cwd, &["rev-parse", "HEAD"]))
.map(|base| base.trim().to_string());
let base = match base {
Ok(base) => base,
Err(error) => {
let warning = format!(
"worktree isolation unavailable: could not resolve the base revision ({error}); using the plain cwd"
);
log::warn!("orchestrate dispatch: {warning}");
return (cwd, None, Some(warning));
}
};
let path = worktree_path_for(child_id);
let requested_branch = format!("tcode/{child_id}");
match create_git_worktree(&cwd, &path, &requested_branch, &base) {
Ok(created) => {
let info = WorktreeInfo {
root_project_path: cwd,
base,
branch: created.branch,
};
(created.path, Some(info), None)
}
Err(error) => {
let warning = format!("worktree isolation failed ({error}); using the plain cwd");
log::warn!("orchestrate dispatch: {warning}");
(cwd, None, Some(warning))
}
}
}

#[allow(clippy::too_many_arguments)] // mirrors the MCP dispatch schema
pub(super) fn build_child_meta(
parent: &SessionMeta,
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions crates/core/src/settings.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -323,6 +323,10 @@ pub struct OrchestrateSettings {
pub child_models: Vec<OrchestrateChildModel>,
#[serde(default)]
pub child_approval: ChildApprovalMode,
/// Give dispatched children dedicated Git worktrees when their resolved cwd
/// is itself a repository root. Dispatch-level `worktree` overrides this.
#[serde(default)]
pub child_worktrees: bool,
/// Archive completed children automatically once their terminal result has
/// been delivered to the parent. Per-dispatch `archive_on_complete`
/// overrides this; failed children always stay visible for retries.
Expand DownExpand Up@@ -393,6 +397,7 @@ impl Default for OrchestrateSettings {
},
],
child_approval: ChildApprovalMode::default(),
child_worktrees: false,
archive_on_complete: true,
}
}
Expand DownExpand Up@@ -1171,6 +1176,23 @@ mod tests {
}
}

#[test]
fn orchestrate_child_worktrees_default_false_and_round_trip() {
let legacy: OrchestrateSettings = serde_json::from_str("{}").unwrap();
assert!(!legacy.child_worktrees);

let settings = OrchestrateSettings {
child_worktrees: true,
..Default::default()
};
let json = serde_json::to_string(&settings).unwrap();
assert!(json.contains(r#""child_worktrees":true"#));
assert_eq!(
serde_json::from_str::<OrchestrateSettings>(&json).unwrap(),
settings
);
}

#[test]
fn orchestrate_child_legacy_default_effort_alias_parses() {
let settings: OrchestrateSettings = serde_json::from_str(
Expand Down
1 change: 1 addition & 0 deletions crates/orchestrate-mcp/src/lib.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,6 +16,7 @@ pub enum OrchestrateOp {
title: String,
brief: String,
cwd: Option<String>,
worktree: Option<bool>,
archive_on_complete: Option<bool>,
result_max_chars: Option<u32>,
},
Expand Down
8 changes: 7 additions & 1 deletion crates/orchestrate-mcp/src/tools.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,6 +28,11 @@ struct DispatchParams {
#[serde(default)]
cwd: Option<String>,
#[serde(default)]
#[schemars(
description = "Override Settings → Orchestrate child-worktree isolation for this dispatch. When true and cwd resolves to a Git repository root, the child runs on branch tcode/<thread-id> in a dedicated worktree. The response includes its path and branch. Non-Git cwd or creation failure falls back to cwd and reports a warning."
)]
worktree: Option<bool>,
#[serde(default)]
#[schemars(
description = "Override the auto-archive policy for this child. By default (per Settings → Orchestrate) a completed child is archived once its terminal result reaches you; failed children always stay visible. Set false to keep a completed child in the sidebar; send to an archived child unarchives it."
)]
Expand DownExpand Up@@ -82,7 +87,7 @@ impl OrchestrateTools {
}

#[tool(
description = "Dispatch a brief to a new child tcode thread and return its thread id. profile is the provider-profile id from the fleet table, required when the entry names one. access is one of read_only (review/investigation: read-only actions run without prompts; anything that mutates pauses for user approval), workspace_write (edits auto-approved inside the workspace), or full (default; no approval prompts). Completed children are auto-archived after their result is delivered unless archive_on_complete: false; failed children stay visible for retries."
description = "Dispatch a brief to a new child tcode thread and return its thread id. profile is the provider-profile id from the fleet table, required when the entry names one. access is one of read_only (review/investigation: read-only actions run without prompts; anything that mutates pauses for user approval), workspace_write (edits auto-approved inside the workspace), or full (default; no approval prompts). worktree optionally isolates the child in tcode/<thread-id> and overrides the Orchestrate setting; the response identifies the path and branch or explains fallback. Completed children are auto-archived after their result is delivered unless archive_on_complete: false; failed children stay visible for retries."
)]
async fn dispatch(
&self,
Expand All@@ -99,6 +104,7 @@ impl OrchestrateTools {
title: p.title,
brief: p.brief,
cwd: p.cwd,
worktree: p.worktree,
archive_on_complete: p.archive_on_complete,
result_max_chars: p.result_max_chars,
})
Expand Down
4 changes: 4 additions & 0 deletions crates/protocol/src/command.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -40,6 +40,7 @@ pub enum SettingsPatch {
AutoArchiveKeepCount(usize),
AutoArchiveNoticeShown(bool),
Orchestrate(OrchestrateSettings),
OrchestrateChildWorktrees(bool),
ComputerUse(ComputerUseSettings),
Browser(BrowserSettings),
TitleGeneration(TitleGenerationSettings),
Expand DownExpand Up@@ -196,6 +197,9 @@ pub enum Command {
session_id: String,
remove_worktree: bool,
},
MergeWorktree {
session_id: String,
},
DeleteProject {
project_id: String,
},
Expand Down
17 changes: 17 additions & 0 deletions crates/protocol/src/event.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -252,6 +252,17 @@ pub struct GitActionRequest {
pub feature_branch: Option<String>,
}

#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)]
#[serde(rename_all = "snake_case")]
pub enum MergeWorktreeFailure {
Missing,
DirtyWorktree,
DestinationDetached,
DirtyDestination,
DivergedConflict,
Git,
}

#[non_exhaustive]
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
#[serde(tag = "type", content = "content", rename_all = "snake_case")]
Expand DownExpand Up@@ -354,4 +365,10 @@ pub enum RuntimeNotice {
skipped: Vec<String>,
limit_reached: bool,
},
WorktreeMergedFastForward,
WorktreeMergedCommit,
WorktreeMergeFailed {
reason: MergeWorktreeFailure,
detail: Option<String>,
},
}
8 changes: 4 additions & 4 deletions crates/protocol/src/lib.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,10 +12,10 @@ mod wire;
pub use command::{Command, CommandResponse, SettingsPatch, ThreadExportFormat};
pub use event::{
AcpMarketplaceItem, EventEnvelope, GitActionRequest, GitStatusStatus, IndexSnapshot,
ProviderVersionStatus, ProvidersStatus, QueuedMessageStatus, RuntimeEffect, RuntimeError,
RuntimeNotice, RuntimeNotification, RuntimeOperationId, RuntimeToast, ServerEvent,
SessionEventRecord, SessionStatus, TcodeUpdateStatus, TerminalContextStatus,
TerminalSplitStatus, TerminalStatus, Topic,
MergeWorktreeFailure, ProviderVersionStatus, ProvidersStatus, QueuedMessageStatus,
RuntimeEffect, RuntimeError, RuntimeNotice, RuntimeNotification, RuntimeOperationId,
RuntimeToast, ServerEvent, SessionEventRecord, SessionStatus, TcodeUpdateStatus,
TerminalContextStatus, TerminalSplitStatus, TerminalStatus, Topic,
};
pub use query::{
ExternalThread, GitDiffResult, GitDiffScope, GitFileText, PathEntry, Query, QueryResponse,
Expand Down
6 changes: 6 additions & 0 deletions crates/protocol/src/tests.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -227,6 +227,11 @@ fn round_trips_top_level_wire_types() {
});
}

#[test]
fn orchestrate_child_worktrees_patch_round_trips() {
round_trip(&SettingsPatch::OrchestrateChildWorktrees(true));
}

fn assert_command_crosses_ndjson(id: u64, command: Command) {
match &command {
Command::ApplyPendingRelaunch => {}
Expand DownExpand Up@@ -275,6 +280,7 @@ fn assert_command_crosses_ndjson(id: u64, command: Command) {
Command::AutoArchiveSweep { .. } => {}
Command::RenameSession { .. } => {}
Command::ForkThread { .. } => {}
Command::MergeWorktree { .. } => {}
Command::DeleteSession { .. } => {}
Command::DeleteProject { .. } => {}
Command::MarkSessionUnread { .. } => {}
Expand Down
16 changes: 9 additions & 7 deletions crates/runtime/src/app/mod.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,20 +48,22 @@ use tcode_core::ui::{
};
use tcode_protocol::ThreadExportFormat;
use tcode_protocol::{
AcpMarketplaceItem, EventEnvelope, ExternalThread, GitStatusStatus, IndexSnapshot, PathEntry,
ProviderVersionStatus as ProtocolProviderVersionStatus, ProvidersStatus, QueuedMessageStatus,
RecentDir, ServerEvent, SessionEventRecord, SessionStatus, TcodeUpdateStatus,
TerminalContextStatus, TerminalSplitStatus, TerminalStatus, Topic,
AcpMarketplaceItem, EventEnvelope, ExternalThread, GitStatusStatus, IndexSnapshot,
MergeWorktreeFailure, PathEntry, ProviderVersionStatus as ProtocolProviderVersionStatus,
ProvidersStatus, QueuedMessageStatus, RecentDir, ServerEvent, SessionEventRecord,
SessionStatus, TcodeUpdateStatus, TerminalContextStatus, TerminalSplitStatus, TerminalStatus,
Topic,
};
use tcode_services::acp_registry::{
Registry, RegistryAgent, cached, install, load, platform_key, resolve_recipe, uninstall,
visible_agents,
};
use tcode_services::export;
use tcode_services::git::{
CheckoutError, checkout_if_clean, cleanup_orphaned_worktrees, commit_diff_context,
create_git_worktree, list_git_branches, perform_action, read_git_branch, read_status,
remove_git_worktree, run_claude_headless, worktree_path_for,
CheckoutError, MergeWorktreeError, MergeWorktreeOutcome, checkout_if_clean,
cleanup_orphaned_worktrees, commit_diff_context, create_git_worktree, list_git_branches,
merge_worktree_back, perform_action, read_git_branch, read_status, remove_git_worktree,
run_claude_headless, run_git, worktree_path_for,
};
use tcode_services::import::{
ExternalImportUpdate, ExternalRoots, ImportOutcome, existing_external_ids, import_thread,
Expand Down
130 changes: 107 additions & 23 deletions crates/runtime/src/app/orchestrate.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -252,6 +252,15 @@ impl AppState {
result_max_chars,
);
meta.title = title;
self.install_child_session(meta, brief, cx)
}

fn install_child_session(
&mut self,
meta: SessionMeta,
brief: String,
cx: &mut HostCx,
) -> Result<String, String> {
self.enqueue_store_write(
StoreWrite::UpsertMeta {
meta: Box::new(meta.clone()),
Expand DownExpand Up@@ -307,6 +316,7 @@ impl AppState {
title,
brief,
cwd,
worktree,
archive_on_complete,
result_max_chars,
} => {
Expand DownExpand Up@@ -335,7 +345,8 @@ impl AppState {
};
let archive_on_complete =
archive_on_complete.unwrap_or(self.settings.orchestrate.archive_on_complete);
let Some(cwd) = cwd else {
let isolate = worktree.unwrap_or(self.settings.orchestrate.child_worktrees);
if cwd.is_none() && !isolate {
let result = self
.create_child_session(
&parent_id,
Expand All@@ -354,17 +365,32 @@ impl AppState {
.map(|id| serde_json::json!({ "thread_id": id }));
let _ = reply.try_send(result);
return;
};
let Some(parent_cwd) = self.find_meta(&parent_id).map(|meta| meta.cwd) else {
}
let Some(parent) = self.find_meta(&parent_id) else {
let _ = reply.try_send(Err("unknown parent session".to_string()));
return;
};
let path = PathBuf::from(cwd);
let path = if path.is_absolute() {
let path = PathBuf::from(cwd.unwrap_or_default());
let path = if path.as_os_str().is_empty() {
parent.cwd.clone()
} else if path.is_absolute() {
path
} else {
parent_cwd.join(path)
parent.cwd.join(path)
};
let mut meta = build_child_meta(
&parent,
provider,
Some(model),
effort,
profile_id,
approval_mode,
path.clone(),
archive_on_complete,
result_max_chars,
);
meta.title = title;
let child_id = meta.id.clone();
let host_cx = cx.clone();
HostCx::spawn_detached(cx, async move {
let resolved_cwd = host_cx
Expand All@@ -375,30 +401,39 @@ impl AppState {
if !canonical.is_dir() {
return Err(format!("invalid cwd: {}", canonical.display()));
}
Ok(canonical)
if isolate {
Ok(resolve_child_worktree(canonical, &child_id))
} else {
Ok((canonical, None, None))
}
})
.await;
let result = match resolved_cwd {
Ok(cwd) => host_cx
Ok((cwd, worktree, warning)) => host_cx
.enqueue_and_wait(move |state, cx| {
state.create_child_session(
&parent_id,
provider,
Some(model),
effort,
profile_id,
approval_mode,
title,
Some(cwd),
brief,
archive_on_complete,
result_max_chars,
cx,
)
meta.cwd = cwd;
meta.worktree = worktree;
let worktree_info = meta.worktree.clone();
state
.install_child_session(meta, brief, cx)
.map(|id| (id, worktree_info, warning))
})
.await
.unwrap_or_else(|_| Err("application closed".to_string()))
.map(|id| serde_json::json!({ "thread_id": id })),
.map(|(id, worktree, warning)| {
let mut response = serde_json::json!({ "thread_id": id });
if let Some(worktree) = worktree {
response["worktree_path"] = serde_json::json!(
worktree_path_for(&id).display().to_string()
);
response["worktree_branch"] =
serde_json::json!(worktree.branch);
}
if let Some(warning) = warning {
response["warning"] = serde_json::json!(warning);
}
response
}),
Err(err) => Err(err),
};
let _ = reply.try_send(result);
Expand DownExpand Up@@ -1211,6 +1246,55 @@ pub(super) fn provider_name(provider: ProviderKind) -> &'static str {
}
}

fn resolve_child_worktree(
cwd: PathBuf,
child_id: &str,
) -> (PathBuf, Option<WorktreeInfo>, Option<String>) {
let repo_root = run_git(&cwd, &["rev-parse", "--show-toplevel"])
.ok()
.map(|root| PathBuf::from(root.trim()))
.and_then(|root| root.canonicalize().ok());
if repo_root.as_ref() != Some(&cwd) {
let warning = format!(
"worktree isolation unavailable: {} is not a Git repository root; using the plain cwd",
cwd.display()
);
log::warn!("orchestrate dispatch: {warning}");
return (cwd, None, Some(warning));
}

let base = run_git(&cwd, &["symbolic-ref", "--quiet", "--short", "HEAD"])
.or_else(|_| run_git(&cwd, &["rev-parse", "HEAD"]))
.map(|base| base.trim().to_string());
let base = match base {
Ok(base) => base,
Err(error) => {
let warning = format!(
"worktree isolation unavailable: could not resolve the base revision ({error}); using the plain cwd"
);
log::warn!("orchestrate dispatch: {warning}");
return (cwd, None, Some(warning));
}
};
let path = worktree_path_for(child_id);
let requested_branch = format!("tcode/{child_id}");
match create_git_worktree(&cwd, &path, &requested_branch, &base) {
Ok(created) => {
let info = WorktreeInfo {
root_project_path: cwd,
base,
branch: created.branch,
};
(created.path, Some(info), None)
}
Err(error) => {
let warning = format!("worktree isolation failed ({error}); using the plain cwd");
log::warn!("orchestrate dispatch: {warning}");
(cwd, None, Some(warning))
}
}
}

#[allow(clippy::too_many_arguments)] // mirrors the MCP dispatch schema
pub(super) fn build_child_meta(
parent: &SessionMeta,
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions crates/core/src/settings.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -323,6 +323,10 @@ pub struct OrchestrateSettings {
pub child_models: Vec<OrchestrateChildModel>,
#[serde(default)]
pub child_approval: ChildApprovalMode,
/// Give dispatched children dedicated Git worktrees when their resolved cwd
/// is itself a repository root. Dispatch-level `worktree` overrides this.
#[serde(default)]
pub child_worktrees: bool,
/// Archive completed children automatically once their terminal result has
/// been delivered to the parent. Per-dispatch `archive_on_complete`
/// overrides this; failed children always stay visible for retries.
Expand DownExpand Up@@ -393,6 +397,7 @@ impl Default for OrchestrateSettings {
},
],
child_approval: ChildApprovalMode::default(),
child_worktrees: false,
archive_on_complete: true,
}
}
Expand DownExpand Up@@ -1171,6 +1176,23 @@ mod tests {
}
}

#[test]
fn orchestrate_child_worktrees_default_false_and_round_trip() {
let legacy: OrchestrateSettings = serde_json::from_str("{}").unwrap();
assert!(!legacy.child_worktrees);

let settings = OrchestrateSettings {
child_worktrees: true,
..Default::default()
};
let json = serde_json::to_string(&settings).unwrap();
assert!(json.contains(r#""child_worktrees":true"#));
assert_eq!(
serde_json::from_str::<OrchestrateSettings>(&json).unwrap(),
settings
);
}

#[test]
fn orchestrate_child_legacy_default_effort_alias_parses() {
let settings: OrchestrateSettings = serde_json::from_str(
Expand Down
1 change: 1 addition & 0 deletions crates/orchestrate-mcp/src/lib.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,6 +16,7 @@ pub enum OrchestrateOp {
title: String,
brief: String,
cwd: Option<String>,
worktree: Option<bool>,
archive_on_complete: Option<bool>,
result_max_chars: Option<u32>,
},
Expand Down
8 changes: 7 additions & 1 deletion crates/orchestrate-mcp/src/tools.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,6 +28,11 @@ struct DispatchParams {
#[serde(default)]
cwd: Option<String>,
#[serde(default)]
#[schemars(
description = "Override Settings → Orchestrate child-worktree isolation for this dispatch. When true and cwd resolves to a Git repository root, the child runs on branch tcode/<thread-id> in a dedicated worktree. The response includes its path and branch. Non-Git cwd or creation failure falls back to cwd and reports a warning."
)]
worktree: Option<bool>,
#[serde(default)]
#[schemars(
description = "Override the auto-archive policy for this child. By default (per Settings → Orchestrate) a completed child is archived once its terminal result reaches you; failed children always stay visible. Set false to keep a completed child in the sidebar; send to an archived child unarchives it."
)]
Expand DownExpand Up@@ -82,7 +87,7 @@ impl OrchestrateTools {
}

#[tool(
description = "Dispatch a brief to a new child tcode thread and return its thread id. profile is the provider-profile id from the fleet table, required when the entry names one. access is one of read_only (review/investigation: read-only actions run without prompts; anything that mutates pauses for user approval), workspace_write (edits auto-approved inside the workspace), or full (default; no approval prompts). Completed children are auto-archived after their result is delivered unless archive_on_complete: false; failed children stay visible for retries."
description = "Dispatch a brief to a new child tcode thread and return its thread id. profile is the provider-profile id from the fleet table, required when the entry names one. access is one of read_only (review/investigation: read-only actions run without prompts; anything that mutates pauses for user approval), workspace_write (edits auto-approved inside the workspace), or full (default; no approval prompts). worktree optionally isolates the child in tcode/<thread-id> and overrides the Orchestrate setting; the response identifies the path and branch or explains fallback. Completed children are auto-archived after their result is delivered unless archive_on_complete: false; failed children stay visible for retries."
)]
async fn dispatch(
&self,
Expand All@@ -99,6 +104,7 @@ impl OrchestrateTools {
title: p.title,
brief: p.brief,
cwd: p.cwd,
worktree: p.worktree,
archive_on_complete: p.archive_on_complete,
result_max_chars: p.result_max_chars,
})
Expand Down
4 changes: 4 additions & 0 deletions crates/protocol/src/command.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -40,6 +40,7 @@ pub enum SettingsPatch {
AutoArchiveKeepCount(usize),
AutoArchiveNoticeShown(bool),
Orchestrate(OrchestrateSettings),
OrchestrateChildWorktrees(bool),
ComputerUse(ComputerUseSettings),
Browser(BrowserSettings),
TitleGeneration(TitleGenerationSettings),
Expand DownExpand Up@@ -196,6 +197,9 @@ pub enum Command {
session_id: String,
remove_worktree: bool,
},
MergeWorktree {
session_id: String,
},
DeleteProject {
project_id: String,
},
Expand Down
17 changes: 17 additions & 0 deletions crates/protocol/src/event.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -252,6 +252,17 @@ pub struct GitActionRequest {
pub feature_branch: Option<String>,
}

#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)]
#[serde(rename_all = "snake_case")]
pub enum MergeWorktreeFailure {
Missing,
DirtyWorktree,
DestinationDetached,
DirtyDestination,
DivergedConflict,
Git,
}

#[non_exhaustive]
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
#[serde(tag = "type", content = "content", rename_all = "snake_case")]
Expand DownExpand Up@@ -354,4 +365,10 @@ pub enum RuntimeNotice {
skipped: Vec<String>,
limit_reached: bool,
},
WorktreeMergedFastForward,
WorktreeMergedCommit,
WorktreeMergeFailed {
reason: MergeWorktreeFailure,
detail: Option<String>,
},
}
8 changes: 4 additions & 4 deletions crates/protocol/src/lib.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,10 +12,10 @@ mod wire;
pub use command::{Command, CommandResponse, SettingsPatch, ThreadExportFormat};
pub use event::{
AcpMarketplaceItem, EventEnvelope, GitActionRequest, GitStatusStatus, IndexSnapshot,
ProviderVersionStatus, ProvidersStatus, QueuedMessageStatus, RuntimeEffect, RuntimeError,
RuntimeNotice, RuntimeNotification, RuntimeOperationId, RuntimeToast, ServerEvent,
SessionEventRecord, SessionStatus, TcodeUpdateStatus, TerminalContextStatus,
TerminalSplitStatus, TerminalStatus, Topic,
MergeWorktreeFailure, ProviderVersionStatus, ProvidersStatus, QueuedMessageStatus,
RuntimeEffect, RuntimeError, RuntimeNotice, RuntimeNotification, RuntimeOperationId,
RuntimeToast, ServerEvent, SessionEventRecord, SessionStatus, TcodeUpdateStatus,
TerminalContextStatus, TerminalSplitStatus, TerminalStatus, Topic,
};
pub use query::{
ExternalThread, GitDiffResult, GitDiffScope, GitFileText, PathEntry, Query, QueryResponse,
Expand Down
6 changes: 6 additions & 0 deletions crates/protocol/src/tests.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -227,6 +227,11 @@ fn round_trips_top_level_wire_types() {
});
}

#[test]
fn orchestrate_child_worktrees_patch_round_trips() {
round_trip(&SettingsPatch::OrchestrateChildWorktrees(true));
}

fn assert_command_crosses_ndjson(id: u64, command: Command) {
match &command {
Command::ApplyPendingRelaunch => {}
Expand DownExpand Up@@ -275,6 +280,7 @@ fn assert_command_crosses_ndjson(id: u64, command: Command) {
Command::AutoArchiveSweep { .. } => {}
Command::RenameSession { .. } => {}
Command::ForkThread { .. } => {}
Command::MergeWorktree { .. } => {}
Command::DeleteSession { .. } => {}
Command::DeleteProject { .. } => {}
Command::MarkSessionUnread { .. } => {}
Expand Down
16 changes: 9 additions & 7 deletions crates/runtime/src/app/mod.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,20 +48,22 @@ use tcode_core::ui::{
};
use tcode_protocol::ThreadExportFormat;
use tcode_protocol::{
AcpMarketplaceItem, EventEnvelope, ExternalThread, GitStatusStatus, IndexSnapshot, PathEntry,
ProviderVersionStatus as ProtocolProviderVersionStatus, ProvidersStatus, QueuedMessageStatus,
RecentDir, ServerEvent, SessionEventRecord, SessionStatus, TcodeUpdateStatus,
TerminalContextStatus, TerminalSplitStatus, TerminalStatus, Topic,
AcpMarketplaceItem, EventEnvelope, ExternalThread, GitStatusStatus, IndexSnapshot,
MergeWorktreeFailure, PathEntry, ProviderVersionStatus as ProtocolProviderVersionStatus,
ProvidersStatus, QueuedMessageStatus, RecentDir, ServerEvent, SessionEventRecord,
SessionStatus, TcodeUpdateStatus, TerminalContextStatus, TerminalSplitStatus, TerminalStatus,
Topic,
};
use tcode_services::acp_registry::{
Registry, RegistryAgent, cached, install, load, platform_key, resolve_recipe, uninstall,
visible_agents,
};
use tcode_services::export;
use tcode_services::git::{
CheckoutError, checkout_if_clean, cleanup_orphaned_worktrees, commit_diff_context,
create_git_worktree, list_git_branches, perform_action, read_git_branch, read_status,
remove_git_worktree, run_claude_headless, worktree_path_for,
CheckoutError, MergeWorktreeError, MergeWorktreeOutcome, checkout_if_clean,
cleanup_orphaned_worktrees, commit_diff_context, create_git_worktree, list_git_branches,
merge_worktree_back, perform_action, read_git_branch, read_status, remove_git_worktree,
run_claude_headless, run_git, worktree_path_for,
};
use tcode_services::import::{
ExternalImportUpdate, ExternalRoots, ImportOutcome, existing_external_ids, import_thread,
Expand Down
130 changes: 107 additions & 23 deletions crates/runtime/src/app/orchestrate.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -252,6 +252,15 @@ impl AppState {
result_max_chars,
);
meta.title = title;
self.install_child_session(meta, brief, cx)
}

fn install_child_session(
&mut self,
meta: SessionMeta,
brief: String,
cx: &mut HostCx,
) -> Result<String, String> {
self.enqueue_store_write(
StoreWrite::UpsertMeta {
meta: Box::new(meta.clone()),
Expand DownExpand Up@@ -307,6 +316,7 @@ impl AppState {
title,
brief,
cwd,
worktree,
archive_on_complete,
result_max_chars,
} => {
Expand DownExpand Up@@ -335,7 +345,8 @@ impl AppState {
};
let archive_on_complete =
archive_on_complete.unwrap_or(self.settings.orchestrate.archive_on_complete);
let Some(cwd) = cwd else {
let isolate = worktree.unwrap_or(self.settings.orchestrate.child_worktrees);
if cwd.is_none() && !isolate {
let result = self
.create_child_session(
&parent_id,
Expand All@@ -354,17 +365,32 @@ impl AppState {
.map(|id| serde_json::json!({ "thread_id": id }));
let _ = reply.try_send(result);
return;
};
let Some(parent_cwd) = self.find_meta(&parent_id).map(|meta| meta.cwd) else {
}
let Some(parent) = self.find_meta(&parent_id) else {
let _ = reply.try_send(Err("unknown parent session".to_string()));
return;
};
let path = PathBuf::from(cwd);
let path = if path.is_absolute() {
let path = PathBuf::from(cwd.unwrap_or_default());
let path = if path.as_os_str().is_empty() {
parent.cwd.clone()
} else if path.is_absolute() {
path
} else {
parent_cwd.join(path)
parent.cwd.join(path)
};
let mut meta = build_child_meta(
&parent,
provider,
Some(model),
effort,
profile_id,
approval_mode,
path.clone(),
archive_on_complete,
result_max_chars,
);
meta.title = title;
let child_id = meta.id.clone();
let host_cx = cx.clone();
HostCx::spawn_detached(cx, async move {
let resolved_cwd = host_cx
Expand All@@ -375,30 +401,39 @@ impl AppState {
if !canonical.is_dir() {
return Err(format!("invalid cwd: {}", canonical.display()));
}
Ok(canonical)
if isolate {
Ok(resolve_child_worktree(canonical, &child_id))
} else {
Ok((canonical, None, None))
}
})
.await;
let result = match resolved_cwd {
Ok(cwd) => host_cx
Ok((cwd, worktree, warning)) => host_cx
.enqueue_and_wait(move |state, cx| {
state.create_child_session(
&parent_id,
provider,
Some(model),
effort,
profile_id,
approval_mode,
title,
Some(cwd),
brief,
archive_on_complete,
result_max_chars,
cx,
)
meta.cwd = cwd;
meta.worktree = worktree;
let worktree_info = meta.worktree.clone();
state
.install_child_session(meta, brief, cx)
.map(|id| (id, worktree_info, warning))
})
.await
.unwrap_or_else(|_| Err("application closed".to_string()))
.map(|id| serde_json::json!({ "thread_id": id })),
.map(|(id, worktree, warning)| {
let mut response = serde_json::json!({ "thread_id": id });
if let Some(worktree) = worktree {
response["worktree_path"] = serde_json::json!(
worktree_path_for(&id).display().to_string()
);
response["worktree_branch"] =
serde_json::json!(worktree.branch);
}
if let Some(warning) = warning {
response["warning"] = serde_json::json!(warning);
}
response
}),
Err(err) => Err(err),
};
let _ = reply.try_send(result);
Expand DownExpand Up@@ -1211,6 +1246,55 @@ pub(super) fn provider_name(provider: ProviderKind) -> &'static str {
}
}

fn resolve_child_worktree(
cwd: PathBuf,
child_id: &str,
) -> (PathBuf, Option<WorktreeInfo>, Option<String>) {
let repo_root = run_git(&cwd, &["rev-parse", "--show-toplevel"])
.ok()
.map(|root| PathBuf::from(root.trim()))
.and_then(|root| root.canonicalize().ok());
if repo_root.as_ref() != Some(&cwd) {
let warning = format!(
"worktree isolation unavailable: {} is not a Git repository root; using the plain cwd",
cwd.display()
);
log::warn!("orchestrate dispatch: {warning}");
return (cwd, None, Some(warning));
}

let base = run_git(&cwd, &["symbolic-ref", "--quiet", "--short", "HEAD"])
.or_else(|_| run_git(&cwd, &["rev-parse", "HEAD"]))
.map(|base| base.trim().to_string());
let base = match base {
Ok(base) => base,
Err(error) => {
let warning = format!(
"worktree isolation unavailable: could not resolve the base revision ({error}); using the plain cwd"
);
log::warn!("orchestrate dispatch: {warning}");
return (cwd, None, Some(warning));
}
};
let path = worktree_path_for(child_id);
let requested_branch = format!("tcode/{child_id}");
match create_git_worktree(&cwd, &path, &requested_branch, &base) {
Ok(created) => {
let info = WorktreeInfo {
root_project_path: cwd,
base,
branch: created.branch,
};
(created.path, Some(info), None)
}
Err(error) => {
let warning = format!("worktree isolation failed ({error}); using the plain cwd");
log::warn!("orchestrate dispatch: {warning}");
(cwd, None, Some(warning))
}
}
}

#[allow(clippy::too_many_arguments)] // mirrors the MCP dispatch schema
pub(super) fn build_child_meta(
parent: &SessionMeta,
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions crates/core/src/settings.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -323,6 +323,10 @@ pub struct OrchestrateSettings {
pub child_models: Vec<OrchestrateChildModel>,
#[serde(default)]
pub child_approval: ChildApprovalMode,
/// Give dispatched children dedicated Git worktrees when their resolved cwd
/// is itself a repository root. Dispatch-level `worktree` overrides this.
#[serde(default)]
pub child_worktrees: bool,
/// Archive completed children automatically once their terminal result has
/// been delivered to the parent. Per-dispatch `archive_on_complete`
/// overrides this; failed children always stay visible for retries.
Expand DownExpand Up@@ -393,6 +397,7 @@ impl Default for OrchestrateSettings {
},
],
child_approval: ChildApprovalMode::default(),
child_worktrees: false,
archive_on_complete: true,
}
}
Expand DownExpand Up@@ -1171,6 +1176,23 @@ mod tests {
}
}

#[test]
fn orchestrate_child_worktrees_default_false_and_round_trip() {
let legacy: OrchestrateSettings = serde_json::from_str("{}").unwrap();
assert!(!legacy.child_worktrees);

let settings = OrchestrateSettings {
child_worktrees: true,
..Default::default()
};
let json = serde_json::to_string(&settings).unwrap();
assert!(json.contains(r#""child_worktrees":true"#));
assert_eq!(
serde_json::from_str::<OrchestrateSettings>(&json).unwrap(),
settings
);
}

#[test]
fn orchestrate_child_legacy_default_effort_alias_parses() {
let settings: OrchestrateSettings = serde_json::from_str(
Expand Down
1 change: 1 addition & 0 deletions crates/orchestrate-mcp/src/lib.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,6 +16,7 @@ pub enum OrchestrateOp {
title: String,
brief: String,
cwd: Option<String>,
worktree: Option<bool>,
archive_on_complete: Option<bool>,
result_max_chars: Option<u32>,
},
Expand Down
8 changes: 7 additions & 1 deletion crates/orchestrate-mcp/src/tools.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,6 +28,11 @@ struct DispatchParams {
#[serde(default)]
cwd: Option<String>,
#[serde(default)]
#[schemars(
description = "Override Settings → Orchestrate child-worktree isolation for this dispatch. When true and cwd resolves to a Git repository root, the child runs on branch tcode/<thread-id> in a dedicated worktree. The response includes its path and branch. Non-Git cwd or creation failure falls back to cwd and reports a warning."
)]
worktree: Option<bool>,
#[serde(default)]
#[schemars(
description = "Override the auto-archive policy for this child. By default (per Settings → Orchestrate) a completed child is archived once its terminal result reaches you; failed children always stay visible. Set false to keep a completed child in the sidebar; send to an archived child unarchives it."
)]
Expand DownExpand Up@@ -82,7 +87,7 @@ impl OrchestrateTools {
}

#[tool(
description = "Dispatch a brief to a new child tcode thread and return its thread id. profile is the provider-profile id from the fleet table, required when the entry names one. access is one of read_only (review/investigation: read-only actions run without prompts; anything that mutates pauses for user approval), workspace_write (edits auto-approved inside the workspace), or full (default; no approval prompts). Completed children are auto-archived after their result is delivered unless archive_on_complete: false; failed children stay visible for retries."
description = "Dispatch a brief to a new child tcode thread and return its thread id. profile is the provider-profile id from the fleet table, required when the entry names one. access is one of read_only (review/investigation: read-only actions run without prompts; anything that mutates pauses for user approval), workspace_write (edits auto-approved inside the workspace), or full (default; no approval prompts). worktree optionally isolates the child in tcode/<thread-id> and overrides the Orchestrate setting; the response identifies the path and branch or explains fallback. Completed children are auto-archived after their result is delivered unless archive_on_complete: false; failed children stay visible for retries."
)]
async fn dispatch(
&self,
Expand All@@ -99,6 +104,7 @@ impl OrchestrateTools {
title: p.title,
brief: p.brief,
cwd: p.cwd,
worktree: p.worktree,
archive_on_complete: p.archive_on_complete,
result_max_chars: p.result_max_chars,
})
Expand Down
4 changes: 4 additions & 0 deletions crates/protocol/src/command.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -40,6 +40,7 @@ pub enum SettingsPatch {
AutoArchiveKeepCount(usize),
AutoArchiveNoticeShown(bool),
Orchestrate(OrchestrateSettings),
OrchestrateChildWorktrees(bool),
ComputerUse(ComputerUseSettings),
Browser(BrowserSettings),
TitleGeneration(TitleGenerationSettings),
Expand DownExpand Up@@ -196,6 +197,9 @@ pub enum Command {
session_id: String,
remove_worktree: bool,
},
MergeWorktree {
session_id: String,
},
DeleteProject {
project_id: String,
},
Expand Down
17 changes: 17 additions & 0 deletions crates/protocol/src/event.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -252,6 +252,17 @@ pub struct GitActionRequest {
pub feature_branch: Option<String>,
}

#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)]
#[serde(rename_all = "snake_case")]
pub enum MergeWorktreeFailure {
Missing,
DirtyWorktree,
DestinationDetached,
DirtyDestination,
DivergedConflict,
Git,
}

#[non_exhaustive]
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
#[serde(tag = "type", content = "content", rename_all = "snake_case")]
Expand DownExpand Up@@ -354,4 +365,10 @@ pub enum RuntimeNotice {
skipped: Vec<String>,
limit_reached: bool,
},
WorktreeMergedFastForward,
WorktreeMergedCommit,
WorktreeMergeFailed {
reason: MergeWorktreeFailure,
detail: Option<String>,
},
}
8 changes: 4 additions & 4 deletions crates/protocol/src/lib.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,10 +12,10 @@ mod wire;
pub use command::{Command, CommandResponse, SettingsPatch, ThreadExportFormat};
pub use event::{
AcpMarketplaceItem, EventEnvelope, GitActionRequest, GitStatusStatus, IndexSnapshot,
ProviderVersionStatus, ProvidersStatus, QueuedMessageStatus, RuntimeEffect, RuntimeError,
RuntimeNotice, RuntimeNotification, RuntimeOperationId, RuntimeToast, ServerEvent,
SessionEventRecord, SessionStatus, TcodeUpdateStatus, TerminalContextStatus,
TerminalSplitStatus, TerminalStatus, Topic,
MergeWorktreeFailure, ProviderVersionStatus, ProvidersStatus, QueuedMessageStatus,
RuntimeEffect, RuntimeError, RuntimeNotice, RuntimeNotification, RuntimeOperationId,
RuntimeToast, ServerEvent, SessionEventRecord, SessionStatus, TcodeUpdateStatus,
TerminalContextStatus, TerminalSplitStatus, TerminalStatus, Topic,
};
pub use query::{
ExternalThread, GitDiffResult, GitDiffScope, GitFileText, PathEntry, Query, QueryResponse,
Expand Down
6 changes: 6 additions & 0 deletions crates/protocol/src/tests.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -227,6 +227,11 @@ fn round_trips_top_level_wire_types() {
});
}

#[test]
fn orchestrate_child_worktrees_patch_round_trips() {
round_trip(&SettingsPatch::OrchestrateChildWorktrees(true));
}

fn assert_command_crosses_ndjson(id: u64, command: Command) {
match &command {
Command::ApplyPendingRelaunch => {}
Expand DownExpand Up@@ -275,6 +280,7 @@ fn assert_command_crosses_ndjson(id: u64, command: Command) {
Command::AutoArchiveSweep { .. } => {}
Command::RenameSession { .. } => {}
Command::ForkThread { .. } => {}
Command::MergeWorktree { .. } => {}
Command::DeleteSession { .. } => {}
Command::DeleteProject { .. } => {}
Command::MarkSessionUnread { .. } => {}
Expand Down
16 changes: 9 additions & 7 deletions crates/runtime/src/app/mod.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,20 +48,22 @@ use tcode_core::ui::{
};
use tcode_protocol::ThreadExportFormat;
use tcode_protocol::{
AcpMarketplaceItem, EventEnvelope, ExternalThread, GitStatusStatus, IndexSnapshot, PathEntry,
ProviderVersionStatus as ProtocolProviderVersionStatus, ProvidersStatus, QueuedMessageStatus,
RecentDir, ServerEvent, SessionEventRecord, SessionStatus, TcodeUpdateStatus,
TerminalContextStatus, TerminalSplitStatus, TerminalStatus, Topic,
AcpMarketplaceItem, EventEnvelope, ExternalThread, GitStatusStatus, IndexSnapshot,
MergeWorktreeFailure, PathEntry, ProviderVersionStatus as ProtocolProviderVersionStatus,
ProvidersStatus, QueuedMessageStatus, RecentDir, ServerEvent, SessionEventRecord,
SessionStatus, TcodeUpdateStatus, TerminalContextStatus, TerminalSplitStatus, TerminalStatus,
Topic,
};
use tcode_services::acp_registry::{
Registry, RegistryAgent, cached, install, load, platform_key, resolve_recipe, uninstall,
visible_agents,
};
use tcode_services::export;
use tcode_services::git::{
CheckoutError, checkout_if_clean, cleanup_orphaned_worktrees, commit_diff_context,
create_git_worktree, list_git_branches, perform_action, read_git_branch, read_status,
remove_git_worktree, run_claude_headless, worktree_path_for,
CheckoutError, MergeWorktreeError, MergeWorktreeOutcome, checkout_if_clean,
cleanup_orphaned_worktrees, commit_diff_context, create_git_worktree, list_git_branches,
merge_worktree_back, perform_action, read_git_branch, read_status, remove_git_worktree,
run_claude_headless, run_git, worktree_path_for,
};
use tcode_services::import::{
ExternalImportUpdate, ExternalRoots, ImportOutcome, existing_external_ids, import_thread,
Expand Down
130 changes: 107 additions & 23 deletions crates/runtime/src/app/orchestrate.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -252,6 +252,15 @@ impl AppState {
result_max_chars,
);
meta.title = title;
self.install_child_session(meta, brief, cx)
}

fn install_child_session(
&mut self,
meta: SessionMeta,
brief: String,
cx: &mut HostCx,
) -> Result<String, String> {
self.enqueue_store_write(
StoreWrite::UpsertMeta {
meta: Box::new(meta.clone()),
Expand DownExpand Up@@ -307,6 +316,7 @@ impl AppState {
title,
brief,
cwd,
worktree,
archive_on_complete,
result_max_chars,
} => {
Expand DownExpand Up@@ -335,7 +345,8 @@ impl AppState {
};
let archive_on_complete =
archive_on_complete.unwrap_or(self.settings.orchestrate.archive_on_complete);
let Some(cwd) = cwd else {
let isolate = worktree.unwrap_or(self.settings.orchestrate.child_worktrees);
if cwd.is_none() && !isolate {
let result = self
.create_child_session(
&parent_id,
Expand All@@ -354,17 +365,32 @@ impl AppState {
.map(|id| serde_json::json!({ "thread_id": id }));
let _ = reply.try_send(result);
return;
};
let Some(parent_cwd) = self.find_meta(&parent_id).map(|meta| meta.cwd) else {
}
let Some(parent) = self.find_meta(&parent_id) else {
let _ = reply.try_send(Err("unknown parent session".to_string()));
return;
};
let path = PathBuf::from(cwd);
let path = if path.is_absolute() {
let path = PathBuf::from(cwd.unwrap_or_default());
let path = if path.as_os_str().is_empty() {
parent.cwd.clone()
} else if path.is_absolute() {
path
} else {
parent_cwd.join(path)
parent.cwd.join(path)
};
let mut meta = build_child_meta(
&parent,
provider,
Some(model),
effort,
profile_id,
approval_mode,
path.clone(),
archive_on_complete,
result_max_chars,
);
meta.title = title;
let child_id = meta.id.clone();
let host_cx = cx.clone();
HostCx::spawn_detached(cx, async move {
let resolved_cwd = host_cx
Expand All@@ -375,30 +401,39 @@ impl AppState {
if !canonical.is_dir() {
return Err(format!("invalid cwd: {}", canonical.display()));
}
Ok(canonical)
if isolate {
Ok(resolve_child_worktree(canonical, &child_id))
} else {
Ok((canonical, None, None))
}
})
.await;
let result = match resolved_cwd {
Ok(cwd) => host_cx
Ok((cwd, worktree, warning)) => host_cx
.enqueue_and_wait(move |state, cx| {
state.create_child_session(
&parent_id,
provider,
Some(model),
effort,
profile_id,
approval_mode,
title,
Some(cwd),
brief,
archive_on_complete,
result_max_chars,
cx,
)
meta.cwd = cwd;
meta.worktree = worktree;
let worktree_info = meta.worktree.clone();
state
.install_child_session(meta, brief, cx)
.map(|id| (id, worktree_info, warning))
})
.await
.unwrap_or_else(|_| Err("application closed".to_string()))
.map(|id| serde_json::json!({ "thread_id": id })),
.map(|(id, worktree, warning)| {
let mut response = serde_json::json!({ "thread_id": id });
if let Some(worktree) = worktree {
response["worktree_path"] = serde_json::json!(
worktree_path_for(&id).display().to_string()
);
response["worktree_branch"] =
serde_json::json!(worktree.branch);
}
if let Some(warning) = warning {
response["warning"] = serde_json::json!(warning);
}
response
}),
Err(err) => Err(err),
};
let _ = reply.try_send(result);
Expand DownExpand Up@@ -1211,6 +1246,55 @@ pub(super) fn provider_name(provider: ProviderKind) -> &'static str {
}
}

fn resolve_child_worktree(
cwd: PathBuf,
child_id: &str,
) -> (PathBuf, Option<WorktreeInfo>, Option<String>) {
let repo_root = run_git(&cwd, &["rev-parse", "--show-toplevel"])
.ok()
.map(|root| PathBuf::from(root.trim()))
.and_then(|root| root.canonicalize().ok());
if repo_root.as_ref() != Some(&cwd) {
let warning = format!(
"worktree isolation unavailable: {} is not a Git repository root; using the plain cwd",
cwd.display()
);
log::warn!("orchestrate dispatch: {warning}");
return (cwd, None, Some(warning));
}

let base = run_git(&cwd, &["symbolic-ref", "--quiet", "--short", "HEAD"])
.or_else(|_| run_git(&cwd, &["rev-parse", "HEAD"]))
.map(|base| base.trim().to_string());
let base = match base {
Ok(base) => base,
Err(error) => {
let warning = format!(
"worktree isolation unavailable: could not resolve the base revision ({error}); using the plain cwd"
);
log::warn!("orchestrate dispatch: {warning}");
return (cwd, None, Some(warning));
}
};
let path = worktree_path_for(child_id);
let requested_branch = format!("tcode/{child_id}");
match create_git_worktree(&cwd, &path, &requested_branch, &base) {
Ok(created) => {
let info = WorktreeInfo {
root_project_path: cwd,
base,
branch: created.branch,
};
(created.path, Some(info), None)
}
Err(error) => {
let warning = format!("worktree isolation failed ({error}); using the plain cwd");
log::warn!("orchestrate dispatch: {warning}");
(cwd, None, Some(warning))
}
}
}

#[allow(clippy::too_many_arguments)] // mirrors the MCP dispatch schema
pub(super) fn build_child_meta(
parent: &SessionMeta,
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions crates/core/src/settings.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -323,6 +323,10 @@ pub struct OrchestrateSettings {
pub child_models: Vec<OrchestrateChildModel>,
#[serde(default)]
pub child_approval: ChildApprovalMode,
/// Give dispatched children dedicated Git worktrees when their resolved cwd
/// is itself a repository root. Dispatch-level `worktree` overrides this.
#[serde(default)]
pub child_worktrees: bool,
/// Archive completed children automatically once their terminal result has
/// been delivered to the parent. Per-dispatch `archive_on_complete`
/// overrides this; failed children always stay visible for retries.
Expand DownExpand Up@@ -393,6 +397,7 @@ impl Default for OrchestrateSettings {
},
],
child_approval: ChildApprovalMode::default(),
child_worktrees: false,
archive_on_complete: true,
}
}
Expand DownExpand Up@@ -1171,6 +1176,23 @@ mod tests {
}
}

#[test]
fn orchestrate_child_worktrees_default_false_and_round_trip() {
let legacy: OrchestrateSettings = serde_json::from_str("{}").unwrap();
assert!(!legacy.child_worktrees);

let settings = OrchestrateSettings {
child_worktrees: true,
..Default::default()
};
let json = serde_json::to_string(&settings).unwrap();
assert!(json.contains(r#""child_worktrees":true"#));
assert_eq!(
serde_json::from_str::<OrchestrateSettings>(&json).unwrap(),
settings
);
}

#[test]
fn orchestrate_child_legacy_default_effort_alias_parses() {
let settings: OrchestrateSettings = serde_json::from_str(
Expand Down
1 change: 1 addition & 0 deletions crates/orchestrate-mcp/src/lib.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,6 +16,7 @@ pub enum OrchestrateOp {
title: String,
brief: String,
cwd: Option<String>,
worktree: Option<bool>,
archive_on_complete: Option<bool>,
result_max_chars: Option<u32>,
},
Expand Down
8 changes: 7 additions & 1 deletion crates/orchestrate-mcp/src/tools.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,6 +28,11 @@ struct DispatchParams {
#[serde(default)]
cwd: Option<String>,
#[serde(default)]
#[schemars(
description = "Override Settings → Orchestrate child-worktree isolation for this dispatch. When true and cwd resolves to a Git repository root, the child runs on branch tcode/<thread-id> in a dedicated worktree. The response includes its path and branch. Non-Git cwd or creation failure falls back to cwd and reports a warning."
)]
worktree: Option<bool>,
#[serde(default)]
#[schemars(
description = "Override the auto-archive policy for this child. By default (per Settings → Orchestrate) a completed child is archived once its terminal result reaches you; failed children always stay visible. Set false to keep a completed child in the sidebar; send to an archived child unarchives it."
)]
Expand DownExpand Up@@ -82,7 +87,7 @@ impl OrchestrateTools {
}

#[tool(
description = "Dispatch a brief to a new child tcode thread and return its thread id. profile is the provider-profile id from the fleet table, required when the entry names one. access is one of read_only (review/investigation: read-only actions run without prompts; anything that mutates pauses for user approval), workspace_write (edits auto-approved inside the workspace), or full (default; no approval prompts). Completed children are auto-archived after their result is delivered unless archive_on_complete: false; failed children stay visible for retries."
description = "Dispatch a brief to a new child tcode thread and return its thread id. profile is the provider-profile id from the fleet table, required when the entry names one. access is one of read_only (review/investigation: read-only actions run without prompts; anything that mutates pauses for user approval), workspace_write (edits auto-approved inside the workspace), or full (default; no approval prompts). worktree optionally isolates the child in tcode/<thread-id> and overrides the Orchestrate setting; the response identifies the path and branch or explains fallback. Completed children are auto-archived after their result is delivered unless archive_on_complete: false; failed children stay visible for retries."
)]
async fn dispatch(
&self,
Expand All@@ -99,6 +104,7 @@ impl OrchestrateTools {
title: p.title,
brief: p.brief,
cwd: p.cwd,
worktree: p.worktree,
archive_on_complete: p.archive_on_complete,
result_max_chars: p.result_max_chars,
})
Expand Down
4 changes: 4 additions & 0 deletions crates/protocol/src/command.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -40,6 +40,7 @@ pub enum SettingsPatch {
AutoArchiveKeepCount(usize),
AutoArchiveNoticeShown(bool),
Orchestrate(OrchestrateSettings),
OrchestrateChildWorktrees(bool),
ComputerUse(ComputerUseSettings),
Browser(BrowserSettings),
TitleGeneration(TitleGenerationSettings),
Expand DownExpand Up@@ -196,6 +197,9 @@ pub enum Command {
session_id: String,
remove_worktree: bool,
},
MergeWorktree {
session_id: String,
},
DeleteProject {
project_id: String,
},
Expand Down
17 changes: 17 additions & 0 deletions crates/protocol/src/event.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -252,6 +252,17 @@ pub struct GitActionRequest {
pub feature_branch: Option<String>,
}

#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)]
#[serde(rename_all = "snake_case")]
pub enum MergeWorktreeFailure {
Missing,
DirtyWorktree,
DestinationDetached,
DirtyDestination,
DivergedConflict,
Git,
}

#[non_exhaustive]
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
#[serde(tag = "type", content = "content", rename_all = "snake_case")]
Expand DownExpand Up@@ -354,4 +365,10 @@ pub enum RuntimeNotice {
skipped: Vec<String>,
limit_reached: bool,
},
WorktreeMergedFastForward,
WorktreeMergedCommit,
WorktreeMergeFailed {
reason: MergeWorktreeFailure,
detail: Option<String>,
},
}
8 changes: 4 additions & 4 deletions crates/protocol/src/lib.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,10 +12,10 @@ mod wire;
pub use command::{Command, CommandResponse, SettingsPatch, ThreadExportFormat};
pub use event::{
AcpMarketplaceItem, EventEnvelope, GitActionRequest, GitStatusStatus, IndexSnapshot,
ProviderVersionStatus, ProvidersStatus, QueuedMessageStatus, RuntimeEffect, RuntimeError,
RuntimeNotice, RuntimeNotification, RuntimeOperationId, RuntimeToast, ServerEvent,
SessionEventRecord, SessionStatus, TcodeUpdateStatus, TerminalContextStatus,
TerminalSplitStatus, TerminalStatus, Topic,
MergeWorktreeFailure, ProviderVersionStatus, ProvidersStatus, QueuedMessageStatus,
RuntimeEffect, RuntimeError, RuntimeNotice, RuntimeNotification, RuntimeOperationId,
RuntimeToast, ServerEvent, SessionEventRecord, SessionStatus, TcodeUpdateStatus,
TerminalContextStatus, TerminalSplitStatus, TerminalStatus, Topic,
};
pub use query::{
ExternalThread, GitDiffResult, GitDiffScope, GitFileText, PathEntry, Query, QueryResponse,
Expand Down
6 changes: 6 additions & 0 deletions crates/protocol/src/tests.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -227,6 +227,11 @@ fn round_trips_top_level_wire_types() {
});
}

#[test]
fn orchestrate_child_worktrees_patch_round_trips() {
round_trip(&SettingsPatch::OrchestrateChildWorktrees(true));
}

fn assert_command_crosses_ndjson(id: u64, command: Command) {
match &command {
Command::ApplyPendingRelaunch => {}
Expand DownExpand Up@@ -275,6 +280,7 @@ fn assert_command_crosses_ndjson(id: u64, command: Command) {
Command::AutoArchiveSweep { .. } => {}
Command::RenameSession { .. } => {}
Command::ForkThread { .. } => {}
Command::MergeWorktree { .. } => {}
Command::DeleteSession { .. } => {}
Command::DeleteProject { .. } => {}
Command::MarkSessionUnread { .. } => {}
Expand Down
16 changes: 9 additions & 7 deletions crates/runtime/src/app/mod.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,20 +48,22 @@ use tcode_core::ui::{
};
use tcode_protocol::ThreadExportFormat;
use tcode_protocol::{
AcpMarketplaceItem, EventEnvelope, ExternalThread, GitStatusStatus, IndexSnapshot, PathEntry,
ProviderVersionStatus as ProtocolProviderVersionStatus, ProvidersStatus, QueuedMessageStatus,
RecentDir, ServerEvent, SessionEventRecord, SessionStatus, TcodeUpdateStatus,
TerminalContextStatus, TerminalSplitStatus, TerminalStatus, Topic,
AcpMarketplaceItem, EventEnvelope, ExternalThread, GitStatusStatus, IndexSnapshot,
MergeWorktreeFailure, PathEntry, ProviderVersionStatus as ProtocolProviderVersionStatus,
ProvidersStatus, QueuedMessageStatus, RecentDir, ServerEvent, SessionEventRecord,
SessionStatus, TcodeUpdateStatus, TerminalContextStatus, TerminalSplitStatus, TerminalStatus,
Topic,
};
use tcode_services::acp_registry::{
Registry, RegistryAgent, cached, install, load, platform_key, resolve_recipe, uninstall,
visible_agents,
};
use tcode_services::export;
use tcode_services::git::{
CheckoutError, checkout_if_clean, cleanup_orphaned_worktrees, commit_diff_context,
create_git_worktree, list_git_branches, perform_action, read_git_branch, read_status,
remove_git_worktree, run_claude_headless, worktree_path_for,
CheckoutError, MergeWorktreeError, MergeWorktreeOutcome, checkout_if_clean,
cleanup_orphaned_worktrees, commit_diff_context, create_git_worktree, list_git_branches,
merge_worktree_back, perform_action, read_git_branch, read_status, remove_git_worktree,
run_claude_headless, run_git, worktree_path_for,
};
use tcode_services::import::{
ExternalImportUpdate, ExternalRoots, ImportOutcome, existing_external_ids, import_thread,
Expand Down
130 changes: 107 additions & 23 deletions crates/runtime/src/app/orchestrate.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -252,6 +252,15 @@ impl AppState {
result_max_chars,
);
meta.title = title;
self.install_child_session(meta, brief, cx)
}

fn install_child_session(
&mut self,
meta: SessionMeta,
brief: String,
cx: &mut HostCx,
) -> Result<String, String> {
self.enqueue_store_write(
StoreWrite::UpsertMeta {
meta: Box::new(meta.clone()),
Expand DownExpand Up@@ -307,6 +316,7 @@ impl AppState {
title,
brief,
cwd,
worktree,
archive_on_complete,
result_max_chars,
} => {
Expand DownExpand Up@@ -335,7 +345,8 @@ impl AppState {
};
let archive_on_complete =
archive_on_complete.unwrap_or(self.settings.orchestrate.archive_on_complete);
let Some(cwd) = cwd else {
let isolate = worktree.unwrap_or(self.settings.orchestrate.child_worktrees);
if cwd.is_none() && !isolate {
let result = self
.create_child_session(
&parent_id,
Expand All@@ -354,17 +365,32 @@ impl AppState {
.map(|id| serde_json::json!({ "thread_id": id }));
let _ = reply.try_send(result);
return;
};
let Some(parent_cwd) = self.find_meta(&parent_id).map(|meta| meta.cwd) else {
}
let Some(parent) = self.find_meta(&parent_id) else {
let _ = reply.try_send(Err("unknown parent session".to_string()));
return;
};
let path = PathBuf::from(cwd);
let path = if path.is_absolute() {
let path = PathBuf::from(cwd.unwrap_or_default());
let path = if path.as_os_str().is_empty() {
parent.cwd.clone()
} else if path.is_absolute() {
path
} else {
parent_cwd.join(path)
parent.cwd.join(path)
};
let mut meta = build_child_meta(
&parent,
provider,
Some(model),
effort,
profile_id,
approval_mode,
path.clone(),
archive_on_complete,
result_max_chars,
);
meta.title = title;
let child_id = meta.id.clone();
let host_cx = cx.clone();
HostCx::spawn_detached(cx, async move {
let resolved_cwd = host_cx
Expand All@@ -375,30 +401,39 @@ impl AppState {
if !canonical.is_dir() {
return Err(format!("invalid cwd: {}", canonical.display()));
}
Ok(canonical)
if isolate {
Ok(resolve_child_worktree(canonical, &child_id))
} else {
Ok((canonical, None, None))
}
})
.await;
let result = match resolved_cwd {
Ok(cwd) => host_cx
Ok((cwd, worktree, warning)) => host_cx
.enqueue_and_wait(move |state, cx| {
state.create_child_session(
&parent_id,
provider,
Some(model),
effort,
profile_id,
approval_mode,
title,
Some(cwd),
brief,
archive_on_complete,
result_max_chars,
cx,
)
meta.cwd = cwd;
meta.worktree = worktree;
let worktree_info = meta.worktree.clone();
state
.install_child_session(meta, brief, cx)
.map(|id| (id, worktree_info, warning))
})
.await
.unwrap_or_else(|_| Err("application closed".to_string()))
.map(|id| serde_json::json!({ "thread_id": id })),
.map(|(id, worktree, warning)| {
let mut response = serde_json::json!({ "thread_id": id });
if let Some(worktree) = worktree {
response["worktree_path"] = serde_json::json!(
worktree_path_for(&id).display().to_string()
);
response["worktree_branch"] =
serde_json::json!(worktree.branch);
}
if let Some(warning) = warning {
response["warning"] = serde_json::json!(warning);
}
response
}),
Err(err) => Err(err),
};
let _ = reply.try_send(result);
Expand DownExpand Up@@ -1211,6 +1246,55 @@ pub(super) fn provider_name(provider: ProviderKind) -> &'static str {
}
}

fn resolve_child_worktree(
cwd: PathBuf,
child_id: &str,
) -> (PathBuf, Option<WorktreeInfo>, Option<String>) {
let repo_root = run_git(&cwd, &["rev-parse", "--show-toplevel"])
.ok()
.map(|root| PathBuf::from(root.trim()))
.and_then(|root| root.canonicalize().ok());
if repo_root.as_ref() != Some(&cwd) {
let warning = format!(
"worktree isolation unavailable: {} is not a Git repository root; using the plain cwd",
cwd.display()
);
log::warn!("orchestrate dispatch: {warning}");
return (cwd, None, Some(warning));
}

let base = run_git(&cwd, &["symbolic-ref", "--quiet", "--short", "HEAD"])
.or_else(|_| run_git(&cwd, &["rev-parse", "HEAD"]))
.map(|base| base.trim().to_string());
let base = match base {
Ok(base) => base,
Err(error) => {
let warning = format!(
"worktree isolation unavailable: could not resolve the base revision ({error}); using the plain cwd"
);
log::warn!("orchestrate dispatch: {warning}");
return (cwd, None, Some(warning));
}
};
let path = worktree_path_for(child_id);
let requested_branch = format!("tcode/{child_id}");
match create_git_worktree(&cwd, &path, &requested_branch, &base) {
Ok(created) => {
let info = WorktreeInfo {
root_project_path: cwd,
base,
branch: created.branch,
};
(created.path, Some(info), None)
}
Err(error) => {
let warning = format!("worktree isolation failed ({error}); using the plain cwd");
log::warn!("orchestrate dispatch: {warning}");
(cwd, None, Some(warning))
}
}
}

#[allow(clippy::too_many_arguments)] // mirrors the MCP dispatch schema
pub(super) fn build_child_meta(
parent: &SessionMeta,
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions crates/core/src/settings.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -323,6 +323,10 @@ pub struct OrchestrateSettings {
pub child_models: Vec<OrchestrateChildModel>,
#[serde(default)]
pub child_approval: ChildApprovalMode,
/// Give dispatched children dedicated Git worktrees when their resolved cwd
/// is itself a repository root. Dispatch-level `worktree` overrides this.
#[serde(default)]
pub child_worktrees: bool,
/// Archive completed children automatically once their terminal result has
/// been delivered to the parent. Per-dispatch `archive_on_complete`
/// overrides this; failed children always stay visible for retries.
Expand DownExpand Up@@ -393,6 +397,7 @@ impl Default for OrchestrateSettings {
},
],
child_approval: ChildApprovalMode::default(),
child_worktrees: false,
archive_on_complete: true,
}
}
Expand DownExpand Up@@ -1171,6 +1176,23 @@ mod tests {
}
}

#[test]
fn orchestrate_child_worktrees_default_false_and_round_trip() {
let legacy: OrchestrateSettings = serde_json::from_str("{}").unwrap();
assert!(!legacy.child_worktrees);

let settings = OrchestrateSettings {
child_worktrees: true,
..Default::default()
};
let json = serde_json::to_string(&settings).unwrap();
assert!(json.contains(r#""child_worktrees":true"#));
assert_eq!(
serde_json::from_str::<OrchestrateSettings>(&json).unwrap(),
settings
);
}

#[test]
fn orchestrate_child_legacy_default_effort_alias_parses() {
let settings: OrchestrateSettings = serde_json::from_str(
Expand Down
1 change: 1 addition & 0 deletions crates/orchestrate-mcp/src/lib.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,6 +16,7 @@ pub enum OrchestrateOp {
title: String,
brief: String,
cwd: Option<String>,
worktree: Option<bool>,
archive_on_complete: Option<bool>,
result_max_chars: Option<u32>,
},
Expand Down
8 changes: 7 additions & 1 deletion crates/orchestrate-mcp/src/tools.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,6 +28,11 @@ struct DispatchParams {
#[serde(default)]
cwd: Option<String>,
#[serde(default)]
#[schemars(
description = "Override Settings → Orchestrate child-worktree isolation for this dispatch. When true and cwd resolves to a Git repository root, the child runs on branch tcode/<thread-id> in a dedicated worktree. The response includes its path and branch. Non-Git cwd or creation failure falls back to cwd and reports a warning."
)]
worktree: Option<bool>,
#[serde(default)]
#[schemars(
description = "Override the auto-archive policy for this child. By default (per Settings → Orchestrate) a completed child is archived once its terminal result reaches you; failed children always stay visible. Set false to keep a completed child in the sidebar; send to an archived child unarchives it."
)]
Expand DownExpand Up@@ -82,7 +87,7 @@ impl OrchestrateTools {
}

#[tool(
description = "Dispatch a brief to a new child tcode thread and return its thread id. profile is the provider-profile id from the fleet table, required when the entry names one. access is one of read_only (review/investigation: read-only actions run without prompts; anything that mutates pauses for user approval), workspace_write (edits auto-approved inside the workspace), or full (default; no approval prompts). Completed children are auto-archived after their result is delivered unless archive_on_complete: false; failed children stay visible for retries."
description = "Dispatch a brief to a new child tcode thread and return its thread id. profile is the provider-profile id from the fleet table, required when the entry names one. access is one of read_only (review/investigation: read-only actions run without prompts; anything that mutates pauses for user approval), workspace_write (edits auto-approved inside the workspace), or full (default; no approval prompts). worktree optionally isolates the child in tcode/<thread-id> and overrides the Orchestrate setting; the response identifies the path and branch or explains fallback. Completed children are auto-archived after their result is delivered unless archive_on_complete: false; failed children stay visible for retries."
)]
async fn dispatch(
&self,
Expand All@@ -99,6 +104,7 @@ impl OrchestrateTools {
title: p.title,
brief: p.brief,
cwd: p.cwd,
worktree: p.worktree,
archive_on_complete: p.archive_on_complete,
result_max_chars: p.result_max_chars,
})
Expand Down
4 changes: 4 additions & 0 deletions crates/protocol/src/command.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -40,6 +40,7 @@ pub enum SettingsPatch {
AutoArchiveKeepCount(usize),
AutoArchiveNoticeShown(bool),
Orchestrate(OrchestrateSettings),
OrchestrateChildWorktrees(bool),
ComputerUse(ComputerUseSettings),
Browser(BrowserSettings),
TitleGeneration(TitleGenerationSettings),
Expand DownExpand Up@@ -196,6 +197,9 @@ pub enum Command {
session_id: String,
remove_worktree: bool,
},
MergeWorktree {
session_id: String,
},
DeleteProject {
project_id: String,
},
Expand Down
17 changes: 17 additions & 0 deletions crates/protocol/src/event.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -252,6 +252,17 @@ pub struct GitActionRequest {
pub feature_branch: Option<String>,
}

#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)]
#[serde(rename_all = "snake_case")]
pub enum MergeWorktreeFailure {
Missing,
DirtyWorktree,
DestinationDetached,
DirtyDestination,
DivergedConflict,
Git,
}

#[non_exhaustive]
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
#[serde(tag = "type", content = "content", rename_all = "snake_case")]
Expand DownExpand Up@@ -354,4 +365,10 @@ pub enum RuntimeNotice {
skipped: Vec<String>,
limit_reached: bool,
},
WorktreeMergedFastForward,
WorktreeMergedCommit,
WorktreeMergeFailed {
reason: MergeWorktreeFailure,
detail: Option<String>,
},
}
8 changes: 4 additions & 4 deletions crates/protocol/src/lib.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,10 +12,10 @@ mod wire;
pub use command::{Command, CommandResponse, SettingsPatch, ThreadExportFormat};
pub use event::{
AcpMarketplaceItem, EventEnvelope, GitActionRequest, GitStatusStatus, IndexSnapshot,
ProviderVersionStatus, ProvidersStatus, QueuedMessageStatus, RuntimeEffect, RuntimeError,
RuntimeNotice, RuntimeNotification, RuntimeOperationId, RuntimeToast, ServerEvent,
SessionEventRecord, SessionStatus, TcodeUpdateStatus, TerminalContextStatus,
TerminalSplitStatus, TerminalStatus, Topic,
MergeWorktreeFailure, ProviderVersionStatus, ProvidersStatus, QueuedMessageStatus,
RuntimeEffect, RuntimeError, RuntimeNotice, RuntimeNotification, RuntimeOperationId,
RuntimeToast, ServerEvent, SessionEventRecord, SessionStatus, TcodeUpdateStatus,
TerminalContextStatus, TerminalSplitStatus, TerminalStatus, Topic,
};
pub use query::{
ExternalThread, GitDiffResult, GitDiffScope, GitFileText, PathEntry, Query, QueryResponse,
Expand Down
6 changes: 6 additions & 0 deletions crates/protocol/src/tests.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -227,6 +227,11 @@ fn round_trips_top_level_wire_types() {
});
}

#[test]
fn orchestrate_child_worktrees_patch_round_trips() {
round_trip(&SettingsPatch::OrchestrateChildWorktrees(true));
}

fn assert_command_crosses_ndjson(id: u64, command: Command) {
match &command {
Command::ApplyPendingRelaunch => {}
Expand DownExpand Up@@ -275,6 +280,7 @@ fn assert_command_crosses_ndjson(id: u64, command: Command) {
Command::AutoArchiveSweep { .. } => {}
Command::RenameSession { .. } => {}
Command::ForkThread { .. } => {}
Command::MergeWorktree { .. } => {}
Command::DeleteSession { .. } => {}
Command::DeleteProject { .. } => {}
Command::MarkSessionUnread { .. } => {}
Expand Down
16 changes: 9 additions & 7 deletions crates/runtime/src/app/mod.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,20 +48,22 @@ use tcode_core::ui::{
};
use tcode_protocol::ThreadExportFormat;
use tcode_protocol::{
AcpMarketplaceItem, EventEnvelope, ExternalThread, GitStatusStatus, IndexSnapshot, PathEntry,
ProviderVersionStatus as ProtocolProviderVersionStatus, ProvidersStatus, QueuedMessageStatus,
RecentDir, ServerEvent, SessionEventRecord, SessionStatus, TcodeUpdateStatus,
TerminalContextStatus, TerminalSplitStatus, TerminalStatus, Topic,
AcpMarketplaceItem, EventEnvelope, ExternalThread, GitStatusStatus, IndexSnapshot,
MergeWorktreeFailure, PathEntry, ProviderVersionStatus as ProtocolProviderVersionStatus,
ProvidersStatus, QueuedMessageStatus, RecentDir, ServerEvent, SessionEventRecord,
SessionStatus, TcodeUpdateStatus, TerminalContextStatus, TerminalSplitStatus, TerminalStatus,
Topic,
};
use tcode_services::acp_registry::{
Registry, RegistryAgent, cached, install, load, platform_key, resolve_recipe, uninstall,
visible_agents,
};
use tcode_services::export;
use tcode_services::git::{
CheckoutError, checkout_if_clean, cleanup_orphaned_worktrees, commit_diff_context,
create_git_worktree, list_git_branches, perform_action, read_git_branch, read_status,
remove_git_worktree, run_claude_headless, worktree_path_for,
CheckoutError, MergeWorktreeError, MergeWorktreeOutcome, checkout_if_clean,
cleanup_orphaned_worktrees, commit_diff_context, create_git_worktree, list_git_branches,
merge_worktree_back, perform_action, read_git_branch, read_status, remove_git_worktree,
run_claude_headless, run_git, worktree_path_for,
};
use tcode_services::import::{
ExternalImportUpdate, ExternalRoots, ImportOutcome, existing_external_ids, import_thread,
Expand Down
130 changes: 107 additions & 23 deletions crates/runtime/src/app/orchestrate.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -252,6 +252,15 @@ impl AppState {
result_max_chars,
);
meta.title = title;
self.install_child_session(meta, brief, cx)
}

fn install_child_session(
&mut self,
meta: SessionMeta,
brief: String,
cx: &mut HostCx,
) -> Result<String, String> {
self.enqueue_store_write(
StoreWrite::UpsertMeta {
meta: Box::new(meta.clone()),
Expand DownExpand Up@@ -307,6 +316,7 @@ impl AppState {
title,
brief,
cwd,
worktree,
archive_on_complete,
result_max_chars,
} => {
Expand DownExpand Up@@ -335,7 +345,8 @@ impl AppState {
};
let archive_on_complete =
archive_on_complete.unwrap_or(self.settings.orchestrate.archive_on_complete);
let Some(cwd) = cwd else {
let isolate = worktree.unwrap_or(self.settings.orchestrate.child_worktrees);
if cwd.is_none() && !isolate {
let result = self
.create_child_session(
&parent_id,
Expand All@@ -354,17 +365,32 @@ impl AppState {
.map(|id| serde_json::json!({ "thread_id": id }));
let _ = reply.try_send(result);
return;
};
let Some(parent_cwd) = self.find_meta(&parent_id).map(|meta| meta.cwd) else {
}
let Some(parent) = self.find_meta(&parent_id) else {
let _ = reply.try_send(Err("unknown parent session".to_string()));
return;
};
let path = PathBuf::from(cwd);
let path = if path.is_absolute() {
let path = PathBuf::from(cwd.unwrap_or_default());
let path = if path.as_os_str().is_empty() {
parent.cwd.clone()
} else if path.is_absolute() {
path
} else {
parent_cwd.join(path)
parent.cwd.join(path)
};
let mut meta = build_child_meta(
&parent,
provider,
Some(model),
effort,
profile_id,
approval_mode,
path.clone(),
archive_on_complete,
result_max_chars,
);
meta.title = title;
let child_id = meta.id.clone();
let host_cx = cx.clone();
HostCx::spawn_detached(cx, async move {
let resolved_cwd = host_cx
Expand All@@ -375,30 +401,39 @@ impl AppState {
if !canonical.is_dir() {
return Err(format!("invalid cwd: {}", canonical.display()));
}
Ok(canonical)
if isolate {
Ok(resolve_child_worktree(canonical, &child_id))
} else {
Ok((canonical, None, None))
}
})
.await;
let result = match resolved_cwd {
Ok(cwd) => host_cx
Ok((cwd, worktree, warning)) => host_cx
.enqueue_and_wait(move |state, cx| {
state.create_child_session(
&parent_id,
provider,
Some(model),
effort,
profile_id,
approval_mode,
title,
Some(cwd),
brief,
archive_on_complete,
result_max_chars,
cx,
)
meta.cwd = cwd;
meta.worktree = worktree;
let worktree_info = meta.worktree.clone();
state
.install_child_session(meta, brief, cx)
.map(|id| (id, worktree_info, warning))
})
.await
.unwrap_or_else(|_| Err("application closed".to_string()))
.map(|id| serde_json::json!({ "thread_id": id })),
.map(|(id, worktree, warning)| {
let mut response = serde_json::json!({ "thread_id": id });
if let Some(worktree) = worktree {
response["worktree_path"] = serde_json::json!(
worktree_path_for(&id).display().to_string()
);
response["worktree_branch"] =
serde_json::json!(worktree.branch);
}
if let Some(warning) = warning {
response["warning"] = serde_json::json!(warning);
}
response
}),
Err(err) => Err(err),
};
let _ = reply.try_send(result);
Expand DownExpand Up@@ -1211,6 +1246,55 @@ pub(super) fn provider_name(provider: ProviderKind) -> &'static str {
}
}

fn resolve_child_worktree(
cwd: PathBuf,
child_id: &str,
) -> (PathBuf, Option<WorktreeInfo>, Option<String>) {
let repo_root = run_git(&cwd, &["rev-parse", "--show-toplevel"])
.ok()
.map(|root| PathBuf::from(root.trim()))
.and_then(|root| root.canonicalize().ok());
if repo_root.as_ref() != Some(&cwd) {
let warning = format!(
"worktree isolation unavailable: {} is not a Git repository root; using the plain cwd",
cwd.display()
);
log::warn!("orchestrate dispatch: {warning}");
return (cwd, None, Some(warning));
}

let base = run_git(&cwd, &["symbolic-ref", "--quiet", "--short", "HEAD"])
.or_else(|_| run_git(&cwd, &["rev-parse", "HEAD"]))
.map(|base| base.trim().to_string());
let base = match base {
Ok(base) => base,
Err(error) => {
let warning = format!(
"worktree isolation unavailable: could not resolve the base revision ({error}); using the plain cwd"
);
log::warn!("orchestrate dispatch: {warning}");
return (cwd, None, Some(warning));
}
};
let path = worktree_path_for(child_id);
let requested_branch = format!("tcode/{child_id}");
match create_git_worktree(&cwd, &path, &requested_branch, &base) {
Ok(created) => {
let info = WorktreeInfo {
root_project_path: cwd,
base,
branch: created.branch,
};
(created.path, Some(info), None)
}
Err(error) => {
let warning = format!("worktree isolation failed ({error}); using the plain cwd");
log::warn!("orchestrate dispatch: {warning}");
(cwd, None, Some(warning))
}
}
}

#[allow(clippy::too_many_arguments)] // mirrors the MCP dispatch schema
pub(super) fn build_child_meta(
parent: &SessionMeta,
Expand Down
Loading