fix(markdown,menu): make link clicks and context menus reliable

[Tryanks]

Summary

Fixes three defects in ChatView Markdown link interaction:

1. Context menu opened at the wrong place — the Popover-based ContextMenu could only anchor to the trigger element's bounds, and for Markdown the trigger is the whole block, so the menu appeared at the block's edge instead of the cursor. ContextMenu is rewritten (modeled on the upstream gpui-component implementation at the same pinned revision) to anchor at the right-click mouse position via deferred + anchored().position(...), snapped to the window with an 8px margin. Sidebar and terminal context menus pick up mouse-position anchoring too.

2. Menu items did nothing — the menu rendered as a sibling of the trigger, while the OpenLink/CopyLinkAddress/OpenPath/… handlers are registered on_action on the trigger div itself. Actions dispatch along the focused (menu) node's ancestor chain, which never included the trigger, so every action was silently dropped. The menu is now a child of the trigger, putting those handlers on the dispatch path. The new link_context_menu_action_opens_the_url test fails on the old structure.

3. Left clicks unreliable — mouse-up was guarded by the window-wide TextSelection::has_selection, and the selection snapshot compares anchor/cursor as pixels, so the ~1px jitter of a real press-and-release registered as a selection and swallowed the click. Replaced with press-origin tracking: a release within 3px of a press that started on the link is a click; farther is a drag-selection. click_count == 1 keeps a double-click (which selects the word) from opening the link twice.

Changes

• crates/ui/src/widgets/menu.rs — ContextMenu rewritten off gpui_base::Popover: mouse-position anchoring, menu as trigger child, focus restore on dismiss, deferred-popover registration preserved (keeps the collapsed-sidebar hover overlay alive while a menu is open).
• crates/ui/src/markdown/inline.rs — link press-origin tracking replaces the has_selection guard.
• crates/ui/src/markdown/state.rs — new link_press_origin field.
• crates/ui/src/markdown/view.rs — two regression tests.

Testing

• cargo test -p tcode-ui: 268 passed, 0 failed (includes new link_click_survives_pixel_jitter_but_not_a_drag and link_context_menu_action_opens_the_url).
• cargo clippy -p tcode-ui: clean.

[Tryanks]

Summary

Fixes three defects in ChatView Markdown link interaction:

1. Context menu opened at the wrong place — the Popover-based ContextMenu could only anchor to the trigger element's bounds, and for Markdown the trigger is the whole block, so the menu appeared at the block's edge instead of the cursor. ContextMenu is rewritten (modeled on the upstream gpui-component implementation at the same pinned revision) to anchor at the right-click mouse position via deferred + anchored().position(...), snapped to the window with an 8px margin. Sidebar and terminal context menus pick up mouse-position anchoring too.

2. Menu items did nothing — the menu rendered as a sibling of the trigger, while the OpenLink/CopyLinkAddress/OpenPath/… handlers are registered on_action on the trigger div itself. Actions dispatch along the focused (menu) node's ancestor chain, which never included the trigger, so every action was silently dropped. The menu is now a child of the trigger, putting those handlers on the dispatch path. The new link_context_menu_action_opens_the_url test fails on the old structure.

3. Left clicks unreliable — mouse-up was guarded by the window-wide TextSelection::has_selection, and the selection snapshot compares anchor/cursor as pixels, so the ~1px jitter of a real press-and-release registered as a selection and swallowed the click. Replaced with press-origin tracking: a release within 3px of a press that started on the link is a click; farther is a drag-selection. click_count == 1 keeps a double-click (which selects the word) from opening the link twice.

Changes

• crates/ui/src/widgets/menu.rs — ContextMenu rewritten off gpui_base::Popover: mouse-position anchoring, menu as trigger child, focus restore on dismiss, deferred-popover registration preserved (keeps the collapsed-sidebar hover overlay alive while a menu is open).
• crates/ui/src/markdown/inline.rs — link press-origin tracking replaces the has_selection guard.
• crates/ui/src/markdown/state.rs — new link_press_origin field.
• crates/ui/src/markdown/view.rs — two regression tests.

Testing

• cargo test -p tcode-ui: 268 passed, 0 failed (includes new link_click_survives_pixel_jitter_but_not_a_drag and link_context_menu_action_opens_the_url).
• cargo clippy -p tcode-ui: clean.

[Tryanks]

Summary

Fixes three defects in ChatView Markdown link interaction:

1. Context menu opened at the wrong place — the Popover-based ContextMenu could only anchor to the trigger element's bounds, and for Markdown the trigger is the whole block, so the menu appeared at the block's edge instead of the cursor. ContextMenu is rewritten (modeled on the upstream gpui-component implementation at the same pinned revision) to anchor at the right-click mouse position via deferred + anchored().position(...), snapped to the window with an 8px margin. Sidebar and terminal context menus pick up mouse-position anchoring too.

2. Menu items did nothing — the menu rendered as a sibling of the trigger, while the OpenLink/CopyLinkAddress/OpenPath/… handlers are registered on_action on the trigger div itself. Actions dispatch along the focused (menu) node's ancestor chain, which never included the trigger, so every action was silently dropped. The menu is now a child of the trigger, putting those handlers on the dispatch path. The new link_context_menu_action_opens_the_url test fails on the old structure.

3. Left clicks unreliable — mouse-up was guarded by the window-wide TextSelection::has_selection, and the selection snapshot compares anchor/cursor as pixels, so the ~1px jitter of a real press-and-release registered as a selection and swallowed the click. Replaced with press-origin tracking: a release within 3px of a press that started on the link is a click; farther is a drag-selection. click_count == 1 keeps a double-click (which selects the word) from opening the link twice.

Changes

• crates/ui/src/widgets/menu.rs — ContextMenu rewritten off gpui_base::Popover: mouse-position anchoring, menu as trigger child, focus restore on dismiss, deferred-popover registration preserved (keeps the collapsed-sidebar hover overlay alive while a menu is open).
• crates/ui/src/markdown/inline.rs — link press-origin tracking replaces the has_selection guard.
• crates/ui/src/markdown/state.rs — new link_press_origin field.
• crates/ui/src/markdown/view.rs — two regression tests.

Testing

• cargo test -p tcode-ui: 268 passed, 0 failed (includes new link_click_survives_pixel_jitter_but_not_a_drag and link_context_menu_action_opens_the_url).
• cargo clippy -p tcode-ui: clean.

[Tryanks]

Summary

Fixes three defects in ChatView Markdown link interaction:

1. Context menu opened at the wrong place — the Popover-based ContextMenu could only anchor to the trigger element's bounds, and for Markdown the trigger is the whole block, so the menu appeared at the block's edge instead of the cursor. ContextMenu is rewritten (modeled on the upstream gpui-component implementation at the same pinned revision) to anchor at the right-click mouse position via deferred + anchored().position(...), snapped to the window with an 8px margin. Sidebar and terminal context menus pick up mouse-position anchoring too.

2. Menu items did nothing — the menu rendered as a sibling of the trigger, while the OpenLink/CopyLinkAddress/OpenPath/… handlers are registered on_action on the trigger div itself. Actions dispatch along the focused (menu) node's ancestor chain, which never included the trigger, so every action was silently dropped. The menu is now a child of the trigger, putting those handlers on the dispatch path. The new link_context_menu_action_opens_the_url test fails on the old structure.

3. Left clicks unreliable — mouse-up was guarded by the window-wide TextSelection::has_selection, and the selection snapshot compares anchor/cursor as pixels, so the ~1px jitter of a real press-and-release registered as a selection and swallowed the click. Replaced with press-origin tracking: a release within 3px of a press that started on the link is a click; farther is a drag-selection. click_count == 1 keeps a double-click (which selects the word) from opening the link twice.

Changes

• crates/ui/src/widgets/menu.rs — ContextMenu rewritten off gpui_base::Popover: mouse-position anchoring, menu as trigger child, focus restore on dismiss, deferred-popover registration preserved (keeps the collapsed-sidebar hover overlay alive while a menu is open).
• crates/ui/src/markdown/inline.rs — link press-origin tracking replaces the has_selection guard.
• crates/ui/src/markdown/state.rs — new link_press_origin field.
• crates/ui/src/markdown/view.rs — two regression tests.

Testing

• cargo test -p tcode-ui: 268 passed, 0 failed (includes new link_click_survives_pixel_jitter_but_not_a_drag and link_context_menu_action_opens_the_url).
• cargo clippy -p tcode-ui: clean.

[Tryanks]

Summary

Fixes three defects in ChatView Markdown link interaction:

1. Context menu opened at the wrong place — the Popover-based ContextMenu could only anchor to the trigger element's bounds, and for Markdown the trigger is the whole block, so the menu appeared at the block's edge instead of the cursor. ContextMenu is rewritten (modeled on the upstream gpui-component implementation at the same pinned revision) to anchor at the right-click mouse position via deferred + anchored().position(...), snapped to the window with an 8px margin. Sidebar and terminal context menus pick up mouse-position anchoring too.

2. Menu items did nothing — the menu rendered as a sibling of the trigger, while the OpenLink/CopyLinkAddress/OpenPath/… handlers are registered on_action on the trigger div itself. Actions dispatch along the focused (menu) node's ancestor chain, which never included the trigger, so every action was silently dropped. The menu is now a child of the trigger, putting those handlers on the dispatch path. The new link_context_menu_action_opens_the_url test fails on the old structure.

3. Left clicks unreliable — mouse-up was guarded by the window-wide TextSelection::has_selection, and the selection snapshot compares anchor/cursor as pixels, so the ~1px jitter of a real press-and-release registered as a selection and swallowed the click. Replaced with press-origin tracking: a release within 3px of a press that started on the link is a click; farther is a drag-selection. click_count == 1 keeps a double-click (which selects the word) from opening the link twice.

Changes

• crates/ui/src/widgets/menu.rs — ContextMenu rewritten off gpui_base::Popover: mouse-position anchoring, menu as trigger child, focus restore on dismiss, deferred-popover registration preserved (keeps the collapsed-sidebar hover overlay alive while a menu is open).
• crates/ui/src/markdown/inline.rs — link press-origin tracking replaces the has_selection guard.
• crates/ui/src/markdown/state.rs — new link_press_origin field.
• crates/ui/src/markdown/view.rs — two regression tests.

Testing

• cargo test -p tcode-ui: 268 passed, 0 failed (includes new link_click_survives_pixel_jitter_but_not_a_drag and link_context_menu_action_opens_the_url).
• cargo clippy -p tcode-ui: clean.

[Tryanks]

Summary

Fixes three defects in ChatView Markdown link interaction:

1. Context menu opened at the wrong place — the Popover-based ContextMenu could only anchor to the trigger element's bounds, and for Markdown the trigger is the whole block, so the menu appeared at the block's edge instead of the cursor. ContextMenu is rewritten (modeled on the upstream gpui-component implementation at the same pinned revision) to anchor at the right-click mouse position via deferred + anchored().position(...), snapped to the window with an 8px margin. Sidebar and terminal context menus pick up mouse-position anchoring too.

2. Menu items did nothing — the menu rendered as a sibling of the trigger, while the OpenLink/CopyLinkAddress/OpenPath/… handlers are registered on_action on the trigger div itself. Actions dispatch along the focused (menu) node's ancestor chain, which never included the trigger, so every action was silently dropped. The menu is now a child of the trigger, putting those handlers on the dispatch path. The new link_context_menu_action_opens_the_url test fails on the old structure.

3. Left clicks unreliable — mouse-up was guarded by the window-wide TextSelection::has_selection, and the selection snapshot compares anchor/cursor as pixels, so the ~1px jitter of a real press-and-release registered as a selection and swallowed the click. Replaced with press-origin tracking: a release within 3px of a press that started on the link is a click; farther is a drag-selection. click_count == 1 keeps a double-click (which selects the word) from opening the link twice.

Changes

• crates/ui/src/widgets/menu.rs — ContextMenu rewritten off gpui_base::Popover: mouse-position anchoring, menu as trigger child, focus restore on dismiss, deferred-popover registration preserved (keeps the collapsed-sidebar hover overlay alive while a menu is open).
• crates/ui/src/markdown/inline.rs — link press-origin tracking replaces the has_selection guard.
• crates/ui/src/markdown/state.rs — new link_press_origin field.
• crates/ui/src/markdown/view.rs — two regression tests.

Testing

• cargo test -p tcode-ui: 268 passed, 0 failed (includes new link_click_survives_pixel_jitter_but_not_a_drag and link_context_menu_action_opens_the_url).
• cargo clippy -p tcode-ui: clean.

[Tryanks]

Summary

Fixes three defects in ChatView Markdown link interaction:

1. Context menu opened at the wrong place — the Popover-based ContextMenu could only anchor to the trigger element's bounds, and for Markdown the trigger is the whole block, so the menu appeared at the block's edge instead of the cursor. ContextMenu is rewritten (modeled on the upstream gpui-component implementation at the same pinned revision) to anchor at the right-click mouse position via deferred + anchored().position(...), snapped to the window with an 8px margin. Sidebar and terminal context menus pick up mouse-position anchoring too.

2. Menu items did nothing — the menu rendered as a sibling of the trigger, while the OpenLink/CopyLinkAddress/OpenPath/… handlers are registered on_action on the trigger div itself. Actions dispatch along the focused (menu) node's ancestor chain, which never included the trigger, so every action was silently dropped. The menu is now a child of the trigger, putting those handlers on the dispatch path. The new link_context_menu_action_opens_the_url test fails on the old structure.

3. Left clicks unreliable — mouse-up was guarded by the window-wide TextSelection::has_selection, and the selection snapshot compares anchor/cursor as pixels, so the ~1px jitter of a real press-and-release registered as a selection and swallowed the click. Replaced with press-origin tracking: a release within 3px of a press that started on the link is a click; farther is a drag-selection. click_count == 1 keeps a double-click (which selects the word) from opening the link twice.

Changes

• crates/ui/src/widgets/menu.rs — ContextMenu rewritten off gpui_base::Popover: mouse-position anchoring, menu as trigger child, focus restore on dismiss, deferred-popover registration preserved (keeps the collapsed-sidebar hover overlay alive while a menu is open).
• crates/ui/src/markdown/inline.rs — link press-origin tracking replaces the has_selection guard.
• crates/ui/src/markdown/state.rs — new link_press_origin field.
• crates/ui/src/markdown/view.rs — two regression tests.

Testing

• cargo test -p tcode-ui: 268 passed, 0 failed (includes new link_click_survives_pixel_jitter_but_not_a_drag and link_context_menu_action_opens_the_url).
• cargo clippy -p tcode-ui: clean.

[Tryanks]

Summary

Fixes three defects in ChatView Markdown link interaction:

1. Context menu opened at the wrong place — the Popover-based ContextMenu could only anchor to the trigger element's bounds, and for Markdown the trigger is the whole block, so the menu appeared at the block's edge instead of the cursor. ContextMenu is rewritten (modeled on the upstream gpui-component implementation at the same pinned revision) to anchor at the right-click mouse position via deferred + anchored().position(...), snapped to the window with an 8px margin. Sidebar and terminal context menus pick up mouse-position anchoring too.

2. Menu items did nothing — the menu rendered as a sibling of the trigger, while the OpenLink/CopyLinkAddress/OpenPath/… handlers are registered on_action on the trigger div itself. Actions dispatch along the focused (menu) node's ancestor chain, which never included the trigger, so every action was silently dropped. The menu is now a child of the trigger, putting those handlers on the dispatch path. The new link_context_menu_action_opens_the_url test fails on the old structure.

3. Left clicks unreliable — mouse-up was guarded by the window-wide TextSelection::has_selection, and the selection snapshot compares anchor/cursor as pixels, so the ~1px jitter of a real press-and-release registered as a selection and swallowed the click. Replaced with press-origin tracking: a release within 3px of a press that started on the link is a click; farther is a drag-selection. click_count == 1 keeps a double-click (which selects the word) from opening the link twice.

Changes

• crates/ui/src/widgets/menu.rs — ContextMenu rewritten off gpui_base::Popover: mouse-position anchoring, menu as trigger child, focus restore on dismiss, deferred-popover registration preserved (keeps the collapsed-sidebar hover overlay alive while a menu is open).
• crates/ui/src/markdown/inline.rs — link press-origin tracking replaces the has_selection guard.
• crates/ui/src/markdown/state.rs — new link_press_origin field.
• crates/ui/src/markdown/view.rs — two regression tests.

Testing

• cargo test -p tcode-ui: 268 passed, 0 failed (includes new link_click_survives_pixel_jitter_but_not_a_drag and link_context_menu_action_opens_the_url).
• cargo clippy -p tcode-ui: clean.