chore(deps): roll up dependabot bumps + adapt to rio-vt 0.5.26 - #317
Merged
Conversation
Combines open dependabot PRs into one lockfile update: - log 0.4.33 -> 0.4.34 (#313) - uuid 1.24.1 -> 1.25.0 (#311) - rmcp 3.1.3 -> 3.1.4 (#309) - rio-graphics 0.5.25 -> 0.5.26 (#314) - rio-vt 0.5.24 -> 0.5.26 (supersedes #308's 0.5.25, which does not compile against rio-graphics 0.5.26: missing DecodeError::TooLarge arm) - gpui / gpui_platform 7eec892 -> 1662f5f (#310, #312) rio-vt 0.5.26 privatized Grid::style_set; switch to the public Grid::styles() accessor.
The write runs on the global smol pool, whose threads are concurrent with the GPUI update, so any file-existence check races them — it flaked on fast Windows runners both after and inside the update. Keep the deterministic eventual-write assertion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rolls the 7 open dependabot PRs into one lockfile update so they land in a single CI cycle instead of six rebase rounds. Closes the underlying bumps for #308#309#310#311#312#313#314.
Versions
7eec8921662f5fWhy not merge them individually
DecodeError::TooLargevariant. rio-vt 0.5.26 handles it — so the pair must move together, past what chore(deps): bump rio-vt from 0.5.24 to 0.5.25 #308 proposed.7eec892to1662f5f#310 and chore(deps): bump gpui_platform from7eec892to1662f5f#312 pin the same zed git source; they only make sense as one pin move.Code change
rio-vt 0.5.26 privatized
Grid::style_set;crates/term/src/grid_emulator.rsnow uses the publicGrid::styles()accessor (one line).Verification
cargo fmt --all --check✅cargo clippy --workspace --all-targets --locked -- -D warnings✅cargo test --workspace --locked✅ (718 passed, 0 failed)