Uh oh!
There was an error while loading. Please reload this page.
fix: Plain content issues - #2896
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
@blocknote/ariakit@blocknote/code-block@blocknote/core@blocknote/diagram-block@blocknote/mantine@blocknote/math-block@blocknote/react@blocknote/server-util@blocknote/shadcn@blocknote/xl-ai@blocknote/xl-docx-exporter@blocknote/xl-email-exporter@blocknote/xl-multi-column@blocknote/xl-odt-exporter@blocknote/xl-pdf-exportercommit: |
| const parseHardBreaks = | ||
| !blockType || !isPlainContentNodeType(schema, schema.nodes[blockType]); |
There was a problem hiding this comment.
should still be for code too no?
There was a problem hiding this comment.
I think the only case it matters is if someone creates a block with code: true and content: "styled", which is unlikely to ever happen since code should be content: "plain". But if someone does do that, we can just parse line breaks normally. We were just checking for code before since content: "plain" didn't exist.
|
Uh oh!
There was an error while loading. Please reload this page.
Summary
This PR fixes some leftover issues from #2868:
content: "plain", but the type was not propagated fully and the implementation was missing.ReactBlockSpec.tswas not updated to support plain text content.Rationale
The aforementioned issues are blocking for #2857.
Changes
Fixed the 2 issues listed above.
Impact
N/A
Testing
TODO
Screenshots/Video
N/A
Checklist
Additional Notes
N/A