Skip to content

Fix for #361 Converting image block to md#381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jmas wants to merge 2 commits into from
Closed

Fix for #361 Converting image block to md #381

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd75cf0
Fix #361 Error converting Image Block to Markdown
jmas Oct 15, 2023
9e61058
Add: caption
jmas Oct 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/core/src/api/formatConversions/simplifyBlocksRehypePlugin.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,6 +38,8 @@ export function simplifyBlocks(options: SimplifyBlocksOptions) {
blockContent.properties!["dataContentType"] as string
);

const isImageBlock = blockContent.properties!["dataContentType"] as string === 'image';

const listItemBlockType = isListItemBlock
? options.orderedListItemBlockTypes.has(
blockContent.properties!["dataContentType"] as string
Expand DownExpand Up@@ -104,6 +106,16 @@ export function simplifyBlocks(options: SimplifyBlocksOptions) {
const numElementsAdded = blockGroup.children.length;
i += numElementsAdded;
numChildElements += numElementsAdded;
} else if (isImageBlock) {
const img = document.createElement("img");
img.setAttribute('src', blockContent.properties!['dataUrl'] as string || '');
img.setAttribute('alt', blockContent.properties!['dataCaption'] as string || '');

const imgElement = fromDom(
img
) as HASTElement;

tree.children[i] = imgElement;
} else {
// Replaces the block with only the content inside it.
tree.children[i] = blockContent.children[0];
Expand Down