Uh oh!
There was an error while loading. Please reload this page.
feat: Parsing blocks from external HTML - #414
Closed
matthewlipski wants to merge 1 commit into
Closed
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
matthewlipski
changed the base branch from
main
to
custom-block-serializationNovember 17, 2023 18:11
YousefED
commented
Nov 29, 2023
Collaborator
superseded by #422 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
fromExternalHTMLfunction that can be defined for each block type. The function provides a HTML element and a function to parseInlineContent[]from inside a HTML element, as attributes. The function should return aPartialBlockwith the parsed block, orundefinedif the element should not be parsed as that block type. Currently, it is the responsibility of thefromExternalHTMLfunction to construct every aspect of the block. This means thatcontentandchildrenmust be defined manually as the parser will not fill them. This is probably not the approach we want to go for, for reasons documented inparseExternalHTML.ts.