Uh oh!
There was an error while loading. Please reload this page.
fix(playground): runtime fixes — esbuild WASM URL, iframe sandbox, blob cleanup, CDN version sync - #34
Merged
joaodibba merged 2 commits intoJun 12, 2026
Conversation
The previous code used a filesystem path '/node_modules/esbuild-wasm/esbuild.wasm' as the wasmURL. Vite does NOT serve node_modules as static files via fetch — the path 404s in dev and node_modules/ doesn't exist in production at all. The playground could never compile anything as shipped. Fix: replace with a Vite `?url` import so the WASM binary is copied to dist/assets/ with a content-hash filename and served correctly in both dev and prod. Also add `declare module '*.wasm?url'` to src/vite-env.d.ts to satisfy TypeScript for the new import. FixesTypeComposer#14 post-merge regression.
…remove brittle import rewrite Five runtime quality fixes for PlaygroundView: 1. TYPECOMPOSER_VERSION constant (0.1.53 → 0.1.56) - Hardcoded '0.1.53' silently mismatched the package.json ^0.1.56 dep. - Renamed to module-level TYPECOMPOSER_VERSION constant with a sync comment. 2. sandbox="allow-scripts" on preview iframe - User-compiled code previously had full access to window.parent and could mutate the docs page DOM. sandbox="allow-scripts" isolates the iframe. - allow-same-origin intentionally omitted — blob: URLs are opaque-origin, so omitting it makes the sandbox stricter, not weaker. 3. Blob URL memory leak / revocation race removed - createCodeBlobUrl() used setTimeout(revoke, 5000) — a race condition (module may not have finished loading) that also leaked URLs between runs. - Fix: track blob URLs in pendingBlobUrls[], revoke at the start of the next compile run and in disconnectedCallback(). disconnectedCallback() also cancels the debounce timer. 4. Brittle import text-replace removed - createCodeBlobUrl() did a regex replace of `from "typecomposer"` with the CDN URL. This was redundant (import map handles it), fragile (missed dynamic import(), subpath imports, single-quote variants), and now gone. - The import map in the iframe HTML is the correct, complete mechanism. 5. Demo /package.json updated - In-editor demo config still referenced @codesandbox/sandpack-client and typecomposer@0.0.98 — sandpack migration artifacts left from before PR TypeComposer#15. - Updated to reference only typecomposer at the current TYPECOMPOSER_VERSION.
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Jun 12, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this PR exists
PR #33 was merged correctly (thanks @zico15!) but its branch (
copilot/fix-6666f3a8-e9fd-449a-9eb0-49c50f6f3c2d) was the Copilot branch reused from PR #15 — GitHub considered it already partially merged/dirty, so fix commits pushed after the merge could not be included. This is a clean replacement branch (fix/browser-playground-esbuild) based directly from the currentTypeComposer/docs:main(dedd68a) with only the runtime fixes applied on top.What was wrong (post-merge audit of #33)
wasmURL: '/node_modules/esbuild-wasm/esbuild.wasm'— filesystem path, not a served URLnode_modules/via fetch; playground could never compile anythingtypeComposerVersion = "0.1.53"hardcodedpackage.json's^0.1.56sandboxattribute on preview iframewindow.parentand docs page DOMsetTimeout(5000)— race + leakcreateCodeBlobUrl()text-replacedfrom "typecomposer"import(), subpaths, single quotes)/package.jsonstill had@codesandbox/sandpack-client+typecomposer@0.0.98Changes (2 commits)
Commit 1 —
fix(playground): correct esbuild-wasm WASM URL — use Vite ?url importsrc/utils/browserCompiler.tssrc/vite-env.d.ts— addeddeclare module '*.wasm?url'so TypeScript accepts the import.Commit 2 —
fix(playground): CDN version sync, iframe sandbox, blob URL cleanup, remove brittle import rewritesrc/views/playground/PlaygroundView.ts"0.1.53"→ module-levelTYPECOMPOSER_VERSION = "0.1.56"constant with sync commentthis.iframe.setAttribute("sandbox", "allow-scripts")— iframe isolation (allow-same-origin intentionally omitted)createCodeBlobUrl()— blob URLs now tracked inpendingBlobUrls[], revoked at the start of each compile run and in newdisconnectedCallback()from "typecomposer"— import map is the correct mechanism/package.jsontotypecomposer: "^0.1.56", removed sandpack artefactsBuild result
The
esbuild.wasmasset is now present indist/assets/— confirming the?urlimport works correctly and the playground will be able to compile code at runtime.Does this fix the "branch was merged before" problem?
Yes. This branch (
fix/browser-playground-esbuild) is a fresh branch fromTypeComposer/docs:mainatdedd68a. It has no shared history with the old Copilot branch — GitHub will treat it as a clean, unmerged branch with a clear diff.Files changed
src/utils/browserCompiler.ts?urlWASM import, minor cleanupsrc/vite-env.d.ts*.wasm?urltype declarationsrc/views/playground/PlaygroundView.tscc @zico15@joaodibba