test: strengthen RefObject assertions in reactive-collections.test.ts by lucas-spin · Pull Request #23 · TypeComposer/typecomposer

lucas-spin · 2026-06-15T19:21:07Z

Summary

Follow-up to PR #15 — replaces four weak toBeTruthy() / typeof-only assertions in the RefObject (refObject) describe block with exact behavioral assertions that would catch real regressions.

File changed:tests/reactive-collections.test.ts (test-only change, no production code modified)

Old assertion (weak)	New assertion (exact)
`expect(obj).toBeTruthy()`	`expect(typeof obj.id).toBe('string')` + `id.length > 0` + `subscribe`/`update` are functions
`expect(obj.value).toBeTruthy()`	`expect((obj.value as any).x).toBe(1)` — checks actual wrapped value
`expect(lastValue).toBeTruthy()` after update	counts subscriber calls (> baseCalls) and checks `lastValue` is a defined object
`expect(typeof json).toBe('object')`	checks `json.key === 'value'` and `json.count === 42` — verifies serialized shape

Validation

npm run test:run → 9 test files, 162 tests passed ✓
npx tsc --noEmit → no errors ✓

Roadmap alignment

Addresses audit item 8 (strengthen weak RefObject test assertions). No production code changed.

Reviewer: @zico15

Replaces four weak toBeTruthy / typeof-only assertions from the RefObject (refObject) describe block (introduced in PR TypeComposer#15) with exact behavioral assertions: - 'creates a reactive object wrapper': now verifies id is a non-empty string and that subscribe/update are functions (not just truthy). - 'value exposes the wrapped plain object': now asserts the actual key value (x === 1) rather than just that the value is truthy. - 'update with new plain object replaces content': now counts subscriber call invocations to confirm notification fires, and checks lastValue is a defined object. - 'toJSON serializes the object value': now checks the serialized shape contains the original key/value pairs (key === 'value', count === 42). All 162 tests pass. Addresses audit item 8.

lucas-spin · 2026-06-15T19:21:07Z

Summary

Follow-up to PR #15 — replaces four weak toBeTruthy() / typeof-only assertions in the RefObject (refObject) describe block with exact behavioral assertions that would catch real regressions.

File changed:tests/reactive-collections.test.ts (test-only change, no production code modified)

Old assertion (weak)	New assertion (exact)
`expect(obj).toBeTruthy()`	`expect(typeof obj.id).toBe('string')` + `id.length > 0` + `subscribe`/`update` are functions
`expect(obj.value).toBeTruthy()`	`expect((obj.value as any).x).toBe(1)` — checks actual wrapped value
`expect(lastValue).toBeTruthy()` after update	counts subscriber calls (> baseCalls) and checks `lastValue` is a defined object
`expect(typeof json).toBe('object')`	checks `json.key === 'value'` and `json.count === 42` — verifies serialized shape

Validation

npm run test:run → 9 test files, 162 tests passed ✓
npx tsc --noEmit → no errors ✓

Roadmap alignment

Addresses audit item 8 (strengthen weak RefObject test assertions). No production code changed.

Reviewer: @zico15

Replaces four weak toBeTruthy / typeof-only assertions from the RefObject (refObject) describe block (introduced in PR TypeComposer#15) with exact behavioral assertions: - 'creates a reactive object wrapper': now verifies id is a non-empty string and that subscribe/update are functions (not just truthy). - 'value exposes the wrapped plain object': now asserts the actual key value (x === 1) rather than just that the value is truthy. - 'update with new plain object replaces content': now counts subscriber call invocations to confirm notification fires, and checks lastValue is a defined object. - 'toJSON serializes the object value': now checks the serialized shape contains the original key/value pairs (key === 'value', count === 42). All 162 tests pass. Addresses audit item 8.

lucas-spin · 2026-06-15T19:21:07Z

Summary

Follow-up to PR #15 — replaces four weak toBeTruthy() / typeof-only assertions in the RefObject (refObject) describe block with exact behavioral assertions that would catch real regressions.

File changed:tests/reactive-collections.test.ts (test-only change, no production code modified)

Old assertion (weak)	New assertion (exact)
`expect(obj).toBeTruthy()`	`expect(typeof obj.id).toBe('string')` + `id.length > 0` + `subscribe`/`update` are functions
`expect(obj.value).toBeTruthy()`	`expect((obj.value as any).x).toBe(1)` — checks actual wrapped value
`expect(lastValue).toBeTruthy()` after update	counts subscriber calls (> baseCalls) and checks `lastValue` is a defined object
`expect(typeof json).toBe('object')`	checks `json.key === 'value'` and `json.count === 42` — verifies serialized shape

Validation

npm run test:run → 9 test files, 162 tests passed ✓
npx tsc --noEmit → no errors ✓

Roadmap alignment

Addresses audit item 8 (strengthen weak RefObject test assertions). No production code changed.

Reviewer: @zico15

Replaces four weak toBeTruthy / typeof-only assertions from the RefObject (refObject) describe block (introduced in PR TypeComposer#15) with exact behavioral assertions: - 'creates a reactive object wrapper': now verifies id is a non-empty string and that subscribe/update are functions (not just truthy). - 'value exposes the wrapped plain object': now asserts the actual key value (x === 1) rather than just that the value is truthy. - 'update with new plain object replaces content': now counts subscriber call invocations to confirm notification fires, and checks lastValue is a defined object. - 'toJSON serializes the object value': now checks the serialized shape contains the original key/value pairs (key === 'value', count === 42). All 162 tests pass. Addresses audit item 8.

lucas-spin · 2026-06-15T19:21:07Z

Summary

Follow-up to PR #15 — replaces four weak toBeTruthy() / typeof-only assertions in the RefObject (refObject) describe block with exact behavioral assertions that would catch real regressions.

File changed:tests/reactive-collections.test.ts (test-only change, no production code modified)

Old assertion (weak)	New assertion (exact)
`expect(obj).toBeTruthy()`	`expect(typeof obj.id).toBe('string')` + `id.length > 0` + `subscribe`/`update` are functions
`expect(obj.value).toBeTruthy()`	`expect((obj.value as any).x).toBe(1)` — checks actual wrapped value
`expect(lastValue).toBeTruthy()` after update	counts subscriber calls (> baseCalls) and checks `lastValue` is a defined object
`expect(typeof json).toBe('object')`	checks `json.key === 'value'` and `json.count === 42` — verifies serialized shape

Validation

npm run test:run → 9 test files, 162 tests passed ✓
npx tsc --noEmit → no errors ✓

Roadmap alignment

Addresses audit item 8 (strengthen weak RefObject test assertions). No production code changed.

Reviewer: @zico15

Replaces four weak toBeTruthy / typeof-only assertions from the RefObject (refObject) describe block (introduced in PR TypeComposer#15) with exact behavioral assertions: - 'creates a reactive object wrapper': now verifies id is a non-empty string and that subscribe/update are functions (not just truthy). - 'value exposes the wrapped plain object': now asserts the actual key value (x === 1) rather than just that the value is truthy. - 'update with new plain object replaces content': now counts subscriber call invocations to confirm notification fires, and checks lastValue is a defined object. - 'toJSON serializes the object value': now checks the serialized shape contains the original key/value pairs (key === 'value', count === 42). All 162 tests pass. Addresses audit item 8.

lucas-spin · 2026-06-15T19:21:07Z

Summary

Follow-up to PR #15 — replaces four weak toBeTruthy() / typeof-only assertions in the RefObject (refObject) describe block with exact behavioral assertions that would catch real regressions.

File changed:tests/reactive-collections.test.ts (test-only change, no production code modified)

Old assertion (weak)	New assertion (exact)
`expect(obj).toBeTruthy()`	`expect(typeof obj.id).toBe('string')` + `id.length > 0` + `subscribe`/`update` are functions
`expect(obj.value).toBeTruthy()`	`expect((obj.value as any).x).toBe(1)` — checks actual wrapped value
`expect(lastValue).toBeTruthy()` after update	counts subscriber calls (> baseCalls) and checks `lastValue` is a defined object
`expect(typeof json).toBe('object')`	checks `json.key === 'value'` and `json.count === 42` — verifies serialized shape

Validation

npm run test:run → 9 test files, 162 tests passed ✓
npx tsc --noEmit → no errors ✓

Roadmap alignment

Addresses audit item 8 (strengthen weak RefObject test assertions). No production code changed.

Reviewer: @zico15

Replaces four weak toBeTruthy / typeof-only assertions from the RefObject (refObject) describe block (introduced in PR TypeComposer#15) with exact behavioral assertions: - 'creates a reactive object wrapper': now verifies id is a non-empty string and that subscribe/update are functions (not just truthy). - 'value exposes the wrapped plain object': now asserts the actual key value (x === 1) rather than just that the value is truthy. - 'update with new plain object replaces content': now counts subscriber call invocations to confirm notification fires, and checks lastValue is a defined object. - 'toJSON serializes the object value': now checks the serialized shape contains the original key/value pairs (key === 'value', count === 42). All 162 tests pass. Addresses audit item 8.

lucas-spin · 2026-06-15T19:21:07Z

Summary

Follow-up to PR #15 — replaces four weak toBeTruthy() / typeof-only assertions in the RefObject (refObject) describe block with exact behavioral assertions that would catch real regressions.

File changed:tests/reactive-collections.test.ts (test-only change, no production code modified)

Old assertion (weak)	New assertion (exact)
`expect(obj).toBeTruthy()`	`expect(typeof obj.id).toBe('string')` + `id.length > 0` + `subscribe`/`update` are functions
`expect(obj.value).toBeTruthy()`	`expect((obj.value as any).x).toBe(1)` — checks actual wrapped value
`expect(lastValue).toBeTruthy()` after update	counts subscriber calls (> baseCalls) and checks `lastValue` is a defined object
`expect(typeof json).toBe('object')`	checks `json.key === 'value'` and `json.count === 42` — verifies serialized shape

Validation

npm run test:run → 9 test files, 162 tests passed ✓
npx tsc --noEmit → no errors ✓

Roadmap alignment

Addresses audit item 8 (strengthen weak RefObject test assertions). No production code changed.

Reviewer: @zico15

Replaces four weak toBeTruthy / typeof-only assertions from the RefObject (refObject) describe block (introduced in PR TypeComposer#15) with exact behavioral assertions: - 'creates a reactive object wrapper': now verifies id is a non-empty string and that subscribe/update are functions (not just truthy). - 'value exposes the wrapped plain object': now asserts the actual key value (x === 1) rather than just that the value is truthy. - 'update with new plain object replaces content': now counts subscriber call invocations to confirm notification fires, and checks lastValue is a defined object. - 'toJSON serializes the object value': now checks the serialized shape contains the original key/value pairs (key === 'value', count === 42). All 162 tests pass. Addresses audit item 8.

lucas-spin · 2026-06-15T19:21:07Z

Summary

Follow-up to PR #15 — replaces four weak toBeTruthy() / typeof-only assertions in the RefObject (refObject) describe block with exact behavioral assertions that would catch real regressions.

File changed:tests/reactive-collections.test.ts (test-only change, no production code modified)

Old assertion (weak)	New assertion (exact)
`expect(obj).toBeTruthy()`	`expect(typeof obj.id).toBe('string')` + `id.length > 0` + `subscribe`/`update` are functions
`expect(obj.value).toBeTruthy()`	`expect((obj.value as any).x).toBe(1)` — checks actual wrapped value
`expect(lastValue).toBeTruthy()` after update	counts subscriber calls (> baseCalls) and checks `lastValue` is a defined object
`expect(typeof json).toBe('object')`	checks `json.key === 'value'` and `json.count === 42` — verifies serialized shape

Validation

npm run test:run → 9 test files, 162 tests passed ✓
npx tsc --noEmit → no errors ✓

Roadmap alignment

Addresses audit item 8 (strengthen weak RefObject test assertions). No production code changed.

Reviewer: @zico15

Replaces four weak toBeTruthy / typeof-only assertions from the RefObject (refObject) describe block (introduced in PR TypeComposer#15) with exact behavioral assertions: - 'creates a reactive object wrapper': now verifies id is a non-empty string and that subscribe/update are functions (not just truthy). - 'value exposes the wrapped plain object': now asserts the actual key value (x === 1) rather than just that the value is truthy. - 'update with new plain object replaces content': now counts subscriber call invocations to confirm notification fires, and checks lastValue is a defined object. - 'toJSON serializes the object value': now checks the serialized shape contains the original key/value pairs (key === 'value', count === 42). All 162 tests pass. Addresses audit item 8.

lucas-spin · 2026-06-15T19:21:07Z

Summary

Follow-up to PR #15 — replaces four weak toBeTruthy() / typeof-only assertions in the RefObject (refObject) describe block with exact behavioral assertions that would catch real regressions.

File changed:tests/reactive-collections.test.ts (test-only change, no production code modified)

Old assertion (weak)	New assertion (exact)
`expect(obj).toBeTruthy()`	`expect(typeof obj.id).toBe('string')` + `id.length > 0` + `subscribe`/`update` are functions
`expect(obj.value).toBeTruthy()`	`expect((obj.value as any).x).toBe(1)` — checks actual wrapped value
`expect(lastValue).toBeTruthy()` after update	counts subscriber calls (> baseCalls) and checks `lastValue` is a defined object
`expect(typeof json).toBe('object')`	checks `json.key === 'value'` and `json.count === 42` — verifies serialized shape

Validation

npm run test:run → 9 test files, 162 tests passed ✓
npx tsc --noEmit → no errors ✓

Roadmap alignment

Addresses audit item 8 (strengthen weak RefObject test assertions). No production code changed.

Reviewer: @zico15

Replaces four weak toBeTruthy / typeof-only assertions from the RefObject (refObject) describe block (introduced in PR TypeComposer#15) with exact behavioral assertions: - 'creates a reactive object wrapper': now verifies id is a non-empty string and that subscribe/update are functions (not just truthy). - 'value exposes the wrapped plain object': now asserts the actual key value (x === 1) rather than just that the value is truthy. - 'update with new plain object replaces content': now counts subscriber call invocations to confirm notification fires, and checks lastValue is a defined object. - 'toJSON serializes the object value': now checks the serialized shape contains the original key/value pairs (key === 'value', count === 42). All 162 tests pass. Addresses audit item 8.

joaodibba merged commit a71b9ae into TypeComposer:mainJun 15, 2026
2 of 3 checks passed

Uh oh!

Conversation

lucas-spin commented Jun 15, 2026

Summary

Validation

Roadmap alignment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

lucas-spin commented Jun 15, 2026

Summary

Validation

Roadmap alignment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

lucas-spin commented Jun 15, 2026

Summary

Validation

Roadmap alignment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

lucas-spin commented Jun 15, 2026

Summary

Validation

Roadmap alignment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

lucas-spin commented Jun 15, 2026

Summary

Validation

Roadmap alignment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants