Skip to content

our caching for readDirectory drops all but the first argument #962

Description

@cspotcode

ts.sys.readDirectory accepts a half-dozen arguments, but our caching wrapper drops all but the first. It seems like this isn't causing bugs because typescript normally doesn't call this function. Perhaps it's only used to populate the files array based on tsconfig "include" and "exclude" arrays, so our implementation is never called.

It looks like a bug waiting to happen, unless I'm missing something. We can either drop the caching or write a different wrapper that puts all arguments into the cache key.

1e838f7

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions