Skip to content

Fix code coverage so it maps to TS sources - #1043

Merged
cspotcode merged 3 commits into
masterfrom
ab/fix-coverage
May 16, 2020
Merged

Fix code coverage so it maps to TS sources#1043
cspotcode merged 3 commits into
masterfrom
ab/fix-coverage

Conversation

@cspotcode

Copy link
Copy Markdown
Collaborator

Upgraded from istanbul to nyc, so this is blocked by dropping support for node 6.

The captured coverage is of the npm installed instance of ts-node in ./tests/node_modules. So I wrote a small remapper script to post-process the coverage report, rewriting the paths.

upgrade from istanbul to nyc
use a remapper script to remap from ./node_modules/ts-node to our source tree,
since all coverage is captured from an `npm install`ed instance of ts-node
@coveralls

coveralls commented May 16, 2020

Copy link
Copy Markdown

Coverage Status

Coverage increased (+2.2%) to 82.988% when pulling 2f620a9 on ab/fix-coverage into 4f18ceb on master.

@cspotcode

Copy link
Copy Markdown
CollaboratorAuthor

Coveralls can visualize the coverage now.

image
image

@cspotcode
cspotcode merged commit 4ce5846 into masterMay 16, 2020
@cspotcode
cspotcode deleted the ab/fix-coverage branch May 16, 2020 17:23
@cspotcodecspotcode mentioned this pull request Aug 21, 2020
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@cspotcode@coveralls