Skip to content

Fix #1072 - #1085

Merged
cspotcode merged 3 commits into
masterfrom
ab/1072
Aug 4, 2020
Merged

Fix #1072#1085
cspotcode merged 3 commits into
masterfrom
ab/1072

Conversation

@cspotcode

Copy link
Copy Markdown
Collaborator

Fix#1072
Ripped directly from @evg656e's C-to-JS port of ParseNodeOptionsEnvVar. Thanks!

@codecov

codecovBot commented Jul 29, 2020

Copy link
Copy Markdown

Codecov Report

Merging #1085 into master will increase coverage by 0.17%.
The diff coverage is 78.78%.

Impacted file tree graph

@@ Coverage Diff @@## master #1085 +/- ##
==========================================
+ Coverage 75.32% 75.49% +0.17% 
==========================================
Files 6 7 +1 Lines 624 657 +33 Branches 148 148 ==========================================
+ Hits 470 496 +26 - Misses 100 107 +7 
Partials 54 54 
FlagCoverage Δ
#node_1072.15% <ø> (ø)
#node_12_1572.53% <ø> (ø)
#node_12_1672.34% <ø> (-0.19%)⬇️
#node_1375.19% <78.78%> (+0.19%)⬆️
#node_1475.19% <78.78%> (+0.19%)⬆️
#typescript_2_775.03% <78.78%> (+0.19%)⬆️
#typescript_latest74.27% <78.78%> (+0.23%)⬆️
#typescript_next74.12% <78.78%> (+0.24%)⬆️
#ubuntu75.19% <78.78%> (+0.19%)⬆️
#windows75.34% <78.78%> (+0.18%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted FilesCoverage Δ
dist-raw/node-options.js78.78% <78.78%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dfb75c...c44f76e. Read the comment docs.

@coveralls

coveralls commented Jul 29, 2020

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.8%) to 83.175% when pulling c44f76e on ab/1072 into 8dfb75c on master.

@cspotcode
cspotcodeforce-pushed the ab/1072 branch 2 times, most recently from 3534360 to 3c4816cCompareAugust 4, 2020 22:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ESM support: can't recognize '--experimental-specifier-resolution' flag passed via NODE_OPTIONS

3 participants

@cspotcode@coveralls@blakeembrey