Uh oh!
There was an error while loading. Please reload this page.
Add test coverage - #1109
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@## master #1109 +/- ##
==========================================
+ Coverage 75.68% 78.87% +3.19%
==========================================
Files 7 7 Lines 658 658 Branches 147 147 ==========================================
+ Hits 498 519 +21 + Misses 107 91 -16 + Partials 53 48 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
cspotcode
marked this pull request as ready for review
August 12, 2020 23:02
cspotcodeforce-pushed
the
ab/esm-loader-test-deferred-urls
branch
from
August 12, 2020 23:07
64256d8 to
98dc6f5Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of these tests are silly, but they were easy to implement and bump the coverage up. I personally don't believe in coverage numbers out of context, but I know other people (incorrectly) do, so why not?
Blocked by #1103 which will be merged soon