Skip to content

Fix data URL format determination in new loader hooks API - #1529

Merged
cspotcode merged 6 commits into
mainfrom
fix-1526
Oct 22, 2021
Merged

Fix data URL format determination in new loader hooks API#1529
cspotcode merged 6 commits into
mainfrom
fix-1526

Conversation

@cspotcode

@cspotcodecspotcode commented Oct 21, 2021•
edited
Loading

Copy link
Copy Markdown
Collaborator

Fixes#1526

Also fixes#1506

@cspotcode

cspotcode commented Oct 21, 2021

Copy link
Copy Markdown
CollaboratorAuthor

Pushing twice, once to verify the tests fail, then again with the fix.

@codecov

codecovBot commented Oct 21, 2021•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1529 (b5ff840) into main (8cde25b) will decrease coverage by 0.05%.
The diff coverage is 66.66%.

Impacted FilesCoverage Δ
dist-raw/node-primordials.js59.09% <0.00%> (-2.82%)⬇️
src/esm.ts84.21% <100.00%> (ø)
src/index.ts77.83% <100.00%> (ø)

@cspotcodecspotcode changed the title Fix data: URL format determination in new loader hooks APIFix data URL format determination in new loader hooks APIOct 22, 2021
@cspotcodecspotcode added this to the 10.3.2 milestone Oct 22, 2021
@cspotcode
cspotcode merged commit 889c21d into mainOct 22, 2021
@cspotcode
cspotcode deleted the fix-1526 branch October 24, 2021 15:30
@sync-by-unitosync-by-unitoBot mentioned this pull request Nov 1, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

10.4.0

1 participant

@cspotcode