Skip to content

fix(coverage): --coverage-diff passes a new file that no test executed #1054

Description

@Chemaclass

Problem

--coverage-diff reports 100% for a brand new file that no test executed, and --coverage-min passes. That is the exact case the gate exists to catch.

report_diff (src/coverage/diff.sh:102) iterates get_tracked_files, which only holds files that executed at least once. A changed file that never ran is skipped, the changed-line total stays 0, and diff_percentage returns 100 for an empty set (src/coverage/diff.sh:37-41, intentionally, so a docs-only commit does not fail).

Reproduced on Bash 3.2 arm64, macOS. Added an untracked file with three executable lines and no test:

printf'#!/usr/bin/env bash\n\nfunction never_called_probe() {\n echo "one"\n echo "two"\n echo "three"\n}\n'> src/zz_probe_tmp.sh
./bashunit --coverage --coverage-paths src --coverage-diff HEAD --coverage-min 90 \
--coverage-report /dev/null tests/unit/assert/basic_test.sh

Output:

Diff Coverage (vs HEAD)
---------------
No changed executable lines.
---------------
Total: 0/0 (100%)

Exit code 0. A PR adding a fully untested file passes a 90% diff gate.

The empty-set-is-100% rule is correct on its own. The defect is the input set: "nothing changed" and "the changed file never ran" are being treated as the same thing.

Proposal

Compute diff coverage over the changed files, not over the executed files.

  • Ask git for the changed files against the base ref, filter them through the coverage paths and excludes, and iterate that set unioned with the tracked set.
  • A changed file with no hit data yields 0/N, not a skip.
  • Keep the empty-set-is-100% rule for the case it was written for: no changed executable lines anywhere.
  • bashunit::helper::git_changed_lines (src/helper/git.sh:101) already handles an untracked file by treating every line as new, so the per-file half works once the file reaches the loop.

Seeding tracked files from the coverage paths would fix this as a side effect, but the diff report should not depend on that: it needs the changed set regardless, and a changed file outside the seeded paths must still be excluded.

Where to change

  • src/coverage/diff.sh:91-137report_diff
  • src/coverage/stats.sh:164-186check_threshold, which reads _BASHUNIT_COVERAGE_DIFF_PCT_OUT
  • src/helper/git.sh:137git_filter_changed is the existing helper for the changed-file list

Acceptance criteria

  • A new, never-executed file with changed executable lines appears in the diff report as 0/N (0%)
  • --coverage-diff <ref> --coverage-min 90 exits non-zero for that file
  • An untracked (new, uncommitted) file is covered by the same behaviour, matching git_changed_lines
  • A modified file whose changed lines all ran still reports 100%
  • A run with no changed executable lines anywhere still reports 100% and passes the gate (feat(coverage): diff coverage — restrict the report to lines changed against a base ref #1032 behaviour preserved)
  • A changed file outside BASHUNIT_COVERAGE_PATHS, or matched by BASHUNIT_COVERAGE_EXCLUDE, is not counted
  • A changed file that was deleted does not break the report
  • A renamed file resolves to its new path, matching --changed (feat(cli): --changed to run only the tests touched since a git ref #1010)
  • Works under --parallel
  • Both engines produce the same numbers (trap and xtrace)
  • LCOV and HTML stay whole-file, as documented in src/coverage/diff.sh:10-12

Repo checklist (agent)

  • TDD: RED then GREEN then REFACTOR. The RED test is the reproduction above, in a fixture git repo under a temp dir, never against this repo's own history.
  • Bash 3.0+ only: no printf -v, no += append, no declare -A, no [[ ]], no ${var,,}, no &>>, no ${arr[-1]}. Expanding a possibly-empty array under set -u needs ${arr[@]+"${arr[@]}"}.
  • Fixtures under tests/acceptance/fixtures/ must not end in *test.sh.
  • Gates: make sa, make lint, ./bashunit tests/, ./bashunit --parallel tests/. Never run shfmt -w.
  • CHANGELOG.md: one line under ## Unreleased (Fixed).
  • One issue = one PR.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

  • Status
    Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(coverage): --coverage-diff passes a new file that no test executed · Issue #1054 · TypedDevs/bashunit · GitHub
Skip to content

fix(coverage): --coverage-diff passes a new file that no test executed #1054

Description

@Chemaclass

Problem

--coverage-diff reports 100% for a brand new file that no test executed, and --coverage-min passes. That is the exact case the gate exists to catch.

report_diff (src/coverage/diff.sh:102) iterates get_tracked_files, which only holds files that executed at least once. A changed file that never ran is skipped, the changed-line total stays 0, and diff_percentage returns 100 for an empty set (src/coverage/diff.sh:37-41, intentionally, so a docs-only commit does not fail).

Reproduced on Bash 3.2 arm64, macOS. Added an untracked file with three executable lines and no test:

printf'#!/usr/bin/env bash\n\nfunction never_called_probe() {\n echo "one"\n echo "two"\n echo "three"\n}\n'> src/zz_probe_tmp.sh
./bashunit --coverage --coverage-paths src --coverage-diff HEAD --coverage-min 90 \
--coverage-report /dev/null tests/unit/assert/basic_test.sh

Output:

Diff Coverage (vs HEAD)
---------------
No changed executable lines.
---------------
Total: 0/0 (100%)

Exit code 0. A PR adding a fully untested file passes a 90% diff gate.

The empty-set-is-100% rule is correct on its own. The defect is the input set: "nothing changed" and "the changed file never ran" are being treated as the same thing.

Proposal

Compute diff coverage over the changed files, not over the executed files.

  • Ask git for the changed files against the base ref, filter them through the coverage paths and excludes, and iterate that set unioned with the tracked set.
  • A changed file with no hit data yields 0/N, not a skip.
  • Keep the empty-set-is-100% rule for the case it was written for: no changed executable lines anywhere.
  • bashunit::helper::git_changed_lines (src/helper/git.sh:101) already handles an untracked file by treating every line as new, so the per-file half works once the file reaches the loop.

Seeding tracked files from the coverage paths would fix this as a side effect, but the diff report should not depend on that: it needs the changed set regardless, and a changed file outside the seeded paths must still be excluded.

Where to change

  • src/coverage/diff.sh:91-137report_diff
  • src/coverage/stats.sh:164-186check_threshold, which reads _BASHUNIT_COVERAGE_DIFF_PCT_OUT
  • src/helper/git.sh:137git_filter_changed is the existing helper for the changed-file list

Acceptance criteria

  • A new, never-executed file with changed executable lines appears in the diff report as 0/N (0%)
  • --coverage-diff <ref> --coverage-min 90 exits non-zero for that file
  • An untracked (new, uncommitted) file is covered by the same behaviour, matching git_changed_lines
  • A modified file whose changed lines all ran still reports 100%
  • A run with no changed executable lines anywhere still reports 100% and passes the gate (feat(coverage): diff coverage — restrict the report to lines changed against a base ref #1032 behaviour preserved)
  • A changed file outside BASHUNIT_COVERAGE_PATHS, or matched by BASHUNIT_COVERAGE_EXCLUDE, is not counted
  • A changed file that was deleted does not break the report
  • A renamed file resolves to its new path, matching --changed (feat(cli): --changed to run only the tests touched since a git ref #1010)
  • Works under --parallel
  • Both engines produce the same numbers (trap and xtrace)
  • LCOV and HTML stay whole-file, as documented in src/coverage/diff.sh:10-12

Repo checklist (agent)

  • TDD: RED then GREEN then REFACTOR. The RED test is the reproduction above, in a fixture git repo under a temp dir, never against this repo's own history.
  • Bash 3.0+ only: no printf -v, no += append, no declare -A, no [[ ]], no ${var,,}, no &>>, no ${arr[-1]}. Expanding a possibly-empty array under set -u needs ${arr[@]+"${arr[@]}"}.
  • Fixtures under tests/acceptance/fixtures/ must not end in *test.sh.
  • Gates: make sa, make lint, ./bashunit tests/, ./bashunit --parallel tests/. Never run shfmt -w.
  • CHANGELOG.md: one line under ## Unreleased (Fixed).
  • One issue = one PR.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

  • Status
    Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(coverage): --coverage-diff passes a new file that no test executed · Issue #1054 · TypedDevs/bashunit · GitHub
Skip to content

fix(coverage): --coverage-diff passes a new file that no test executed #1054

Description

@Chemaclass

Problem

--coverage-diff reports 100% for a brand new file that no test executed, and --coverage-min passes. That is the exact case the gate exists to catch.

report_diff (src/coverage/diff.sh:102) iterates get_tracked_files, which only holds files that executed at least once. A changed file that never ran is skipped, the changed-line total stays 0, and diff_percentage returns 100 for an empty set (src/coverage/diff.sh:37-41, intentionally, so a docs-only commit does not fail).

Reproduced on Bash 3.2 arm64, macOS. Added an untracked file with three executable lines and no test:

printf'#!/usr/bin/env bash\n\nfunction never_called_probe() {\n echo "one"\n echo "two"\n echo "three"\n}\n'> src/zz_probe_tmp.sh
./bashunit --coverage --coverage-paths src --coverage-diff HEAD --coverage-min 90 \
--coverage-report /dev/null tests/unit/assert/basic_test.sh

Output:

Diff Coverage (vs HEAD)
---------------
No changed executable lines.
---------------
Total: 0/0 (100%)

Exit code 0. A PR adding a fully untested file passes a 90% diff gate.

The empty-set-is-100% rule is correct on its own. The defect is the input set: "nothing changed" and "the changed file never ran" are being treated as the same thing.

Proposal

Compute diff coverage over the changed files, not over the executed files.

  • Ask git for the changed files against the base ref, filter them through the coverage paths and excludes, and iterate that set unioned with the tracked set.
  • A changed file with no hit data yields 0/N, not a skip.
  • Keep the empty-set-is-100% rule for the case it was written for: no changed executable lines anywhere.
  • bashunit::helper::git_changed_lines (src/helper/git.sh:101) already handles an untracked file by treating every line as new, so the per-file half works once the file reaches the loop.

Seeding tracked files from the coverage paths would fix this as a side effect, but the diff report should not depend on that: it needs the changed set regardless, and a changed file outside the seeded paths must still be excluded.

Where to change

  • src/coverage/diff.sh:91-137report_diff
  • src/coverage/stats.sh:164-186check_threshold, which reads _BASHUNIT_COVERAGE_DIFF_PCT_OUT
  • src/helper/git.sh:137git_filter_changed is the existing helper for the changed-file list

Acceptance criteria

  • A new, never-executed file with changed executable lines appears in the diff report as 0/N (0%)
  • --coverage-diff <ref> --coverage-min 90 exits non-zero for that file
  • An untracked (new, uncommitted) file is covered by the same behaviour, matching git_changed_lines
  • A modified file whose changed lines all ran still reports 100%
  • A run with no changed executable lines anywhere still reports 100% and passes the gate (feat(coverage): diff coverage — restrict the report to lines changed against a base ref #1032 behaviour preserved)
  • A changed file outside BASHUNIT_COVERAGE_PATHS, or matched by BASHUNIT_COVERAGE_EXCLUDE, is not counted
  • A changed file that was deleted does not break the report
  • A renamed file resolves to its new path, matching --changed (feat(cli): --changed to run only the tests touched since a git ref #1010)
  • Works under --parallel
  • Both engines produce the same numbers (trap and xtrace)
  • LCOV and HTML stay whole-file, as documented in src/coverage/diff.sh:10-12

Repo checklist (agent)

  • TDD: RED then GREEN then REFACTOR. The RED test is the reproduction above, in a fixture git repo under a temp dir, never against this repo's own history.
  • Bash 3.0+ only: no printf -v, no += append, no declare -A, no [[ ]], no ${var,,}, no &>>, no ${arr[-1]}. Expanding a possibly-empty array under set -u needs ${arr[@]+"${arr[@]}"}.
  • Fixtures under tests/acceptance/fixtures/ must not end in *test.sh.
  • Gates: make sa, make lint, ./bashunit tests/, ./bashunit --parallel tests/. Never run shfmt -w.
  • CHANGELOG.md: one line under ## Unreleased (Fixed).
  • One issue = one PR.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

  • Status
    Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(coverage): --coverage-diff passes a new file that no test executed · Issue #1054 · TypedDevs/bashunit · GitHub
Skip to content

fix(coverage): --coverage-diff passes a new file that no test executed #1054

Description

@Chemaclass

Problem

--coverage-diff reports 100% for a brand new file that no test executed, and --coverage-min passes. That is the exact case the gate exists to catch.

report_diff (src/coverage/diff.sh:102) iterates get_tracked_files, which only holds files that executed at least once. A changed file that never ran is skipped, the changed-line total stays 0, and diff_percentage returns 100 for an empty set (src/coverage/diff.sh:37-41, intentionally, so a docs-only commit does not fail).

Reproduced on Bash 3.2 arm64, macOS. Added an untracked file with three executable lines and no test:

printf'#!/usr/bin/env bash\n\nfunction never_called_probe() {\n echo "one"\n echo "two"\n echo "three"\n}\n'> src/zz_probe_tmp.sh
./bashunit --coverage --coverage-paths src --coverage-diff HEAD --coverage-min 90 \
--coverage-report /dev/null tests/unit/assert/basic_test.sh

Output:

Diff Coverage (vs HEAD)
---------------
No changed executable lines.
---------------
Total: 0/0 (100%)

Exit code 0. A PR adding a fully untested file passes a 90% diff gate.

The empty-set-is-100% rule is correct on its own. The defect is the input set: "nothing changed" and "the changed file never ran" are being treated as the same thing.

Proposal

Compute diff coverage over the changed files, not over the executed files.

  • Ask git for the changed files against the base ref, filter them through the coverage paths and excludes, and iterate that set unioned with the tracked set.
  • A changed file with no hit data yields 0/N, not a skip.
  • Keep the empty-set-is-100% rule for the case it was written for: no changed executable lines anywhere.
  • bashunit::helper::git_changed_lines (src/helper/git.sh:101) already handles an untracked file by treating every line as new, so the per-file half works once the file reaches the loop.

Seeding tracked files from the coverage paths would fix this as a side effect, but the diff report should not depend on that: it needs the changed set regardless, and a changed file outside the seeded paths must still be excluded.

Where to change

  • src/coverage/diff.sh:91-137report_diff
  • src/coverage/stats.sh:164-186check_threshold, which reads _BASHUNIT_COVERAGE_DIFF_PCT_OUT
  • src/helper/git.sh:137git_filter_changed is the existing helper for the changed-file list

Acceptance criteria

  • A new, never-executed file with changed executable lines appears in the diff report as 0/N (0%)
  • --coverage-diff <ref> --coverage-min 90 exits non-zero for that file
  • An untracked (new, uncommitted) file is covered by the same behaviour, matching git_changed_lines
  • A modified file whose changed lines all ran still reports 100%
  • A run with no changed executable lines anywhere still reports 100% and passes the gate (feat(coverage): diff coverage — restrict the report to lines changed against a base ref #1032 behaviour preserved)
  • A changed file outside BASHUNIT_COVERAGE_PATHS, or matched by BASHUNIT_COVERAGE_EXCLUDE, is not counted
  • A changed file that was deleted does not break the report
  • A renamed file resolves to its new path, matching --changed (feat(cli): --changed to run only the tests touched since a git ref #1010)
  • Works under --parallel
  • Both engines produce the same numbers (trap and xtrace)
  • LCOV and HTML stay whole-file, as documented in src/coverage/diff.sh:10-12

Repo checklist (agent)

  • TDD: RED then GREEN then REFACTOR. The RED test is the reproduction above, in a fixture git repo under a temp dir, never against this repo's own history.
  • Bash 3.0+ only: no printf -v, no += append, no declare -A, no [[ ]], no ${var,,}, no &>>, no ${arr[-1]}. Expanding a possibly-empty array under set -u needs ${arr[@]+"${arr[@]}"}.
  • Fixtures under tests/acceptance/fixtures/ must not end in *test.sh.
  • Gates: make sa, make lint, ./bashunit tests/, ./bashunit --parallel tests/. Never run shfmt -w.
  • CHANGELOG.md: one line under ## Unreleased (Fixed).
  • One issue = one PR.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

  • Status
    Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' fix(coverage): --coverage-diff passes a new file that no test executed · Issue #1054 · TypedDevs/bashunit · GitHub
Skip to content

fix(coverage): --coverage-diff passes a new file that no test executed #1054

Description

@Chemaclass

Problem

--coverage-diff reports 100% for a brand new file that no test executed, and --coverage-min passes. That is the exact case the gate exists to catch.

report_diff (src/coverage/diff.sh:102) iterates get_tracked_files, which only holds files that executed at least once. A changed file that never ran is skipped, the changed-line total stays 0, and diff_percentage returns 100 for an empty set (src/coverage/diff.sh:37-41, intentionally, so a docs-only commit does not fail).

Reproduced on Bash 3.2 arm64, macOS. Added an untracked file with three executable lines and no test:

printf'#!/usr/bin/env bash\n\nfunction never_called_probe() {\n echo "one"\n echo "two"\n echo "three"\n}\n'> src/zz_probe_tmp.sh
./bashunit --coverage --coverage-paths src --coverage-diff HEAD --coverage-min 90 \
--coverage-report /dev/null tests/unit/assert/basic_test.sh

Output:

Diff Coverage (vs HEAD)
---------------
No changed executable lines.
---------------
Total: 0/0 (100%)

Exit code 0. A PR adding a fully untested file passes a 90% diff gate.

The empty-set-is-100% rule is correct on its own. The defect is the input set: "nothing changed" and "the changed file never ran" are being treated as the same thing.

Proposal

Compute diff coverage over the changed files, not over the executed files.

  • Ask git for the changed files against the base ref, filter them through the coverage paths and excludes, and iterate that set unioned with the tracked set.
  • A changed file with no hit data yields 0/N, not a skip.
  • Keep the empty-set-is-100% rule for the case it was written for: no changed executable lines anywhere.
  • bashunit::helper::git_changed_lines (src/helper/git.sh:101) already handles an untracked file by treating every line as new, so the per-file half works once the file reaches the loop.

Seeding tracked files from the coverage paths would fix this as a side effect, but the diff report should not depend on that: it needs the changed set regardless, and a changed file outside the seeded paths must still be excluded.

Where to change

  • src/coverage/diff.sh:91-137report_diff
  • src/coverage/stats.sh:164-186check_threshold, which reads _BASHUNIT_COVERAGE_DIFF_PCT_OUT
  • src/helper/git.sh:137git_filter_changed is the existing helper for the changed-file list

Acceptance criteria

  • A new, never-executed file with changed executable lines appears in the diff report as 0/N (0%)
  • --coverage-diff <ref> --coverage-min 90 exits non-zero for that file
  • An untracked (new, uncommitted) file is covered by the same behaviour, matching git_changed_lines
  • A modified file whose changed lines all ran still reports 100%
  • A run with no changed executable lines anywhere still reports 100% and passes the gate (feat(coverage): diff coverage — restrict the report to lines changed against a base ref #1032 behaviour preserved)
  • A changed file outside BASHUNIT_COVERAGE_PATHS, or matched by BASHUNIT_COVERAGE_EXCLUDE, is not counted
  • A changed file that was deleted does not break the report
  • A renamed file resolves to its new path, matching --changed (feat(cli): --changed to run only the tests touched since a git ref #1010)
  • Works under --parallel
  • Both engines produce the same numbers (trap and xtrace)
  • LCOV and HTML stay whole-file, as documented in src/coverage/diff.sh:10-12

Repo checklist (agent)

  • TDD: RED then GREEN then REFACTOR. The RED test is the reproduction above, in a fixture git repo under a temp dir, never against this repo's own history.
  • Bash 3.0+ only: no printf -v, no += append, no declare -A, no [[ ]], no ${var,,}, no &>>, no ${arr[-1]}. Expanding a possibly-empty array under set -u needs ${arr[@]+"${arr[@]}"}.
  • Fixtures under tests/acceptance/fixtures/ must not end in *test.sh.
  • Gates: make sa, make lint, ./bashunit tests/, ./bashunit --parallel tests/. Never run shfmt -w.
  • CHANGELOG.md: one line under ## Unreleased (Fixed).
  • One issue = one PR.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

  • Status
    Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(coverage): --coverage-diff passes a new file that no test executed · Issue #1054 · TypedDevs/bashunit · GitHub
Skip to content

fix(coverage): --coverage-diff passes a new file that no test executed #1054

Description

@Chemaclass

Problem

--coverage-diff reports 100% for a brand new file that no test executed, and --coverage-min passes. That is the exact case the gate exists to catch.

report_diff (src/coverage/diff.sh:102) iterates get_tracked_files, which only holds files that executed at least once. A changed file that never ran is skipped, the changed-line total stays 0, and diff_percentage returns 100 for an empty set (src/coverage/diff.sh:37-41, intentionally, so a docs-only commit does not fail).

Reproduced on Bash 3.2 arm64, macOS. Added an untracked file with three executable lines and no test:

printf'#!/usr/bin/env bash\n\nfunction never_called_probe() {\n echo "one"\n echo "two"\n echo "three"\n}\n'> src/zz_probe_tmp.sh
./bashunit --coverage --coverage-paths src --coverage-diff HEAD --coverage-min 90 \
--coverage-report /dev/null tests/unit/assert/basic_test.sh

Output:

Diff Coverage (vs HEAD)
---------------
No changed executable lines.
---------------
Total: 0/0 (100%)

Exit code 0. A PR adding a fully untested file passes a 90% diff gate.

The empty-set-is-100% rule is correct on its own. The defect is the input set: "nothing changed" and "the changed file never ran" are being treated as the same thing.

Proposal

Compute diff coverage over the changed files, not over the executed files.

  • Ask git for the changed files against the base ref, filter them through the coverage paths and excludes, and iterate that set unioned with the tracked set.
  • A changed file with no hit data yields 0/N, not a skip.
  • Keep the empty-set-is-100% rule for the case it was written for: no changed executable lines anywhere.
  • bashunit::helper::git_changed_lines (src/helper/git.sh:101) already handles an untracked file by treating every line as new, so the per-file half works once the file reaches the loop.

Seeding tracked files from the coverage paths would fix this as a side effect, but the diff report should not depend on that: it needs the changed set regardless, and a changed file outside the seeded paths must still be excluded.

Where to change

  • src/coverage/diff.sh:91-137report_diff
  • src/coverage/stats.sh:164-186check_threshold, which reads _BASHUNIT_COVERAGE_DIFF_PCT_OUT
  • src/helper/git.sh:137git_filter_changed is the existing helper for the changed-file list

Acceptance criteria

  • A new, never-executed file with changed executable lines appears in the diff report as 0/N (0%)
  • --coverage-diff <ref> --coverage-min 90 exits non-zero for that file
  • An untracked (new, uncommitted) file is covered by the same behaviour, matching git_changed_lines
  • A modified file whose changed lines all ran still reports 100%
  • A run with no changed executable lines anywhere still reports 100% and passes the gate (feat(coverage): diff coverage — restrict the report to lines changed against a base ref #1032 behaviour preserved)
  • A changed file outside BASHUNIT_COVERAGE_PATHS, or matched by BASHUNIT_COVERAGE_EXCLUDE, is not counted
  • A changed file that was deleted does not break the report
  • A renamed file resolves to its new path, matching --changed (feat(cli): --changed to run only the tests touched since a git ref #1010)
  • Works under --parallel
  • Both engines produce the same numbers (trap and xtrace)
  • LCOV and HTML stay whole-file, as documented in src/coverage/diff.sh:10-12

Repo checklist (agent)

  • TDD: RED then GREEN then REFACTOR. The RED test is the reproduction above, in a fixture git repo under a temp dir, never against this repo's own history.
  • Bash 3.0+ only: no printf -v, no += append, no declare -A, no [[ ]], no ${var,,}, no &>>, no ${arr[-1]}. Expanding a possibly-empty array under set -u needs ${arr[@]+"${arr[@]}"}.
  • Fixtures under tests/acceptance/fixtures/ must not end in *test.sh.
  • Gates: make sa, make lint, ./bashunit tests/, ./bashunit --parallel tests/. Never run shfmt -w.
  • CHANGELOG.md: one line under ## Unreleased (Fixed).
  • One issue = one PR.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

  • Status
    Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(coverage): --coverage-diff passes a new file that no test executed · Issue #1054 · TypedDevs/bashunit · GitHub
Skip to content

fix(coverage): --coverage-diff passes a new file that no test executed #1054

Description

@Chemaclass

Problem

--coverage-diff reports 100% for a brand new file that no test executed, and --coverage-min passes. That is the exact case the gate exists to catch.

report_diff (src/coverage/diff.sh:102) iterates get_tracked_files, which only holds files that executed at least once. A changed file that never ran is skipped, the changed-line total stays 0, and diff_percentage returns 100 for an empty set (src/coverage/diff.sh:37-41, intentionally, so a docs-only commit does not fail).

Reproduced on Bash 3.2 arm64, macOS. Added an untracked file with three executable lines and no test:

printf'#!/usr/bin/env bash\n\nfunction never_called_probe() {\n echo "one"\n echo "two"\n echo "three"\n}\n'> src/zz_probe_tmp.sh
./bashunit --coverage --coverage-paths src --coverage-diff HEAD --coverage-min 90 \
--coverage-report /dev/null tests/unit/assert/basic_test.sh

Output:

Diff Coverage (vs HEAD)
---------------
No changed executable lines.
---------------
Total: 0/0 (100%)

Exit code 0. A PR adding a fully untested file passes a 90% diff gate.

The empty-set-is-100% rule is correct on its own. The defect is the input set: "nothing changed" and "the changed file never ran" are being treated as the same thing.

Proposal

Compute diff coverage over the changed files, not over the executed files.

  • Ask git for the changed files against the base ref, filter them through the coverage paths and excludes, and iterate that set unioned with the tracked set.
  • A changed file with no hit data yields 0/N, not a skip.
  • Keep the empty-set-is-100% rule for the case it was written for: no changed executable lines anywhere.
  • bashunit::helper::git_changed_lines (src/helper/git.sh:101) already handles an untracked file by treating every line as new, so the per-file half works once the file reaches the loop.

Seeding tracked files from the coverage paths would fix this as a side effect, but the diff report should not depend on that: it needs the changed set regardless, and a changed file outside the seeded paths must still be excluded.

Where to change

  • src/coverage/diff.sh:91-137report_diff
  • src/coverage/stats.sh:164-186check_threshold, which reads _BASHUNIT_COVERAGE_DIFF_PCT_OUT
  • src/helper/git.sh:137git_filter_changed is the existing helper for the changed-file list

Acceptance criteria

  • A new, never-executed file with changed executable lines appears in the diff report as 0/N (0%)
  • --coverage-diff <ref> --coverage-min 90 exits non-zero for that file
  • An untracked (new, uncommitted) file is covered by the same behaviour, matching git_changed_lines
  • A modified file whose changed lines all ran still reports 100%
  • A run with no changed executable lines anywhere still reports 100% and passes the gate (feat(coverage): diff coverage — restrict the report to lines changed against a base ref #1032 behaviour preserved)
  • A changed file outside BASHUNIT_COVERAGE_PATHS, or matched by BASHUNIT_COVERAGE_EXCLUDE, is not counted
  • A changed file that was deleted does not break the report
  • A renamed file resolves to its new path, matching --changed (feat(cli): --changed to run only the tests touched since a git ref #1010)
  • Works under --parallel
  • Both engines produce the same numbers (trap and xtrace)
  • LCOV and HTML stay whole-file, as documented in src/coverage/diff.sh:10-12

Repo checklist (agent)

  • TDD: RED then GREEN then REFACTOR. The RED test is the reproduction above, in a fixture git repo under a temp dir, never against this repo's own history.
  • Bash 3.0+ only: no printf -v, no += append, no declare -A, no [[ ]], no ${var,,}, no &>>, no ${arr[-1]}. Expanding a possibly-empty array under set -u needs ${arr[@]+"${arr[@]}"}.
  • Fixtures under tests/acceptance/fixtures/ must not end in *test.sh.
  • Gates: make sa, make lint, ./bashunit tests/, ./bashunit --parallel tests/. Never run shfmt -w.
  • CHANGELOG.md: one line under ## Unreleased (Fixed).
  • One issue = one PR.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

  • Status
    Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); fix(coverage): --coverage-diff passes a new file that no test executed · Issue #1054 · TypedDevs/bashunit · GitHub
Skip to content

fix(coverage): --coverage-diff passes a new file that no test executed #1054

Description

@Chemaclass

Problem

--coverage-diff reports 100% for a brand new file that no test executed, and --coverage-min passes. That is the exact case the gate exists to catch.

report_diff (src/coverage/diff.sh:102) iterates get_tracked_files, which only holds files that executed at least once. A changed file that never ran is skipped, the changed-line total stays 0, and diff_percentage returns 100 for an empty set (src/coverage/diff.sh:37-41, intentionally, so a docs-only commit does not fail).

Reproduced on Bash 3.2 arm64, macOS. Added an untracked file with three executable lines and no test:

printf'#!/usr/bin/env bash\n\nfunction never_called_probe() {\n echo "one"\n echo "two"\n echo "three"\n}\n'> src/zz_probe_tmp.sh
./bashunit --coverage --coverage-paths src --coverage-diff HEAD --coverage-min 90 \
--coverage-report /dev/null tests/unit/assert/basic_test.sh

Output:

Diff Coverage (vs HEAD)
---------------
No changed executable lines.
---------------
Total: 0/0 (100%)

Exit code 0. A PR adding a fully untested file passes a 90% diff gate.

The empty-set-is-100% rule is correct on its own. The defect is the input set: "nothing changed" and "the changed file never ran" are being treated as the same thing.

Proposal

Compute diff coverage over the changed files, not over the executed files.

  • Ask git for the changed files against the base ref, filter them through the coverage paths and excludes, and iterate that set unioned with the tracked set.
  • A changed file with no hit data yields 0/N, not a skip.
  • Keep the empty-set-is-100% rule for the case it was written for: no changed executable lines anywhere.
  • bashunit::helper::git_changed_lines (src/helper/git.sh:101) already handles an untracked file by treating every line as new, so the per-file half works once the file reaches the loop.

Seeding tracked files from the coverage paths would fix this as a side effect, but the diff report should not depend on that: it needs the changed set regardless, and a changed file outside the seeded paths must still be excluded.

Where to change

  • src/coverage/diff.sh:91-137report_diff
  • src/coverage/stats.sh:164-186check_threshold, which reads _BASHUNIT_COVERAGE_DIFF_PCT_OUT
  • src/helper/git.sh:137git_filter_changed is the existing helper for the changed-file list

Acceptance criteria

  • A new, never-executed file with changed executable lines appears in the diff report as 0/N (0%)
  • --coverage-diff <ref> --coverage-min 90 exits non-zero for that file
  • An untracked (new, uncommitted) file is covered by the same behaviour, matching git_changed_lines
  • A modified file whose changed lines all ran still reports 100%
  • A run with no changed executable lines anywhere still reports 100% and passes the gate (feat(coverage): diff coverage — restrict the report to lines changed against a base ref #1032 behaviour preserved)
  • A changed file outside BASHUNIT_COVERAGE_PATHS, or matched by BASHUNIT_COVERAGE_EXCLUDE, is not counted
  • A changed file that was deleted does not break the report
  • A renamed file resolves to its new path, matching --changed (feat(cli): --changed to run only the tests touched since a git ref #1010)
  • Works under --parallel
  • Both engines produce the same numbers (trap and xtrace)
  • LCOV and HTML stay whole-file, as documented in src/coverage/diff.sh:10-12

Repo checklist (agent)

  • TDD: RED then GREEN then REFACTOR. The RED test is the reproduction above, in a fixture git repo under a temp dir, never against this repo's own history.
  • Bash 3.0+ only: no printf -v, no += append, no declare -A, no [[ ]], no ${var,,}, no &>>, no ${arr[-1]}. Expanding a possibly-empty array under set -u needs ${arr[@]+"${arr[@]}"}.
  • Fixtures under tests/acceptance/fixtures/ must not end in *test.sh.
  • Gates: make sa, make lint, ./bashunit tests/, ./bashunit --parallel tests/. Never run shfmt -w.
  • CHANGELOG.md: one line under ## Unreleased (Fixed).
  • One issue = one PR.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

  • Status
    Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions