Skip to content

perf(clock): skip per-test clock reads when the clock impl forks an interpreter #765

Description

@Chemaclass

Part of #761.

Problem

bashunit::runner::run_test reads the clock twice per test (src/runner.sh:1070 and src/runner.sh:1097). On shells without EPOCHREALTIME (bash < 5, i.e. macOS default 3.2) and without GNU date +%s%N (macOS/Alpine are explicitly excluded at src/clock.sh:22), bashunit::clock::now falls through to forking a perl interpreter per read (src/clock.sh:88-90). Measured: ~5-8ms per perl fork, so ~10-16ms per test, ~2400 perl processes and ~15-20s per full suite run on a stock Mac — plus the same tax inside every one of the 258 nested ./bashunit acceptance invocations.

The same two-reads-per-hook pattern exists for set_up_before_script/tear_down_after_script (src/runner.sh:1761,1778 and src/runner.sh:1900,1917) — per file, so much cheaper, but it rides the same code path.

Proposed behavior (needs ADR)

Per-test wall-clock timing becomes best-effort based on clock cost:

  1. Add bashunit::clock::is_expensive (or similar): true when the chosen impl forks an interpreter (perl, python, node, powershell); false for shell (EPOCHREALTIME) and date/date-seconds.
  2. Introduce an auto default for per-test timing: when the clock is expensive AND nothing needs per-test durations, skip BOTH clock::now reads in run_test. Per-test durations are consumed by:
    • execution-time display (bashunit::env::is_show_execution_time_enabled, src/env.sh:250, default true via _BASHUNIT_DEFAULT_SHOW_EXECUTION_TIMEsrc/env.sh:103),
    • --profile (src/runner.sh:1101), --verbose (src/runner.sh:1105), and report writers (src/reports.sh).
      Suggested mechanics: change the default of BASHUNIT_SHOW_EXECUTION_TIME from "true" to "auto"; auto resolves to false only when the clock is expensive. An explicit BASHUNIT_SHOW_EXECUTION_TIME=true, --profile, --verbose, or an active report keeps precise timing (and its perl cost). Explicit false already skips display but currently NOT the clock reads — fix that too: when duration is not consumed, do not read the clock at all.
  3. When timing is skipped, the per-test duration renders as empty (verify print_successful_test / report writers handle an empty or 0 duration gracefully — decide and test one representation).
  4. Total suite runtime (bashunit::clock::total_runtime_in_milliseconds, 2 reads per run) stays as-is.
  5. Write an ADR in adrs/ documenting the decision and the alternative considered and rejected: a persistent co-process timestamp server over FIFOs (one fork per suite). Rejected because concurrent readers in --parallel mode would race on the FIFO without a portable lock (no flock on stock macOS), plus lifecycle/cleanup complexity.

If during implementation a materially better design emerges, propose it in the issue before building.

Tests first (TDD)

  • Unit tests for the impl-classification function (force _BASHUNIT_CLOCK_NOW_IMPL values).
  • Acceptance: on an expensive-clock system, default run shows no per-test times but correct totals; BASHUNIT_SHOW_EXECUTION_TIME=true restores them; --profile/report runs still produce durations. Use BASHUNIT_TEST_BASH_VERSION-style seams or env overrides rather than depending on the host — check how existing clock tests (tests/unit/clock_test.sh if present) fake impls.
  • Existing display/report tests must pass on Linux CI (bash 5, cheap clock: behavior unchanged there).

Constraints

  • Bash 3.0+ only: no declare -A, no [[ ]], no ${var,,}, no negative array indexing, no &>>.
  • No behavior change on fork-free clock systems (Linux CI, bash 5).
  • User-visible change (per-test times disappear by default on old-bash Macs): CHANGELOG.md entry + docs update required.

Acceptance criteria

  • ./bashunit tests/ and ./bashunit --parallel tests/ pass.
  • make sa, make lint pass; shfmt -w . produces no diff.
  • Fork census on macOS bash 3.2: perl count drops from ~2/test to ~2/run in a default run.
  • 100-noop benchmark before/after reported in PR (expect roughly 5s -> 3.5s or better).
  • ADR merged.

Line references valid at commit 4d80e7c.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    • Status
      Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    , 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
     blocks
    (function() {
    function addCopyButtons() {
    document.querySelectorAll('pre code').forEach(function(codeBlock) {
    if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
    codeBlock.parentElement.setAttribute('data-copy-added', 'true');
    var btn = document.createElement('button');
    btn.textContent = 'Copy';
    btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
    btn.onmouseover = function() { this.style.opacity = '1'; };
    btn.onmouseout = function() { this.style.opacity = '0.7'; };
    btn.onclick = function() {
    navigator.clipboard.writeText(codeBlock.textContent).then(function() {
    btn.textContent = 'Copied!';
    setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
    });
    };
    codeBlock.parentElement.style.position = 'relative';
    codeBlock.parentElement.appendChild(btn);
    });
    }
    addCopyButtons();
    // Re-run on dynamic content
    var observer = new MutationObserver(addCopyButtons);
    observer.observe(document.body, { childList: true, subtree: true });
    })();
    }
    } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
    })();
    (function(){
    try {
    var __m = "github.com";
    var __re = new RegExp('^' + "github\\.com" + '
    perf(clock): skip per-test clock reads when the clock impl forks an interpreter · Issue #765 · TypedDevs/bashunit · GitHub
    Skip to content

    perf(clock): skip per-test clock reads when the clock impl forks an interpreter #765

    Description

    @Chemaclass

    Part of #761.

    Problem

    bashunit::runner::run_test reads the clock twice per test (src/runner.sh:1070 and src/runner.sh:1097). On shells without EPOCHREALTIME (bash < 5, i.e. macOS default 3.2) and without GNU date +%s%N (macOS/Alpine are explicitly excluded at src/clock.sh:22), bashunit::clock::now falls through to forking a perl interpreter per read (src/clock.sh:88-90). Measured: ~5-8ms per perl fork, so ~10-16ms per test, ~2400 perl processes and ~15-20s per full suite run on a stock Mac — plus the same tax inside every one of the 258 nested ./bashunit acceptance invocations.

    The same two-reads-per-hook pattern exists for set_up_before_script/tear_down_after_script (src/runner.sh:1761,1778 and src/runner.sh:1900,1917) — per file, so much cheaper, but it rides the same code path.

    Proposed behavior (needs ADR)

    Per-test wall-clock timing becomes best-effort based on clock cost:

    1. Add bashunit::clock::is_expensive (or similar): true when the chosen impl forks an interpreter (perl, python, node, powershell); false for shell (EPOCHREALTIME) and date/date-seconds.
    2. Introduce an auto default for per-test timing: when the clock is expensive AND nothing needs per-test durations, skip BOTH clock::now reads in run_test. Per-test durations are consumed by:
      • execution-time display (bashunit::env::is_show_execution_time_enabled, src/env.sh:250, default true via _BASHUNIT_DEFAULT_SHOW_EXECUTION_TIMEsrc/env.sh:103),
      • --profile (src/runner.sh:1101), --verbose (src/runner.sh:1105), and report writers (src/reports.sh).
        Suggested mechanics: change the default of BASHUNIT_SHOW_EXECUTION_TIME from "true" to "auto"; auto resolves to false only when the clock is expensive. An explicit BASHUNIT_SHOW_EXECUTION_TIME=true, --profile, --verbose, or an active report keeps precise timing (and its perl cost). Explicit false already skips display but currently NOT the clock reads — fix that too: when duration is not consumed, do not read the clock at all.
    3. When timing is skipped, the per-test duration renders as empty (verify print_successful_test / report writers handle an empty or 0 duration gracefully — decide and test one representation).
    4. Total suite runtime (bashunit::clock::total_runtime_in_milliseconds, 2 reads per run) stays as-is.
    5. Write an ADR in adrs/ documenting the decision and the alternative considered and rejected: a persistent co-process timestamp server over FIFOs (one fork per suite). Rejected because concurrent readers in --parallel mode would race on the FIFO without a portable lock (no flock on stock macOS), plus lifecycle/cleanup complexity.

    If during implementation a materially better design emerges, propose it in the issue before building.

    Tests first (TDD)

    • Unit tests for the impl-classification function (force _BASHUNIT_CLOCK_NOW_IMPL values).
    • Acceptance: on an expensive-clock system, default run shows no per-test times but correct totals; BASHUNIT_SHOW_EXECUTION_TIME=true restores them; --profile/report runs still produce durations. Use BASHUNIT_TEST_BASH_VERSION-style seams or env overrides rather than depending on the host — check how existing clock tests (tests/unit/clock_test.sh if present) fake impls.
    • Existing display/report tests must pass on Linux CI (bash 5, cheap clock: behavior unchanged there).

    Constraints

    • Bash 3.0+ only: no declare -A, no [[ ]], no ${var,,}, no negative array indexing, no &>>.
    • No behavior change on fork-free clock systems (Linux CI, bash 5).
    • User-visible change (per-test times disappear by default on old-bash Macs): CHANGELOG.md entry + docs update required.

    Acceptance criteria

    • ./bashunit tests/ and ./bashunit --parallel tests/ pass.
    • make sa, make lint pass; shfmt -w . produces no diff.
    • Fork census on macOS bash 3.2: perl count drops from ~2/test to ~2/run in a default run.
    • 100-noop benchmark before/after reported in PR (expect roughly 5s -> 3.5s or better).
    • ADR merged.

    Line references valid at commit 4d80e7c.

    Metadata

    Metadata

    Assignees

    No one assigned

      Labels

      enhancementNew feature or request

      Type

      No type

      Projects

      • Status
        Done

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      , 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' perf(clock): skip per-test clock reads when the clock impl forks an interpreter · Issue #765 · TypedDevs/bashunit · GitHub
      Skip to content

      perf(clock): skip per-test clock reads when the clock impl forks an interpreter #765

      Description

      @Chemaclass

      Part of #761.

      Problem

      bashunit::runner::run_test reads the clock twice per test (src/runner.sh:1070 and src/runner.sh:1097). On shells without EPOCHREALTIME (bash < 5, i.e. macOS default 3.2) and without GNU date +%s%N (macOS/Alpine are explicitly excluded at src/clock.sh:22), bashunit::clock::now falls through to forking a perl interpreter per read (src/clock.sh:88-90). Measured: ~5-8ms per perl fork, so ~10-16ms per test, ~2400 perl processes and ~15-20s per full suite run on a stock Mac — plus the same tax inside every one of the 258 nested ./bashunit acceptance invocations.

      The same two-reads-per-hook pattern exists for set_up_before_script/tear_down_after_script (src/runner.sh:1761,1778 and src/runner.sh:1900,1917) — per file, so much cheaper, but it rides the same code path.

      Proposed behavior (needs ADR)

      Per-test wall-clock timing becomes best-effort based on clock cost:

      1. Add bashunit::clock::is_expensive (or similar): true when the chosen impl forks an interpreter (perl, python, node, powershell); false for shell (EPOCHREALTIME) and date/date-seconds.
      2. Introduce an auto default for per-test timing: when the clock is expensive AND nothing needs per-test durations, skip BOTH clock::now reads in run_test. Per-test durations are consumed by:
        • execution-time display (bashunit::env::is_show_execution_time_enabled, src/env.sh:250, default true via _BASHUNIT_DEFAULT_SHOW_EXECUTION_TIMEsrc/env.sh:103),
        • --profile (src/runner.sh:1101), --verbose (src/runner.sh:1105), and report writers (src/reports.sh).
          Suggested mechanics: change the default of BASHUNIT_SHOW_EXECUTION_TIME from "true" to "auto"; auto resolves to false only when the clock is expensive. An explicit BASHUNIT_SHOW_EXECUTION_TIME=true, --profile, --verbose, or an active report keeps precise timing (and its perl cost). Explicit false already skips display but currently NOT the clock reads — fix that too: when duration is not consumed, do not read the clock at all.
      3. When timing is skipped, the per-test duration renders as empty (verify print_successful_test / report writers handle an empty or 0 duration gracefully — decide and test one representation).
      4. Total suite runtime (bashunit::clock::total_runtime_in_milliseconds, 2 reads per run) stays as-is.
      5. Write an ADR in adrs/ documenting the decision and the alternative considered and rejected: a persistent co-process timestamp server over FIFOs (one fork per suite). Rejected because concurrent readers in --parallel mode would race on the FIFO without a portable lock (no flock on stock macOS), plus lifecycle/cleanup complexity.

      If during implementation a materially better design emerges, propose it in the issue before building.

      Tests first (TDD)

      • Unit tests for the impl-classification function (force _BASHUNIT_CLOCK_NOW_IMPL values).
      • Acceptance: on an expensive-clock system, default run shows no per-test times but correct totals; BASHUNIT_SHOW_EXECUTION_TIME=true restores them; --profile/report runs still produce durations. Use BASHUNIT_TEST_BASH_VERSION-style seams or env overrides rather than depending on the host — check how existing clock tests (tests/unit/clock_test.sh if present) fake impls.
      • Existing display/report tests must pass on Linux CI (bash 5, cheap clock: behavior unchanged there).

      Constraints

      • Bash 3.0+ only: no declare -A, no [[ ]], no ${var,,}, no negative array indexing, no &>>.
      • No behavior change on fork-free clock systems (Linux CI, bash 5).
      • User-visible change (per-test times disappear by default on old-bash Macs): CHANGELOG.md entry + docs update required.

      Acceptance criteria

      • ./bashunit tests/ and ./bashunit --parallel tests/ pass.
      • make sa, make lint pass; shfmt -w . produces no diff.
      • Fork census on macOS bash 3.2: perl count drops from ~2/test to ~2/run in a default run.
      • 100-noop benchmark before/after reported in PR (expect roughly 5s -> 3.5s or better).
      • ADR merged.

      Line references valid at commit 4d80e7c.

      Metadata

      Metadata

      Assignees

      No one assigned

        Labels

        enhancementNew feature or request

        Type

        No type

        Projects

        • Status
          Done

        Milestone

        No milestone

        Relationships

        None yet

        Development

        No branches or pull requests

        Issue actions

        , 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' perf(clock): skip per-test clock reads when the clock impl forks an interpreter · Issue #765 · TypedDevs/bashunit · GitHub
        Skip to content

        perf(clock): skip per-test clock reads when the clock impl forks an interpreter #765

        Description

        @Chemaclass

        Part of #761.

        Problem

        bashunit::runner::run_test reads the clock twice per test (src/runner.sh:1070 and src/runner.sh:1097). On shells without EPOCHREALTIME (bash < 5, i.e. macOS default 3.2) and without GNU date +%s%N (macOS/Alpine are explicitly excluded at src/clock.sh:22), bashunit::clock::now falls through to forking a perl interpreter per read (src/clock.sh:88-90). Measured: ~5-8ms per perl fork, so ~10-16ms per test, ~2400 perl processes and ~15-20s per full suite run on a stock Mac — plus the same tax inside every one of the 258 nested ./bashunit acceptance invocations.

        The same two-reads-per-hook pattern exists for set_up_before_script/tear_down_after_script (src/runner.sh:1761,1778 and src/runner.sh:1900,1917) — per file, so much cheaper, but it rides the same code path.

        Proposed behavior (needs ADR)

        Per-test wall-clock timing becomes best-effort based on clock cost:

        1. Add bashunit::clock::is_expensive (or similar): true when the chosen impl forks an interpreter (perl, python, node, powershell); false for shell (EPOCHREALTIME) and date/date-seconds.
        2. Introduce an auto default for per-test timing: when the clock is expensive AND nothing needs per-test durations, skip BOTH clock::now reads in run_test. Per-test durations are consumed by:
          • execution-time display (bashunit::env::is_show_execution_time_enabled, src/env.sh:250, default true via _BASHUNIT_DEFAULT_SHOW_EXECUTION_TIMEsrc/env.sh:103),
          • --profile (src/runner.sh:1101), --verbose (src/runner.sh:1105), and report writers (src/reports.sh).
            Suggested mechanics: change the default of BASHUNIT_SHOW_EXECUTION_TIME from "true" to "auto"; auto resolves to false only when the clock is expensive. An explicit BASHUNIT_SHOW_EXECUTION_TIME=true, --profile, --verbose, or an active report keeps precise timing (and its perl cost). Explicit false already skips display but currently NOT the clock reads — fix that too: when duration is not consumed, do not read the clock at all.
        3. When timing is skipped, the per-test duration renders as empty (verify print_successful_test / report writers handle an empty or 0 duration gracefully — decide and test one representation).
        4. Total suite runtime (bashunit::clock::total_runtime_in_milliseconds, 2 reads per run) stays as-is.
        5. Write an ADR in adrs/ documenting the decision and the alternative considered and rejected: a persistent co-process timestamp server over FIFOs (one fork per suite). Rejected because concurrent readers in --parallel mode would race on the FIFO without a portable lock (no flock on stock macOS), plus lifecycle/cleanup complexity.

        If during implementation a materially better design emerges, propose it in the issue before building.

        Tests first (TDD)

        • Unit tests for the impl-classification function (force _BASHUNIT_CLOCK_NOW_IMPL values).
        • Acceptance: on an expensive-clock system, default run shows no per-test times but correct totals; BASHUNIT_SHOW_EXECUTION_TIME=true restores them; --profile/report runs still produce durations. Use BASHUNIT_TEST_BASH_VERSION-style seams or env overrides rather than depending on the host — check how existing clock tests (tests/unit/clock_test.sh if present) fake impls.
        • Existing display/report tests must pass on Linux CI (bash 5, cheap clock: behavior unchanged there).

        Constraints

        • Bash 3.0+ only: no declare -A, no [[ ]], no ${var,,}, no negative array indexing, no &>>.
        • No behavior change on fork-free clock systems (Linux CI, bash 5).
        • User-visible change (per-test times disappear by default on old-bash Macs): CHANGELOG.md entry + docs update required.

        Acceptance criteria

        • ./bashunit tests/ and ./bashunit --parallel tests/ pass.
        • make sa, make lint pass; shfmt -w . produces no diff.
        • Fork census on macOS bash 3.2: perl count drops from ~2/test to ~2/run in a default run.
        • 100-noop benchmark before/after reported in PR (expect roughly 5s -> 3.5s or better).
        • ADR merged.

        Line references valid at commit 4d80e7c.

        Metadata

        Metadata

        Assignees

        No one assigned

          Labels

          enhancementNew feature or request

          Type

          No type

          Projects

          • Status
            Done

          Milestone

          No milestone

          Relationships

          None yet

          Development

          No branches or pull requests

          Issue actions

          , 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' perf(clock): skip per-test clock reads when the clock impl forks an interpreter · Issue #765 · TypedDevs/bashunit · GitHub
          Skip to content

          perf(clock): skip per-test clock reads when the clock impl forks an interpreter #765

          Description

          @Chemaclass

          Part of #761.

          Problem

          bashunit::runner::run_test reads the clock twice per test (src/runner.sh:1070 and src/runner.sh:1097). On shells without EPOCHREALTIME (bash < 5, i.e. macOS default 3.2) and without GNU date +%s%N (macOS/Alpine are explicitly excluded at src/clock.sh:22), bashunit::clock::now falls through to forking a perl interpreter per read (src/clock.sh:88-90). Measured: ~5-8ms per perl fork, so ~10-16ms per test, ~2400 perl processes and ~15-20s per full suite run on a stock Mac — plus the same tax inside every one of the 258 nested ./bashunit acceptance invocations.

          The same two-reads-per-hook pattern exists for set_up_before_script/tear_down_after_script (src/runner.sh:1761,1778 and src/runner.sh:1900,1917) — per file, so much cheaper, but it rides the same code path.

          Proposed behavior (needs ADR)

          Per-test wall-clock timing becomes best-effort based on clock cost:

          1. Add bashunit::clock::is_expensive (or similar): true when the chosen impl forks an interpreter (perl, python, node, powershell); false for shell (EPOCHREALTIME) and date/date-seconds.
          2. Introduce an auto default for per-test timing: when the clock is expensive AND nothing needs per-test durations, skip BOTH clock::now reads in run_test. Per-test durations are consumed by:
            • execution-time display (bashunit::env::is_show_execution_time_enabled, src/env.sh:250, default true via _BASHUNIT_DEFAULT_SHOW_EXECUTION_TIMEsrc/env.sh:103),
            • --profile (src/runner.sh:1101), --verbose (src/runner.sh:1105), and report writers (src/reports.sh).
              Suggested mechanics: change the default of BASHUNIT_SHOW_EXECUTION_TIME from "true" to "auto"; auto resolves to false only when the clock is expensive. An explicit BASHUNIT_SHOW_EXECUTION_TIME=true, --profile, --verbose, or an active report keeps precise timing (and its perl cost). Explicit false already skips display but currently NOT the clock reads — fix that too: when duration is not consumed, do not read the clock at all.
          3. When timing is skipped, the per-test duration renders as empty (verify print_successful_test / report writers handle an empty or 0 duration gracefully — decide and test one representation).
          4. Total suite runtime (bashunit::clock::total_runtime_in_milliseconds, 2 reads per run) stays as-is.
          5. Write an ADR in adrs/ documenting the decision and the alternative considered and rejected: a persistent co-process timestamp server over FIFOs (one fork per suite). Rejected because concurrent readers in --parallel mode would race on the FIFO without a portable lock (no flock on stock macOS), plus lifecycle/cleanup complexity.

          If during implementation a materially better design emerges, propose it in the issue before building.

          Tests first (TDD)

          • Unit tests for the impl-classification function (force _BASHUNIT_CLOCK_NOW_IMPL values).
          • Acceptance: on an expensive-clock system, default run shows no per-test times but correct totals; BASHUNIT_SHOW_EXECUTION_TIME=true restores them; --profile/report runs still produce durations. Use BASHUNIT_TEST_BASH_VERSION-style seams or env overrides rather than depending on the host — check how existing clock tests (tests/unit/clock_test.sh if present) fake impls.
          • Existing display/report tests must pass on Linux CI (bash 5, cheap clock: behavior unchanged there).

          Constraints

          • Bash 3.0+ only: no declare -A, no [[ ]], no ${var,,}, no negative array indexing, no &>>.
          • No behavior change on fork-free clock systems (Linux CI, bash 5).
          • User-visible change (per-test times disappear by default on old-bash Macs): CHANGELOG.md entry + docs update required.

          Acceptance criteria

          • ./bashunit tests/ and ./bashunit --parallel tests/ pass.
          • make sa, make lint pass; shfmt -w . produces no diff.
          • Fork census on macOS bash 3.2: perl count drops from ~2/test to ~2/run in a default run.
          • 100-noop benchmark before/after reported in PR (expect roughly 5s -> 3.5s or better).
          • ADR merged.

          Line references valid at commit 4d80e7c.

          Metadata

          Metadata

          Assignees

          No one assigned

            Labels

            enhancementNew feature or request

            Type

            No type

            Projects

            • Status
              Done

            Milestone

            No milestone

            Relationships

            None yet

            Development

            No branches or pull requests

            Issue actions

            , 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' perf(clock): skip per-test clock reads when the clock impl forks an interpreter · Issue #765 · TypedDevs/bashunit · GitHub
            Skip to content

            perf(clock): skip per-test clock reads when the clock impl forks an interpreter #765

            Description

            @Chemaclass

            Part of #761.

            Problem

            bashunit::runner::run_test reads the clock twice per test (src/runner.sh:1070 and src/runner.sh:1097). On shells without EPOCHREALTIME (bash < 5, i.e. macOS default 3.2) and without GNU date +%s%N (macOS/Alpine are explicitly excluded at src/clock.sh:22), bashunit::clock::now falls through to forking a perl interpreter per read (src/clock.sh:88-90). Measured: ~5-8ms per perl fork, so ~10-16ms per test, ~2400 perl processes and ~15-20s per full suite run on a stock Mac — plus the same tax inside every one of the 258 nested ./bashunit acceptance invocations.

            The same two-reads-per-hook pattern exists for set_up_before_script/tear_down_after_script (src/runner.sh:1761,1778 and src/runner.sh:1900,1917) — per file, so much cheaper, but it rides the same code path.

            Proposed behavior (needs ADR)

            Per-test wall-clock timing becomes best-effort based on clock cost:

            1. Add bashunit::clock::is_expensive (or similar): true when the chosen impl forks an interpreter (perl, python, node, powershell); false for shell (EPOCHREALTIME) and date/date-seconds.
            2. Introduce an auto default for per-test timing: when the clock is expensive AND nothing needs per-test durations, skip BOTH clock::now reads in run_test. Per-test durations are consumed by:
              • execution-time display (bashunit::env::is_show_execution_time_enabled, src/env.sh:250, default true via _BASHUNIT_DEFAULT_SHOW_EXECUTION_TIMEsrc/env.sh:103),
              • --profile (src/runner.sh:1101), --verbose (src/runner.sh:1105), and report writers (src/reports.sh).
                Suggested mechanics: change the default of BASHUNIT_SHOW_EXECUTION_TIME from "true" to "auto"; auto resolves to false only when the clock is expensive. An explicit BASHUNIT_SHOW_EXECUTION_TIME=true, --profile, --verbose, or an active report keeps precise timing (and its perl cost). Explicit false already skips display but currently NOT the clock reads — fix that too: when duration is not consumed, do not read the clock at all.
            3. When timing is skipped, the per-test duration renders as empty (verify print_successful_test / report writers handle an empty or 0 duration gracefully — decide and test one representation).
            4. Total suite runtime (bashunit::clock::total_runtime_in_milliseconds, 2 reads per run) stays as-is.
            5. Write an ADR in adrs/ documenting the decision and the alternative considered and rejected: a persistent co-process timestamp server over FIFOs (one fork per suite). Rejected because concurrent readers in --parallel mode would race on the FIFO without a portable lock (no flock on stock macOS), plus lifecycle/cleanup complexity.

            If during implementation a materially better design emerges, propose it in the issue before building.

            Tests first (TDD)

            • Unit tests for the impl-classification function (force _BASHUNIT_CLOCK_NOW_IMPL values).
            • Acceptance: on an expensive-clock system, default run shows no per-test times but correct totals; BASHUNIT_SHOW_EXECUTION_TIME=true restores them; --profile/report runs still produce durations. Use BASHUNIT_TEST_BASH_VERSION-style seams or env overrides rather than depending on the host — check how existing clock tests (tests/unit/clock_test.sh if present) fake impls.
            • Existing display/report tests must pass on Linux CI (bash 5, cheap clock: behavior unchanged there).

            Constraints

            • Bash 3.0+ only: no declare -A, no [[ ]], no ${var,,}, no negative array indexing, no &>>.
            • No behavior change on fork-free clock systems (Linux CI, bash 5).
            • User-visible change (per-test times disappear by default on old-bash Macs): CHANGELOG.md entry + docs update required.

            Acceptance criteria

            • ./bashunit tests/ and ./bashunit --parallel tests/ pass.
            • make sa, make lint pass; shfmt -w . produces no diff.
            • Fork census on macOS bash 3.2: perl count drops from ~2/test to ~2/run in a default run.
            • 100-noop benchmark before/after reported in PR (expect roughly 5s -> 3.5s or better).
            • ADR merged.

            Line references valid at commit 4d80e7c.

            Metadata

            Metadata

            Assignees

            No one assigned

              Labels

              enhancementNew feature or request

              Type

              No type

              Projects

              • Status
                Done

              Milestone

              No milestone

              Relationships

              None yet

              Development

              No branches or pull requests

              Issue actions

              , 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' perf(clock): skip per-test clock reads when the clock impl forks an interpreter · Issue #765 · TypedDevs/bashunit · GitHub
              Skip to content

              perf(clock): skip per-test clock reads when the clock impl forks an interpreter #765

              Description

              @Chemaclass

              Part of #761.

              Problem

              bashunit::runner::run_test reads the clock twice per test (src/runner.sh:1070 and src/runner.sh:1097). On shells without EPOCHREALTIME (bash < 5, i.e. macOS default 3.2) and without GNU date +%s%N (macOS/Alpine are explicitly excluded at src/clock.sh:22), bashunit::clock::now falls through to forking a perl interpreter per read (src/clock.sh:88-90). Measured: ~5-8ms per perl fork, so ~10-16ms per test, ~2400 perl processes and ~15-20s per full suite run on a stock Mac — plus the same tax inside every one of the 258 nested ./bashunit acceptance invocations.

              The same two-reads-per-hook pattern exists for set_up_before_script/tear_down_after_script (src/runner.sh:1761,1778 and src/runner.sh:1900,1917) — per file, so much cheaper, but it rides the same code path.

              Proposed behavior (needs ADR)

              Per-test wall-clock timing becomes best-effort based on clock cost:

              1. Add bashunit::clock::is_expensive (or similar): true when the chosen impl forks an interpreter (perl, python, node, powershell); false for shell (EPOCHREALTIME) and date/date-seconds.
              2. Introduce an auto default for per-test timing: when the clock is expensive AND nothing needs per-test durations, skip BOTH clock::now reads in run_test. Per-test durations are consumed by:
                • execution-time display (bashunit::env::is_show_execution_time_enabled, src/env.sh:250, default true via _BASHUNIT_DEFAULT_SHOW_EXECUTION_TIMEsrc/env.sh:103),
                • --profile (src/runner.sh:1101), --verbose (src/runner.sh:1105), and report writers (src/reports.sh).
                  Suggested mechanics: change the default of BASHUNIT_SHOW_EXECUTION_TIME from "true" to "auto"; auto resolves to false only when the clock is expensive. An explicit BASHUNIT_SHOW_EXECUTION_TIME=true, --profile, --verbose, or an active report keeps precise timing (and its perl cost). Explicit false already skips display but currently NOT the clock reads — fix that too: when duration is not consumed, do not read the clock at all.
              3. When timing is skipped, the per-test duration renders as empty (verify print_successful_test / report writers handle an empty or 0 duration gracefully — decide and test one representation).
              4. Total suite runtime (bashunit::clock::total_runtime_in_milliseconds, 2 reads per run) stays as-is.
              5. Write an ADR in adrs/ documenting the decision and the alternative considered and rejected: a persistent co-process timestamp server over FIFOs (one fork per suite). Rejected because concurrent readers in --parallel mode would race on the FIFO without a portable lock (no flock on stock macOS), plus lifecycle/cleanup complexity.

              If during implementation a materially better design emerges, propose it in the issue before building.

              Tests first (TDD)

              • Unit tests for the impl-classification function (force _BASHUNIT_CLOCK_NOW_IMPL values).
              • Acceptance: on an expensive-clock system, default run shows no per-test times but correct totals; BASHUNIT_SHOW_EXECUTION_TIME=true restores them; --profile/report runs still produce durations. Use BASHUNIT_TEST_BASH_VERSION-style seams or env overrides rather than depending on the host — check how existing clock tests (tests/unit/clock_test.sh if present) fake impls.
              • Existing display/report tests must pass on Linux CI (bash 5, cheap clock: behavior unchanged there).

              Constraints

              • Bash 3.0+ only: no declare -A, no [[ ]], no ${var,,}, no negative array indexing, no &>>.
              • No behavior change on fork-free clock systems (Linux CI, bash 5).
              • User-visible change (per-test times disappear by default on old-bash Macs): CHANGELOG.md entry + docs update required.

              Acceptance criteria

              • ./bashunit tests/ and ./bashunit --parallel tests/ pass.
              • make sa, make lint pass; shfmt -w . produces no diff.
              • Fork census on macOS bash 3.2: perl count drops from ~2/test to ~2/run in a default run.
              • 100-noop benchmark before/after reported in PR (expect roughly 5s -> 3.5s or better).
              • ADR merged.

              Line references valid at commit 4d80e7c.

              Metadata

              Metadata

              Assignees

              No one assigned

                Labels

                enhancementNew feature or request

                Type

                No type

                Projects

                • Status
                  Done

                Milestone

                No milestone

                Relationships

                None yet

                Development

                No branches or pull requests

                Issue actions

                , 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); perf(clock): skip per-test clock reads when the clock impl forks an interpreter · Issue #765 · TypedDevs/bashunit · GitHub
                Skip to content

                perf(clock): skip per-test clock reads when the clock impl forks an interpreter #765

                Description

                @Chemaclass

                Part of #761.

                Problem

                bashunit::runner::run_test reads the clock twice per test (src/runner.sh:1070 and src/runner.sh:1097). On shells without EPOCHREALTIME (bash < 5, i.e. macOS default 3.2) and without GNU date +%s%N (macOS/Alpine are explicitly excluded at src/clock.sh:22), bashunit::clock::now falls through to forking a perl interpreter per read (src/clock.sh:88-90). Measured: ~5-8ms per perl fork, so ~10-16ms per test, ~2400 perl processes and ~15-20s per full suite run on a stock Mac — plus the same tax inside every one of the 258 nested ./bashunit acceptance invocations.

                The same two-reads-per-hook pattern exists for set_up_before_script/tear_down_after_script (src/runner.sh:1761,1778 and src/runner.sh:1900,1917) — per file, so much cheaper, but it rides the same code path.

                Proposed behavior (needs ADR)

                Per-test wall-clock timing becomes best-effort based on clock cost:

                1. Add bashunit::clock::is_expensive (or similar): true when the chosen impl forks an interpreter (perl, python, node, powershell); false for shell (EPOCHREALTIME) and date/date-seconds.
                2. Introduce an auto default for per-test timing: when the clock is expensive AND nothing needs per-test durations, skip BOTH clock::now reads in run_test. Per-test durations are consumed by:
                  • execution-time display (bashunit::env::is_show_execution_time_enabled, src/env.sh:250, default true via _BASHUNIT_DEFAULT_SHOW_EXECUTION_TIMEsrc/env.sh:103),
                  • --profile (src/runner.sh:1101), --verbose (src/runner.sh:1105), and report writers (src/reports.sh).
                    Suggested mechanics: change the default of BASHUNIT_SHOW_EXECUTION_TIME from "true" to "auto"; auto resolves to false only when the clock is expensive. An explicit BASHUNIT_SHOW_EXECUTION_TIME=true, --profile, --verbose, or an active report keeps precise timing (and its perl cost). Explicit false already skips display but currently NOT the clock reads — fix that too: when duration is not consumed, do not read the clock at all.
                3. When timing is skipped, the per-test duration renders as empty (verify print_successful_test / report writers handle an empty or 0 duration gracefully — decide and test one representation).
                4. Total suite runtime (bashunit::clock::total_runtime_in_milliseconds, 2 reads per run) stays as-is.
                5. Write an ADR in adrs/ documenting the decision and the alternative considered and rejected: a persistent co-process timestamp server over FIFOs (one fork per suite). Rejected because concurrent readers in --parallel mode would race on the FIFO without a portable lock (no flock on stock macOS), plus lifecycle/cleanup complexity.

                If during implementation a materially better design emerges, propose it in the issue before building.

                Tests first (TDD)

                • Unit tests for the impl-classification function (force _BASHUNIT_CLOCK_NOW_IMPL values).
                • Acceptance: on an expensive-clock system, default run shows no per-test times but correct totals; BASHUNIT_SHOW_EXECUTION_TIME=true restores them; --profile/report runs still produce durations. Use BASHUNIT_TEST_BASH_VERSION-style seams or env overrides rather than depending on the host — check how existing clock tests (tests/unit/clock_test.sh if present) fake impls.
                • Existing display/report tests must pass on Linux CI (bash 5, cheap clock: behavior unchanged there).

                Constraints

                • Bash 3.0+ only: no declare -A, no [[ ]], no ${var,,}, no negative array indexing, no &>>.
                • No behavior change on fork-free clock systems (Linux CI, bash 5).
                • User-visible change (per-test times disappear by default on old-bash Macs): CHANGELOG.md entry + docs update required.

                Acceptance criteria

                • ./bashunit tests/ and ./bashunit --parallel tests/ pass.
                • make sa, make lint pass; shfmt -w . produces no diff.
                • Fork census on macOS bash 3.2: perl count drops from ~2/test to ~2/run in a default run.
                • 100-noop benchmark before/after reported in PR (expect roughly 5s -> 3.5s or better).
                • ADR merged.

                Line references valid at commit 4d80e7c.

                Metadata

                Metadata

                Assignees

                No one assigned

                  Labels

                  enhancementNew feature or request

                  Type

                  No type

                  Projects

                  • Status
                    Done

                  Milestone

                  No milestone

                  Relationships

                  None yet

                  Development

                  No branches or pull requests

                  Issue actions