Skip to content

perf(snapshot): remove success-path forks from assert_match_snapshot #775

Closed
Closed
perf(snapshot): remove success-path forks from assert_match_snapshot#775
Assignees
Chemaclass
Labels
enhancementNew feature or request

Description

@Chemaclass
Chemaclass
opened on Jul 12, 2026

Part of #761.

Problem

assert_match_snapshot forks ~6-8 times even when the snapshot matches (the common case):

  • src/assert_snapshot.sh:5 — $(echo -n "$1" | tr -d '\r'): 2 forks to strip carriage returns.
  • src/assert_snapshot.sh:7 — $(bashunit::helper::find_test_function_name): capture fork around a pure-bash helper.
  • src/assert_snapshot.sh:8 — $(bashunit::snapshot::resolve_file ...), which internally (src/assert_snapshot.sh:62-64) forks dirname once, basename once, and normalize_variable_name twice.
  • src/assert_snapshot.sh:83 — snapshot=$(tr -d '\r' <"$snapshot_path"): subshell + external tr per compare.

assert_match_snapshot_ignore_colors (src/assert_snapshot.sh:19) adds a sed on top.

Task — checklist, one commit each

  • Replace \r stripping with pure-bash ${var//$'\r'/} at src/assert_snapshot.sh:5 and for the file content at :83 (read with $(<"$snapshot_path") — no external exec — then strip in bash).
  • Use return-slot variants of find_test_function_name and normalize_test_function_name/normalize_variable_name (add slots if they don't exist yet; coordinate with the assert hot-path issue which adds some of the same slots).
  • In resolve_file (src/assert_snapshot.sh:55), replace dirname/basename with parameter expansion (${path%/*}, ${path##*/}) and convert the function itself to a return slot. Watch the edge case BASH_SOURCE without a slash.
  • ignore_colors variant: reuse bashunit::str::strip_ansi (src/str.sh:4) instead of a bespoke sed, so plain input takes its pure-bash fast path. Verify the sed patterns match ([mK] suffixes) before swapping; if they differ, align deliberately and cover with a test.

Tests first (TDD)

tests/unit/snapshot_test.sh (or nearest existing snapshot tests — grep first) is the spec. Add cases: content containing \r, snapshot file with \r\n line endings, custom file hint vs derived path, ANSI-colored input for the ignore-colors variant. Snapshot files on disk must remain byte-compatible with ones created by the current version.

Constraints

  • Bash 3.0+ only.
  • Existing .snapshot files must keep matching (no format/normalization change).

Acceptance criteria

  • ./bashunit tests/ and ./bashunit --parallel tests/ pass after every commit.
  • make sa, make lint pass; shfmt -w . produces no diff.

Line references valid at commit 1ae3e82.

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

bashunit
Status
Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
perf(snapshot): remove success-path forks from assert_match_snapshot · Issue #775 · TypedDevs/bashunit · GitHub
Skip to content
perf(snapshot): remove success-path forks from assert_match_snapshot #775
Closed
Closed
perf(snapshot): remove success-path forks from assert_match_snapshot#775
Assignees
Chemaclass
Labels
enhancementNew feature or request
Description
@Chemaclass
Chemaclass
opened on Jul 12, 2026
Part of #761.
Problem
assert_match_snapshot forks ~6-8 times even when the snapshot matches (the common case):
  • src/assert_snapshot.sh:5 — $(echo -n "$1" | tr -d '\r'): 2 forks to strip carriage returns.
  • src/assert_snapshot.sh:7 — $(bashunit::helper::find_test_function_name): capture fork around a pure-bash helper.
  • src/assert_snapshot.sh:8 — $(bashunit::snapshot::resolve_file ...), which internally (src/assert_snapshot.sh:62-64) forks dirname once, basename once, and normalize_variable_name twice.
  • src/assert_snapshot.sh:83 — snapshot=$(tr -d '\r' <"$snapshot_path"): subshell + external tr per compare.
assert_match_snapshot_ignore_colors (src/assert_snapshot.sh:19) adds a sed on top.
Task — checklist, one commit each
  •  Replace \r stripping with pure-bash ${var//$'\r'/} at src/assert_snapshot.sh:5 and for the file content at :83 (read with $(<"$snapshot_path") — no external exec — then strip in bash).
  •  Use return-slot variants of find_test_function_name and normalize_test_function_name/normalize_variable_name (add slots if they don't exist yet; coordinate with the assert hot-path issue which adds some of the same slots).
  •  In resolve_file (src/assert_snapshot.sh:55), replace dirname/basename with parameter expansion (${path%/*}, ${path##*/}) and convert the function itself to a return slot. Watch the edge case BASH_SOURCE without a slash.
  • ignore_colors variant: reuse bashunit::str::strip_ansi (src/str.sh:4) instead of a bespoke sed, so plain input takes its pure-bash fast path. Verify the sed patterns match ([mK] suffixes) before swapping; if they differ, align deliberately and cover with a test.
Tests first (TDD)
tests/unit/snapshot_test.sh (or nearest existing snapshot tests — grep first) is the spec. Add cases: content containing \r, snapshot file with \r\n line endings, custom file hint vs derived path, ANSI-colored input for the ignore-colors variant. Snapshot files on disk must remain byte-compatible with ones created by the current version.
Constraints
  • Bash 3.0+ only.
  • Existing .snapshot files must keep matching (no format/normalization change).
Acceptance criteria
  • ./bashunit tests/ and ./bashunit --parallel tests/ pass after every commit.
  • make sa, make lint pass; shfmt -w . produces no diff.
Line references valid at commit 1ae3e82.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or request
Type
No type
Projects
bashunit
Status
Done
Milestone
No milestone
Relationships
None yet
Development
No branches or pull requests
Issue actions

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
perf(snapshot): remove success-path forks from assert_match_snapshot · Issue #775 · TypedDevs/bashunit · GitHub
Skip to content
perf(snapshot): remove success-path forks from assert_match_snapshot #775
Closed
Closed
perf(snapshot): remove success-path forks from assert_match_snapshot#775
Assignees
Chemaclass
Labels
enhancementNew feature or request
Description
@Chemaclass
Chemaclass
opened on Jul 12, 2026
Part of #761.
Problem
assert_match_snapshot forks ~6-8 times even when the snapshot matches (the common case):
  • src/assert_snapshot.sh:5 — $(echo -n "$1" | tr -d '\r'): 2 forks to strip carriage returns.
  • src/assert_snapshot.sh:7 — $(bashunit::helper::find_test_function_name): capture fork around a pure-bash helper.
  • src/assert_snapshot.sh:8 — $(bashunit::snapshot::resolve_file ...), which internally (src/assert_snapshot.sh:62-64) forks dirname once, basename once, and normalize_variable_name twice.
  • src/assert_snapshot.sh:83 — snapshot=$(tr -d '\r' <"$snapshot_path"): subshell + external tr per compare.
assert_match_snapshot_ignore_colors (src/assert_snapshot.sh:19) adds a sed on top.
Task — checklist, one commit each
  •  Replace \r stripping with pure-bash ${var//$'\r'/} at src/assert_snapshot.sh:5 and for the file content at :83 (read with $(<"$snapshot_path") — no external exec — then strip in bash).
  •  Use return-slot variants of find_test_function_name and normalize_test_function_name/normalize_variable_name (add slots if they don't exist yet; coordinate with the assert hot-path issue which adds some of the same slots).
  •  In resolve_file (src/assert_snapshot.sh:55), replace dirname/basename with parameter expansion (${path%/*}, ${path##*/}) and convert the function itself to a return slot. Watch the edge case BASH_SOURCE without a slash.
  • ignore_colors variant: reuse bashunit::str::strip_ansi (src/str.sh:4) instead of a bespoke sed, so plain input takes its pure-bash fast path. Verify the sed patterns match ([mK] suffixes) before swapping; if they differ, align deliberately and cover with a test.
Tests first (TDD)
tests/unit/snapshot_test.sh (or nearest existing snapshot tests — grep first) is the spec. Add cases: content containing \r, snapshot file with \r\n line endings, custom file hint vs derived path, ANSI-colored input for the ignore-colors variant. Snapshot files on disk must remain byte-compatible with ones created by the current version.
Constraints
  • Bash 3.0+ only.
  • Existing .snapshot files must keep matching (no format/normalization change).
Acceptance criteria
  • ./bashunit tests/ and ./bashunit --parallel tests/ pass after every commit.
  • make sa, make lint pass; shfmt -w . produces no diff.
Line references valid at commit 1ae3e82.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or request
Type
No type
Projects
bashunit
Status
Done
Milestone
No milestone
Relationships
None yet
Development
No branches or pull requests
Issue actions

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
perf(snapshot): remove success-path forks from assert_match_snapshot · Issue #775 · TypedDevs/bashunit · GitHub
Skip to content
perf(snapshot): remove success-path forks from assert_match_snapshot #775
Closed
Closed
perf(snapshot): remove success-path forks from assert_match_snapshot#775
Assignees
Chemaclass
Labels
enhancementNew feature or request
Description
@Chemaclass
Chemaclass
opened on Jul 12, 2026
Part of #761.
Problem
assert_match_snapshot forks ~6-8 times even when the snapshot matches (the common case):
  • src/assert_snapshot.sh:5 — $(echo -n "$1" | tr -d '\r'): 2 forks to strip carriage returns.
  • src/assert_snapshot.sh:7 — $(bashunit::helper::find_test_function_name): capture fork around a pure-bash helper.
  • src/assert_snapshot.sh:8 — $(bashunit::snapshot::resolve_file ...), which internally (src/assert_snapshot.sh:62-64) forks dirname once, basename once, and normalize_variable_name twice.
  • src/assert_snapshot.sh:83 — snapshot=$(tr -d '\r' <"$snapshot_path"): subshell + external tr per compare.
assert_match_snapshot_ignore_colors (src/assert_snapshot.sh:19) adds a sed on top.
Task — checklist, one commit each
  •  Replace \r stripping with pure-bash ${var//$'\r'/} at src/assert_snapshot.sh:5 and for the file content at :83 (read with $(<"$snapshot_path") — no external exec — then strip in bash).
  •  Use return-slot variants of find_test_function_name and normalize_test_function_name/normalize_variable_name (add slots if they don't exist yet; coordinate with the assert hot-path issue which adds some of the same slots).
  •  In resolve_file (src/assert_snapshot.sh:55), replace dirname/basename with parameter expansion (${path%/*}, ${path##*/}) and convert the function itself to a return slot. Watch the edge case BASH_SOURCE without a slash.
  • ignore_colors variant: reuse bashunit::str::strip_ansi (src/str.sh:4) instead of a bespoke sed, so plain input takes its pure-bash fast path. Verify the sed patterns match ([mK] suffixes) before swapping; if they differ, align deliberately and cover with a test.
Tests first (TDD)
tests/unit/snapshot_test.sh (or nearest existing snapshot tests — grep first) is the spec. Add cases: content containing \r, snapshot file with \r\n line endings, custom file hint vs derived path, ANSI-colored input for the ignore-colors variant. Snapshot files on disk must remain byte-compatible with ones created by the current version.
Constraints
  • Bash 3.0+ only.
  • Existing .snapshot files must keep matching (no format/normalization change).
Acceptance criteria
  • ./bashunit tests/ and ./bashunit --parallel tests/ pass after every commit.
  • make sa, make lint pass; shfmt -w . produces no diff.
Line references valid at commit 1ae3e82.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or request
Type
No type
Projects
bashunit
Status
Done
Milestone
No milestone
Relationships
None yet
Development
No branches or pull requests
Issue actions

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
perf(snapshot): remove success-path forks from assert_match_snapshot · Issue #775 · TypedDevs/bashunit · GitHub
Skip to content
perf(snapshot): remove success-path forks from assert_match_snapshot #775
Closed
Closed
perf(snapshot): remove success-path forks from assert_match_snapshot#775
Assignees
Chemaclass
Labels
enhancementNew feature or request
Description
@Chemaclass
Chemaclass
opened on Jul 12, 2026
Part of #761.
Problem
assert_match_snapshot forks ~6-8 times even when the snapshot matches (the common case):
  • src/assert_snapshot.sh:5 — $(echo -n "$1" | tr -d '\r'): 2 forks to strip carriage returns.
  • src/assert_snapshot.sh:7 — $(bashunit::helper::find_test_function_name): capture fork around a pure-bash helper.
  • src/assert_snapshot.sh:8 — $(bashunit::snapshot::resolve_file ...), which internally (src/assert_snapshot.sh:62-64) forks dirname once, basename once, and normalize_variable_name twice.
  • src/assert_snapshot.sh:83 — snapshot=$(tr -d '\r' <"$snapshot_path"): subshell + external tr per compare.
assert_match_snapshot_ignore_colors (src/assert_snapshot.sh:19) adds a sed on top.
Task — checklist, one commit each
  •  Replace \r stripping with pure-bash ${var//$'\r'/} at src/assert_snapshot.sh:5 and for the file content at :83 (read with $(<"$snapshot_path") — no external exec — then strip in bash).
  •  Use return-slot variants of find_test_function_name and normalize_test_function_name/normalize_variable_name (add slots if they don't exist yet; coordinate with the assert hot-path issue which adds some of the same slots).
  •  In resolve_file (src/assert_snapshot.sh:55), replace dirname/basename with parameter expansion (${path%/*}, ${path##*/}) and convert the function itself to a return slot. Watch the edge case BASH_SOURCE without a slash.
  • ignore_colors variant: reuse bashunit::str::strip_ansi (src/str.sh:4) instead of a bespoke sed, so plain input takes its pure-bash fast path. Verify the sed patterns match ([mK] suffixes) before swapping; if they differ, align deliberately and cover with a test.
Tests first (TDD)
tests/unit/snapshot_test.sh (or nearest existing snapshot tests — grep first) is the spec. Add cases: content containing \r, snapshot file with \r\n line endings, custom file hint vs derived path, ANSI-colored input for the ignore-colors variant. Snapshot files on disk must remain byte-compatible with ones created by the current version.
Constraints
  • Bash 3.0+ only.
  • Existing .snapshot files must keep matching (no format/normalization change).
Acceptance criteria
  • ./bashunit tests/ and ./bashunit --parallel tests/ pass after every commit.
  • make sa, make lint pass; shfmt -w . produces no diff.
Line references valid at commit 1ae3e82.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or request
Type
No type
Projects
bashunit
Status
Done
Milestone
No milestone
Relationships
None yet
Development
No branches or pull requests
Issue actions

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
perf(snapshot): remove success-path forks from assert_match_snapshot · Issue #775 · TypedDevs/bashunit · GitHub
Skip to content
perf(snapshot): remove success-path forks from assert_match_snapshot #775
Closed
Closed
perf(snapshot): remove success-path forks from assert_match_snapshot#775
Assignees
Chemaclass
Labels
enhancementNew feature or request
Description
@Chemaclass
Chemaclass
opened on Jul 12, 2026
Part of #761.
Problem
assert_match_snapshot forks ~6-8 times even when the snapshot matches (the common case):
  • src/assert_snapshot.sh:5 — $(echo -n "$1" | tr -d '\r'): 2 forks to strip carriage returns.
  • src/assert_snapshot.sh:7 — $(bashunit::helper::find_test_function_name): capture fork around a pure-bash helper.
  • src/assert_snapshot.sh:8 — $(bashunit::snapshot::resolve_file ...), which internally (src/assert_snapshot.sh:62-64) forks dirname once, basename once, and normalize_variable_name twice.
  • src/assert_snapshot.sh:83 — snapshot=$(tr -d '\r' <"$snapshot_path"): subshell + external tr per compare.
assert_match_snapshot_ignore_colors (src/assert_snapshot.sh:19) adds a sed on top.
Task — checklist, one commit each
  •  Replace \r stripping with pure-bash ${var//$'\r'/} at src/assert_snapshot.sh:5 and for the file content at :83 (read with $(<"$snapshot_path") — no external exec — then strip in bash).
  •  Use return-slot variants of find_test_function_name and normalize_test_function_name/normalize_variable_name (add slots if they don't exist yet; coordinate with the assert hot-path issue which adds some of the same slots).
  •  In resolve_file (src/assert_snapshot.sh:55), replace dirname/basename with parameter expansion (${path%/*}, ${path##*/}) and convert the function itself to a return slot. Watch the edge case BASH_SOURCE without a slash.
  • ignore_colors variant: reuse bashunit::str::strip_ansi (src/str.sh:4) instead of a bespoke sed, so plain input takes its pure-bash fast path. Verify the sed patterns match ([mK] suffixes) before swapping; if they differ, align deliberately and cover with a test.
Tests first (TDD)
tests/unit/snapshot_test.sh (or nearest existing snapshot tests — grep first) is the spec. Add cases: content containing \r, snapshot file with \r\n line endings, custom file hint vs derived path, ANSI-colored input for the ignore-colors variant. Snapshot files on disk must remain byte-compatible with ones created by the current version.
Constraints
  • Bash 3.0+ only.
  • Existing .snapshot files must keep matching (no format/normalization change).
Acceptance criteria
  • ./bashunit tests/ and ./bashunit --parallel tests/ pass after every commit.
  • make sa, make lint pass; shfmt -w . produces no diff.
Line references valid at commit 1ae3e82.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or request
Type
No type
Projects
bashunit
Status
Done
Milestone
No milestone
Relationships
None yet
Development
No branches or pull requests
Issue actions

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
perf(snapshot): remove success-path forks from assert_match_snapshot · Issue #775 · TypedDevs/bashunit · GitHub
Skip to content
perf(snapshot): remove success-path forks from assert_match_snapshot #775
Closed
Closed
perf(snapshot): remove success-path forks from assert_match_snapshot#775
Assignees
Chemaclass
Labels
enhancementNew feature or request
Description
@Chemaclass
Chemaclass
opened on Jul 12, 2026
Part of #761.
Problem
assert_match_snapshot forks ~6-8 times even when the snapshot matches (the common case):
  • src/assert_snapshot.sh:5 — $(echo -n "$1" | tr -d '\r'): 2 forks to strip carriage returns.
  • src/assert_snapshot.sh:7 — $(bashunit::helper::find_test_function_name): capture fork around a pure-bash helper.
  • src/assert_snapshot.sh:8 — $(bashunit::snapshot::resolve_file ...), which internally (src/assert_snapshot.sh:62-64) forks dirname once, basename once, and normalize_variable_name twice.
  • src/assert_snapshot.sh:83 — snapshot=$(tr -d '\r' <"$snapshot_path"): subshell + external tr per compare.
assert_match_snapshot_ignore_colors (src/assert_snapshot.sh:19) adds a sed on top.
Task — checklist, one commit each
  •  Replace \r stripping with pure-bash ${var//$'\r'/} at src/assert_snapshot.sh:5 and for the file content at :83 (read with $(<"$snapshot_path") — no external exec — then strip in bash).
  •  Use return-slot variants of find_test_function_name and normalize_test_function_name/normalize_variable_name (add slots if they don't exist yet; coordinate with the assert hot-path issue which adds some of the same slots).
  •  In resolve_file (src/assert_snapshot.sh:55), replace dirname/basename with parameter expansion (${path%/*}, ${path##*/}) and convert the function itself to a return slot. Watch the edge case BASH_SOURCE without a slash.
  • ignore_colors variant: reuse bashunit::str::strip_ansi (src/str.sh:4) instead of a bespoke sed, so plain input takes its pure-bash fast path. Verify the sed patterns match ([mK] suffixes) before swapping; if they differ, align deliberately and cover with a test.
Tests first (TDD)
tests/unit/snapshot_test.sh (or nearest existing snapshot tests — grep first) is the spec. Add cases: content containing \r, snapshot file with \r\n line endings, custom file hint vs derived path, ANSI-colored input for the ignore-colors variant. Snapshot files on disk must remain byte-compatible with ones created by the current version.
Constraints
  • Bash 3.0+ only.
  • Existing .snapshot files must keep matching (no format/normalization change).
Acceptance criteria
  • ./bashunit tests/ and ./bashunit --parallel tests/ pass after every commit.
  • make sa, make lint pass; shfmt -w . produces no diff.
Line references valid at commit 1ae3e82.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or request
Type
No type
Projects
bashunit
Status
Done
Milestone
No milestone
Relationships
None yet
Development
No branches or pull requests
Issue actions