Skip to content

perf(runner): test functions accumulate across files, making multi-file runs quadratic — unset after each file (unit suite 64s → 22s) #829

Description

@Chemaclass

Problem

Sequential multi-file runs slow down quadratically with the number of test files. The framework sources every test file into the main shell and never unsets the test functions, so the shell grows as the run progresses — and since every test executes in a $() subshell, every fork copies an ever-fatter process. The cost is fork overhead (sys time), invisible to any per-file profile.

Measured on bashunit's own unit suite (63 files, 1072 tests, macOS, Bash 3.2):

Files runWallMarginal cost/file
first 103.0s0.30s
first 3013.9s0.55s
first 4526.3s0.82s
all 63~64s~2s

Smoking gun: the last 18 files take 8.7s standalone but ~38s as the tail of the full run — a 4.4x penalty purely from accumulated shell state. Sys time explodes correspondingly (10 files: 1.3s → 45 files: 8.6s).

Fix (prototype validated)

Unset the file's test functions after the file has been processed, next to the existing hook cleanup (bashunit::runner::clean_set_up_and_tear_down_after_script, which already unsets set_up/tear_down/set_up_before_script/tear_down_after_script — src/runner.sh:2069).

Prototype diff (sequential + parallel path, after run_tear_down_after_script in bashunit::runner::load_test_files, ~src/runner.sh:494):

local _fn
for_fnin$_cached_fns;dounset -f "$_fn"2>/dev/null ||truedone

_cached_fns is the output of runner::functions_for_script (the file's test functions). unset -f is a builtin — zero forks, Bash 3.0-safe.

Prototype results (identical pass/skip/snapshot counts before/after: 1065/5/2, assertions 1447/5/2):

SuiteBeforeAfter
./bashunit tests/unit/~64s21.7s
./bashunit --parallel tests/unit/~26s6.8s

CPU time dropped from ~61s to ~19.5s (sequential). Parallel benefits too: workers fork from the main shell, so they inherit the same bloat today.

Why it's safe

  • Unset happens aftercall_test_functions returns (sequential) or after the & worker has forked (parallel — the subshell got its copy at fork time), and after run_tear_down_after_script.
  • Data-provider functions and file-local helper functions are not in functions_for_script output and stay defined (same as today).
  • Cross-file behavior today: a later file's same-named test function silently overwrites the earlier one (per-file duplicate check only) — unsetting produces the same observable results.
  • Header count (find_total_tests) sources files in its own subshell, unaffected.

Implementation notes

  • TDD: RED test first — e.g. a runner test asserting a test function from file A is no longer defined when file B is being processed (or a timing-free proxy: after load_test_files over two fixture files, declare -F no longer lists file A's tests). Study tests/unit/runner_test.sh patterns.
  • Word-splitting the newline-separated $_cached_fns with default IFS is intended; function names contain no glob chars, but keep the loop consistent with existing style in load_test_files.
  • Watch the fork-budget acceptance tests (tests/acceptance/bashunit_coldstart_forks_test.sh, bashunit_run_forks_test.sh) — unset -f adds no forks, so they must stay green as-is.
  • Check interactions: --rerun-failed, --retry, --random-order, --shard, providers, --parallel (aggregation), --stop-on-failure.
  • CHANGELOG entry under ## Unreleased### Changed (perf, no behavior change).

Constraints

  • Bash 3.0+ (.claude/rules/bash-style.md); unset -f qualifies
  • Console output byte-identical (snapshot/acceptance suites green)
  • make sa, make lint clean

Acceptance criteria

  • Sequential unit suite counts identical to baseline (1065 passed / 5 skipped / 2 snapshot at time of writing)
  • ./bashunit tests/unit/ wall time drops to ~1/3 of baseline (~64s → ~22s on the reference machine)
  • ./bashunit --parallel tests/unit/ similarly improved (~26s → ~7s)
  • Full suite green: ./bashunit tests/, ./bashunit --parallel tests/, ./bashunit --parallel --simple --strict tests/
  • Fork-budget acceptance tests unchanged and green
  • make sa, make lint pass
  • CHANGELOG.md updated

Verification commands

time ./bashunit tests/unit/
time ./bashunit --parallel tests/unit/
./bashunit tests/ && ./bashunit --parallel tests/ && ./bashunit --parallel --simple --strict tests/
make sa && make lint

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

  • Status
    Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
perf(runner): test functions accumulate across files, making multi-file runs quadratic — unset after each file (unit suite 64s → 22s) · Issue #829 · TypedDevs/bashunit · GitHub
Skip to content

perf(runner): test functions accumulate across files, making multi-file runs quadratic — unset after each file (unit suite 64s → 22s) #829

Description

@Chemaclass

Problem

Sequential multi-file runs slow down quadratically with the number of test files. The framework sources every test file into the main shell and never unsets the test functions, so the shell grows as the run progresses — and since every test executes in a $() subshell, every fork copies an ever-fatter process. The cost is fork overhead (sys time), invisible to any per-file profile.

Measured on bashunit's own unit suite (63 files, 1072 tests, macOS, Bash 3.2):

Files runWallMarginal cost/file
first 103.0s0.30s
first 3013.9s0.55s
first 4526.3s0.82s
all 63~64s~2s

Smoking gun: the last 18 files take 8.7s standalone but ~38s as the tail of the full run — a 4.4x penalty purely from accumulated shell state. Sys time explodes correspondingly (10 files: 1.3s → 45 files: 8.6s).

Fix (prototype validated)

Unset the file's test functions after the file has been processed, next to the existing hook cleanup (bashunit::runner::clean_set_up_and_tear_down_after_script, which already unsets set_up/tear_down/set_up_before_script/tear_down_after_script — src/runner.sh:2069).

Prototype diff (sequential + parallel path, after run_tear_down_after_script in bashunit::runner::load_test_files, ~src/runner.sh:494):

local _fn
for_fnin$_cached_fns;dounset -f "$_fn"2>/dev/null ||truedone

_cached_fns is the output of runner::functions_for_script (the file's test functions). unset -f is a builtin — zero forks, Bash 3.0-safe.

Prototype results (identical pass/skip/snapshot counts before/after: 1065/5/2, assertions 1447/5/2):

SuiteBeforeAfter
./bashunit tests/unit/~64s21.7s
./bashunit --parallel tests/unit/~26s6.8s

CPU time dropped from ~61s to ~19.5s (sequential). Parallel benefits too: workers fork from the main shell, so they inherit the same bloat today.

Why it's safe

  • Unset happens aftercall_test_functions returns (sequential) or after the & worker has forked (parallel — the subshell got its copy at fork time), and after run_tear_down_after_script.
  • Data-provider functions and file-local helper functions are not in functions_for_script output and stay defined (same as today).
  • Cross-file behavior today: a later file's same-named test function silently overwrites the earlier one (per-file duplicate check only) — unsetting produces the same observable results.
  • Header count (find_total_tests) sources files in its own subshell, unaffected.

Implementation notes

  • TDD: RED test first — e.g. a runner test asserting a test function from file A is no longer defined when file B is being processed (or a timing-free proxy: after load_test_files over two fixture files, declare -F no longer lists file A's tests). Study tests/unit/runner_test.sh patterns.
  • Word-splitting the newline-separated $_cached_fns with default IFS is intended; function names contain no glob chars, but keep the loop consistent with existing style in load_test_files.
  • Watch the fork-budget acceptance tests (tests/acceptance/bashunit_coldstart_forks_test.sh, bashunit_run_forks_test.sh) — unset -f adds no forks, so they must stay green as-is.
  • Check interactions: --rerun-failed, --retry, --random-order, --shard, providers, --parallel (aggregation), --stop-on-failure.
  • CHANGELOG entry under ## Unreleased### Changed (perf, no behavior change).

Constraints

  • Bash 3.0+ (.claude/rules/bash-style.md); unset -f qualifies
  • Console output byte-identical (snapshot/acceptance suites green)
  • make sa, make lint clean

Acceptance criteria

  • Sequential unit suite counts identical to baseline (1065 passed / 5 skipped / 2 snapshot at time of writing)
  • ./bashunit tests/unit/ wall time drops to ~1/3 of baseline (~64s → ~22s on the reference machine)
  • ./bashunit --parallel tests/unit/ similarly improved (~26s → ~7s)
  • Full suite green: ./bashunit tests/, ./bashunit --parallel tests/, ./bashunit --parallel --simple --strict tests/
  • Fork-budget acceptance tests unchanged and green
  • make sa, make lint pass
  • CHANGELOG.md updated

Verification commands

time ./bashunit tests/unit/
time ./bashunit --parallel tests/unit/
./bashunit tests/ && ./bashunit --parallel tests/ && ./bashunit --parallel --simple --strict tests/
make sa && make lint

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

  • Status
    Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' perf(runner): test functions accumulate across files, making multi-file runs quadratic — unset after each file (unit suite 64s → 22s) · Issue #829 · TypedDevs/bashunit · GitHub
Skip to content

perf(runner): test functions accumulate across files, making multi-file runs quadratic — unset after each file (unit suite 64s → 22s) #829

Description

@Chemaclass

Problem

Sequential multi-file runs slow down quadratically with the number of test files. The framework sources every test file into the main shell and never unsets the test functions, so the shell grows as the run progresses — and since every test executes in a $() subshell, every fork copies an ever-fatter process. The cost is fork overhead (sys time), invisible to any per-file profile.

Measured on bashunit's own unit suite (63 files, 1072 tests, macOS, Bash 3.2):

Files runWallMarginal cost/file
first 103.0s0.30s
first 3013.9s0.55s
first 4526.3s0.82s
all 63~64s~2s

Smoking gun: the last 18 files take 8.7s standalone but ~38s as the tail of the full run — a 4.4x penalty purely from accumulated shell state. Sys time explodes correspondingly (10 files: 1.3s → 45 files: 8.6s).

Fix (prototype validated)

Unset the file's test functions after the file has been processed, next to the existing hook cleanup (bashunit::runner::clean_set_up_and_tear_down_after_script, which already unsets set_up/tear_down/set_up_before_script/tear_down_after_script — src/runner.sh:2069).

Prototype diff (sequential + parallel path, after run_tear_down_after_script in bashunit::runner::load_test_files, ~src/runner.sh:494):

local _fn
for_fnin$_cached_fns;dounset -f "$_fn"2>/dev/null ||truedone

_cached_fns is the output of runner::functions_for_script (the file's test functions). unset -f is a builtin — zero forks, Bash 3.0-safe.

Prototype results (identical pass/skip/snapshot counts before/after: 1065/5/2, assertions 1447/5/2):

SuiteBeforeAfter
./bashunit tests/unit/~64s21.7s
./bashunit --parallel tests/unit/~26s6.8s

CPU time dropped from ~61s to ~19.5s (sequential). Parallel benefits too: workers fork from the main shell, so they inherit the same bloat today.

Why it's safe

  • Unset happens aftercall_test_functions returns (sequential) or after the & worker has forked (parallel — the subshell got its copy at fork time), and after run_tear_down_after_script.
  • Data-provider functions and file-local helper functions are not in functions_for_script output and stay defined (same as today).
  • Cross-file behavior today: a later file's same-named test function silently overwrites the earlier one (per-file duplicate check only) — unsetting produces the same observable results.
  • Header count (find_total_tests) sources files in its own subshell, unaffected.

Implementation notes

  • TDD: RED test first — e.g. a runner test asserting a test function from file A is no longer defined when file B is being processed (or a timing-free proxy: after load_test_files over two fixture files, declare -F no longer lists file A's tests). Study tests/unit/runner_test.sh patterns.
  • Word-splitting the newline-separated $_cached_fns with default IFS is intended; function names contain no glob chars, but keep the loop consistent with existing style in load_test_files.
  • Watch the fork-budget acceptance tests (tests/acceptance/bashunit_coldstart_forks_test.sh, bashunit_run_forks_test.sh) — unset -f adds no forks, so they must stay green as-is.
  • Check interactions: --rerun-failed, --retry, --random-order, --shard, providers, --parallel (aggregation), --stop-on-failure.
  • CHANGELOG entry under ## Unreleased### Changed (perf, no behavior change).

Constraints

  • Bash 3.0+ (.claude/rules/bash-style.md); unset -f qualifies
  • Console output byte-identical (snapshot/acceptance suites green)
  • make sa, make lint clean

Acceptance criteria

  • Sequential unit suite counts identical to baseline (1065 passed / 5 skipped / 2 snapshot at time of writing)
  • ./bashunit tests/unit/ wall time drops to ~1/3 of baseline (~64s → ~22s on the reference machine)
  • ./bashunit --parallel tests/unit/ similarly improved (~26s → ~7s)
  • Full suite green: ./bashunit tests/, ./bashunit --parallel tests/, ./bashunit --parallel --simple --strict tests/
  • Fork-budget acceptance tests unchanged and green
  • make sa, make lint pass
  • CHANGELOG.md updated

Verification commands

time ./bashunit tests/unit/
time ./bashunit --parallel tests/unit/
./bashunit tests/ && ./bashunit --parallel tests/ && ./bashunit --parallel --simple --strict tests/
make sa && make lint

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

  • Status
    Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' perf(runner): test functions accumulate across files, making multi-file runs quadratic — unset after each file (unit suite 64s → 22s) · Issue #829 · TypedDevs/bashunit · GitHub
Skip to content

perf(runner): test functions accumulate across files, making multi-file runs quadratic — unset after each file (unit suite 64s → 22s) #829

Description

@Chemaclass

Problem

Sequential multi-file runs slow down quadratically with the number of test files. The framework sources every test file into the main shell and never unsets the test functions, so the shell grows as the run progresses — and since every test executes in a $() subshell, every fork copies an ever-fatter process. The cost is fork overhead (sys time), invisible to any per-file profile.

Measured on bashunit's own unit suite (63 files, 1072 tests, macOS, Bash 3.2):

Files runWallMarginal cost/file
first 103.0s0.30s
first 3013.9s0.55s
first 4526.3s0.82s
all 63~64s~2s

Smoking gun: the last 18 files take 8.7s standalone but ~38s as the tail of the full run — a 4.4x penalty purely from accumulated shell state. Sys time explodes correspondingly (10 files: 1.3s → 45 files: 8.6s).

Fix (prototype validated)

Unset the file's test functions after the file has been processed, next to the existing hook cleanup (bashunit::runner::clean_set_up_and_tear_down_after_script, which already unsets set_up/tear_down/set_up_before_script/tear_down_after_script — src/runner.sh:2069).

Prototype diff (sequential + parallel path, after run_tear_down_after_script in bashunit::runner::load_test_files, ~src/runner.sh:494):

local _fn
for_fnin$_cached_fns;dounset -f "$_fn"2>/dev/null ||truedone

_cached_fns is the output of runner::functions_for_script (the file's test functions). unset -f is a builtin — zero forks, Bash 3.0-safe.

Prototype results (identical pass/skip/snapshot counts before/after: 1065/5/2, assertions 1447/5/2):

SuiteBeforeAfter
./bashunit tests/unit/~64s21.7s
./bashunit --parallel tests/unit/~26s6.8s

CPU time dropped from ~61s to ~19.5s (sequential). Parallel benefits too: workers fork from the main shell, so they inherit the same bloat today.

Why it's safe

  • Unset happens aftercall_test_functions returns (sequential) or after the & worker has forked (parallel — the subshell got its copy at fork time), and after run_tear_down_after_script.
  • Data-provider functions and file-local helper functions are not in functions_for_script output and stay defined (same as today).
  • Cross-file behavior today: a later file's same-named test function silently overwrites the earlier one (per-file duplicate check only) — unsetting produces the same observable results.
  • Header count (find_total_tests) sources files in its own subshell, unaffected.

Implementation notes

  • TDD: RED test first — e.g. a runner test asserting a test function from file A is no longer defined when file B is being processed (or a timing-free proxy: after load_test_files over two fixture files, declare -F no longer lists file A's tests). Study tests/unit/runner_test.sh patterns.
  • Word-splitting the newline-separated $_cached_fns with default IFS is intended; function names contain no glob chars, but keep the loop consistent with existing style in load_test_files.
  • Watch the fork-budget acceptance tests (tests/acceptance/bashunit_coldstart_forks_test.sh, bashunit_run_forks_test.sh) — unset -f adds no forks, so they must stay green as-is.
  • Check interactions: --rerun-failed, --retry, --random-order, --shard, providers, --parallel (aggregation), --stop-on-failure.
  • CHANGELOG entry under ## Unreleased### Changed (perf, no behavior change).

Constraints

  • Bash 3.0+ (.claude/rules/bash-style.md); unset -f qualifies
  • Console output byte-identical (snapshot/acceptance suites green)
  • make sa, make lint clean

Acceptance criteria

  • Sequential unit suite counts identical to baseline (1065 passed / 5 skipped / 2 snapshot at time of writing)
  • ./bashunit tests/unit/ wall time drops to ~1/3 of baseline (~64s → ~22s on the reference machine)
  • ./bashunit --parallel tests/unit/ similarly improved (~26s → ~7s)
  • Full suite green: ./bashunit tests/, ./bashunit --parallel tests/, ./bashunit --parallel --simple --strict tests/
  • Fork-budget acceptance tests unchanged and green
  • make sa, make lint pass
  • CHANGELOG.md updated

Verification commands

time ./bashunit tests/unit/
time ./bashunit --parallel tests/unit/
./bashunit tests/ && ./bashunit --parallel tests/ && ./bashunit --parallel --simple --strict tests/
make sa && make lint

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

  • Status
    Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' perf(runner): test functions accumulate across files, making multi-file runs quadratic — unset after each file (unit suite 64s → 22s) · Issue #829 · TypedDevs/bashunit · GitHub
Skip to content

perf(runner): test functions accumulate across files, making multi-file runs quadratic — unset after each file (unit suite 64s → 22s) #829

Description

@Chemaclass

Problem

Sequential multi-file runs slow down quadratically with the number of test files. The framework sources every test file into the main shell and never unsets the test functions, so the shell grows as the run progresses — and since every test executes in a $() subshell, every fork copies an ever-fatter process. The cost is fork overhead (sys time), invisible to any per-file profile.

Measured on bashunit's own unit suite (63 files, 1072 tests, macOS, Bash 3.2):

Files runWallMarginal cost/file
first 103.0s0.30s
first 3013.9s0.55s
first 4526.3s0.82s
all 63~64s~2s

Smoking gun: the last 18 files take 8.7s standalone but ~38s as the tail of the full run — a 4.4x penalty purely from accumulated shell state. Sys time explodes correspondingly (10 files: 1.3s → 45 files: 8.6s).

Fix (prototype validated)

Unset the file's test functions after the file has been processed, next to the existing hook cleanup (bashunit::runner::clean_set_up_and_tear_down_after_script, which already unsets set_up/tear_down/set_up_before_script/tear_down_after_script — src/runner.sh:2069).

Prototype diff (sequential + parallel path, after run_tear_down_after_script in bashunit::runner::load_test_files, ~src/runner.sh:494):

local _fn
for_fnin$_cached_fns;dounset -f "$_fn"2>/dev/null ||truedone

_cached_fns is the output of runner::functions_for_script (the file's test functions). unset -f is a builtin — zero forks, Bash 3.0-safe.

Prototype results (identical pass/skip/snapshot counts before/after: 1065/5/2, assertions 1447/5/2):

SuiteBeforeAfter
./bashunit tests/unit/~64s21.7s
./bashunit --parallel tests/unit/~26s6.8s

CPU time dropped from ~61s to ~19.5s (sequential). Parallel benefits too: workers fork from the main shell, so they inherit the same bloat today.

Why it's safe

  • Unset happens aftercall_test_functions returns (sequential) or after the & worker has forked (parallel — the subshell got its copy at fork time), and after run_tear_down_after_script.
  • Data-provider functions and file-local helper functions are not in functions_for_script output and stay defined (same as today).
  • Cross-file behavior today: a later file's same-named test function silently overwrites the earlier one (per-file duplicate check only) — unsetting produces the same observable results.
  • Header count (find_total_tests) sources files in its own subshell, unaffected.

Implementation notes

  • TDD: RED test first — e.g. a runner test asserting a test function from file A is no longer defined when file B is being processed (or a timing-free proxy: after load_test_files over two fixture files, declare -F no longer lists file A's tests). Study tests/unit/runner_test.sh patterns.
  • Word-splitting the newline-separated $_cached_fns with default IFS is intended; function names contain no glob chars, but keep the loop consistent with existing style in load_test_files.
  • Watch the fork-budget acceptance tests (tests/acceptance/bashunit_coldstart_forks_test.sh, bashunit_run_forks_test.sh) — unset -f adds no forks, so they must stay green as-is.
  • Check interactions: --rerun-failed, --retry, --random-order, --shard, providers, --parallel (aggregation), --stop-on-failure.
  • CHANGELOG entry under ## Unreleased### Changed (perf, no behavior change).

Constraints

  • Bash 3.0+ (.claude/rules/bash-style.md); unset -f qualifies
  • Console output byte-identical (snapshot/acceptance suites green)
  • make sa, make lint clean

Acceptance criteria

  • Sequential unit suite counts identical to baseline (1065 passed / 5 skipped / 2 snapshot at time of writing)
  • ./bashunit tests/unit/ wall time drops to ~1/3 of baseline (~64s → ~22s on the reference machine)
  • ./bashunit --parallel tests/unit/ similarly improved (~26s → ~7s)
  • Full suite green: ./bashunit tests/, ./bashunit --parallel tests/, ./bashunit --parallel --simple --strict tests/
  • Fork-budget acceptance tests unchanged and green
  • make sa, make lint pass
  • CHANGELOG.md updated

Verification commands

time ./bashunit tests/unit/
time ./bashunit --parallel tests/unit/
./bashunit tests/ && ./bashunit --parallel tests/ && ./bashunit --parallel --simple --strict tests/
make sa && make lint

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

  • Status
    Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' perf(runner): test functions accumulate across files, making multi-file runs quadratic — unset after each file (unit suite 64s → 22s) · Issue #829 · TypedDevs/bashunit · GitHub
Skip to content

perf(runner): test functions accumulate across files, making multi-file runs quadratic — unset after each file (unit suite 64s → 22s) #829

Description

@Chemaclass

Problem

Sequential multi-file runs slow down quadratically with the number of test files. The framework sources every test file into the main shell and never unsets the test functions, so the shell grows as the run progresses — and since every test executes in a $() subshell, every fork copies an ever-fatter process. The cost is fork overhead (sys time), invisible to any per-file profile.

Measured on bashunit's own unit suite (63 files, 1072 tests, macOS, Bash 3.2):

Files runWallMarginal cost/file
first 103.0s0.30s
first 3013.9s0.55s
first 4526.3s0.82s
all 63~64s~2s

Smoking gun: the last 18 files take 8.7s standalone but ~38s as the tail of the full run — a 4.4x penalty purely from accumulated shell state. Sys time explodes correspondingly (10 files: 1.3s → 45 files: 8.6s).

Fix (prototype validated)

Unset the file's test functions after the file has been processed, next to the existing hook cleanup (bashunit::runner::clean_set_up_and_tear_down_after_script, which already unsets set_up/tear_down/set_up_before_script/tear_down_after_script — src/runner.sh:2069).

Prototype diff (sequential + parallel path, after run_tear_down_after_script in bashunit::runner::load_test_files, ~src/runner.sh:494):

local _fn
for_fnin$_cached_fns;dounset -f "$_fn"2>/dev/null ||truedone

_cached_fns is the output of runner::functions_for_script (the file's test functions). unset -f is a builtin — zero forks, Bash 3.0-safe.

Prototype results (identical pass/skip/snapshot counts before/after: 1065/5/2, assertions 1447/5/2):

SuiteBeforeAfter
./bashunit tests/unit/~64s21.7s
./bashunit --parallel tests/unit/~26s6.8s

CPU time dropped from ~61s to ~19.5s (sequential). Parallel benefits too: workers fork from the main shell, so they inherit the same bloat today.

Why it's safe

  • Unset happens aftercall_test_functions returns (sequential) or after the & worker has forked (parallel — the subshell got its copy at fork time), and after run_tear_down_after_script.
  • Data-provider functions and file-local helper functions are not in functions_for_script output and stay defined (same as today).
  • Cross-file behavior today: a later file's same-named test function silently overwrites the earlier one (per-file duplicate check only) — unsetting produces the same observable results.
  • Header count (find_total_tests) sources files in its own subshell, unaffected.

Implementation notes

  • TDD: RED test first — e.g. a runner test asserting a test function from file A is no longer defined when file B is being processed (or a timing-free proxy: after load_test_files over two fixture files, declare -F no longer lists file A's tests). Study tests/unit/runner_test.sh patterns.
  • Word-splitting the newline-separated $_cached_fns with default IFS is intended; function names contain no glob chars, but keep the loop consistent with existing style in load_test_files.
  • Watch the fork-budget acceptance tests (tests/acceptance/bashunit_coldstart_forks_test.sh, bashunit_run_forks_test.sh) — unset -f adds no forks, so they must stay green as-is.
  • Check interactions: --rerun-failed, --retry, --random-order, --shard, providers, --parallel (aggregation), --stop-on-failure.
  • CHANGELOG entry under ## Unreleased### Changed (perf, no behavior change).

Constraints

  • Bash 3.0+ (.claude/rules/bash-style.md); unset -f qualifies
  • Console output byte-identical (snapshot/acceptance suites green)
  • make sa, make lint clean

Acceptance criteria

  • Sequential unit suite counts identical to baseline (1065 passed / 5 skipped / 2 snapshot at time of writing)
  • ./bashunit tests/unit/ wall time drops to ~1/3 of baseline (~64s → ~22s on the reference machine)
  • ./bashunit --parallel tests/unit/ similarly improved (~26s → ~7s)
  • Full suite green: ./bashunit tests/, ./bashunit --parallel tests/, ./bashunit --parallel --simple --strict tests/
  • Fork-budget acceptance tests unchanged and green
  • make sa, make lint pass
  • CHANGELOG.md updated

Verification commands

time ./bashunit tests/unit/
time ./bashunit --parallel tests/unit/
./bashunit tests/ && ./bashunit --parallel tests/ && ./bashunit --parallel --simple --strict tests/
make sa && make lint

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

  • Status
    Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' perf(runner): test functions accumulate across files, making multi-file runs quadratic — unset after each file (unit suite 64s → 22s) · Issue #829 · TypedDevs/bashunit · GitHub
Skip to content

perf(runner): test functions accumulate across files, making multi-file runs quadratic — unset after each file (unit suite 64s → 22s) #829

Description

@Chemaclass

Problem

Sequential multi-file runs slow down quadratically with the number of test files. The framework sources every test file into the main shell and never unsets the test functions, so the shell grows as the run progresses — and since every test executes in a $() subshell, every fork copies an ever-fatter process. The cost is fork overhead (sys time), invisible to any per-file profile.

Measured on bashunit's own unit suite (63 files, 1072 tests, macOS, Bash 3.2):

Files runWallMarginal cost/file
first 103.0s0.30s
first 3013.9s0.55s
first 4526.3s0.82s
all 63~64s~2s

Smoking gun: the last 18 files take 8.7s standalone but ~38s as the tail of the full run — a 4.4x penalty purely from accumulated shell state. Sys time explodes correspondingly (10 files: 1.3s → 45 files: 8.6s).

Fix (prototype validated)

Unset the file's test functions after the file has been processed, next to the existing hook cleanup (bashunit::runner::clean_set_up_and_tear_down_after_script, which already unsets set_up/tear_down/set_up_before_script/tear_down_after_script — src/runner.sh:2069).

Prototype diff (sequential + parallel path, after run_tear_down_after_script in bashunit::runner::load_test_files, ~src/runner.sh:494):

local _fn
for_fnin$_cached_fns;dounset -f "$_fn"2>/dev/null ||truedone

_cached_fns is the output of runner::functions_for_script (the file's test functions). unset -f is a builtin — zero forks, Bash 3.0-safe.

Prototype results (identical pass/skip/snapshot counts before/after: 1065/5/2, assertions 1447/5/2):

SuiteBeforeAfter
./bashunit tests/unit/~64s21.7s
./bashunit --parallel tests/unit/~26s6.8s

CPU time dropped from ~61s to ~19.5s (sequential). Parallel benefits too: workers fork from the main shell, so they inherit the same bloat today.

Why it's safe

  • Unset happens aftercall_test_functions returns (sequential) or after the & worker has forked (parallel — the subshell got its copy at fork time), and after run_tear_down_after_script.
  • Data-provider functions and file-local helper functions are not in functions_for_script output and stay defined (same as today).
  • Cross-file behavior today: a later file's same-named test function silently overwrites the earlier one (per-file duplicate check only) — unsetting produces the same observable results.
  • Header count (find_total_tests) sources files in its own subshell, unaffected.

Implementation notes

  • TDD: RED test first — e.g. a runner test asserting a test function from file A is no longer defined when file B is being processed (or a timing-free proxy: after load_test_files over two fixture files, declare -F no longer lists file A's tests). Study tests/unit/runner_test.sh patterns.
  • Word-splitting the newline-separated $_cached_fns with default IFS is intended; function names contain no glob chars, but keep the loop consistent with existing style in load_test_files.
  • Watch the fork-budget acceptance tests (tests/acceptance/bashunit_coldstart_forks_test.sh, bashunit_run_forks_test.sh) — unset -f adds no forks, so they must stay green as-is.
  • Check interactions: --rerun-failed, --retry, --random-order, --shard, providers, --parallel (aggregation), --stop-on-failure.
  • CHANGELOG entry under ## Unreleased### Changed (perf, no behavior change).

Constraints

  • Bash 3.0+ (.claude/rules/bash-style.md); unset -f qualifies
  • Console output byte-identical (snapshot/acceptance suites green)
  • make sa, make lint clean

Acceptance criteria

  • Sequential unit suite counts identical to baseline (1065 passed / 5 skipped / 2 snapshot at time of writing)
  • ./bashunit tests/unit/ wall time drops to ~1/3 of baseline (~64s → ~22s on the reference machine)
  • ./bashunit --parallel tests/unit/ similarly improved (~26s → ~7s)
  • Full suite green: ./bashunit tests/, ./bashunit --parallel tests/, ./bashunit --parallel --simple --strict tests/
  • Fork-budget acceptance tests unchanged and green
  • make sa, make lint pass
  • CHANGELOG.md updated

Verification commands

time ./bashunit tests/unit/
time ./bashunit --parallel tests/unit/
./bashunit tests/ && ./bashunit --parallel tests/ && ./bashunit --parallel --simple --strict tests/
make sa && make lint

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

  • Status
    Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); perf(runner): test functions accumulate across files, making multi-file runs quadratic — unset after each file (unit suite 64s → 22s) · Issue #829 · TypedDevs/bashunit · GitHub
Skip to content

perf(runner): test functions accumulate across files, making multi-file runs quadratic — unset after each file (unit suite 64s → 22s) #829

Description

@Chemaclass

Problem

Sequential multi-file runs slow down quadratically with the number of test files. The framework sources every test file into the main shell and never unsets the test functions, so the shell grows as the run progresses — and since every test executes in a $() subshell, every fork copies an ever-fatter process. The cost is fork overhead (sys time), invisible to any per-file profile.

Measured on bashunit's own unit suite (63 files, 1072 tests, macOS, Bash 3.2):

Files runWallMarginal cost/file
first 103.0s0.30s
first 3013.9s0.55s
first 4526.3s0.82s
all 63~64s~2s

Smoking gun: the last 18 files take 8.7s standalone but ~38s as the tail of the full run — a 4.4x penalty purely from accumulated shell state. Sys time explodes correspondingly (10 files: 1.3s → 45 files: 8.6s).

Fix (prototype validated)

Unset the file's test functions after the file has been processed, next to the existing hook cleanup (bashunit::runner::clean_set_up_and_tear_down_after_script, which already unsets set_up/tear_down/set_up_before_script/tear_down_after_script — src/runner.sh:2069).

Prototype diff (sequential + parallel path, after run_tear_down_after_script in bashunit::runner::load_test_files, ~src/runner.sh:494):

local _fn
for_fnin$_cached_fns;dounset -f "$_fn"2>/dev/null ||truedone

_cached_fns is the output of runner::functions_for_script (the file's test functions). unset -f is a builtin — zero forks, Bash 3.0-safe.

Prototype results (identical pass/skip/snapshot counts before/after: 1065/5/2, assertions 1447/5/2):

SuiteBeforeAfter
./bashunit tests/unit/~64s21.7s
./bashunit --parallel tests/unit/~26s6.8s

CPU time dropped from ~61s to ~19.5s (sequential). Parallel benefits too: workers fork from the main shell, so they inherit the same bloat today.

Why it's safe

  • Unset happens aftercall_test_functions returns (sequential) or after the & worker has forked (parallel — the subshell got its copy at fork time), and after run_tear_down_after_script.
  • Data-provider functions and file-local helper functions are not in functions_for_script output and stay defined (same as today).
  • Cross-file behavior today: a later file's same-named test function silently overwrites the earlier one (per-file duplicate check only) — unsetting produces the same observable results.
  • Header count (find_total_tests) sources files in its own subshell, unaffected.

Implementation notes

  • TDD: RED test first — e.g. a runner test asserting a test function from file A is no longer defined when file B is being processed (or a timing-free proxy: after load_test_files over two fixture files, declare -F no longer lists file A's tests). Study tests/unit/runner_test.sh patterns.
  • Word-splitting the newline-separated $_cached_fns with default IFS is intended; function names contain no glob chars, but keep the loop consistent with existing style in load_test_files.
  • Watch the fork-budget acceptance tests (tests/acceptance/bashunit_coldstart_forks_test.sh, bashunit_run_forks_test.sh) — unset -f adds no forks, so they must stay green as-is.
  • Check interactions: --rerun-failed, --retry, --random-order, --shard, providers, --parallel (aggregation), --stop-on-failure.
  • CHANGELOG entry under ## Unreleased### Changed (perf, no behavior change).

Constraints

  • Bash 3.0+ (.claude/rules/bash-style.md); unset -f qualifies
  • Console output byte-identical (snapshot/acceptance suites green)
  • make sa, make lint clean

Acceptance criteria

  • Sequential unit suite counts identical to baseline (1065 passed / 5 skipped / 2 snapshot at time of writing)
  • ./bashunit tests/unit/ wall time drops to ~1/3 of baseline (~64s → ~22s on the reference machine)
  • ./bashunit --parallel tests/unit/ similarly improved (~26s → ~7s)
  • Full suite green: ./bashunit tests/, ./bashunit --parallel tests/, ./bashunit --parallel --simple --strict tests/
  • Fork-budget acceptance tests unchanged and green
  • make sa, make lint pass
  • CHANGELOG.md updated

Verification commands

time ./bashunit tests/unit/
time ./bashunit --parallel tests/unit/
./bashunit tests/ && ./bashunit --parallel tests/ && ./bashunit --parallel --simple --strict tests/
make sa && make lint

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

  • Status
    Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions