Skip to content

feat(coverage): expand branch coverage beyond if/case (&&, ||, guards, loops) #855

Closed
Closed
feat(coverage): expand branch coverage beyond if/case (&&, ||, guards, loops)#855
Assignees
Chemaclass
Labels
enhancementNew feature or request

Description

@Chemaclass
Chemaclass
opened on Jul 24, 2026

🎯 Goal

Expand branch coverage beyond the current MVP (only if/elif/else chains and case patterns) to the other common Bash decision points, so branch-coverage numbers reflect real control flow.

📍 Where

  • bashunit::coverage::extract_branches and the _branch_* helpers — src/coverage.sh:877-990+. Scope is documented at src/coverage.sh:880 and adrs/adr-007-branch-coverage-mvp.md: if/elif/else + case only.
  • The _branch_* helpers deliberately mutate caller locals via dynamic scope (documented src/coverage.sh:818-821, :954) — extend within that established pattern, with inline justification.

💡 Targets to add (pick the high-value, low-ambiguity ones first)

  1. && / || short-circuit — cmd_a && cmd_b, cmd_a || cmd_b: each right-hand side is a branch that may or may not execute.
  2. Guard idiom — [ cond ] && action and [ cond ] || action (extremely common in this codebase); the action arm is a branch.
  3. Ternary-style — [ cond ] && x || y: two arms.
  4. Loop taken / not-taken — while/until/for bodies that may execute zero times; a zero-iteration loop is an uncovered branch.

Explicitly out of scope (note in ADR): [[ ]] (not used — Bash 3.0 floor), arithmetic ((.

🔧 Approach

  • Extend the single-pass tokenizer in extract_branches to recognise the new constructs and emit branch points with the same record shape the report already consumes (verify against src/coverage.sh:575,688 report readers).
  • Reuse the DEBUG-trap hit data — a branch arm is "covered" when its line appears in the covered-line set. No new runtime cost; this is a static extraction change plus report accounting.
  • Keep each construct additive and independently testable.

✅ Acceptance criteria

  • For a fixture exercising each construct, branch coverage reports the correct total branch count and covered/uncovered arms.
  • Existing if/case branch results are unchanged (pure superset).
  • No runtime (record_line) changes; extraction stays a static pass.

🧪 TDD / measurement

  • RED per construct: add a fixture + a tests/unit/coverage*_test.sh (or the branch-extraction test file) asserting extract_branches emits the expected branch points for &&, ||, guard, ternary, zero-iteration loop — one failing test per construct, implement one at a time.
  • Regression: an if/elif/else/case fixture must produce byte-identical branch output to main.
  • Gate: ./bashunit tests/, ./bashunit --parallel --simple --strict tests/, make sa, make lint.

⛓️ Constraints

  • Bash 3.0+ parsing of Bash 3.0 source — no [[, no ${var,,}.
  • The _branch_* dynamic-scope mutation pattern is intentional and documented; extend it, don't refactor it away, and keep the inline justification comments.
  • Update adrs/adr-007-branch-coverage-mvp.md (or supersede with adr-009+) to record the expanded scope and the accepted exclusions.

📈 Impact

More faithful branch/condition coverage — the guard idiom ([ ] && …) alone is pervasive in src/, so current branch numbers under-report real decisions.

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

bashunit
Status
Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
feat(coverage): expand branch coverage beyond if/case (&&, ||, guards, loops) · Issue #855 · TypedDevs/bashunit · GitHub
Skip to content
feat(coverage): expand branch coverage beyond if/case (&&, ||, guards, loops) #855
Closed
Closed
feat(coverage): expand branch coverage beyond if/case (&&, ||, guards, loops)#855
Assignees
Chemaclass
Labels
enhancementNew feature or request
Description
@Chemaclass
Chemaclass
opened on Jul 24, 2026
🎯 Goal
Expand branch coverage beyond the current MVP (only if/elif/else chains and case patterns) to the other common Bash decision points, so branch-coverage numbers reflect real control flow.
📍 Where
  • bashunit::coverage::extract_branches and the _branch_* helpers — src/coverage.sh:877-990+. Scope is documented at src/coverage.sh:880 and adrs/adr-007-branch-coverage-mvp.md: if/elif/else + case only.
  • The _branch_* helpers deliberately mutate caller locals via dynamic scope (documented src/coverage.sh:818-821, :954) — extend within that established pattern, with inline justification.
💡 Targets to add (pick the high-value, low-ambiguity ones first)
  1. && / || short-circuit — cmd_a && cmd_b, cmd_a || cmd_b: each right-hand side is a branch that may or may not execute.
  2. Guard idiom — [ cond ] && action and [ cond ] || action (extremely common in this codebase); the action arm is a branch.
  3. Ternary-style — [ cond ] && x || y: two arms.
  4. Loop taken / not-taken — while/until/for bodies that may execute zero times; a zero-iteration loop is an uncovered branch.
Explicitly out of scope (note in ADR): [[ ]] (not used — Bash 3.0 floor), arithmetic ((.
🔧 Approach
  • Extend the single-pass tokenizer in extract_branches to recognise the new constructs and emit branch points with the same record shape the report already consumes (verify against src/coverage.sh:575,688 report readers).
  • Reuse the DEBUG-trap hit data — a branch arm is "covered" when its line appears in the covered-line set. No new runtime cost; this is a static extraction change plus report accounting.
  • Keep each construct additive and independently testable.
✅ Acceptance criteria
  • For a fixture exercising each construct, branch coverage reports the correct total branch count and covered/uncovered arms.
  • Existing if/case branch results are unchanged (pure superset).
  • No runtime (record_line) changes; extraction stays a static pass.
🧪 TDD / measurement
  • RED per construct: add a fixture + a tests/unit/coverage*_test.sh (or the branch-extraction test file) asserting extract_branches emits the expected branch points for &&, ||, guard, ternary, zero-iteration loop — one failing test per construct, implement one at a time.
  • Regression: an if/elif/else/case fixture must produce byte-identical branch output to main.
  • Gate: ./bashunit tests/, ./bashunit --parallel --simple --strict tests/, make sa, make lint.
⛓️ Constraints
  • Bash 3.0+ parsing of Bash 3.0 source — no [[, no ${var,,}.
  • The _branch_* dynamic-scope mutation pattern is intentional and documented; extend it, don't refactor it away, and keep the inline justification comments.
  • Update adrs/adr-007-branch-coverage-mvp.md (or supersede with adr-009+) to record the expanded scope and the accepted exclusions.
📈 Impact
More faithful branch/condition coverage — the guard idiom ([ ] && …) alone is pervasive in src/, so current branch numbers under-report real decisions.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or request
Type
No type
Projects
bashunit
Status
Done
Milestone
No milestone
Relationships
None yet
Development
No branches or pull requests
Issue actions

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat(coverage): expand branch coverage beyond if/case (&&, ||, guards, loops) · Issue #855 · TypedDevs/bashunit · GitHub
Skip to content
feat(coverage): expand branch coverage beyond if/case (&&, ||, guards, loops) #855
Closed
Closed
feat(coverage): expand branch coverage beyond if/case (&&, ||, guards, loops)#855
Assignees
Chemaclass
Labels
enhancementNew feature or request
Description
@Chemaclass
Chemaclass
opened on Jul 24, 2026
🎯 Goal
Expand branch coverage beyond the current MVP (only if/elif/else chains and case patterns) to the other common Bash decision points, so branch-coverage numbers reflect real control flow.
📍 Where
  • bashunit::coverage::extract_branches and the _branch_* helpers — src/coverage.sh:877-990+. Scope is documented at src/coverage.sh:880 and adrs/adr-007-branch-coverage-mvp.md: if/elif/else + case only.
  • The _branch_* helpers deliberately mutate caller locals via dynamic scope (documented src/coverage.sh:818-821, :954) — extend within that established pattern, with inline justification.
💡 Targets to add (pick the high-value, low-ambiguity ones first)
  1. && / || short-circuit — cmd_a && cmd_b, cmd_a || cmd_b: each right-hand side is a branch that may or may not execute.
  2. Guard idiom — [ cond ] && action and [ cond ] || action (extremely common in this codebase); the action arm is a branch.
  3. Ternary-style — [ cond ] && x || y: two arms.
  4. Loop taken / not-taken — while/until/for bodies that may execute zero times; a zero-iteration loop is an uncovered branch.
Explicitly out of scope (note in ADR): [[ ]] (not used — Bash 3.0 floor), arithmetic ((.
🔧 Approach
  • Extend the single-pass tokenizer in extract_branches to recognise the new constructs and emit branch points with the same record shape the report already consumes (verify against src/coverage.sh:575,688 report readers).
  • Reuse the DEBUG-trap hit data — a branch arm is "covered" when its line appears in the covered-line set. No new runtime cost; this is a static extraction change plus report accounting.
  • Keep each construct additive and independently testable.
✅ Acceptance criteria
  • For a fixture exercising each construct, branch coverage reports the correct total branch count and covered/uncovered arms.
  • Existing if/case branch results are unchanged (pure superset).
  • No runtime (record_line) changes; extraction stays a static pass.
🧪 TDD / measurement
  • RED per construct: add a fixture + a tests/unit/coverage*_test.sh (or the branch-extraction test file) asserting extract_branches emits the expected branch points for &&, ||, guard, ternary, zero-iteration loop — one failing test per construct, implement one at a time.
  • Regression: an if/elif/else/case fixture must produce byte-identical branch output to main.
  • Gate: ./bashunit tests/, ./bashunit --parallel --simple --strict tests/, make sa, make lint.
⛓️ Constraints
  • Bash 3.0+ parsing of Bash 3.0 source — no [[, no ${var,,}.
  • The _branch_* dynamic-scope mutation pattern is intentional and documented; extend it, don't refactor it away, and keep the inline justification comments.
  • Update adrs/adr-007-branch-coverage-mvp.md (or supersede with adr-009+) to record the expanded scope and the accepted exclusions.
📈 Impact
More faithful branch/condition coverage — the guard idiom ([ ] && …) alone is pervasive in src/, so current branch numbers under-report real decisions.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or request
Type
No type
Projects
bashunit
Status
Done
Milestone
No milestone
Relationships
None yet
Development
No branches or pull requests
Issue actions

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat(coverage): expand branch coverage beyond if/case (&&, ||, guards, loops) · Issue #855 · TypedDevs/bashunit · GitHub
Skip to content
feat(coverage): expand branch coverage beyond if/case (&&, ||, guards, loops) #855
Closed
Closed
feat(coverage): expand branch coverage beyond if/case (&&, ||, guards, loops)#855
Assignees
Chemaclass
Labels
enhancementNew feature or request
Description
@Chemaclass
Chemaclass
opened on Jul 24, 2026
🎯 Goal
Expand branch coverage beyond the current MVP (only if/elif/else chains and case patterns) to the other common Bash decision points, so branch-coverage numbers reflect real control flow.
📍 Where
  • bashunit::coverage::extract_branches and the _branch_* helpers — src/coverage.sh:877-990+. Scope is documented at src/coverage.sh:880 and adrs/adr-007-branch-coverage-mvp.md: if/elif/else + case only.
  • The _branch_* helpers deliberately mutate caller locals via dynamic scope (documented src/coverage.sh:818-821, :954) — extend within that established pattern, with inline justification.
💡 Targets to add (pick the high-value, low-ambiguity ones first)
  1. && / || short-circuit — cmd_a && cmd_b, cmd_a || cmd_b: each right-hand side is a branch that may or may not execute.
  2. Guard idiom — [ cond ] && action and [ cond ] || action (extremely common in this codebase); the action arm is a branch.
  3. Ternary-style — [ cond ] && x || y: two arms.
  4. Loop taken / not-taken — while/until/for bodies that may execute zero times; a zero-iteration loop is an uncovered branch.
Explicitly out of scope (note in ADR): [[ ]] (not used — Bash 3.0 floor), arithmetic ((.
🔧 Approach
  • Extend the single-pass tokenizer in extract_branches to recognise the new constructs and emit branch points with the same record shape the report already consumes (verify against src/coverage.sh:575,688 report readers).
  • Reuse the DEBUG-trap hit data — a branch arm is "covered" when its line appears in the covered-line set. No new runtime cost; this is a static extraction change plus report accounting.
  • Keep each construct additive and independently testable.
✅ Acceptance criteria
  • For a fixture exercising each construct, branch coverage reports the correct total branch count and covered/uncovered arms.
  • Existing if/case branch results are unchanged (pure superset).
  • No runtime (record_line) changes; extraction stays a static pass.
🧪 TDD / measurement
  • RED per construct: add a fixture + a tests/unit/coverage*_test.sh (or the branch-extraction test file) asserting extract_branches emits the expected branch points for &&, ||, guard, ternary, zero-iteration loop — one failing test per construct, implement one at a time.
  • Regression: an if/elif/else/case fixture must produce byte-identical branch output to main.
  • Gate: ./bashunit tests/, ./bashunit --parallel --simple --strict tests/, make sa, make lint.
⛓️ Constraints
  • Bash 3.0+ parsing of Bash 3.0 source — no [[, no ${var,,}.
  • The _branch_* dynamic-scope mutation pattern is intentional and documented; extend it, don't refactor it away, and keep the inline justification comments.
  • Update adrs/adr-007-branch-coverage-mvp.md (or supersede with adr-009+) to record the expanded scope and the accepted exclusions.
📈 Impact
More faithful branch/condition coverage — the guard idiom ([ ] && …) alone is pervasive in src/, so current branch numbers under-report real decisions.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or request
Type
No type
Projects
bashunit
Status
Done
Milestone
No milestone
Relationships
None yet
Development
No branches or pull requests
Issue actions

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
feat(coverage): expand branch coverage beyond if/case (&&, ||, guards, loops) · Issue #855 · TypedDevs/bashunit · GitHub
Skip to content
feat(coverage): expand branch coverage beyond if/case (&&, ||, guards, loops) #855
Closed
Closed
feat(coverage): expand branch coverage beyond if/case (&&, ||, guards, loops)#855
Assignees
Chemaclass
Labels
enhancementNew feature or request
Description
@Chemaclass
Chemaclass
opened on Jul 24, 2026
🎯 Goal
Expand branch coverage beyond the current MVP (only if/elif/else chains and case patterns) to the other common Bash decision points, so branch-coverage numbers reflect real control flow.
📍 Where
  • bashunit::coverage::extract_branches and the _branch_* helpers — src/coverage.sh:877-990+. Scope is documented at src/coverage.sh:880 and adrs/adr-007-branch-coverage-mvp.md: if/elif/else + case only.
  • The _branch_* helpers deliberately mutate caller locals via dynamic scope (documented src/coverage.sh:818-821, :954) — extend within that established pattern, with inline justification.
💡 Targets to add (pick the high-value, low-ambiguity ones first)
  1. && / || short-circuit — cmd_a && cmd_b, cmd_a || cmd_b: each right-hand side is a branch that may or may not execute.
  2. Guard idiom — [ cond ] && action and [ cond ] || action (extremely common in this codebase); the action arm is a branch.
  3. Ternary-style — [ cond ] && x || y: two arms.
  4. Loop taken / not-taken — while/until/for bodies that may execute zero times; a zero-iteration loop is an uncovered branch.
Explicitly out of scope (note in ADR): [[ ]] (not used — Bash 3.0 floor), arithmetic ((.
🔧 Approach
  • Extend the single-pass tokenizer in extract_branches to recognise the new constructs and emit branch points with the same record shape the report already consumes (verify against src/coverage.sh:575,688 report readers).
  • Reuse the DEBUG-trap hit data — a branch arm is "covered" when its line appears in the covered-line set. No new runtime cost; this is a static extraction change plus report accounting.
  • Keep each construct additive and independently testable.
✅ Acceptance criteria
  • For a fixture exercising each construct, branch coverage reports the correct total branch count and covered/uncovered arms.
  • Existing if/case branch results are unchanged (pure superset).
  • No runtime (record_line) changes; extraction stays a static pass.
🧪 TDD / measurement
  • RED per construct: add a fixture + a tests/unit/coverage*_test.sh (or the branch-extraction test file) asserting extract_branches emits the expected branch points for &&, ||, guard, ternary, zero-iteration loop — one failing test per construct, implement one at a time.
  • Regression: an if/elif/else/case fixture must produce byte-identical branch output to main.
  • Gate: ./bashunit tests/, ./bashunit --parallel --simple --strict tests/, make sa, make lint.
⛓️ Constraints
  • Bash 3.0+ parsing of Bash 3.0 source — no [[, no ${var,,}.
  • The _branch_* dynamic-scope mutation pattern is intentional and documented; extend it, don't refactor it away, and keep the inline justification comments.
  • Update adrs/adr-007-branch-coverage-mvp.md (or supersede with adr-009+) to record the expanded scope and the accepted exclusions.
📈 Impact
More faithful branch/condition coverage — the guard idiom ([ ] && …) alone is pervasive in src/, so current branch numbers under-report real decisions.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or request
Type
No type
Projects
bashunit
Status
Done
Milestone
No milestone
Relationships
None yet
Development
No branches or pull requests
Issue actions

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat(coverage): expand branch coverage beyond if/case (&&, ||, guards, loops) · Issue #855 · TypedDevs/bashunit · GitHub
Skip to content
feat(coverage): expand branch coverage beyond if/case (&&, ||, guards, loops) #855
Closed
Closed
feat(coverage): expand branch coverage beyond if/case (&&, ||, guards, loops)#855
Assignees
Chemaclass
Labels
enhancementNew feature or request
Description
@Chemaclass
Chemaclass
opened on Jul 24, 2026
🎯 Goal
Expand branch coverage beyond the current MVP (only if/elif/else chains and case patterns) to the other common Bash decision points, so branch-coverage numbers reflect real control flow.
📍 Where
  • bashunit::coverage::extract_branches and the _branch_* helpers — src/coverage.sh:877-990+. Scope is documented at src/coverage.sh:880 and adrs/adr-007-branch-coverage-mvp.md: if/elif/else + case only.
  • The _branch_* helpers deliberately mutate caller locals via dynamic scope (documented src/coverage.sh:818-821, :954) — extend within that established pattern, with inline justification.
💡 Targets to add (pick the high-value, low-ambiguity ones first)
  1. && / || short-circuit — cmd_a && cmd_b, cmd_a || cmd_b: each right-hand side is a branch that may or may not execute.
  2. Guard idiom — [ cond ] && action and [ cond ] || action (extremely common in this codebase); the action arm is a branch.
  3. Ternary-style — [ cond ] && x || y: two arms.
  4. Loop taken / not-taken — while/until/for bodies that may execute zero times; a zero-iteration loop is an uncovered branch.
Explicitly out of scope (note in ADR): [[ ]] (not used — Bash 3.0 floor), arithmetic ((.
🔧 Approach
  • Extend the single-pass tokenizer in extract_branches to recognise the new constructs and emit branch points with the same record shape the report already consumes (verify against src/coverage.sh:575,688 report readers).
  • Reuse the DEBUG-trap hit data — a branch arm is "covered" when its line appears in the covered-line set. No new runtime cost; this is a static extraction change plus report accounting.
  • Keep each construct additive and independently testable.
✅ Acceptance criteria
  • For a fixture exercising each construct, branch coverage reports the correct total branch count and covered/uncovered arms.
  • Existing if/case branch results are unchanged (pure superset).
  • No runtime (record_line) changes; extraction stays a static pass.
🧪 TDD / measurement
  • RED per construct: add a fixture + a tests/unit/coverage*_test.sh (or the branch-extraction test file) asserting extract_branches emits the expected branch points for &&, ||, guard, ternary, zero-iteration loop — one failing test per construct, implement one at a time.
  • Regression: an if/elif/else/case fixture must produce byte-identical branch output to main.
  • Gate: ./bashunit tests/, ./bashunit --parallel --simple --strict tests/, make sa, make lint.
⛓️ Constraints
  • Bash 3.0+ parsing of Bash 3.0 source — no [[, no ${var,,}.
  • The _branch_* dynamic-scope mutation pattern is intentional and documented; extend it, don't refactor it away, and keep the inline justification comments.
  • Update adrs/adr-007-branch-coverage-mvp.md (or supersede with adr-009+) to record the expanded scope and the accepted exclusions.
📈 Impact
More faithful branch/condition coverage — the guard idiom ([ ] && …) alone is pervasive in src/, so current branch numbers under-report real decisions.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or request
Type
No type
Projects
bashunit
Status
Done
Milestone
No milestone
Relationships
None yet
Development
No branches or pull requests
Issue actions

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
feat(coverage): expand branch coverage beyond if/case (&&, ||, guards, loops) · Issue #855 · TypedDevs/bashunit · GitHub
Skip to content
feat(coverage): expand branch coverage beyond if/case (&&, ||, guards, loops) #855
Closed
Closed
feat(coverage): expand branch coverage beyond if/case (&&, ||, guards, loops)#855
Assignees
Chemaclass
Labels
enhancementNew feature or request
Description
@Chemaclass
Chemaclass
opened on Jul 24, 2026
🎯 Goal
Expand branch coverage beyond the current MVP (only if/elif/else chains and case patterns) to the other common Bash decision points, so branch-coverage numbers reflect real control flow.
📍 Where
  • bashunit::coverage::extract_branches and the _branch_* helpers — src/coverage.sh:877-990+. Scope is documented at src/coverage.sh:880 and adrs/adr-007-branch-coverage-mvp.md: if/elif/else + case only.
  • The _branch_* helpers deliberately mutate caller locals via dynamic scope (documented src/coverage.sh:818-821, :954) — extend within that established pattern, with inline justification.
💡 Targets to add (pick the high-value, low-ambiguity ones first)
  1. && / || short-circuit — cmd_a && cmd_b, cmd_a || cmd_b: each right-hand side is a branch that may or may not execute.
  2. Guard idiom — [ cond ] && action and [ cond ] || action (extremely common in this codebase); the action arm is a branch.
  3. Ternary-style — [ cond ] && x || y: two arms.
  4. Loop taken / not-taken — while/until/for bodies that may execute zero times; a zero-iteration loop is an uncovered branch.
Explicitly out of scope (note in ADR): [[ ]] (not used — Bash 3.0 floor), arithmetic ((.
🔧 Approach
  • Extend the single-pass tokenizer in extract_branches to recognise the new constructs and emit branch points with the same record shape the report already consumes (verify against src/coverage.sh:575,688 report readers).
  • Reuse the DEBUG-trap hit data — a branch arm is "covered" when its line appears in the covered-line set. No new runtime cost; this is a static extraction change plus report accounting.
  • Keep each construct additive and independently testable.
✅ Acceptance criteria
  • For a fixture exercising each construct, branch coverage reports the correct total branch count and covered/uncovered arms.
  • Existing if/case branch results are unchanged (pure superset).
  • No runtime (record_line) changes; extraction stays a static pass.
🧪 TDD / measurement
  • RED per construct: add a fixture + a tests/unit/coverage*_test.sh (or the branch-extraction test file) asserting extract_branches emits the expected branch points for &&, ||, guard, ternary, zero-iteration loop — one failing test per construct, implement one at a time.
  • Regression: an if/elif/else/case fixture must produce byte-identical branch output to main.
  • Gate: ./bashunit tests/, ./bashunit --parallel --simple --strict tests/, make sa, make lint.
⛓️ Constraints
  • Bash 3.0+ parsing of Bash 3.0 source — no [[, no ${var,,}.
  • The _branch_* dynamic-scope mutation pattern is intentional and documented; extend it, don't refactor it away, and keep the inline justification comments.
  • Update adrs/adr-007-branch-coverage-mvp.md (or supersede with adr-009+) to record the expanded scope and the accepted exclusions.
📈 Impact
More faithful branch/condition coverage — the guard idiom ([ ] && …) alone is pervasive in src/, so current branch numbers under-report real decisions.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or request
Type
No type
Projects
bashunit
Status
Done
Milestone
No milestone
Relationships
None yet
Development
No branches or pull requests
Issue actions