Skip to content

fix(runner): runtime-error detection is English-only, so it does nothing under a translated locale #998

Description

@Chemaclass

Summary

bashunit::runner::detect_runtime_error recognises a shell error by matching English phrases — command not found, unbound variable, permission denied, and about twenty more. bash translates those diagnostics, so under any locale with bash's message catalogue installed, none of them matches and a genuine runtime error is not classified at all.

LC_ALL=C /tmp/x.sh: line 1: foo: command not found → classified
LC_ALL=es_ES /tmp/x.sh: línea 1: foo: orden no encontrada → not classified

How it surfaced

While fixing #992 I added a regression guard asserting that a real shell error is still reported as an Error. It passed on every English job and failed on Ubuntu - Spanish Locale and Ubuntu - Japanese Locale, with the fixture exiting 0 — the error was never detected, so the test passed and the run was green.

I pinned that guard to LC_ALL=C, because it exists to test classification mechanics rather than localization. That is the right scope for it and the wrong place to leave the underlying gap unrecorded.

Impact

A user running under a translated locale gets no runtime-error classification. Their test still fails — the exit code and assertion counts are unaffected — but it is reported as a plain Failed with no indication that the cause was a shell error rather than a wrong value. That is precisely the distinction the Error channel exists to draw, and it is the one that saves debugging time.

The repo already runs Spanish, Brazilian and Japanese locale jobs, so this is a supported configuration, not a hypothetical.

Why phrase matching was chosen, and what it costs

Matching on message text is the reason this is locale-dependent. Two directions worth weighing:

  1. Force the C locale around the captured command. Setting LC_ALL=C for the test subshell would make diagnostics predictable, but it changes what the code under test sees — a test asserting on localized output would break. Almost certainly wrong.
  2. Stop relying on message text where possible. Exit codes carry some of this unambiguously (127 not found, 126 not executable, 128+N killed by signal N) and are locale-independent. That would not cover every phrase in the list, but it would cover the common ones without any translation dependency.
  3. Accept and document it. If the classifier stays English-only, say so, so nobody is surprised that the Error channel goes quiet on their machine.

My preference is 2 for the codes that carry the information, and 3 for the remainder.

Constraints

  • Bash 3.0+; case and parameter expansion only.
  • Per-test failure path — no new fork. See .claude/rules/perf-fork-budget.md.
  • The prefix rule added in fix(runner): a quoted shell-error phrase is no longer a runtime error #997 (: line N: , or its translated equivalent, on the same line as the phrase) is itself partly text-shaped — línea and still match its generic form, but any change here should keep that working.
  • Failure output is compared verbatim across the acceptance suite; regenerate snapshots deliberately and read the diff.

Acceptance criteria

  • A genuine command not found is classified as an Error under a translated locale, or the limitation is documented explicitly
  • Existing English classification does not regress — covered by the tests added in fix(runner): a quoted shell-error phrase is no longer a runtime error #997
  • The LC_ALL=C pin on test_a_real_shell_error_is_still_reported is revisited: kept deliberately, or removed if classification becomes locale-independent
  • make sa · make lint · ./bashunit --parallel --simple --strict tests/ · bash build.sh bin -v

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

  • Status
    Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(runner): runtime-error detection is English-only, so it does nothing under a translated locale · Issue #998 · TypedDevs/bashunit · GitHub
Skip to content

fix(runner): runtime-error detection is English-only, so it does nothing under a translated locale #998

Description

@Chemaclass

Summary

bashunit::runner::detect_runtime_error recognises a shell error by matching English phrases — command not found, unbound variable, permission denied, and about twenty more. bash translates those diagnostics, so under any locale with bash's message catalogue installed, none of them matches and a genuine runtime error is not classified at all.

LC_ALL=C /tmp/x.sh: line 1: foo: command not found → classified
LC_ALL=es_ES /tmp/x.sh: línea 1: foo: orden no encontrada → not classified

How it surfaced

While fixing #992 I added a regression guard asserting that a real shell error is still reported as an Error. It passed on every English job and failed on Ubuntu - Spanish Locale and Ubuntu - Japanese Locale, with the fixture exiting 0 — the error was never detected, so the test passed and the run was green.

I pinned that guard to LC_ALL=C, because it exists to test classification mechanics rather than localization. That is the right scope for it and the wrong place to leave the underlying gap unrecorded.

Impact

A user running under a translated locale gets no runtime-error classification. Their test still fails — the exit code and assertion counts are unaffected — but it is reported as a plain Failed with no indication that the cause was a shell error rather than a wrong value. That is precisely the distinction the Error channel exists to draw, and it is the one that saves debugging time.

The repo already runs Spanish, Brazilian and Japanese locale jobs, so this is a supported configuration, not a hypothetical.

Why phrase matching was chosen, and what it costs

Matching on message text is the reason this is locale-dependent. Two directions worth weighing:

  1. Force the C locale around the captured command. Setting LC_ALL=C for the test subshell would make diagnostics predictable, but it changes what the code under test sees — a test asserting on localized output would break. Almost certainly wrong.
  2. Stop relying on message text where possible. Exit codes carry some of this unambiguously (127 not found, 126 not executable, 128+N killed by signal N) and are locale-independent. That would not cover every phrase in the list, but it would cover the common ones without any translation dependency.
  3. Accept and document it. If the classifier stays English-only, say so, so nobody is surprised that the Error channel goes quiet on their machine.

My preference is 2 for the codes that carry the information, and 3 for the remainder.

Constraints

  • Bash 3.0+; case and parameter expansion only.
  • Per-test failure path — no new fork. See .claude/rules/perf-fork-budget.md.
  • The prefix rule added in fix(runner): a quoted shell-error phrase is no longer a runtime error #997 (: line N: , or its translated equivalent, on the same line as the phrase) is itself partly text-shaped — línea and still match its generic form, but any change here should keep that working.
  • Failure output is compared verbatim across the acceptance suite; regenerate snapshots deliberately and read the diff.

Acceptance criteria

  • A genuine command not found is classified as an Error under a translated locale, or the limitation is documented explicitly
  • Existing English classification does not regress — covered by the tests added in fix(runner): a quoted shell-error phrase is no longer a runtime error #997
  • The LC_ALL=C pin on test_a_real_shell_error_is_still_reported is revisited: kept deliberately, or removed if classification becomes locale-independent
  • make sa · make lint · ./bashunit --parallel --simple --strict tests/ · bash build.sh bin -v

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

  • Status
    Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(runner): runtime-error detection is English-only, so it does nothing under a translated locale · Issue #998 · TypedDevs/bashunit · GitHub
Skip to content

fix(runner): runtime-error detection is English-only, so it does nothing under a translated locale #998

Description

@Chemaclass

Summary

bashunit::runner::detect_runtime_error recognises a shell error by matching English phrases — command not found, unbound variable, permission denied, and about twenty more. bash translates those diagnostics, so under any locale with bash's message catalogue installed, none of them matches and a genuine runtime error is not classified at all.

LC_ALL=C /tmp/x.sh: line 1: foo: command not found → classified
LC_ALL=es_ES /tmp/x.sh: línea 1: foo: orden no encontrada → not classified

How it surfaced

While fixing #992 I added a regression guard asserting that a real shell error is still reported as an Error. It passed on every English job and failed on Ubuntu - Spanish Locale and Ubuntu - Japanese Locale, with the fixture exiting 0 — the error was never detected, so the test passed and the run was green.

I pinned that guard to LC_ALL=C, because it exists to test classification mechanics rather than localization. That is the right scope for it and the wrong place to leave the underlying gap unrecorded.

Impact

A user running under a translated locale gets no runtime-error classification. Their test still fails — the exit code and assertion counts are unaffected — but it is reported as a plain Failed with no indication that the cause was a shell error rather than a wrong value. That is precisely the distinction the Error channel exists to draw, and it is the one that saves debugging time.

The repo already runs Spanish, Brazilian and Japanese locale jobs, so this is a supported configuration, not a hypothetical.

Why phrase matching was chosen, and what it costs

Matching on message text is the reason this is locale-dependent. Two directions worth weighing:

  1. Force the C locale around the captured command. Setting LC_ALL=C for the test subshell would make diagnostics predictable, but it changes what the code under test sees — a test asserting on localized output would break. Almost certainly wrong.
  2. Stop relying on message text where possible. Exit codes carry some of this unambiguously (127 not found, 126 not executable, 128+N killed by signal N) and are locale-independent. That would not cover every phrase in the list, but it would cover the common ones without any translation dependency.
  3. Accept and document it. If the classifier stays English-only, say so, so nobody is surprised that the Error channel goes quiet on their machine.

My preference is 2 for the codes that carry the information, and 3 for the remainder.

Constraints

  • Bash 3.0+; case and parameter expansion only.
  • Per-test failure path — no new fork. See .claude/rules/perf-fork-budget.md.
  • The prefix rule added in fix(runner): a quoted shell-error phrase is no longer a runtime error #997 (: line N: , or its translated equivalent, on the same line as the phrase) is itself partly text-shaped — línea and still match its generic form, but any change here should keep that working.
  • Failure output is compared verbatim across the acceptance suite; regenerate snapshots deliberately and read the diff.

Acceptance criteria

  • A genuine command not found is classified as an Error under a translated locale, or the limitation is documented explicitly
  • Existing English classification does not regress — covered by the tests added in fix(runner): a quoted shell-error phrase is no longer a runtime error #997
  • The LC_ALL=C pin on test_a_real_shell_error_is_still_reported is revisited: kept deliberately, or removed if classification becomes locale-independent
  • make sa · make lint · ./bashunit --parallel --simple --strict tests/ · bash build.sh bin -v

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

  • Status
    Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(runner): runtime-error detection is English-only, so it does nothing under a translated locale · Issue #998 · TypedDevs/bashunit · GitHub
Skip to content

fix(runner): runtime-error detection is English-only, so it does nothing under a translated locale #998

Description

@Chemaclass

Summary

bashunit::runner::detect_runtime_error recognises a shell error by matching English phrases — command not found, unbound variable, permission denied, and about twenty more. bash translates those diagnostics, so under any locale with bash's message catalogue installed, none of them matches and a genuine runtime error is not classified at all.

LC_ALL=C /tmp/x.sh: line 1: foo: command not found → classified
LC_ALL=es_ES /tmp/x.sh: línea 1: foo: orden no encontrada → not classified

How it surfaced

While fixing #992 I added a regression guard asserting that a real shell error is still reported as an Error. It passed on every English job and failed on Ubuntu - Spanish Locale and Ubuntu - Japanese Locale, with the fixture exiting 0 — the error was never detected, so the test passed and the run was green.

I pinned that guard to LC_ALL=C, because it exists to test classification mechanics rather than localization. That is the right scope for it and the wrong place to leave the underlying gap unrecorded.

Impact

A user running under a translated locale gets no runtime-error classification. Their test still fails — the exit code and assertion counts are unaffected — but it is reported as a plain Failed with no indication that the cause was a shell error rather than a wrong value. That is precisely the distinction the Error channel exists to draw, and it is the one that saves debugging time.

The repo already runs Spanish, Brazilian and Japanese locale jobs, so this is a supported configuration, not a hypothetical.

Why phrase matching was chosen, and what it costs

Matching on message text is the reason this is locale-dependent. Two directions worth weighing:

  1. Force the C locale around the captured command. Setting LC_ALL=C for the test subshell would make diagnostics predictable, but it changes what the code under test sees — a test asserting on localized output would break. Almost certainly wrong.
  2. Stop relying on message text where possible. Exit codes carry some of this unambiguously (127 not found, 126 not executable, 128+N killed by signal N) and are locale-independent. That would not cover every phrase in the list, but it would cover the common ones without any translation dependency.
  3. Accept and document it. If the classifier stays English-only, say so, so nobody is surprised that the Error channel goes quiet on their machine.

My preference is 2 for the codes that carry the information, and 3 for the remainder.

Constraints

  • Bash 3.0+; case and parameter expansion only.
  • Per-test failure path — no new fork. See .claude/rules/perf-fork-budget.md.
  • The prefix rule added in fix(runner): a quoted shell-error phrase is no longer a runtime error #997 (: line N: , or its translated equivalent, on the same line as the phrase) is itself partly text-shaped — línea and still match its generic form, but any change here should keep that working.
  • Failure output is compared verbatim across the acceptance suite; regenerate snapshots deliberately and read the diff.

Acceptance criteria

  • A genuine command not found is classified as an Error under a translated locale, or the limitation is documented explicitly
  • Existing English classification does not regress — covered by the tests added in fix(runner): a quoted shell-error phrase is no longer a runtime error #997
  • The LC_ALL=C pin on test_a_real_shell_error_is_still_reported is revisited: kept deliberately, or removed if classification becomes locale-independent
  • make sa · make lint · ./bashunit --parallel --simple --strict tests/ · bash build.sh bin -v

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

  • Status
    Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' fix(runner): runtime-error detection is English-only, so it does nothing under a translated locale · Issue #998 · TypedDevs/bashunit · GitHub
Skip to content

fix(runner): runtime-error detection is English-only, so it does nothing under a translated locale #998

Description

@Chemaclass

Summary

bashunit::runner::detect_runtime_error recognises a shell error by matching English phrases — command not found, unbound variable, permission denied, and about twenty more. bash translates those diagnostics, so under any locale with bash's message catalogue installed, none of them matches and a genuine runtime error is not classified at all.

LC_ALL=C /tmp/x.sh: line 1: foo: command not found → classified
LC_ALL=es_ES /tmp/x.sh: línea 1: foo: orden no encontrada → not classified

How it surfaced

While fixing #992 I added a regression guard asserting that a real shell error is still reported as an Error. It passed on every English job and failed on Ubuntu - Spanish Locale and Ubuntu - Japanese Locale, with the fixture exiting 0 — the error was never detected, so the test passed and the run was green.

I pinned that guard to LC_ALL=C, because it exists to test classification mechanics rather than localization. That is the right scope for it and the wrong place to leave the underlying gap unrecorded.

Impact

A user running under a translated locale gets no runtime-error classification. Their test still fails — the exit code and assertion counts are unaffected — but it is reported as a plain Failed with no indication that the cause was a shell error rather than a wrong value. That is precisely the distinction the Error channel exists to draw, and it is the one that saves debugging time.

The repo already runs Spanish, Brazilian and Japanese locale jobs, so this is a supported configuration, not a hypothetical.

Why phrase matching was chosen, and what it costs

Matching on message text is the reason this is locale-dependent. Two directions worth weighing:

  1. Force the C locale around the captured command. Setting LC_ALL=C for the test subshell would make diagnostics predictable, but it changes what the code under test sees — a test asserting on localized output would break. Almost certainly wrong.
  2. Stop relying on message text where possible. Exit codes carry some of this unambiguously (127 not found, 126 not executable, 128+N killed by signal N) and are locale-independent. That would not cover every phrase in the list, but it would cover the common ones without any translation dependency.
  3. Accept and document it. If the classifier stays English-only, say so, so nobody is surprised that the Error channel goes quiet on their machine.

My preference is 2 for the codes that carry the information, and 3 for the remainder.

Constraints

  • Bash 3.0+; case and parameter expansion only.
  • Per-test failure path — no new fork. See .claude/rules/perf-fork-budget.md.
  • The prefix rule added in fix(runner): a quoted shell-error phrase is no longer a runtime error #997 (: line N: , or its translated equivalent, on the same line as the phrase) is itself partly text-shaped — línea and still match its generic form, but any change here should keep that working.
  • Failure output is compared verbatim across the acceptance suite; regenerate snapshots deliberately and read the diff.

Acceptance criteria

  • A genuine command not found is classified as an Error under a translated locale, or the limitation is documented explicitly
  • Existing English classification does not regress — covered by the tests added in fix(runner): a quoted shell-error phrase is no longer a runtime error #997
  • The LC_ALL=C pin on test_a_real_shell_error_is_still_reported is revisited: kept deliberately, or removed if classification becomes locale-independent
  • make sa · make lint · ./bashunit --parallel --simple --strict tests/ · bash build.sh bin -v

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

  • Status
    Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(runner): runtime-error detection is English-only, so it does nothing under a translated locale · Issue #998 · TypedDevs/bashunit · GitHub
Skip to content

fix(runner): runtime-error detection is English-only, so it does nothing under a translated locale #998

Description

@Chemaclass

Summary

bashunit::runner::detect_runtime_error recognises a shell error by matching English phrases — command not found, unbound variable, permission denied, and about twenty more. bash translates those diagnostics, so under any locale with bash's message catalogue installed, none of them matches and a genuine runtime error is not classified at all.

LC_ALL=C /tmp/x.sh: line 1: foo: command not found → classified
LC_ALL=es_ES /tmp/x.sh: línea 1: foo: orden no encontrada → not classified

How it surfaced

While fixing #992 I added a regression guard asserting that a real shell error is still reported as an Error. It passed on every English job and failed on Ubuntu - Spanish Locale and Ubuntu - Japanese Locale, with the fixture exiting 0 — the error was never detected, so the test passed and the run was green.

I pinned that guard to LC_ALL=C, because it exists to test classification mechanics rather than localization. That is the right scope for it and the wrong place to leave the underlying gap unrecorded.

Impact

A user running under a translated locale gets no runtime-error classification. Their test still fails — the exit code and assertion counts are unaffected — but it is reported as a plain Failed with no indication that the cause was a shell error rather than a wrong value. That is precisely the distinction the Error channel exists to draw, and it is the one that saves debugging time.

The repo already runs Spanish, Brazilian and Japanese locale jobs, so this is a supported configuration, not a hypothetical.

Why phrase matching was chosen, and what it costs

Matching on message text is the reason this is locale-dependent. Two directions worth weighing:

  1. Force the C locale around the captured command. Setting LC_ALL=C for the test subshell would make diagnostics predictable, but it changes what the code under test sees — a test asserting on localized output would break. Almost certainly wrong.
  2. Stop relying on message text where possible. Exit codes carry some of this unambiguously (127 not found, 126 not executable, 128+N killed by signal N) and are locale-independent. That would not cover every phrase in the list, but it would cover the common ones without any translation dependency.
  3. Accept and document it. If the classifier stays English-only, say so, so nobody is surprised that the Error channel goes quiet on their machine.

My preference is 2 for the codes that carry the information, and 3 for the remainder.

Constraints

  • Bash 3.0+; case and parameter expansion only.
  • Per-test failure path — no new fork. See .claude/rules/perf-fork-budget.md.
  • The prefix rule added in fix(runner): a quoted shell-error phrase is no longer a runtime error #997 (: line N: , or its translated equivalent, on the same line as the phrase) is itself partly text-shaped — línea and still match its generic form, but any change here should keep that working.
  • Failure output is compared verbatim across the acceptance suite; regenerate snapshots deliberately and read the diff.

Acceptance criteria

  • A genuine command not found is classified as an Error under a translated locale, or the limitation is documented explicitly
  • Existing English classification does not regress — covered by the tests added in fix(runner): a quoted shell-error phrase is no longer a runtime error #997
  • The LC_ALL=C pin on test_a_real_shell_error_is_still_reported is revisited: kept deliberately, or removed if classification becomes locale-independent
  • make sa · make lint · ./bashunit --parallel --simple --strict tests/ · bash build.sh bin -v

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

  • Status
    Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(runner): runtime-error detection is English-only, so it does nothing under a translated locale · Issue #998 · TypedDevs/bashunit · GitHub
Skip to content

fix(runner): runtime-error detection is English-only, so it does nothing under a translated locale #998

Description

@Chemaclass

Summary

bashunit::runner::detect_runtime_error recognises a shell error by matching English phrases — command not found, unbound variable, permission denied, and about twenty more. bash translates those diagnostics, so under any locale with bash's message catalogue installed, none of them matches and a genuine runtime error is not classified at all.

LC_ALL=C /tmp/x.sh: line 1: foo: command not found → classified
LC_ALL=es_ES /tmp/x.sh: línea 1: foo: orden no encontrada → not classified

How it surfaced

While fixing #992 I added a regression guard asserting that a real shell error is still reported as an Error. It passed on every English job and failed on Ubuntu - Spanish Locale and Ubuntu - Japanese Locale, with the fixture exiting 0 — the error was never detected, so the test passed and the run was green.

I pinned that guard to LC_ALL=C, because it exists to test classification mechanics rather than localization. That is the right scope for it and the wrong place to leave the underlying gap unrecorded.

Impact

A user running under a translated locale gets no runtime-error classification. Their test still fails — the exit code and assertion counts are unaffected — but it is reported as a plain Failed with no indication that the cause was a shell error rather than a wrong value. That is precisely the distinction the Error channel exists to draw, and it is the one that saves debugging time.

The repo already runs Spanish, Brazilian and Japanese locale jobs, so this is a supported configuration, not a hypothetical.

Why phrase matching was chosen, and what it costs

Matching on message text is the reason this is locale-dependent. Two directions worth weighing:

  1. Force the C locale around the captured command. Setting LC_ALL=C for the test subshell would make diagnostics predictable, but it changes what the code under test sees — a test asserting on localized output would break. Almost certainly wrong.
  2. Stop relying on message text where possible. Exit codes carry some of this unambiguously (127 not found, 126 not executable, 128+N killed by signal N) and are locale-independent. That would not cover every phrase in the list, but it would cover the common ones without any translation dependency.
  3. Accept and document it. If the classifier stays English-only, say so, so nobody is surprised that the Error channel goes quiet on their machine.

My preference is 2 for the codes that carry the information, and 3 for the remainder.

Constraints

  • Bash 3.0+; case and parameter expansion only.
  • Per-test failure path — no new fork. See .claude/rules/perf-fork-budget.md.
  • The prefix rule added in fix(runner): a quoted shell-error phrase is no longer a runtime error #997 (: line N: , or its translated equivalent, on the same line as the phrase) is itself partly text-shaped — línea and still match its generic form, but any change here should keep that working.
  • Failure output is compared verbatim across the acceptance suite; regenerate snapshots deliberately and read the diff.

Acceptance criteria

  • A genuine command not found is classified as an Error under a translated locale, or the limitation is documented explicitly
  • Existing English classification does not regress — covered by the tests added in fix(runner): a quoted shell-error phrase is no longer a runtime error #997
  • The LC_ALL=C pin on test_a_real_shell_error_is_still_reported is revisited: kept deliberately, or removed if classification becomes locale-independent
  • make sa · make lint · ./bashunit --parallel --simple --strict tests/ · bash build.sh bin -v

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

  • Status
    Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); fix(runner): runtime-error detection is English-only, so it does nothing under a translated locale · Issue #998 · TypedDevs/bashunit · GitHub
Skip to content

fix(runner): runtime-error detection is English-only, so it does nothing under a translated locale #998

Description

@Chemaclass

Summary

bashunit::runner::detect_runtime_error recognises a shell error by matching English phrases — command not found, unbound variable, permission denied, and about twenty more. bash translates those diagnostics, so under any locale with bash's message catalogue installed, none of them matches and a genuine runtime error is not classified at all.

LC_ALL=C /tmp/x.sh: line 1: foo: command not found → classified
LC_ALL=es_ES /tmp/x.sh: línea 1: foo: orden no encontrada → not classified

How it surfaced

While fixing #992 I added a regression guard asserting that a real shell error is still reported as an Error. It passed on every English job and failed on Ubuntu - Spanish Locale and Ubuntu - Japanese Locale, with the fixture exiting 0 — the error was never detected, so the test passed and the run was green.

I pinned that guard to LC_ALL=C, because it exists to test classification mechanics rather than localization. That is the right scope for it and the wrong place to leave the underlying gap unrecorded.

Impact

A user running under a translated locale gets no runtime-error classification. Their test still fails — the exit code and assertion counts are unaffected — but it is reported as a plain Failed with no indication that the cause was a shell error rather than a wrong value. That is precisely the distinction the Error channel exists to draw, and it is the one that saves debugging time.

The repo already runs Spanish, Brazilian and Japanese locale jobs, so this is a supported configuration, not a hypothetical.

Why phrase matching was chosen, and what it costs

Matching on message text is the reason this is locale-dependent. Two directions worth weighing:

  1. Force the C locale around the captured command. Setting LC_ALL=C for the test subshell would make diagnostics predictable, but it changes what the code under test sees — a test asserting on localized output would break. Almost certainly wrong.
  2. Stop relying on message text where possible. Exit codes carry some of this unambiguously (127 not found, 126 not executable, 128+N killed by signal N) and are locale-independent. That would not cover every phrase in the list, but it would cover the common ones without any translation dependency.
  3. Accept and document it. If the classifier stays English-only, say so, so nobody is surprised that the Error channel goes quiet on their machine.

My preference is 2 for the codes that carry the information, and 3 for the remainder.

Constraints

  • Bash 3.0+; case and parameter expansion only.
  • Per-test failure path — no new fork. See .claude/rules/perf-fork-budget.md.
  • The prefix rule added in fix(runner): a quoted shell-error phrase is no longer a runtime error #997 (: line N: , or its translated equivalent, on the same line as the phrase) is itself partly text-shaped — línea and still match its generic form, but any change here should keep that working.
  • Failure output is compared verbatim across the acceptance suite; regenerate snapshots deliberately and read the diff.

Acceptance criteria

  • A genuine command not found is classified as an Error under a translated locale, or the limitation is documented explicitly
  • Existing English classification does not regress — covered by the tests added in fix(runner): a quoted shell-error phrase is no longer a runtime error #997
  • The LC_ALL=C pin on test_a_real_shell_error_is_still_reported is revisited: kept deliberately, or removed if classification becomes locale-independent
  • make sa · make lint · ./bashunit --parallel --simple --strict tests/ · bash build.sh bin -v

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

  • Status
    Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions