Uh oh!
There was an error while loading. Please reload this page.
feat(runner): report a scratch directory that disappears mid-run - #1168
Merged
Conversation
Surviving the disappearance silently leaves no trace, which is worse for diagnosis than the misleading 'failed to source' it replaced: #1137 is open precisely because that directory goes missing on CI and nobody can say what removes it. Warn once per run on stderr, naming the directory. Once per run rather than per file: a run that loses it early would otherwise repeat the warning for every remaining file. Closes#1167
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Background
Related #1167
#1164 made a run survive its scratch directory going missing, so a valid test
file is no longer reported as unsourceable. But it recovers silently, and
#1137 is open precisely because that directory goes missing on CI and nobody
can say what removes it. No trace at all is worse for diagnosis than the
misleading error it replaced.
💡 Changes